Hi,
On Mon, Jul 11, 2022 at 9:10 AM Kuogee Hsieh wrote:
>
>
> On 7/11/2022 9:02 AM, Doug Anderson wrote:
>
> Hi,
>
> On Mon, Jul 11, 2022 at 8:58 AM Kuogee Hsieh wrote:
>
> Both vdda-1p2-supply and vdda-0p9-supply regulators are controlled
> by dp combo phy.
Hi,
On Mon, Jul 11, 2022 at 8:58 AM Kuogee Hsieh wrote:
>
> Both vdda-1p2-supply and vdda-0p9-supply regulators are controlled
> by dp combo phy. Therefore remove them from dp controller.
>
> Signed-off-by: Kuogee Hsieh
> ---
> arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 3 ---
> 1 file
Hi,
On Wed, Jul 6, 2022 at 12:14 PM Stephen Boyd wrote:
>
> Set the panel orientation in drm when the panel is directly connected,
> i.e. we're not using an external bridge. The external bridge case is
> already handled by the panel bridge code, so we only update the path we
> take when the
Hi,
On Fri, Jul 1, 2022 at 8:47 AM Kuogee Hsieh wrote:
>
> Both vdda-1p2-supply and vdda-0p9-supply regulators are controlled
> by dp combo phy. Therefore remove them from dp controller.
>
> Signed-off-by: Kuogee Hsieh
> ---
> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 --
> 1 file
Hi,
On Tue, Jun 28, 2022 at 1:14 PM Dmitry Baryshkov
wrote:
>
> On 28 June 2022 18:20:06 GMT+03:00, Kuogee Hsieh
> wrote:
> >Some userspace presumes that the first connected connector is the main
> >display, where it's supposed to display e.g. the login screen. For
> >laptops, this should be
Hi,
On Sat, Jun 25, 2022 at 1:48 AM Dmitry Baryshkov
wrote:
>
> On Sat, 25 Jun 2022 at 04:23, Abhinav Kumar wrote:
> > On 6/24/2022 5:11 PM, Dmitry Baryshkov wrote:
> > > On Sat, 25 Jun 2022 at 03:03, Abhinav Kumar
> > > wrote:
> > >> On 6/24/2022 4:56 PM, Kuogee Hsieh wrote:
> > >> diff
Hi,
On Fri, Jun 24, 2022 at 10:15 AM Kuogee Hsieh wrote:
>
> With current implementation, communication between interface driver and
> upper mdss encoder layer are implemented through function calls. This
> increase code complexity. Since struct msm_display_info contains msm
> generic display
Hi,
On Mon, Apr 25, 2022 at 2:07 PM Douglas Anderson wrote:
>
> We're supposed to list the supplies in the dt bindings but there are
> none in the eDP PHY bindings.
>
> Looking at the driver in Linux, I can see that there seem to be two
> relevant supplies: "vdda-phy" and "vdda-pll". Let's add
Hi,
On Tue, Jun 14, 2022 at 7:42 AM Akhil P Oommen wrote:
>
> On 6/10/2022 5:39 AM, Douglas Anderson wrote:
> > >From testing on sc7180-trogdor devices, reading the GMU registers
> > needs the GMU clocks to be enabled. Those clocks get turned on in
> > a6xx_gmu_resume(). Confusingly enough, that
Hi,
On Wed, Jun 8, 2022 at 9:13 AM Rob Clark wrote:
>
> From: Rob Clark
>
> I've seen a few crashes like:
>
> CPU: 0 PID: 216 Comm: A618-worker Tainted: GW 5.4.196 #7
> Hardware name: Google Wormdingler rev1+ INX panel board (DT)
> pstate: 20c9 (nzCv daif +PAN
Hi,
On Thu, Jun 9, 2022 at 7:16 AM Akhil P Oommen wrote:
>
> On 6/9/2022 2:17 AM, Rob Clark wrote:
> > On Wed, Jun 8, 2022 at 12:36 PM Akhil P Oommen
> > wrote:
> >> On 6/8/2022 3:00 AM, Rob Clark wrote:
> >>> On Tue, Sep 28, 2021 at 7:52 AM Akhil P Oommen
> >>> wrote:
> On 9/27/2021
Hi,
On Wed, Jun 1, 2022 at 11:23 AM Douglas Anderson wrote:
>
> If we're unable to read the EDID for a display because it's corrupt /
> bogus / invalid then we'll add a set of standard modes for the
> display. Since we have no true information about the connected
> display, these modes are
Hi,
On Fri, Jun 3, 2022 at 7:14 AM Maxime Ripard wrote:
>
> On Fri, Jun 03, 2022 at 01:19:16PM +0300, Dmitry Baryshkov wrote:
> > On Fri, 3 Jun 2022 at 11:21, Maxime Ripard wrote:
> > >
> > > On Tue, May 31, 2022 at 02:06:34PM -0700, Doug Anderson wrote:
> >
Hi,
On Fri, Jun 3, 2022 at 3:19 AM Dmitry Baryshkov
wrote:
>
> On Fri, 3 Jun 2022 at 11:21, Maxime Ripard wrote:
> >
> > On Tue, May 31, 2022 at 02:06:34PM -0700, Doug Anderson wrote:
> > > On Mon, May 23, 2022 at 10:00 AM Doug Anderson
> > > wrote:
>
Hi,
On Tue, May 10, 2022 at 12:30 PM Douglas Anderson wrote:
>
> This patch is v3 of the first 2 patches from my RFC series ("drm/dp:
> Improvements
> for DP AUX channel") [1]. I've broken the series in two so we can make
> progress on the two halves separately.
>
> v2 of this series tries to
Hi,
On Tue, May 31, 2022 at 2:29 PM Abhinav Kumar wrote:
>
> > @@ -136,6 +178,13 @@ static int msm_mdss_enable(struct msm_mdss *msm_mdss)
> > {
> > int ret;
> >
> > + /*
> > + * Several components have AXI clocks that can only be turned on if
> > + * the interconnect is
Hi,
On Tue, May 10, 2022 at 12:30 PM Douglas Anderson wrote:
>
> This patch is v3 of the first 2 patches from my RFC series ("drm/dp:
> Improvements
> for DP AUX channel") [1]. I've broken the series in two so we can make
> progress on the two halves separately.
>
> v2 of this series tries to
Maxime,
On Mon, May 23, 2022 at 10:00 AM Doug Anderson wrote:
>
> Hi,
>
> On Sat, May 21, 2022 at 2:17 AM Maxime Ripard wrote:
> >
> > Hi,
> >
> > On Tue, May 10, 2022 at 12:29:43PM -0700, Douglas Anderson wrote:
> > > This adds a devm managed versio
Hi,
On Thu, May 26, 2022 at 8:42 AM Daniel Vetter wrote:
>
> On Thu, 26 May 2022 at 03:28, Sean Paul wrote:
> >
> > On Wed, May 25, 2022 at 9:26 AM Daniel Vetter wrote:
> > >
> > > On Mon, May 23, 2022 at 05:59:02PM -0700, Doug Anderson wrote:
> > &g
Hi,
On Wed, May 25, 2022 at 12:37 PM Kuogee Hsieh wrote:
>
> This patch add regulator_set_load() before enable regulator at
> DP phy driver.
>
> Signed-off-by: Kuogee Hsieh
> Reviewed-by: Stephen Boyd
> ---
> drivers/phy/qualcomm/phy-qcom-qmp.c | 41
> +
>
Hi,
On Fri, May 20, 2022 at 2:27 PM Kuogee Hsieh wrote:
>
> @@ -101,11 +101,6 @@ struct dp_reg_entry {
> int disable_load;
> };
>
> -struct dp_regulator_cfg {
> - int num;
> - struct dp_reg_entry regs[DP_DEV_REGULATOR_MAX];
You forgot to delete the #define of
Hi,
On Fri, May 20, 2022 at 2:27 PM Kuogee Hsieh wrote:
>
> This patch add regulator_set_load() before enable regulator at
> DP phy driver.
>
> Signed-off-by: Kuogee Hsieh
> Reviewed-by: Stephen Boyd
> ---
> drivers/phy/qualcomm/phy-qcom-qmp.c | 25 -
> 1 file changed,
Hi,
On Fri, May 20, 2022 at 2:28 PM Kuogee Hsieh wrote:
>
> This patch add regulator_set_load() before enable regulator at
> eDP phy driver.
>
> Signed-off-by: Kuogee Hsieh
> ---
> drivers/phy/qualcomm/phy-qcom-edp.c | 12
> 1 file changed, 12 insertions(+)
Reviewed-by: Douglas
Hi,
On Fri, May 20, 2022 at 5:01 PM Doug Anderson wrote:
>
> Hi,
>
> On Mon, May 16, 2022 at 3:28 AM Thomas Zimmermann wrote:
> >
> > Hi Douglas,
> >
> > I understand that you're trying to tell userspace that the modelist has
> > been made up, but
Hi,
On Sat, May 21, 2022 at 2:17 AM Maxime Ripard wrote:
>
> Hi,
>
> On Tue, May 10, 2022 at 12:29:43PM -0700, Douglas Anderson wrote:
> > This adds a devm managed version of drm_bridge_add(). Like other
> > "devm" function listed in drm_bridge.h, this function takes an
> > explicit "dev" to use
Hi,
On Mon, May 16, 2022 at 3:28 AM Thomas Zimmermann wrote:
>
> Hi Douglas,
>
> I understand that you're trying to tell userspace that the modelist has
> been made up, but it's not something that should be done via fragile
> heuristics IMHO.
>
> I looked at the Chromium source code that you
Hi,
On Tue, May 10, 2022 at 5:22 PM Dmitry Baryshkov
wrote:
>
> On Tue, 10 May 2022 at 22:30, Douglas Anderson wrote:
> >
> > This adds a devm managed version of drm_bridge_add(). Like other
> > "devm" function listed in drm_bridge.h, this function takes an
> > explicit "dev" to use for the
Hi,
On Tue, May 10, 2022 at 12:30 PM Douglas Anderson wrote:
>
> While working on the DP AUX bus code I found a few small things that
> should be fixed. Namely the non-devm version of
> of_dp_aux_populate_ep_devices() was missing an export. There was also
> an extra blank line in a kerneldoc and
Hi,
On Mon, May 9, 2022 at 4:18 PM Douglas Anderson wrote:
>
> When doing DP AUX transfers there are two actors that need to be
> powered in order for the DP AUX transfer to work: the DP source and
> the DP sink. Commit bacbab58f09d ("drm: Mention the power state
> requirement on side-channel
Hi,
On Wed, May 11, 2022 at 3:58 PM Douglas Anderson wrote:
>
> As per Displayport spec section 5.2.1.2 ("Video Timing Format") says
> that all detachable sinks shall support 640x480 @60Hz as a fail safe
> mode.
>
> A DP compliance test expected us to utilize the above fact when all
> modes it
Hi,
On Wed, May 11, 2022 at 3:58 PM Douglas Anderson wrote:
>
> The drm_helper_probe_single_connector_modes() is a bit long. Let's
> break a chunk off to update and validate modes. This helps avoid one
> goto and also will allow us to more easily call the helper a second
> time in a future patch
Hi,
On Tue, May 17, 2022 at 10:26 AM Kuogee Hsieh wrote:
>
> This patch add regulator_set_load() to both eDP and DP phy driver
> to have totally control regulators.
>
> Signed-off-by: Kuogee Hsieh
> ---
> drivers/phy/qualcomm/phy-qcom-edp.c | 25 +
>
Hi,
On Wed, May 11, 2022 at 2:32 PM Doug Anderson wrote:
>
> Hi,
>
> On Wed, May 11, 2022 at 12:14 AM Thomas Zimmermann
> wrote:
> >
> > Hi
> >
> > Am 10.05.22 um 22:51 schrieb Douglas Anderson:
> > > If we're unable to read the EDID for a disp
Hi,
On Thu, May 12, 2022 at 3:34 PM Abhinav Kumar wrote:
>
> On 5/12/2022 3:16 PM, Dmitry Baryshkov wrote:
> > On 13/05/2022 01:00, Douglas Anderson wrote:
> >> Commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset
> >> time") caused sc7180 Chromebooks that use the parade-ps8640
Hi,
On Thu, May 12, 2022 at 1:59 PM Dmitry Baryshkov
wrote:
>
> On 12/05/2022 23:52, Douglas Anderson wrote:
> > Commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset
> > time") caused sc7180 Chromebooks that use the parade-ps8640 bridge
> > chip to fail to turn the display back on
Hi,
On Wed, May 11, 2022 at 4:07 PM Douglas Anderson wrote:
>
> This reverts commit c7e4a2a72e696aa6aed2c8b651279f491bb096fe.
>
> The patch causes sc7180 Chromebooks that use the parade-ps8640 bridge
> chip to fail to turn the display back on after it turns off.
>
> Let's revert to get these
Hi,
On Wed, May 11, 2022 at 12:14 AM Thomas Zimmermann wrote:
>
> Hi
>
> Am 10.05.22 um 22:51 schrieb Douglas Anderson:
> > If we're unable to read the EDID for a display because it's corrupt /
> > bogus / invalid then we'll add a set of standard modes for the
> > display. When userspace looks
Hi,
On Tue, Dec 7, 2021 at 2:29 PM Dmitry Baryshkov
wrote:
>
> The DSI subsystem does not fully fall into the pre-enable/enable system
> of callbacks, since typically DSI device bridge drivers expect to be
> able to communicate with DSI devices at the pre-enable() callback. The
> reason is that
Hi,
On Fri, May 6, 2022 at 6:36 AM Sankeerth Billakanti (QUIC)
wrote:
>
> >> >> Our internal power grid documents list the regulators as
> >> >> VDD_A_*_1P2 and VDD_A_*_0P9 for all the platforms.
> >> >
> >> >Do your internal power grid documents indicate what these supplies
> >> >are powering?
Hi,
On Thu, May 5, 2022 at 3:15 PM Dmitry Baryshkov
wrote:
>
> On 06/05/2022 00:24, Doug Anderson wrote:
> > Hi,
> >
> > On Thu, May 5, 2022 at 1:56 PM Dmitry Baryshkov
> > wrote:
> >>
> >> On Thu, 5 May 2022 at 23:21, Doug Anderson wrote:
>
Hi,
On Thu, May 5, 2022 at 1:56 PM Dmitry Baryshkov
wrote:
>
> On Thu, 5 May 2022 at 23:21, Doug Anderson wrote:
> >
> > Hi,
> >
> > On Thu, May 5, 2022 at 1:10 PM Dmitry Baryshkov
> > wrote:
> > >
> > > On Thu, 5 May 2
Hi,
On Thu, May 5, 2022 at 1:10 PM Dmitry Baryshkov
wrote:
>
> On Thu, 5 May 2022 at 18:53, Doug Anderson wrote:
> >
> > Hi,
> >
> > On Thu, May 5, 2022 at 8:29 AM Ville Syrjälä
> > wrote:
> > >
> > > On Thu, May 05, 202
Hi,
On Thu, May 5, 2022 at 12:19 PM Ville Syrjälä
wrote:
>
> On Thu, May 05, 2022 at 08:53:12AM -0700, Doug Anderson wrote:
> > Hi,
> >
> > On Thu, May 5, 2022 at 8:29 AM Ville Syrjälä
> > wrote:
> > >
> > > On Thu, May 05, 2022 at 0
Hi,
On Thu, May 5, 2022 at 8:29 AM Ville Syrjälä
wrote:
>
> On Thu, May 05, 2022 at 08:00:20AM -0700, Doug Anderson wrote:
> > Hi,
> >
> > On Thu, May 5, 2022 at 7:46 AM Ville Syrjälä
> > wrote:
> > >
> > > On Wed, May 04, 2022 at 02:10:08PM -04
Hi,
On Thu, May 5, 2022 at 7:46 AM Ville Syrjälä
wrote:
>
> On Wed, May 04, 2022 at 02:10:08PM -0400, Lyude Paul wrote:
> > On Wed, 2022-05-04 at 09:04 -0700, Doug Anderson wrote:
> > > Hi,
> > >
> > > On Wed, May 4, 2022 at 5:21 AM Ville Syrjälä
>
Hi,
On Wed, May 4, 2022 at 11:10 AM Lyude Paul wrote:
>
> On Wed, 2022-05-04 at 09:04 -0700, Doug Anderson wrote:
> > Hi,
> >
> > On Wed, May 4, 2022 at 5:21 AM Ville Syrjälä
> > wrote:
> > >
> > > On Tue, May 03, 2022 at 04:21:08PM -0700, D
Hi,
On Wed, May 4, 2022 at 4:29 PM Dmitry Baryshkov
wrote:
>
> On Thu, 5 May 2022 at 01:49, Douglas Anderson wrote:
> >
> > When rebooting on my sc7280-herobrine based device, I got a
> > crash. Upon debugging, I found that I was in msm_drv_shutdown() and my
> > "pdev" was the one associated
Hi,
On Wed, May 4, 2022 at 5:21 AM Ville Syrjälä
wrote:
>
> On Tue, May 03, 2022 at 04:21:08PM -0700, Douglas Anderson wrote:
> > When doing DP AUX transfers there are two actors that need to be
> > powered in order for the DP AUX transfer to work: the DP source and
> > the DP sync. Commit
Hi,
On Wed, May 4, 2022 at 3:41 AM Dmitry Baryshkov
wrote:
>
> > - We had forgotten a EXPORT_SYMBOL_GPL on the non "devm" populate
> >function.
>
> This can go to a separate patch, so that the fix can be backported to
> earlier kernels. Please don't forget the Fixes: tag.
Sure. Will do for
Hi,
On Tue, Apr 26, 2022 at 2:12 PM Kuogee Hsieh wrote:
>
> Current DP driver implementation has adding safe mode done at
> dp_hpd_plug_handle() which is expected to be executed under event
> thread context.
>
> However there is possible circular locking happen (see blow stack trace)
> after edp
Hi,
On Tue, Apr 26, 2022 at 1:30 PM Kuogee Hsieh wrote:
>
> Current DP driver implementation has adding safe mode done at
> dp_hpd_plug_handle() which is expected to be executed under event
> thread context.
>
> However there is possible circular locking happen (see blow stack trace)
> after edp
Hi,
On Mon, Apr 25, 2022 at 10:56 PM Kuogee Hsieh wrote:
>
> Current DP driver implementation has adding safe mode done at
> dp_hpd_plug_handle() which is expected to be executed under event
> thread context.
>
> However there is possible circular locking happen (see blow stack trace)
> after
Hi,
On Tue, Apr 26, 2022 at 8:37 AM Abhinav Kumar wrote:
>
> > Can you provide the exact EDID from the failing test case? Maybe that
> > will help shed some light on what's going on. I looked at the original
> > commit and it just referred to 4.2.2.1, which I assume is "EDID Read
> > upon HPD
Hi,
On Tue, Apr 26, 2022 at 10:44 AM Dmitry Baryshkov
wrote:
>
> On 26/04/2022 20:11, Doug Anderson wrote:
> > Hi,
> >
> > On Tue, Apr 26, 2022 at 10:01 AM Dmitry Baryshkov
> > wrote:
> >>
> >> On 26/04/2022 18:37, Abhinav Kumar wrote:
>
Hi,
On Tue, Apr 26, 2022 at 10:01 AM Dmitry Baryshkov
wrote:
>
> On 26/04/2022 18:37, Abhinav Kumar wrote:
> > Hi Doug
> >
> > On 4/26/2022 8:20 AM, Doug Anderson wrote:
> >> Hi,
> >>
> >> On Mon, Apr 25, 2022 at 8:35 PM Abhinav Kumar
> >
Hi,
On Mon, Apr 25, 2022 at 8:35 PM Abhinav Kumar wrote:
>
> On 4/25/2022 7:18 PM, Doug Anderson wrote:
> > Hi,
> >
> > On Mon, Apr 25, 2022 at 6:42 PM Abhinav Kumar
> > wrote:
> >>
> >>>> 2) When there was a valid EDID but no 640x480
Hi,
On Mon, Apr 25, 2022 at 6:42 PM Abhinav Kumar wrote:
>
> >> 2) When there was a valid EDID but no 640x480 mode
> >>
> >> This is the equipment specific case and the one even I was a bit
> >> surprised. There is a DP compliance equipment we have in-house and while
> >> validation, it was
Hi,
On Sat, Apr 23, 2022 at 8:34 AM Abhinav Kumar wrote:
>
> On 4/22/2022 11:25 PM, Dmitry Baryshkov wrote:
> > On Sat, 23 Apr 2022 at 03:12, Abhinav Kumar
> > wrote:
> >>
> >>
> >>
> >> On 4/22/2022 5:07 PM, Dmitry Baryshkov wrote:
> >>> On 23/04/2022 02:45, Kuogee Hsieh wrote:
> Current
Hi,
On Mon, Apr 25, 2022 at 2:14 PM Stephen Boyd wrote:
>
> Quoting Douglas Anderson (2022-04-25 14:06:42)
> > We're supposed to list the supplies in the dt bindings but there are
> > none in the DP controller bindings. Looking at the Linux driver and
> > existing device trees, we can see that
Hi,
On Fri, Apr 22, 2022 at 9:05 AM Abhinav Kumar wrote:
>
> Hi Doug
>
> For the lockdep error, the splat looks similar to what kuogee fixed
> recently.
>
> Can you please check if below patch is present in your tree?
>
> https://patchwork.freedesktop.org/patch/481396/
Indeed I did have that in
Hi,
On Fri, Apr 22, 2022 at 2:11 AM Sankeerth Billakanti
wrote:
>
> The panel-edp enables the eDP panel power during probe, get_modes
> and pre-enable. The eDP connect and disconnect interrupts for the eDP/DP
> controller are directly dependent on panel power. As eDP display can be
> assumed as
Hi,
On Mon, Mar 21, 2022 at 8:27 PM Vinod Polimera
wrote:
>
> Set mdp clock to max clock rate during probe/bind sequence from the
> opp table so that rails are not at undetermined state. Since we do not
> know what will be the rate set in boot loader, it would be ideal to
> vote at max
Hi,
On Fri, Apr 22, 2022 at 2:11 AM Sankeerth Billakanti
wrote:
>
> The panel-edp enables the eDP panel power during probe, get_modes
> and pre-enable. The eDP connect and disconnect interrupts for the eDP/DP
> controller are directly dependent on panel power. As eDP display can be
> assumed as
Hi,
On Fri, Apr 22, 2022 at 2:11 AM Sankeerth Billakanti
wrote:
>
> This patch adds support for generic eDP sink through aux_bus. The eDP/DP
> controller driver should support aux transactions originating from the
> panel-edp driver and hence should be initialized and ready.
>
> The panel bridge
Hi,
On Thu, Apr 21, 2022 at 9:39 AM Sankeerth Billakanti (QUIC)
wrote:
>
> Hi Doug,
>
> >On Thu, Apr 21, 2022 at 7:37 AM Sankeerth Billakanti
> > wrote:
> >>
> >> The panel-edp enables the eDP panel power during probe, get_modes and
> >> pre-enable. The eDP connect and disconnect interrupts for
Hi,
On Thu, Apr 21, 2022 at 7:37 AM Sankeerth Billakanti
wrote:
>
> The panel-edp enables the eDP panel power during probe, get_modes
> and pre-enable. The eDP connect and disconnect interrupts for the eDP/DP
> controller are directly dependent on panel power. As eDP display can be
> assumed as
Hi,
On Thu, Apr 21, 2022 at 7:37 AM Sankeerth Billakanti
wrote:
>
> @@ -1530,6 +1532,61 @@ void msm_dp_debugfs_init(struct msm_dp *dp_display,
> struct drm_minor *minor)
> }
> }
>
> +static int dp_display_get_next_bridge(struct msm_dp *dp)
> +{
> + int rc;
> + struct
Hi,
On Thu, Apr 14, 2022 at 2:16 PM Dmitry Baryshkov
wrote:
>
> > Hmm, interesting. Probably for DRM_BRIDGE_OP_MODES that will work?
> > It's definitely worth confirming but from my reading of the code it
> > _probably_ wouldn't hurt.
> >
> > One thing someone would want to confirm would be what
Hi,
On Thu, Apr 14, 2022 at 12:40 PM Stephen Boyd wrote:
>
> Quoting Dmitry Baryshkov (2022-04-14 12:16:14)
> >
> > I think it's too verbose and a bit incorrect.
Not sure which part you're asserting is incorrect, but shorter is OK w/ me too.
> > This is a bit saner:
> > /*
> > * These ops
Hi,
On Thu, Apr 14, 2022 at 5:20 AM Sankeerth Billakanti
wrote:
>
> The eDP controller does not have a reliable way keep panel
> powered on to read the sink capabilities. So, the controller
> driver cannot validate if a mode can be supported by the
> source. We will rely on the panel driver to
Hi,
On Thu, Apr 14, 2022 at 5:20 AM Sankeerth Billakanti
wrote:
>
> The source device should ensure the sink is ready before proceeding to
> read the sink capability or perform any aux transactions. The sink
> will indicate its readiness by asserting the HPD line. The controller
> driver needs
Hi,
On Thu, Apr 14, 2022 at 5:20 AM Sankeerth Billakanti
wrote:
>
> The panel-edp enables the eDP panel power during probe, get_modes
> and enable.
Technically the panel-edp powers on the panel in pre_enable()
> The eDP connect and disconnect interrupts for the eDP/DP
> controller are
Hi,
On Thu, Apr 14, 2022 at 5:19 AM Sankeerth Billakanti
wrote:
>
> This series adds support for generic eDP panel over aux_bus.
>
> These changes are dependent on the following series:
> https://patchwork.kernel.org/project/linux-arm-msm/list/?series=613654=*
You're basically depending on the
Hi,
On Thu, Apr 14, 2022 at 5:20 AM Sankeerth Billakanti
wrote:
>
> @@ -1530,6 +1532,60 @@ void msm_dp_debugfs_init(struct msm_dp *dp_display,
> struct drm_minor *minor)
> }
> }
>
> +static int dp_display_get_next_bridge(struct msm_dp *dp)
> +{
> + int rc;
> + struct
Hi,
On Fri, Apr 8, 2022 at 5:13 AM Dmitry Baryshkov
wrote:
>
> On Fri, 8 Apr 2022 at 03:28, Doug Anderson wrote:
> >
> > Hi,
> >
> > On Thu, Apr 7, 2022 at 4:36 PM Dmitry Baryshkov
> > wrote:
> > >
> > > The ps8640 driver looks 'w
Hi,
On Fri, Apr 8, 2022 at 5:20 AM Dmitry Baryshkov
wrote:
>
> > I guess my thought was that in DP you could still create the AUX bus
> > at probe time. Then for DP you just return an instant "transfer
> > failed" from the AUX bus if HPD isn't asserted. For eDP (as discussed
> > elsewhere) when
Hi,
On Thu, Apr 7, 2022 at 4:46 PM Dmitry Baryshkov
wrote:
>
> > The way I'm arguing it should work is that:
> >
> > 1. A whole bunch of the DP init code should move to the DP driver's
> > probe function. This includes parsing the DT, acquiring clocks,
> > getting a handle to our PHY, and IO
Hi,
On Thu, Apr 7, 2022 at 4:36 PM Dmitry Baryshkov
wrote:
>
> The ps8640 driver looks 'working by coincidence'. It calls
> dp_aux_populate, then immediately after the function returns it checks
> for the panel. If panel-edp is built as a module, the probe might fail
> easily.
> The anx7625
Hi,
On Thu, Apr 7, 2022 at 3:03 PM Abhinav Kumar wrote:
>
> Hi Doug
>
> Thanks for the response, some comments below.
>
> Abhinav
> On 4/7/2022 1:47 PM, Doug Anderson wrote:
> > Hi,
> >
> > On Thu, Apr 7, 2022 at 1:11 PM Abhinav Kumar
> > wrote:
Hi,
On Thu, Apr 7, 2022 at 1:11 PM Abhinav Kumar wrote:
>
> Hi Doug and Dmitry
>
> Sorry, but I caught up on this email just now.
>
> Some comments below.
>
> Thanks
>
> Abhinav
> On 4/7/2022 10:07 AM, Doug Anderson wrote:
> > Hi,
> >
> > On Thu
Hi,
On Thu, Apr 7, 2022 at 7:19 AM Sankeerth Billakanti (QUIC)
wrote:
>
> Hi Dmitry and Doug,
>
> > Hi,
> >
> > On Tue, Apr 5, 2022 at 10:36 AM Dmitry Baryshkov
> > wrote:
> > >
> > > On 05/04/2022 20:02, Doug Anderson wrote:
> > >
Hi,
On Tue, Apr 5, 2022 at 10:36 AM Dmitry Baryshkov
wrote:
>
> On 05/04/2022 20:02, Doug Anderson wrote:
> > Hi,
> >
> > On Tue, Apr 5, 2022 at 5:54 AM Dmitry Baryshkov
> > wrote:
> >>> 3. For DP and eDP HPD means something a little different
Hi,
On Tue, Apr 5, 2022 at 5:54 AM Dmitry Baryshkov
wrote:
> > 3. For DP and eDP HPD means something a little different. Essentially
> > there are two concepts: a) is a display physically connected and b) is
> > the display powered up and ready. For DP, the two are really tied
> > together. From
Hi,
On Sat, Apr 2, 2022 at 1:26 PM Dmitry Baryshkov
wrote:
>
> On Sat, 2 Apr 2022 at 20:06, Doug Anderson wrote:
> >
> > Hi,
> >
> > On Sat, Apr 2, 2022 at 3:37 AM Dmitry Baryshkov
> > wrote:
> > >
> > > On 01/04/2022 02:22, Doug Anderson w
Hi,
On Sat, Apr 2, 2022 at 3:37 AM Dmitry Baryshkov
wrote:
>
> On 01/04/2022 02:22, Doug Anderson wrote:
> > Hi,
> >
> > On Wed, Mar 30, 2022 at 9:03 AM Sankeerth Billakanti
> > wrote:
> >>
> >> @@ -1547,6 +1593,10 @@ int msm_dp_modeset_init(st
Hi,
On Wed, Mar 30, 2022 at 9:04 AM Sankeerth Billakanti
wrote:
>
> Some eDP sinks or platform boards will not support hpd.
> This patch adds support for those cases.
You could say more, like:
If we're not using HPD then _both_ the panel node and the eDP
controller node will have "no-hpd".
Hi,
On Wed, Mar 30, 2022 at 11:02 PM Sankeerth Billakanti (QUIC)
wrote:
>
> Hi Dmitry,
>
> > On Wed, 30 Mar 2022 at 19:04, Sankeerth Billakanti
> > wrote:
> > >
> > > The panel-edp driver modes needs to be validated differently from DP
> > > because the link capabilities are not available for
Hi,
On Wed, Mar 30, 2022 at 9:04 AM Sankeerth Billakanti
wrote:
>
> The aux_bus support with the dp_display driver will enable the dp
> resources during msm_dp_modeset_init. The host_init has to return early
> if the core is already initialized to prevent putting an additional vote
> for the dp
Hi,
On Wed, Mar 30, 2022 at 9:03 AM Sankeerth Billakanti
wrote:
>
> @@ -1374,6 +1382,12 @@ static int dp_pm_resume(struct device *dev)
> dp_catalog_ctrl_hpd_config(dp->catalog);
>
>
> + if (dp->dp_display.connector_type == DRM_MODE_CONNECTOR_DisplayPort)
> +
Hi,
On Wed, Mar 30, 2022 at 9:03 AM Sankeerth Billakanti
wrote:
>
> The source device should ensure the sink is ready before proceeding to
> read the sink capability or performing any aux transactions. The sink
s/performing/perform
> will indicate its readiness by asserting the HPD line. The
Hi,
On Wed, Mar 30, 2022 at 9:03 AM Sankeerth Billakanti
wrote:
>
> @@ -1547,6 +1593,10 @@ int msm_dp_modeset_init(struct msm_dp *dp_display,
> struct drm_device *dev,
>
> dp_display->encoder = encoder;
>
> + ret = dp_display_get_next_bridge(dp_display);
> + if (ret)
> +
Hi,
On Wed, Mar 30, 2022 at 4:19 PM Dmitry Baryshkov
wrote:
> > + bridge->ops =
> > + DRM_BRIDGE_OP_DETECT |
> > + DRM_BRIDGE_OP_HPD |
> > + DRM_BRIDGE_OP_MODES;
>
> I think OP_MODES should be used for eDP, shouldn't it?
Hi,
On Fri, Mar 25, 2022 at 7:11 AM Sankeerth Billakanti (QUIC)
wrote:
>
> > > @@ -114,10 +114,12 @@ struct drm_bridge *dp_bridge_init(struct
> > msm_dp *dp_display, struct drm_device *
> > > bridge->funcs = _bridge_ops;
> > > bridge->type = dp_display->connector_type;
> > >
> >
Hi,
On Fri, Mar 25, 2022 at 8:54 AM Sankeerth Billakanti (QUIC)
wrote:
>
> > -Original Message-
> > From: Doug Anderson
> > Sent: Saturday, March 19, 2022 5:26 AM
> > To: Stephen Boyd
> > Cc: Sankeerth Billakanti (QUIC) ; open list:OPEN
> > FIRM
Hi,
On Fri, Mar 25, 2022 at 6:41 AM Sankeerth Billakanti (QUIC)
wrote:
>
> > -Original Message-
> > From: Doug Anderson
> > Sent: Friday, March 18, 2022 10:51 PM
> > To: Sankeerth Billakanti (QUIC)
> > Cc: dri-devel ; linux-arm-msm > m...@vger.kern
Hi,
On Fri, Mar 18, 2022 at 4:27 PM Stephen Boyd wrote:
>
> > > Pushing hpd state checking into aux
> > > transactions looks like the wrong direction. Also, as I said up above I
> > > am concerned that even checking the GPIO won't work and we need some way
> > > to ask the bridge if HPD is
Hi,
On Fri, Mar 18, 2022 at 1:17 PM Stephen Boyd wrote:
>
> > > > + ret = dp_catalog_aux_wait_for_hpd_connect_state(aux->catalog);
> > >
> > > Why are we making aux transactions when hpd isn't asserted? Can we only
> > > register the aux device once we know that state is "connected"? I'm
>
Hi,
On Wed, Mar 16, 2022 at 10:36 AM Sankeerth Billakanti
wrote:
>
> Enable support for eDP interface via aux_bus on CRD platform.
>
> Signed-off-by: Sankeerth Billakanti
> ---
>
> Changes in v5:
> - Change the order of patches
> - Remove the backlight nodes
> - Remove the bias setting
>
Hi,
On Thu, Mar 17, 2022 at 6:19 PM Stephen Boyd wrote:
>
> Quoting Sankeerth Billakanti (2022-03-16 10:35:51)
> > The source device should ensure the sink is ready before
> > proceeding to read the sink capability or performing any aux transactions.
> > The sink will indicate its
Hi,
On Wed, Mar 16, 2022 at 10:36 AM Sankeerth Billakanti
wrote:
>
> Rename the edp_out label in the sc7280 platform to mdss_edp_out
> so that the nodes related to mdss are all grouped together in
> the board specific files.
>
> Signed-off-by: Sankeerth Billakanti
> ---
>
> Changes in v5:
> -
101 - 200 of 380 matches
Mail list logo
