Submitting series of patches to clean up DPU resource manager (RM)
of complicated hw iterations, redundant data maintenence and eventually
modifying the DPU to reserve display HW blocks only in atomic check
and caching the assigned HW blocks in atomic CRTC state.
Thanks,
Jeykumar S.
Jeykumar
pipeline. It helps the driver:
- to get rid of unwanted store and retrieval RM API's
- to preserve HW resources assigned in atomic_check
through atomic swap/duplicate.
Separate patch is submitted to remove resource
reservation in atomic_commit path.
Signed-off-by: Jeykumar Sankaran
---
drivers
Use the hw block pointers stored in crtc state to
release them back to RM resource pool. This change
is made to uncouple RM reservation from encoder_id.
Separate change is submitted to clean up RM of
encoder id tagging.
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/disp/dpu1
While creating display and event threads per crtc, validate
them before setting their priorities.
changes in v2:
- use dev_warn (Abhinav Kumar)
changes in v3:
- fix compilation error
Change-Id: I1dda805286df981c0f0e2b26507d089d3a21ff6c
Signed-off-by: Jeykumar Sankaran
While creating display and event threads per crtc, validate
them before setting their priorities.
changes in v2:
- use dev_warn (Abhinav Kumar)
Change-Id: I1dda805286df981c0f0e2b26507d089d3a21ff6c
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/msm_drv.c | 49
On 2018-10-08 15:24, Jeykumar Sankaran wrote:
On 2018-09-20 07:58, Sean Paul wrote:
From: Sean Paul
I noticed an empty label while driving by and decided to use
coccinelle to see if there were any more. Here's the spatch and the
invocation:
---
@@
identifier lbl;
expression E;
@@
- goto
On 2018-09-20 07:58, Sean Paul wrote:
From: Sean Paul
Per chapter 15 of coding-style, removing 'inline' keyword from
functions
that are larger than a typical macro. In a couple of cases I've
simplified the function and kept the inline.
Signed-off-by: Sean Paul
Reviewed-by: Jeykumar
On 2018-09-20 07:58, Sean Paul wrote:
From: Sean Paul
These functions aren't used anywhere, remove them.
Signed-off-by: Sean Paul
Reviewed-by: Jeykumar Sankaran
---
.../gpu/drm/msm/disp/dpu1/msm_media_info.h| 171 --
1 file changed, 171 deletions(-)
diff --git
On 2018-09-20 07:58, Sean Paul wrote:
From: Sean Paul
Local variable is not needed and condition can't be hit.
Signed-off-by: Sean Paul
Reviewed-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff
On 2018-09-20 07:58, Sean Paul wrote:
From: Sean Paul
We call out of the virt encoder into phys only to call back into the
virt for hw reset. So remove the indirection and just call the virt
function directly.
Signed-off-by: Sean Paul
Reviewed-by: Jeykumar Sankaran
---
drivers/gpu/drm
On 2018-09-20 07:58, Sean Paul wrote:
From: Sean Paul
I noticed an empty label while driving by and decided to use
coccinelle to see if there were any more. Here's the spatch and the
invocation:
---
@@
identifier lbl;
expression E;
@@
- goto lbl;
+ return E;
...
- lbl:
return E;
@@
While creating display and event threads per crtc, validate
them before setting their priorities.
Change-Id: I1dda805286df981c0f0e2b26507d089d3a21ff6c
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/msm_drv.c | 49 ++-
1 file changed, 16
On 2018-10-03 11:36, Sean Paul wrote:
From: Sean Paul
I found these tracepoints useful for debugging cursor/ctl, someone else
might find them useful too
Signed-off-by: Sean Paul
---
Thanks for the patch!
Reviewed-by: Jeykumar Sankaran
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 26
On 2018-10-01 13:30, Sean Paul wrote:
On Wed, Sep 26, 2018 at 11:56:47AM -0700, Jeykumar Sankaran wrote:
On 2018-09-19 11:56, Sean Paul wrote:
> From: Sean Paul
>
> This patch sprinkles a few async/legacy_cursor_update checks
> through commit to ensure that cursor updates ar
On 2018-10-01 13:29, Sean Paul wrote:
On Wed, Sep 26, 2018 at 11:51:35AM -0700, Jeykumar Sankaran wrote:
On 2018-09-19 11:56, Sean Paul wrote:
> From: Sean Paul
>
> There exists a case where a flush of a plane/dma may have been
triggered
> & started from an async commit. I
On 2018-10-02 12:17, Sean Paul wrote:
On Tue, Oct 02, 2018 at 11:09:47AM -0700, Jeykumar Sankaran wrote:
On 2018-09-17 13:49, Sean Paul wrote:
> From: Sean Paul
>
> cur_master in dpu_encoder is assigned at modeset and cleared on
> .disable(). Unfortunately dpms (or enable/d
On 2018-09-19 11:56, Sean Paul wrote:
From: Sean Paul
This patch sprinkles a few async/legacy_cursor_update checks
through commit to ensure that cursor updates aren't blocked on vsync.
There are 2 main components to this, the first is that we don't want to
wait_for_commit_done in msm_atomic
On 2018-09-24 10:45, Bruce Wang wrote:
Remove unneeded checks from _dpu_plane_get_aspace. The function
no longer needs to return anything so it is changed to void.
Are the subject and text still appropriate for the patch? The function
is returning
a ptr to msm_gem_address_space.
v3: change
On 2018-09-13 09:46, Jordan Crouse wrote:
enum dpu_ad isn't used and can be safely removed.
Signed-off-by: Jordan Crouse
---
Reviewed-by: Jeykumar Sankaran
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1
in dpu_plane_atomic_update().
Changes in v2:
- None
Signed-off-by: Sean Paul
---
Reviewed-by: Jeykumar Sankaran
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 71 +--
1 file changed, 14 insertions(+), 57 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
b/drivers/gpu/drm/msm
On 2018-09-12 06:54, Sean Paul wrote:
From: Sean Paul
plane->state->visible encompasses all of these checks and more, so we
can just check visible.
Changes in v2:
- None
Signed-off-by: Sean Paul
---
Reviewed-by: Jeykumar Sankaran
drivers/gpu/drm/msm/disp/dpu1/dpu_plane
On 2018-09-12 06:54, Sean Paul wrote:
From: Sean Paul
It's doing the same thing dpu_plane_enabled() is.
Changes in v2:
- None
Signed-off-by: Sean Paul
---
Reviewed-by: Jeykumar Sankaran
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions
isible = false when this is true. So remove
dpu_plane_atomic_check() and just use dpu_plane_sspp_atomic_check()
directly.
Changes in v2:
- Fix spelling mistake in Subject (Jeykumar)
Reviewed-by: Jeykumar Sankaran
Signed-off-by: Sean Paul
---
Reviewed-by: Jeykumar Sankaran
drivers/gpu/drm/msm/dis
(Jeykumar)
Cc: Jeykumar Sankaran
Signed-off-by: Sean Paul
---
Reviewed-by: Jeykumar Sankaran
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 57 +++
1 file changed, 17 insertions(+), 40 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
b/drivers/gpu/drm/msm
te->fb)
- return 0;
-
- DPU_DEBUG_PLANE(to_dpu_plane(plane), "\n");
-
- return dpu_plane_sspp_atomic_check(plane, state);
-}
-
void dpu_plane_flush(struct drm_plane *plane)
{
struct dpu_plane *pdpu;
Subject line typo:
%s/Consolodate/Consolidate
Reviewed-by
On 2018-09-11 13:15, Sean Paul wrote:
From: Sean Paul
src/dst rects are checked in both atomic_check and atomic_update, with
the more comprehensive check occurring in atomic_update, which is
backwards. So consolodate the checks in atomic_check.
Signed-off-by: Sean Paul
---
:
- Introduced in the series
changes in v6:
- remove parameter checking in rm reserve (Jordan)
Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c| 15 +++---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h| 4
in v5:
- Introduced in the series.
changes in v6:
- none
Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 25 ++---
drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 16
2 files changed, 2 insertions
Support for CDM block is not present in DPU. Remove CDM
handlers from resource manager.
changes in v4:
- Introduced in the series
changes in v5:
- Remove catalog references to CDM (Sean)
changes in v6:
- none
Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
removes left out variables of previous ping pong
split topology cleanup.
changes in v4:
- none
changes in v5:
- none
changes in v6:
- none
Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 3 ---
1 file changed, 3
ned-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 26 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 4 ++--
2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
b/drivers/
the feature is
formally implemented.
changes in v5:
- introduced in the series
changes in v6:
- none
Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 42 +-
drivers/gpu/drm/msm/disp/dpu1
lock all before crtc state access (Sean)
- remove unwanted memset for hw mixer cache (Sean)
changes in v6:
- none
Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 59 +++-
drivers/gpu/drm/msm/disp
(Sean)
changes in v6:
- avoid heap memory for topology (Sean)
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 10 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c| 3 -
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h| 1 -
drivers/gpu
Avoid querying RM for hw mdp block. Use the one
stored in KMS during initialization.
changes in v4:
- none
changes in v5:
- none
changes in v6:
- none
Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 12
Mark CRTC get_mixer_width helper API static as it is
not used outside the file.
changes in v4:
- Patch introduced in the series
changes in v5:
- Simplify the inline function (Sean)
changes in v6:
- none
Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
details on commit text on why the change is needed (Sean)
changes in v5:
- Reword commit text on the usage of hw_intf objects (Sean)
changes in v6:
- none
Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
---
.../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 53
iteration and mapping from physical
encoder to virtual encoder.
changes in v4:
- Fix hw_ctl initialization (Sean)
changes in v5:
- Update commit text with details on why the change is
needed (Sean)
changes in v6:
- none
Signed-off-by: Jeykumar Sankaran
Reviewed
of temporary variable for phys enc(Sean)
changes in v6:
- none
Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 43 -
1 file changed, 12 insertions(+), 31 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1
cleans up left out scalar config definitions from headers
changes in v4:
- none
changes in v5:
- none
changes in v6:
- none
Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h| 2 --
drivers/gpu/drm/msm/disp/dpu1
Encoder H_TILE values are not used for allocating the hw blocks.
no. of hw_intf blocks provides the info.
changes in v4:
- remove irrelevant changes (Sean)
- retain log macros (Sean)
changes in v5:
- none
changes in v6:
- none
Signed-off-by: Jeykumar Sankaran
Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 6 --
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 14 --
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 6 --
3 files changed, 26 deletions
only ENABLE/DISABLE events.
changes in v5:
- introduced in the series
changes in v6:
- define macro values using BIT(x) (Sean)
Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 28 +---
drivers/gpu
- use BIT(x) to define power handle event macros
- avoid head allocation for RM topology
Thanks and Regards,
Jeykumar S.
Jeykumar Sankaran (19):
drm/msm/dpu: remove debugfs support for misr
drm/msm/dpu: squash power handle event types
drm/msm/dpu: remove scalar config definitions
On 2018-09-06 09:14, Jordan Crouse wrote:
On Wed, Sep 05, 2018 at 07:08:26PM -0700, Jeykumar Sankaran wrote:
Connector states were passed around RM to update the custom
topology connector property with chosen topology data. Now that
we got rid of both custom properties and topology names
in v5:
- Introduced in the series.
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 25 ++---
drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 16
2 files changed, 2 insertions(+), 39 deletions(-)
diff --git a/drivers/gpu/drm/msm
:
- Introduced in the series
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c| 15 +++---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h| 4 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 3 +-
.../gpu/drm/msm/disp/dpu1
Support for CDM block is not present in DPU. Remove CDM
handlers from resource manager.
changes in v4:
- Introduced in the series
changes in v5:
- Remove catalog references to CDM (Sean)
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/Makefile | 1
the feature is
formally implemented.
changes in v5:
- introduced in the series
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 42 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 40
drivers/gpu/drm
DPU, being over protective, validates every parameter of a
module. This change traces the call stack for some of encoder
functions affected by previous set of clean up patches and
cleans up unwanted validations.
changes in v5:
- Introduced in the series
Signed-off-by: Jeykumar Sankaran
Encoder H_TILE values are not used for allocating the hw blocks.
no. of hw_intf blocks provides the info.
changes in v4:
- remove irrelevant changes (Sean)
- retain log macros (Sean)
changes in v5:
- none
Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
iteration and mapping from physical
encoder to virtual encoder.
changes in v4:
- Fix hw_ctl initialization (Sean)
changes in v5:
- Update commit text with details on why the change is
needed (Sean)
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/disp/dpu1
Mark CRTC get_mixer_width helper API static as it is
not used outside the file.
changes in v4:
- Patch introduced in the series
changes in v5:
- Simplify the inline function (Sean)
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 12
(Sean)
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 10 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c| 3 -
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h| 1 -
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 9 +-
.../gpu/drm/msm
removes left out variables of previous ping pong
split topology cleanup.
changes in v4:
- none
changes in v5:
- none
Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 3 ---
1 file changed, 3 deletions(-)
diff --git
lock all before crtc state access (Sean)
- remove unwanted memset for hw mixer cache (Sean)
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 59 +++-
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 22 ++--
2 files changed, 39
resource pool manager utility was introduced to manage
rotator sessions. Removing the support as the rotator
feature doesn't exist.
changes in v4:
- none
changes in v5:
- none
Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
the driver.
changes in v4:
- changed introduced in the series
changes in v5:
- update commit text with the need for the change(Sean)
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 139 -
drivers/gpu/drm/msm/disp/dpu1
details on commit text on why the change is needed (Sean)
changes in v5:
- Reword commit text on the usage of hw_intf objects (Sean)
Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
---
.../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 53 +++---
1 file changed
only ENABLE/DISABLE events.
changes in v5:
- introduced in the series
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 28 +---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 8 +++
drivers/gpu/drm/msm/disp/dpu1
/
Thanks and Regards,
Jeykumar S.
Jeykumar Sankaran (19):
drm/msm/dpu: remove debugfs support for misr
drm/msm/dpu: squash power handle event types
drm/msm/dpu: remove scalar config definitions
drm/msm/dpu: remove resource pool manager
drm/msm/dpu: remove ping pong split topology variables
Avoid querying RM for hw mdp block. Use the one
stored in KMS during initialization.
changes in v4:
- none
changes in v5:
- none
Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 12 +---
drivers/gpu/drm
of temporary variable for phys enc(Sean)
Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 43 -
1 file changed, 12 insertions(+), 31 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
b/drivers/gpu/drm
Rename hw_ctl to lm_ctl to mean the ctl associated
with the hw layer mixer block.
sed -i 's/\([*@.>]\)hw_ctl\([^s]\)/\1lm_ctl\2/g' dpu_crtc.c dpu_crtc.h
changes in v4:
- Specifiy shell command used for renaming (Sean)
changes in v5:
- none
Signed-off-by: Jeykumar Sanka
cleans up left out scalar config definitions from headers
changes in v4:
- none
changes in v5:
- none
Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h| 2 --
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h | 10 --
2
Cc: Jeykumar Sankaran
Cc: Ville Syrjälä
Signed-off-by: Sean Paul
---
Reviewed-by: Jeykumar Sankaran
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 3 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 34 +-
drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 1 -
drivers/gpu/drm
On 2018-08-31 09:08, Sean Paul wrote:
On Tue, Aug 28, 2018 at 05:40:01PM -0700, Jeykumar Sankaran wrote:
Strip down the support for topology enums. It
can be replaced with simple hw count checks.
Changes in v4:
...
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/disp/dpu1
On 2018-08-31 07:56, Sean Paul wrote:
On Tue, Aug 28, 2018 at 05:39:59PM -0700, Jeykumar Sankaran wrote:
Prep changes for state based resource management.
Moves all the hw block tracking for the crtc to the state
object.
Changes in v4...
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu
On 2018-08-31 07:56, Sean Paul wrote:
On Tue, Aug 28, 2018 at 05:39:59PM -0700, Jeykumar Sankaran wrote:
Prep changes for state based resource management.
Moves all the hw block tracking for the crtc to the state
object.
Changes in v4...
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu
On 2018-08-30 09:24, Sean Paul wrote:
On Tue, Aug 28, 2018 at 05:39:54PM -0700, Jeykumar Sankaran wrote:
Identify slave-master encoders during initialization and enable
the encoders explicitly as the current logic has redundant and
ambiguous loops.
Please include a "Changes in vX"
Mark CRTC get_mixer_width helper API static as it is
not used outside the file.
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 21 ++---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 18 --
2 files changed, 18 insertions(+), 21
Strip down the support for topology enums. It
can be replaced with simple hw count checks.
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c| 3 --
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h| 1 -
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h
Support for CDM block is not present in DPU. Remove CDM
handlers from resource manager.
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/Makefile | 1 -
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 2 -
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 5
Encoder H_TILE values are not used for allocating the hw blocks.
no. of hw_intf blocks provides the info.
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 5 -
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 3 ---
drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
Identify slave-master encoders during initialization and enable
the encoders explicitly as the current logic has redundant and
ambiguous loops.
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 46 ++---
1 file changed, 15 insertions
Instead of iterating for hw ctrl per physical encoder, this
patch moves the iterations and assignment to the virtual encoder.
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c| 22 +++---
.../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
Resource manager assigns hw_intf blocks for the encoder only on
modeset. If queried for hw_intf objects during init, it will be
NULL. Since hw_intf objects are needed only during encoder enable,
defer the query to encoder enable which will be triggered after
modeset.
Signed-off-by: Jeykumar
removes left out variables of previous ping pong
split topology cleanup.
Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h
b/drivers/gpu/drm/msm
/
Thanks and Regards,
Jeykumar S.
Jeykumar Sankaran (14):
drm/msm/dpu: remove debugfs support for misr
drm/msm/dpu: remove scalar config definitions
drm/msm/dpu: remove resource pool manager
drm/msm/dpu: remove ping pong split topology variables
drm/msm/dpu: enable master-slave encoders
resource pool manager utility was introduced to manage
rotator sessions. Removing the support as the rotator
feature doesn't exist.
Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 205 ---
drivers/gpu/drm/msm
Prep changes for state based resource management.
Moves all the hw block tracking for the crtc to the state
object.
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 60 ++--
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 22 ++--
2
Strip down debugfs support for misr data read on layer mixers
and interfaces.
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 139 -
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 6 -
drivers/gpu/drm/msm/disp/dpu1
cleans up left out scalar config definitions from headers
Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h| 2 --
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h | 10 --
2 files changed, 12 deletions(-)
diff --git a/drivers/gpu/drm
Avoid querying RM for hw mdp block. Use the one
stored in KMS during initialization.
Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 12 +---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 9 +
2 files
On 2018-08-28 15:52, Sean Paul wrote:
On Tue, Aug 28, 2018, 6:04 PM Jeykumar Sankaran
wrote:
On 2018-08-28 13:50, Sean Paul wrote:
From: Sean Paul
The atomic_check is a bit too aggressive with respect to planes
which
leave the active area. This caused a bunch of log spew when the
cursor
With patch [1], DPU is broken since it continues to use
incorrect connector_type to identify the display type. Update
DPU to use the encoder type to get the info.
[1] https://patchwork.kernel.org/patch/10568269/
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
DPU is broken with patch [1]. This patch cleans up few stale codes
and fixes the DPU bug by using encoder type to identify displays.
[1] https://patchwork.kernel.org/patch/10568269/
Thanks.
Jeykumar Sankaran (3):
drm/msm/dpu: remove stale display port programming
drm/msm/dpu: remove
Remove stale display port programming. It can be
added back with DPU support for display port.
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
b/drivers/gpu/drm
the conservative bounds checks from atomic and clips
the dst rect such that we properly display planes which go off the
screen.
Changes in v2:
- Apply the clip to src as well (taking into account scaling)
Cc: Sravanthi Kollukuduru
Cc: Jeykumar Sankaran
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm
On 2018-08-23 07:21, Sean Paul wrote:
On Wed, Aug 22, 2018 at 02:56:22PM -0700, Jeykumar Sankaran wrote:
On 2018-08-22 13:41, Sean Paul wrote:
> From: Sean Paul
>
> The atomic_check is a bit too aggressive with respect to planes which
> leave the active area. This caused a bunch
On 2018-08-22 13:41, Sean Paul wrote:
From: Sean Paul
The atomic_check is a bit too aggressive with respect to planes which
leave the active area. This caused a bunch of log spew when the cursor
got to the edge of the screen and stopped it from going all the way.
This patch removes the
not a connector! We really want to
use DRM_MODE_ENCODER_DSI (integer 6) instead of DRM_MODE_CONNECTOR_DSI
here, or we'll go out of bounds of the encoder array. Pass the right
thing and everything is fine.
Cc: Jeykumar Sankaran
Cc: Jordan Crouse
Cc: Sean Paul
Fixes: 25fdd5933e4c ("drm/msm
On 2018-08-14 13:26, Sean Paul wrote:
On Tue, Aug 07, 2018 at 08:20:10PM -0700, Jeykumar Sankaran wrote:
Subclass drm private state for DPU for handling driver
specific data. Adds atomic private object and private object
lock to dpu kms. Provides helper function to retrieve DPU
private data
On 2018-08-14 13:14, Sean Paul wrote:
On Tue, Aug 07, 2018 at 08:20:08PM -0700, Jeykumar Sankaran wrote:
Strip down the support for topology enums. It
can be replaced with simple hw count checks.
Can you remove the enum entirely? A quick scan seems like it might be
possible,
it seems like
On 2018-08-14 12:19, Sean Paul wrote:
On Tue, Aug 07, 2018 at 08:12:31PM -0700, Jeykumar Sankaran wrote:
Identify slave-master encoders and program them explicitly.
You've got the what, but could you please explain the why?
changes in v2:
- none
changes in v3:
- none
://gitlab.freedesktop.org/seanpaul/dpu-staging/commits/for-next
Change-Id: Iaab32badff224ffed024e6ef6576efc8b3af3aec
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 61 +
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 15
2 files
: Ie9d42eb3e93257816daf3d36c444a335645d65c6
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 165 ++---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 32 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c| 133 ++--
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 2
Strip down the support for topology enums. It
can be replaced with simple hw count checks.
changes in v2:
- none
changes in v3:
- none
Change-Id: If9b2a4db5bbdf8545b99b6d90825e256d014382d
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
Encoder H_TILE values are not used for allocating the hw blocks.
no. of hw_intf blocks provides the info.
changes in v2:
- none
changes in v3:
- none
Change-Id: I1c1c13e9b9f608fbaa8c5897f9f1892029107ac5
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/disp/dpu1
Prep changes for state based resource management.
Moves all the hw block tracking for the crtc to the state
object.
changes in v2:
- none
changes in v3:
- none
Change-Id: I2816e9e28b27f1126b477d62eb3858a30a652747
Signed-off-by: Jeykumar Sankaran
---
drivers/gpu/drm/msm/disp
201 - 300 of 383 matches
Mail list logo
