Re: [Freedreno] [PATCH v3 3/3] drm/komeda: Fix IS_ERR() vs NULL check in komeda_component_get_avail_scaler()

RE") > Signed-off-by: Gaosheng Cui > Reviewed-by: Liviu Dudau > --- > drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_stat

Re: [Freedreno] [PATCH] drm: Explicitly include correct DT includes

alidp_drv.c > index c03cfd57b752..a5a9534d4353 100644 > --- a/drivers/gpu/drm/arm/malidp_drv.c > +++ b/drivers/gpu/drm/arm/malidp_drv.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > For the komeda and malidp d

Re: [Freedreno] [PATCH v2 3/3] drm/komeda: Fix IS_ERR() vs NULL check in komeda_component_get_avail_scaler()

t; Let me know if there's anything I can do, thanks for your work again! > > Gaosheng, > > On 2023/7/13 16:54, Liviu Dudau wrote: > > Hello, > > > > On Thu, Jul 13, 2023 at 10:05:56AM +0800, Gaosheng Cui wrote: > > > The komeda_pipeline_get_state() return

Re: [Freedreno] [PATCH v2 3/3] drm/komeda: Fix IS_ERR() vs NULL check in komeda_component_get_avail_scaler()

ndling the return value from komeda_pipeline_get_state(). If IS_ERR(st) is true it should use return ERR_CAST(st), following the same pattern as komeda_pipeline_get_state(). If you don't want to update this patch I can send a separate patch. Otherwise, the change looks good to me. Reviewed-by:

Re: [Freedreno] [PATCH v3 3/3] drm: Convert users of drm_of_component_match_add to component_match_add_of

ce *pdev) > { > struct device_node *port; > @@ -929,9 +922,7 @@ static int malidp_platform_probe(struct platform_device > *pdev) > if (!port) > return -ENODEV; > > - drm_of_component_match_add(>dev, , malidp_compare_dev, > -

Re: [Freedreno] [PATCH 4/5] drm/komeda: Fix IS_ERR() vs NULL check in komeda_component_get_avail_scaler()

gned-off-by: Gaosheng Cui Acked-by: Liviu Dudau Thanks for the fix! Best regards, Liviu > --- > drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_

Re: [Freedreno] [PATCH v2 04/17] drm/msm/dpu: add writeback blocks to the sm8250 DPU catalog

On Tue, Apr 19, 2022 at 06:45:56PM -0700, Abhinav Kumar wrote: > Add writeback blocks to the sm8250 DPU hardware catalog. Other > chipsets support writeback too but add it to sm8250 to prototype > the feature so that it can be easily extended to other chipsets. > > changes in v2: > - none >

Re: [Freedreno] [PATCH v7 3/4] drm: allow real encoder to be passed for drm_writeback_connector

Hi Abhinav, Sorry for the delay in reviewing this, Easter break happened in between. On Fri, Apr 08, 2022 at 05:53:54PM -0700, Abhinav Kumar wrote: > For some vendor driver implementations, display hardware can > be shared between the encoder used for writeback and the physical > display. > >

Re: [Freedreno] [PATCH v6 2/4] drm: introduce drm_writeback_connector_init_with_encoder() API

already been > + * created and initialized before invoking this function. > + * > + * In addition, this function also assumes that callers of this API will > manage > + * assigning the encoder helper functions, possible_crtcs and any other > encoder > + * specific

Re: [Freedreno] [PATCH v5 2/4] drm: introduce drm_writeback_connector_init_with_encoder() API

On Fri, Mar 25, 2022 at 09:31:35AM -0700, Abhinav Kumar wrote: > Hi Liviu Hi Abhinav, Sorry for the delay, got busy with other things at the beginning of the week. > > On 3/25/2022 3:19 AM, Liviu Dudau wrote: > > On Thu, Mar 24, 2022 at 09:36:50AM -0700, Abhinav Kumar wrote:

Re: [Freedreno] [PATCH v5 2/4] drm: introduce drm_writeback_connector_init_with_encoder() API

On Thu, Mar 24, 2022 at 09:36:50AM -0700, Abhinav Kumar wrote: > Hi Liviu Hello, > > Thanks for the response. > > On 3/24/2022 3:12 AM, Liviu Dudau wrote: > > On Wed, Mar 23, 2022 at 11:28:56AM -0700, Abhinav Kumar wrote: > > > Hi Liviu > > > > Hell

Re: [Freedreno] [PATCH v5 2/4] drm: introduce drm_writeback_connector_init_with_encoder() API

On Wed, Mar 23, 2022 at 11:28:56AM -0700, Abhinav Kumar wrote: > Hi Liviu Hello, > > Thanks for the review. > > On 3/23/2022 9:46 AM, Liviu Dudau wrote: > > On Mon, Mar 21, 2022 at 04:56:43PM -0700, Abhinav Kumar wrote: > > > For vendors drivers w

Re: [Freedreno] [PATCH v5 2/4] drm: introduce drm_writeback_connector_init_with_encoder() API

On Mon, Mar 21, 2022 at 04:56:43PM -0700, Abhinav Kumar wrote: > For vendors drivers which pass an already allocated and > initialized encoder especially for cases where the encoder > hardware is shared OR the writeback encoder shares the resources > with the rest of the display pipeline introduce

Re: [Freedreno] [PATCH v3 1/3] drm: allow real encoder to be passed for drm_writeback_connector

On Thu, Mar 17, 2022 at 10:26:38AM -0700, Abhinav Kumar wrote: > Hi Laurent > > Thanks for the review. > > On 3/17/2022 1:51 AM, Laurent Pinchart wrote: > > Hi Abhinav, > > > > Thank you for the patch. > > > > On Wed, Mar 16, 2022 at 11:48:16AM -0700, Abhinav Kumar wrote: > > > For some vendor

Re: [Freedreno] [PATCH v4 2/4] drm: allow real encoder to be passed for drm_writeback_connector

On Thu, Mar 17, 2022 at 06:45:34PM -0700, Abhinav Kumar wrote: > For some vendor driver implementations, display hardware can > be shared between the encoder used for writeback and the physical > display. > > In addition resources such as clocks and interrupts can > also be shared between

Re: [Freedreno] [PATCH v4 1/4] drm: allow passing possible_crtcs to drm_writeback_connector_init()

nnector *connector = _connector->base; > @@ -190,6 +191,9 @@ int drm_writeback_connector_init(struct drm_device *dev, > return PTR_ERR(blob); > > drm_encoder_helper_add(_connector->encoder, enc_helper_funcs); > + > + wb_connector->encoder.possible_crtcs = possible_crtcs

Re: [Freedreno] [PATCH v2 02/14] drm/arm/hdlcd: Convert to Linux IRQ interfaces

homas Zimmermann > Acked-by: Sam Ravnborg Sorry for the delayed response due to holidays. Acked-by: Liviu Dudau Best regards, Liviu > --- > drivers/gpu/drm/arm/hdlcd_drv.c | 174 ++-- > drivers/gpu/drm/arm/hdlcd_drv.h | 1 + > 2 files changed, 97 ins

Re: [Freedreno] [PATCH v2] drm: prefix header search paths with $(srctree)/

da/Makefile > b/drivers/gpu/drm/arm/display/komeda/Makefile > index 1b875e5..a72e30c 100644 > --- a/drivers/gpu/drm/arm/display/komeda/Makefile > +++ b/drivers/gpu/drm/arm/display/komeda/Makefile > @@ -1,8 +1,8 @@ > # SPDX-License-Identifier: GPL-2.0 > > ccflags-y :=

Re: [Freedreno] [PATCH 2/2] drm/atomic: Create and use __drm_atomic_helper_crtc_reset() everywhere

emented its own __drm_atomic_helper_crtc_reset(), > convert it to the common one. > > Signed-off-by: Maarten Lankhorst > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian König" > Cc: "David (ChunMing) Zhou" > Cc: David Airlie >

Re: [Freedreno] [RFC 1/4] drm: Add writeback connector type

On Fri, Feb 23, 2018 at 11:39:06AM -0500, Sean Paul wrote: > On Fri, Feb 23, 2018 at 04:21:05PM +0000, Liviu Dudau wrote: > > On Fri, Feb 23, 2018 at 10:59:35AM -0500, Sean Paul wrote: > > > On Fri, Feb 23, 2018 at 08:17:51AM -0500, Rob Clark wrote: > > > > F

Re: [Freedreno] [RFC 1/4] drm: Add writeback connector type

On Fri, Feb 23, 2018 at 11:43:29AM -0500, Sean Paul wrote: > On Fri, Feb 23, 2018 at 11:25:11AM -0500, Rob Clark wrote: > > On Fri, Feb 23, 2018 at 10:59 AM, Sean Paul wrote: > > > > > > Have we considered hiding writeback behind a client cap instead? > > > > It is kinda

Re: [Freedreno] [RFC 1/4] drm: Add writeback connector type

> > > Changes since v4: > > - Added atomic_commit() vfunc to connector helper funcs, so that > >writeback jobs are committed from atomic helpers > > > > Signed-off-by: Brian Starkey <brian.star...@arm.com> > > [rebased and fixed conflicts] >

Re: [Freedreno] [RFC 1/4] drm: Add writeback connector type

On Fri, Feb 23, 2018 at 09:24:10AM -0500, Rob Clark wrote: > On Fri, Feb 23, 2018 at 9:00 AM, Liviu Dudau <liviu.du...@arm.com> wrote: > > Hi Rob, > > > > On Fri, Feb 23, 2018 at 08:17:51AM -0500, Rob Clark wrote: > >> From: Brian Starkey <brian.star...@

[Freedreno] [PATCH] drm/msm/hdmi: Use bitwise operators when building register values

Commit c0c0d9eeeb8d ("drm/msm: hdmi audio support") uses logical OR operators to build up a value to be written in the REG_HDMI_AUDIO_INFO0 and REG_HDMI_AUDIO_INFO1 registers when it should have used bitwise operators. Signed-off-by: Liviu Dudau <liviu.du...@arm.com> Fixes: c0c0d9

Re: [Freedreno] [PATCH v3] drm: Add DRM_MODE_ROTATE_ and DRM_MODE_REFLECT_ to UAPI

RM_MODE_ROTATE_180 | > + DRM_MODE_ROTATE_270 | DRM_MODE_REFLECT_X | > DRM_MODE_REFLECT_Y; > u32 *formats; > int ret, i, j, n; > > @@ -420,7 +420,7 @@ int malidp_de_planes_init(struct drm_device *drm) > continue; &g