Re: [PATCH 1/2] drm/print: drop include debugfs.h and include where needed

2024-04-24 Thread Lyude Paul
For the nouveau bits: Reviewed-by: Lyude Paul On Mon, 2024-04-22 at 15:10 +0300, Jani Nikula wrote: > Surprisingly many places depend on debugfs.h to be included via > drm_print.h. Fix them. > > v3: Also fix armada, ite-it6505, imagination, msm, sti, vc4, and xe > >

Re: [Freedreno] [PATCH 5/9] drm/nouveau/pm: Annotate struct nvkm_perfdom with __counted_by

2023-09-22 Thread Lyude Paul
Reviewed-by: Lyude Paul Thanks! On Fri, 2023-09-22 at 10:32 -0700, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time che

[Freedreno] Requests For Proposals for hosting XDC 2023 are now open

2022-08-18 Thread Lyude Paul
there generally will be a bit of Q with organizers. And if you just have some questions about what organizing XDC entails, please feel free to chat with previous organizers, or someone from the board. Best regards, Lyude Paul On behalf of X.org -- Cheers, Lyude Paul (she/her) Software

[Freedreno] XDC 2022: Registration & Call for Presentations still open!

2022-06-02 Thread Lyude Paul
d me an email to x...@codeweavers.com, adding on CC the X.org board (board at foundation.x.org).   And don't forget, you can follow us on Twitter for all the latest updates and to stay connected:   https://twitter.com/XOrgDevConf Best regards, Lyude Paul, on behalf of X.org

Re: [Freedreno] [PATCH] drm: Document that power requirements for DP AUX transfers

2022-05-05 Thread Lyude Paul
te that if a > +    *   panel driver is initiating a DP AUX transfer it may power > itself > +    *   up however it wants. All other code should ensure that the > +    *   pre_enable() bridge chain (which eventually calls the panel > +    *   prepare function) has powered the panel. > */ > ssize_t (*transfer)(struct drm_dp_aux *aux, >     struct drm_dp_aux_msg *msg); -- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat

Re: [Freedreno] [PATCH] drm: Document that power requirements for DP AUX transfers

2022-05-04 Thread Lyude Paul
d take a first > step by spewing a WARN_ON if someone directly uses /dev/aux for eDP? > > c) Somehow dynamically create / remove the /dev/aux device as the eDP > panel turns off and on again. If /dev/aux is there then we know that > the panel is on. NOTE: this ignores PSR. I don't think we'd want to > delete / create the /dev/aux node that often. So we'd either have to > still accept that the transfers will sometimes fail (c1) or make it a > requirement that we bring the panel out of PSR for an AUX transfer > (c2). > > > Technically we could list option (d) to power the panel up, but as per > above I think it's pretty awkward and doesn't feel like the right way > to go. Obviously happy to hear other opinions, though. > -- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat

[Freedreno] Requests For Proposals for hosting XDC 2023 are now open

2022-04-26 Thread Lyude Paul
there generally will be a bit of Q with organizers. And if you just have some questions about what organizing XDC entails, please feel free to chat with previous organizers, or someone from the board. Best regards, Lyude Paul On behalf of X.org

[Freedreno] XDC 2022: Registration & Call for Proposals now open!

2022-04-26 Thread Lyude Paul
oard (board at foundation.x.org). And don't forget, you can follow us on Twitter for all the latest updates and to stay connected: https://twitter.com/XOrgDevConf Best regards, Lyude Paul, on behalf of X.org

[Freedreno] 2022 X.Org Foundation Election vote results

2022-04-19 Thread Lyude Paul
that Emma Anholt, Alyssa Rosenzweig, Mark Filion and Ricardo Garcia were elected for two year terms. The old full board is: Emma Anholt, Samuel Iglesias Gonsálvez, Mark Filion, Manasi D Navare, Keith Packard, Lyude Paul, Daniel Vetter, Harry Wentland The new full board is: Emma Anholt, Samuel

[Freedreno] 2022 X.org Foundation Election Candidates

2022-03-28 Thread Lyude Paul
begins. Lyude Paul, on behalf of the X.Org elections committee

[Freedreno] 2022 X.Org Foundation Membership deadline for voting in the election

2022-03-16 Thread Lyude Paul
in the upcoming election is 31 March 2022 at 23:59 UTC. If you are interested in joining the X.Org Foundation or in renewing your membership, please visit the membership system site at: https://members.x.org/ Lyude Paul, on behalf of the X.Org elections committee

[Freedreno] 2022 X.Org Board of Directors Elections Nomination period is NOW

2022-03-16 Thread Lyude Paul
were Lyude Paul, Samuel Iglesias Gonsálvez, Manasi D Navare and Daniel Vetter. They will continue to serve until their term ends in 2023. Current directors whose term expires in 2022 are Emma Anholt, Keith Packard, Harry Wentland and Mark Filion. A director is expected to participate

[Freedreno] 2022 X.Org Board of Directors Elections timeline extended, Request for nominations

2022-03-03 Thread Lyude Paul
will serve as directors for two year terms. The directors who received two year terms starting in 2021 were Lyude Paul, Samuel Iglesias Gonsálvez, Manasi D Navare and Daniel Vetter. They will continue to serve until their term ends in 2023. Current directors whose term expires in 2022 are Emma Anholt

[Freedreno] 2022 X.Org Board of Directors Elections Nomination period is NOW

2022-02-21 Thread Lyude Paul
of directors elected from the membership. Each year, an election is held to bring the total number of directors to eight. The four members receiving the highest vote totals will serve as directors for two year terms. The directors who received two year terms starting in 2021 were Lyude Paul, Samuel

[Freedreno] [Important!] 2022 X.Org Foundation Membership deadline for voting in the election

2022-02-17 Thread Lyude Paul
/Elections/2022/ Lyude Paul, On behalf of the X.Org elections committee

[Freedreno] [Important!] 2022 X.Org Foundation Membership deadline for voting in the election

2022-02-04 Thread Lyude Paul
/Elections/2022/     Lyude Paul,     On behalf of the X.Org elections committee

Re: [Freedreno] [Nouveau] [PATCH v2 3/5] drm/dp: Move DisplayPort helpers into separate helper module

2022-01-11 Thread Lyude Paul
Acked-by: Lyude Paul On Wed, 2021-12-15 at 11:43 +0100, Thomas Zimmermann wrote: > Move DisplayPort functions into a separate module to reduce the size > of the KMS helpers. Select DRM_DP_HELPER for all users of the code. To > avoid naming conflicts, rename drm_dp_helper.c to

Re: [Freedreno] [PATCH] drm/msm: remove unneeded variable

2021-09-03 Thread Lyude Paul
On Fri, 2021-09-03 at 21:31 +0300, Dmitry Baryshkov wrote: > On 02/09/2021 21:40, Lyude Paul wrote: > > Reviewed-by: Lyude Paul > > > > Do you need me to push this? > > We'd pick this up through the msm tree. ah-totally forgot msm had their own tree and didn't go th

Re: [Freedreno] [PATCH] drm/msm: remove unneeded variable

2021-09-02 Thread Lyude Paul
Reviewed-by: Lyude Paul Do you need me to push this? On Tue, 2021-08-31 at 04:51 -0700, cgel@gmail.com wrote: > From: Chi Minghao > > Fix the following coccicheck REVIEW: > ./drivers/gpu/drm/msm/edp/edp_ctrl.c:1245:5-8 Unneeded variable > > Reported-by: Zeal Robot &g

Re: [Freedreno] [PATCH v3] drm/dp_mst: Fix return code on sideband message failure

2021-08-30 Thread Lyude Paul
On Mon, 2021-08-30 at 08:56 -0700, khs...@codeaurora.org wrote: > On 2021-08-25 09:26, Lyude Paul wrote: > > The patch was pushed yes (was part of drm-misc-next-2021-07-29), seems > > like it > > just hasn't trickled down to linus's branch quite yet. > > Hi Stephen

Re: [Freedreno] [PATCH v3] drm/dp_mst: Fix return code on sideband message failure

2021-08-25 Thread Lyude Paul
The patch was pushed yes (was part of drm-misc-next-2021-07-29), seems like it just hasn't trickled down to linus's branch quite yet. On Wed, 2021-08-25 at 09:06 -0700, khs...@codeaurora.org wrote: > On 2021-07-27 15:44, Lyude Paul wrote: > > Nice timing, you literally got me as I was

Re: [Freedreno] [PATCH v3] drm/dp_mst: Fix return code on sideband message failure

2021-07-27 Thread Lyude Paul
+). will add these tags when I push it On Tue, 2021-07-27 at 15:41 -0700, khs...@codeaurora.org wrote: > On 2021-07-27 12:21, Lyude Paul wrote: > > On Thu, 2021-07-22 at 15:28 -0700, khs...@codeaurora.org wrote: > > > > > > It looks like this patch is good to go (mainli

Re: [Freedreno] [PATCH v3] drm/dp_mst: Fix return code on sideband message failure

2021-07-22 Thread Lyude Paul
t;drm/dp_mst: Add sideband down request tracing + > > > selftests") > > > > > > Signed-off-by: Rajkumar Subbiah > > > Signed-off-by: Kuogee Hsieh > > > > > > Reviewed-by: Stephen Boyd > > > > Reviewed-by: Jani Nikula &g

Re: [Freedreno] [PATCH v2] drm/dp_mst: Fix return code on sideband message failure

2021-07-02 Thread Lyude Paul
mst_dump_sideband_msg_tx(, txmsg); > +   drm_printf(, "sideband msg failed to send\n"); > +   drm_dp_mst_dump_sideband_msg_tx(, txmsg); > +   } > return ret; > } >   -- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [PATCH] drm/dp_mst: Fix return code on sideband message failure

2021-06-29 Thread Lyude Paul
{ > > +   struct drm_printer p = > > drm_debug_printer(DBG_PREFIX); > > > > -   drm_printf(, "sideband msg failed to send\n"); > > -   drm_dp_mst_dump_sideband_msg_tx(, txmsg); > > +   drm_printf(, "sideband msg failed to send\n&qu

Re: [Freedreno] [PATCH] drm/msm/dp: Add missing drm_device backpointer

2021-06-25 Thread Lyude Paul
Ah - must have missed this when I added this. Thanks for the fix! Reviewed-by: Lyude Paul On Thu, 2021-06-24 at 20:47 -0700, Bjorn Andersson wrote: > '6cba3fe43341 ("drm/dp: Add backpointer to drm_device in drm_dp_aux")' > introduced a mandator drm_device backpointer in s

Re: [Freedreno] [v6 1/5] drm/panel: add basic DP AUX backlight support

2021-06-16 Thread Lyude Paul
Reviewed-by: Lyude Paul On Sat, 2021-06-12 at 17:37 +0530, Rajeev Nandan wrote: > Some panels support backlight control over DP AUX channel using > VESA's standard backlight control interface. > Using new DRM eDP backlight helpers, add support to create and > register a backlig

Re: [Freedreno] [v4 1/4] drm/panel-simple: Add basic DPCD backlight support

2021-06-01 Thread Lyude Paul
klight(>base); > -   if (err) > -   goto disable_pm_runtime; > +   if (panel->desc->uses_dpcd_backlight) { > +   if (!panel->aux) { > +   dev_err(dev, "edp backlight needs DP aux\n"); > +   err = -E

Re: [Freedreno] [v4 1/4] drm/panel-simple: Add basic DPCD backlight support

2021-06-01 Thread Lyude Paul
klight(>base); > -   if (err) > -   goto disable_pm_runtime; > +   if (panel->desc->uses_dpcd_backlight) { > +   if (!panel->aux) { > +   dev_err(dev, "edp backlight needs DP aux\n"); > +   err = -E

Re: [Freedreno] [v3 2/2] backlight: Add DisplayPort aux backlight driver

2021-04-30 Thread Lyude Paul
X_MAX_BRIGHTNESS) > > +   val = DP_AUX_MAX_BRIGHTNESS; > > + > > +   bl_props.max_brightness = val; > > +   bl_props.brightness = val; > > +   bl_props.type = BACKLIGHT_RAW; > > +   bd = devm_backlight_device_register(>dev, dev_name( > > >dev), > > +   >dev, aux_bl, > > +   _bl_ops, _props); > > +   if (IS_ERR(bd)) { > > +   ret = PTR_ERR(bd); > > +   dev_err(>dev, > > + "failed to register backlight (%d)\n", ret); > > +   goto free_ddc; > > +   } > > + > > +   platform_set_drvdata(pdev, bd); > > + > > +   return 0; > > + > > +free_ddc: > > +   if (ddc) > > +   put_device(>dev); > > + > > +   return ret; > > +} > > + > > +static int dp_aux_backlight_remove(struct platform_device *pdev) > > +{ > > +   struct backlight_device *bd = platform_get_drvdata(pdev); > > +   struct dp_aux_backlight *aux_bl = bl_get_data(bd); > > +   struct i2c_adapter *ddc = _bl->aux->ddc; > > + > > +   if (ddc) > > +   put_device(>dev); > > + > > +   return 0; > > +} > > + > > +static const struct of_device_id dp_aux_bl_of_match_table[] = { > > +   { .compatible = "dp-aux-backlight"}, > > +   {}, > > +}; > > +MODULE_DEVICE_TABLE(of, dp_aux_bl_of_match_table); > > + > > +static struct platform_driver dp_aux_backlight_driver = { > > +   .driver = { > > +   .name = "dp-aux-backlight", > > +   .of_match_table = dp_aux_bl_of_match_table, > > +   }, > > +   .probe = dp_aux_backlight_probe, > > +   .remove = dp_aux_backlight_remove, > > + > > +}; > > +module_platform_driver(dp_aux_backlight_driver); > > + > > +MODULE_DESCRIPTION("DisplayPort aux backlight driver"); > > +MODULE_LICENSE("GPL v2"); > -- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

[Freedreno] [PATCH v4 06/17] drm/dp: Pass drm_dp_aux to drm_dp*_link_train_channel_eq_delay()

2021-04-23 Thread Lyude Paul
So that we can start using drm_dbg_*() for drm_dp_link_train_channel_eq_delay() and drm_dp_lttpr_link_train_channel_eq_delay(). Signed-off-by: Lyude Paul Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 2 +- drivers/gpu/drm/drm_dp_helper.c

[Freedreno] [PATCH v4 05/17] drm/dp: Pass drm_dp_aux to drm_dp_link_train_clock_recovery_delay()

2021-04-23 Thread Lyude Paul
So that we can start using drm_dbg_*() in drm_dp_link_train_clock_recovery_delay(). Signed-off-by: Lyude Paul Reviewed-by: Laurent Pinchart Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 2 +- drivers/gpu/drm/drm_dp_helper.c | 3

[Freedreno] [PATCH v4 03/17] drm/dp: Add backpointer to drm_device in drm_dp_aux

2021-04-23 Thread Lyude Paul
ure to point this out in the documentation for struct drm_dp_aux. v3: * Add WARN_ON_ONCE() to drm_dp_aux_register() if drm_dev isn't filled out Signed-off-by: Lyude Paul Acked-by: Thierry Reding --- drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 2 ++ .../gpu/drm/amd/display/amdgpu

[Freedreno] [PATCH v3 09/20] drm/dp: Pass drm_dp_aux to drm_dp*_link_train_channel_eq_delay()

2021-04-19 Thread Lyude Paul
So that we can start using drm_dbg_*() for drm_dp_link_train_channel_eq_delay() and drm_dp_lttpr_link_train_channel_eq_delay(). Signed-off-by: Lyude Paul Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 2 +- drivers/gpu/drm/drm_dp_helper.c

[Freedreno] [PATCH v3 08/20] drm/dp: Pass drm_dp_aux to drm_dp_link_train_clock_recovery_delay()

2021-04-19 Thread Lyude Paul
So that we can start using drm_dbg_*() in drm_dp_link_train_clock_recovery_delay(). Signed-off-by: Lyude Paul Reviewed-by: Laurent Pinchart Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 2 +- drivers/gpu/drm/drm_dp_helper.c | 3

[Freedreno] [PATCH v3 06/20] drm/dp: Add backpointer to drm_device in drm_dp_aux

2021-04-19 Thread Lyude Paul
ure to point this out in the documentation for struct drm_dp_aux. v3: * Add WARN_ON_ONCE() to drm_dp_aux_register() if drm_dev isn't filled out Signed-off-by: Lyude Paul Acked-by: Thierry Reding --- drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 7 --- .../gpu/drm/amd/disp

[Freedreno] [PATCH v3 03/20] drm/dp: Move i2c init to drm_dp_aux_init, add __must_check and fini

2021-04-19 Thread Lyude Paul
() and hook it up in all DRM drivers across the kernel to take care of cleaning up the i2c adapter once it's no longer needed. This should also fix the regressions noted in the Tegra driver. Signed-off-by: Lyude Paul Fixes: 39c17ae60ea9 ("drm/tegra: Don't register DP AUX channels before conne

[Freedreno] [PATCH v2 09/20] drm/dp: Pass drm_dp_aux to drm_dp*_link_train_channel_eq_delay()

2021-03-26 Thread Lyude Paul
So that we can start using drm_dbg_*() for drm_dp_link_train_channel_eq_delay() and drm_dp_lttpr_link_train_channel_eq_delay(). Signed-off-by: Lyude Paul Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 2 +- drivers/gpu/drm/drm_dp_helper.c

[Freedreno] [PATCH v2 05/20] drm/dp: Add backpointer to drm_device in drm_dp_aux

2021-03-26 Thread Lyude Paul
ure to point this out in the documentation for struct drm_dp_aux. Signed-off-by: Lyude Paul --- drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 1 + .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 1 + drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 1 + drivers/

[Freedreno] [PATCH v2 08/20] drm/dp: Pass drm_dp_aux to drm_dp_link_train_clock_recovery_delay()

2021-03-26 Thread Lyude Paul
So that we can start using drm_dbg_*() in drm_dp_link_train_clock_recovery_delay(). Signed-off-by: Lyude Paul Reviewed-by: Laurent Pinchart Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 2 +- drivers/gpu/drm/drm_dp_helper.c | 3

Re: [Freedreno] [PATCH 15/30] drm/dp: Add backpointer to drm_device in drm_dp_aux

2021-02-24 Thread Lyude Paul
On Sun, 2021-02-21 at 20:21 +0200, Laurent Pinchart wrote: > Hi Lyude, > > Thank you for the patch. > > On Fri, Feb 19, 2021 at 04:53:11PM -0500, Lyude Paul wrote: > > This is something that we've wanted for a while now: the ability to > > actually look up the respec

[Freedreno] [PATCH 20/30] drm/dp: Pass drm_dp_aux to drm_dp*_link_train_channel_eq_delay()

2021-02-19 Thread Lyude Paul
So that we can start using drm_dbg_*() for drm_dp_link_train_channel_eq_delay() and drm_dp_lttpr_link_train_channel_eq_delay(). Signed-off-by: Lyude Paul --- drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 2 +- drivers/gpu/drm/drm_dp_helper.c| 14

[Freedreno] [PATCH 15/30] drm/dp: Add backpointer to drm_device in drm_dp_aux

2021-02-19 Thread Lyude Paul
ure to point this out in the documentation for struct drm_dp_aux. Signed-off-by: Lyude Paul --- drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 1 + .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 1 + drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 1 + drivers/

[Freedreno] [PATCH 19/30] drm/dp: Pass drm_dp_aux to drm_dp_link_train_clock_recovery_delay()

2021-02-19 Thread Lyude Paul
So that we can start using drm_dbg_*() in drm_dp_link_train_clock_recovery_delay(). Signed-off-by: Lyude Paul --- drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 2 +- drivers/gpu/drm/drm_dp_helper.c | 3 ++- drivers/gpu/drm/i915/display/intel_dp_link_training.c

[Freedreno] [RESEND] Requests For Proposals for hosting XDC2021 are now open

2020-09-03 Thread Lyude Paul
questions about what organizing XDC entails, please feel free to chat with previous organizers, or someone from the board. -- Sincerely, Lyude Paul (she/her) Software Engineer at Red Hat ___ Freedreno mailing list Freedreno

Re: [Freedreno] [PATCH 2/2] drm/atomic: Create and use __drm_atomic_helper_crtc_reset() everywhere

2018-11-21 Thread Lyude Paul
For the nouveau and drm core changes Reviewed-by: Lyude Paul On Mon, 2018-11-12 at 16:01 +0100, Maarten Lankhorst wrote: > We already have __drm_atomic_helper_connector_reset() and > __drm_atomic_helper_plane_reset(), extend this to crtc as well. > > Most drivers already have a gp