Re: [Freedreno] [DPU PATCH 4/4] drm/msm/dpu: use private obj to track hw resources

s. With > the new state based RM, its very unlikely we hit this condition. > In this case, add a comment with "/* This should never happen */" I'm just kidding, that would virtually guarantee that it does happen and we certainly don't need that bad juju ar

Re: [Freedreno] [DPU PATCH v3 0/7] clean up DPU custom properties

4 drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.c > delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.h > delete mode 100644 drivers/gpu/drm/msm/msm_prop.c > delete mode 100644 drivers/gpu/drm/msm/msm_prop.h > delete mode 100644 include/uapi/drm/dpu_drm.h > delete mode

Re: [Freedreno] [DPU PATCH v2 2/7] drm/msm/dpu: clean up dpu plane custom properties

On Tue, Jun 05, 2018 at 08:45:33PM -0700, Jeykumar Sankaran wrote: > This change removes all the dpu plane custom properties > and its handlers. > > changs in v2: > - remove stale code in blend config(Sean Paul) > - Makefile changes to remove warning flags(Sean Pau

Re: [Freedreno] [DPU PATCH 4/7] drm/msm/dpu: switch to drm zpos property

; so > printing the return value isn't interesting. Also if I was reviewing or casual reading this without the ret print, I would probably leave a comment such as "print the return value" since I don't generally keep track of all possible return values. So printing the return value seems reasonable to me. Sean > > > /* success! finalize initialization */ > > drm_plane_helper_add(plane, _plane_helper_funcs); > > > > -- > > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > > a Linux Foundation Collaborative Project > > > > ___ > > Freedreno mailing list > > Freedreno@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/freedreno > > -- > The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project -- Sean Paul, Software Engineer, Google / Chromium OS ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [DPU PATCH 4/7] drm/msm/dpu: switch to drm zpos property

ax = DPU_STAGE_MAX - DPU_STAGE_0 - 1; > + } > + > + ret = drm_plane_create_zpos_property(plane, 0, 0, zpos_max); > + if (ret) > + DPU_ERROR("failed to install zpos property, rc = %d\n", ret); > + > /* success! finalize initialization */ > drm_plane_helper_add(plane, _plane_helper_funcs); > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- Sean Paul, Software Engineer, Google / Chromium OS ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [DPU PATCH 6/7] drm/msm: remove msm_prop files

On Wed, May 23, 2018 at 12:31:01PM -0700, Jeykumar Sankaran wrote: > Remove hand rolled msm property caching to handle DPU > custom properties. This change also cleans up all its > dependencies to cache and restore respective drm > states. > > Signed-off-by: Jeykumar Sankaran

Re: [Freedreno] [DPU PATCH 5/7] drm/msm/dpu: clean up dpu crtc custom properties

On Wed, May 23, 2018 at 12:31:00PM -0700, Jeykumar Sankaran wrote: > Remove dpu crtc custom properties and its handlers. > > Signed-off-by: Jeykumar Sankaran Reviewed-by: Sean Paul > --- > drivers/gpu/drm/msm/Makefile | 1 - > drivers/gpu/drm/msm/disp/dp

Re: [Freedreno] [DPU PATCH 2/7] drm/msm/dpu: clean up dpu plane custom properties

ult to opaque blending */ > - fg_alpha = dpu_plane_get_property(pstate, PLANE_PROP_ALPHA); > + fg_alpha = 0XFF; > bg_alpha = 0xFF - fg_alpha; This goes to 0 and the fg_alpha != 0xff checks are always false. So let's clean the rest of the function to remove the dead code and

[Freedreno] [PATCH] drm/msm: Fix NULL deref on bind/probe deferral

mit to ensure the arguments to msm_gem_put_iova() are correct (even though that function has been a stub for ~5 years). Correctness FTW! \o/ Fixes: b01884a286b0 drm/msm: use correct aspace pointer in msm_gem_put_iova() Cc: Daniel Mack Cc: Rob Clark Signed-off-by: Sean Paul --- drivers/gpu/drm/

Re: [Freedreno] [DPU PATCH v2 5/6] drm/msm: hook up DPU with upstream DSI

ack and display port drivers > - compile out dsi-staging driver (separate patch submitted to > remove the driver) > - adapt upstream device hierarchy > > changes in v2: > - remove files not applicable upstream (Sean Paul) > - remove compiled out non-dsi disp

Re: [Freedreno] [DPU PATCH v2 03/12] drm/msm/dpu: add MDSS top level driver for dpu

; > > It implements runtime_pm support for resource management. > > Child nodes can control these resources via runtime_pm > > get/put calls on their corresponding devices due to parent > > child relationship defined in dt. > > > > Changes in v2: > >

Re: [Freedreno] [DPU PATCH v2 12/12] drm/msm/dpu: add error handling in dpu_core_perf_crtc_update

anks for doing this :-) Reviewed-by: Sean Paul <seanp...@chromium.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 37 > ++- > drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 3 ++- > 2 files changed, 27 insertions(+), 13 deletions(-) > >

Re: [Freedreno] [DPU PATCH v2 11/12] drm/msm/dpu: move dpu_power_handle to dpu folder

lict in dpu_unbind > - dropped (Reviewed-by: Sean Paul) due to above change > Reviewed-by: Sean Paul <seanp...@chromium.org> > Signed-off-by: Rajesh Yadav <rya...@codeaurora.org> > --- > drivers/gpu/drm/msm/Makefile | 2 +- > driver

Re: [Freedreno] [DPU PATCH v2 10/12] drm/msm/dpu: use runtime_pm calls in dpu_dbg

er access). > > Changes in v2: > - resolved conflict in dpu_core_perf_init > - dropped (Reviewed-by: Sean Paul) due to above change Reviewed-by: Sean Paul <seanp...@chromium.org> > > Signed-off-by: Rajesh Yadav <rya...@codeaurora.org> > --- > drivers/gpu/drm

Re: [Freedreno] [DPU PATCH v2 08/12] drm/msm/dpu: remove power management code from dpu_power_handle

> Changes in v2: > - resolved merge conflict in dpu_power_resource_init > - dropped (Reviewed-by: Sean Paul) due to above change > > Signed-off-by: Rajesh Yadav <rya...@codeaurora.org> > --- > drivers/gpu/drm/msm/dpu_power_handle.c | 194 > +-

Re: [Freedreno] [DPU PATCH v2 07/12] drm/msm/dpu: remove clock management code from dpu_power_handle

> > Changes in v2: > - remove local variable to hold and return error code > in _dpu_core_perf_set_core_clk_rate() instead return > retcode directly from msm_dss_clk_set_rate() call (Sean Paul) > - dpu_core_perf_init() is called from dpu_kms_hw_init() and

Re: [Freedreno] [DPU PATCH v2 04/12] drm/msm/dpu: create new platform driver for dpu device

unctionality. > > The dpu driver implements runtime_pm support for managing clocks > and bus bandwidth etc. > > Changes in v2: > - remove redundant param check from _dpu_kms_hw_destroy (Sean Paul) > - remove explicit calls to devm_kfree (Sean Paul) > -

Re: [Freedreno] [DPU PATCH v2 03/12] drm/msm/dpu: add MDSS top level driver for dpu

evices due to parent > child relationship defined in dt. > > Changes in v2: > - merge _dpu_mdss_hw_rev_init to dpu_mdss_init (Sean Paul) > - merge _dpu_mdss_get_intr_sources to dpu_mdss_irq (Sean Paul) > - fix indentation for irq_find_mapping call (Sean Paul) >

Re: [Freedreno] [DPU PATCH 11/11] drm/msm/dpu: move dpu_power_handle to dpu folder

(_kms->base, _funcs); > @@ -1876,6 +1882,7 @@ static int dpu_init(struct platform_device *pdev, > struct drm_device *dev) > > return ret; > > +power_init_fail: Nit: No need to add an empty label, just use clk_rate_error above. With that fixed, Reviewed-by: Sean

Re: [Freedreno] [DPU PATCH 10/11] drm/msm/dpu: use runtime_pm calls in dpu_dbg

t; > Signed-off-by: Rajesh Yadav <rya...@codeaurora.org> Reviewed-by: Sean Paul <seanp...@chromium.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 4 +--- > drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 4 > drivers/gpu/drm/msm/disp/dp

Re: [Freedreno] [DPU PATCH 09/11] drm/msm/dp: remove dpu_power_handle calls from dp driver

like DP device. > For same reason, clock and power management code is > removed from dpu_power_handle. Hence, remove the > dpu_power_handle calls from dp driver. > > Signed-off-by: Rajesh Yadav <rya...@codeaurora.org> Reviewed-by: Sean Paul <seanp...@chromium.org> >

Re: [Freedreno] [DPU PATCH 08/11] drm/msm/dpu: remove power management code from dpu_power_handle

f-by: Rajesh Yadav <rya...@codeaurora.org> Reviewed-by: Sean Paul <seanp...@chromium.org> > --- > drivers/gpu/drm/msm/dpu_power_handle.c | 190 > + > drivers/gpu/drm/msm/dpu_power_handle.h | 2 - > 2 files changed, 1 insertion(+), 191 d

Re: [Freedreno] [DPU PATCH 07/11] drm/msm/dpu: remove clock management code from dpu_power_handle

err("device vreg supply parsing failed\n"); > - goto parse_vreg_err; > + goto end; Just return directly and remove the end label. > } > > rc = msm_dss_config_vreg(>dev, > @@ -700,18 +637,6 @@ int dpu_power_resource_init(struct platform_device *pdev, > goto vreg_err; > } > > - rc = msm_dss_get_clk(>dev, mp->clk_config, mp->num_clk); > - if (rc) { > - pr_err("clock get failed rc=%d\n", rc); > - goto clk_err; > - } > - > - rc = msm_dss_clk_set_rate(mp->clk_config, mp->num_clk); > - if (rc) { > - pr_err("clock set rate failed rc=%d\n", rc); > - goto bus_err; > - } > - > rc = dpu_power_reg_bus_parse(pdev, phandle); > if (rc) { > pr_err("register bus parse failed rc=%d\n", rc); > @@ -742,17 +667,11 @@ int dpu_power_resource_init(struct platform_device > *pdev, > dpu_power_data_bus_unregister(>data_bus_handle[i]); > dpu_power_reg_bus_unregister(phandle->reg_bus_hdl); > bus_err: > - msm_dss_put_clk(mp->clk_config, mp->num_clk); > -clk_err: > msm_dss_config_vreg(>dev, mp->vreg_config, mp->num_vreg, 0); > vreg_err: > if (mp->vreg_config) > devm_kfree(>dev, mp->vreg_config); > mp->num_vreg = 0; > -parse_vreg_err: > - if (mp->clk_config) > - devm_kfree(>dev, mp->clk_config); > - mp->num_clk = 0; > end: > return rc; > } -- Sean Paul, Software Engineer, Google / Chromium OS ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [DPU PATCH 06/11] drm/msm/dpu: use runtime_pm calls on dpu device

or all child nodes > (mdp5/dpu, dsi, dp etc) is done by parent MDSS device/driver > via runtime_pm due to parent child relationship. > > Signed-off-by: Rajesh Yadav <rya...@codeaurora.org> Reviewed-by: Sean Paul <seanp...@chromium.org> > --- > drivers/gpu/drm/msm/di

Re: [Freedreno] [DPU PATCH 05/11] drm/msm/dpu: update dpu sub-block offsets wrt dpu base address

; > Signed-off-by: Rajesh Yadav <rya...@codeaurora.org> Reviewed-by: Sean Paul <seanp...@chromium.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 68 > +++ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 18 +++--- > 2

Re: [Freedreno] [DPU PATCH 01/11] drm/msm: remove redundant pm_runtime_enable call from msm_drv

le call from msm_drv. > > Signed-off-by: Rajesh Yadav <rya...@codeaurora.org> Reviewed-by: Sean Paul <seanp...@chromium.org> > --- > drivers/gpu/drm/msm/msm_drv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/

Re: [Freedreno] [DPU PATCH 04/11] drm/msm/dpu: create new platform driver for dpu device

a..5470529 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -1731,6 +1731,7 @@ static int __init msm_drm_register(void) > > DBG("init"); > msm_mdp_register(); > + msm_dpu_register(); > msm_dsi_register();

Re: [Freedreno] [DPU PATCH 03/11] drm/msm/dpu: add MDSS top level driver for dpu

t;qcom,mdp4", .data = (void *)KMS_MDP4 }, > { .compatible = "qcom,mdss", .data = (void *)KMS_MDP5 }, > #ifdef CONFIG_DRM_MSM_DPU > - { .compatible = "qcom,dpu-kms", .data = (void *)KMS_DPU }, > + { .compatible = "qcom,dpu-mdss", .data = (void *)KMS_DPU }, This requires a dt binding change. > #endif > {} > }; > diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h > index 90a2521..e8e5e73 100644 > --- a/drivers/gpu/drm/msm/msm_drv.h > +++ b/drivers/gpu/drm/msm/msm_drv.h > @@ -381,7 +381,7 @@ struct msm_drm_private { > /* subordinate devices, if present: */ > struct platform_device *gpu_pdev; > > - /* top level MDSS wrapper device (for MDP5 only) */ > + /* top level MDSS wrapper device (for MDP5/DPU only) */ > struct msm_mdss *mdss; > > /* possibly this should be in the kms component, but it is > diff --git a/drivers/gpu/drm/msm/msm_kms.h b/drivers/gpu/drm/msm/msm_kms.h > index 9a7bc7d..8f50613 100644 > --- a/drivers/gpu/drm/msm/msm_kms.h > +++ b/drivers/gpu/drm/msm/msm_kms.h > @@ -145,6 +145,8 @@ struct msm_mdss { > > int mdp5_mdss_init(struct drm_device *dev); > Remove this line. > +int dpu_mdss_init(struct drm_device *dev); > + > /** > * Mode Set Utility Functions > */ > diff --git a/include/linux/dpu_io_util.h b/include/linux/dpu_io_util.h > index 7c73899..45e606f 100644 > --- a/include/linux/dpu_io_util.h > +++ b/include/linux/dpu_io_util.h > @@ -104,6 +104,8 @@ int msm_dss_config_vreg(struct device *dev, struct > dss_vreg *in_vreg, > void msm_dss_put_clk(struct dss_clk *clk_arry, int num_clk); > int msm_dss_clk_set_rate(struct dss_clk *clk_arry, int num_clk); > int msm_dss_enable_clk(struct dss_clk *clk_arry, int num_clk, int enable); > +int msm_dss_parse_clock(struct platform_device *pdev, > + struct dss_module_power *mp); > > int dpu_i2c_byte_read(struct i2c_client *client, uint8_t slave_addr, > uint8_t reg_offset, uint8_t *read_buf); > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- Sean Paul, Software Engineer, Google / Chromium OS ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [PATCH v5 1/4] drm/bridge: add support for sn65dsi86 bridge driver

iver and create a separate edp panel drivers to handle panel >specific mode information and HW resources (Sean Paul). > - Replace pr_* APIs to DRM_* APIs to log error or debug information >(Sean Paul). > - Remove some of the unnecessary structure/variable from driver (S

Re: [Freedreno] [[RFC]DPU PATCH 3/4] drm/panel: add Innolux TV123WAM eDP panel driver

ase); > + > + innolux_edp_2k_panel_disable(>base); > + innolux_edp_2k_panel_unprepare(>base); > + > + if (pdata->backlight) > + put_device(>backlight->dev); > + > + return 0; > +} > + > +static struct platform_driver innolux_edp_2k_panel_driver = { > + .driver = { > + .name = "innolux-2k-edp-panel", > + .of_match_table = platform_of_match, > + }, > + .probe = innolux_edp_2k_panel_probe, > + .remove = innolux_edp_2k_panel_remove, > +}; > + > +static int __init innolux_edp_2k_panel_init(void) > +{ > + int ret; > + > + ret = platform_driver_register(_edp_2k_panel_driver); > + if (ret < 0) > + return ret; > + > + return 0; > +} > +module_init(innolux_edp_2k_panel_init); > + > +static void __exit innolux_edp_2k_panel_exit(void) > +{ > + platform_driver_unregister(_edp_2k_panel_driver); > +} > +module_exit(innolux_edp_2k_panel_exit); > + > +MODULE_DESCRIPTION("Innolux 2k eDP panel driver"); > +MODULE_LICENSE("GPL"); > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- Sean Paul, Software Engineer, Google / Chromium OS ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [[RFC]DPU PATCH 1/4] drm/bridge: add support for sn65dsi86 bridge driver

iver and create a separate edp panel drivers to handle panel >specific mode information and HW resources (Sean Paul). > - Replace pr_* APIs to DRM_* APIs to log error or debug information >(Sean Paul). > - Remove some of the unnecessary structure/variable from driver (S

[Freedreno] [DPU PATCH] drm/msm: dpu: Fix build warnings

Signed-off-by: Sean Paul <seanp...@chromium.org> --- .../gpu/drm/msm/disp/dpu1/dpu_color_processing.c | 5 +++-- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 4 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.c | 14 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_p

Re: [Freedreno] [DPU PATCH v3 2/2] drm/msm/dsi: Use one connector for dual DSI mode

ector/bridge. > > Changes in V2: > -Removed Change-Id from the commit text tags. > -Remove extra parentheses > > Changes in V3: > -None > > Signed-off-by: Chandan Uddaraju <chand...@codeaurora.org> Reviewed-by: Sean Paul <seanp...@chromium.org> &

Re: [Freedreno] [DPU PATCH v3 2/2] drm/msm/dsi: Use one connector for dual DSI mode

ector/bridge. > > Changes in V2: > -Removed Change-Id from the commit text tags. > -Remove extra parentheses > > Changes in V3: > -None > > Signed-off-by: Chandan Uddaraju <chand...@codeaurora.org> Reviewed-by: Sean Paul <seanp...@chromium.org> &

Re: [Freedreno] [DPU PATCH 6/6] drm/msm: remove dsi-staging driver

| 365 -- > drivers/gpu/drm/msm/dsi-staging/dsi_pwr.h | 93 - > 37 files changed, 22057 deletions(-) Awesome! Reviewed-by: Sean Paul <seanp...@chromium.org> -- Sean Paul, Software Engineer, Google / Chromium OS ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

[Freedreno] [PULL] msm fixes/improvements

done waits drm/msm/dsi: check video mode engine status before waiting drm/msm/dsi: implement auto PHY timing calculator for 10nm PHY Jeykumar Sankaran (1): drm/msm: Add modifier to mdp_get_format arguments Sean Paul (1): drm/msm: Mark the crtc->state->event co

Re: [Freedreno] [[RFC]DPU PATCH 0/4] Add suppport for sn65dsi86 bridge chip and Innolux 2k edp panel driver

te mode 100644 drivers/gpu/drm/bridge/ti-sn65dsi86.c > create mode 100644 drivers/gpu/drm/panel/panel-innolux-tv123wam.c > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- Sean Paul,

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

rnel aside from scaling the brightness level down twice. I assume the magic is in userspace. My initial reaction was that the scaling factor should just be applied in userspace. Especially since the scaling factor reduces the resolution of the backlight, and that's not immediately obvious by looking at &q

Re: [Freedreno] [DPU PATCH 4/6] drm/msm: strip down custom event ioctl's

On Mon, Apr 16, 2018 at 11:22:19AM -0700, Jeykumar Sankaran wrote: > Remove custom ioctl support in SDM845 which allows > user space to register/unregister for hw events. > > Signed-off-by: Jeykumar Sankaran <jsa...@codeaurora.org> Reviewed-by: Sean Paul <seanp...@chromium.o

Re: [Freedreno] [DPU PATCH 3/6] drm/msm: remove panel autorefresh support for SDM845

r Sankaran <jsa...@codeaurora.org> Reviewed-by: Sean Paul <seanp...@chromium.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_connector.c | 7 - > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c| 37 +-- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 20 -- > .../gp

Re: [Freedreno] [DPU PATCH 2/6] drm/msm: remove support for ping pong split topology

programming, striping off the support > for SDM845. > > Signed-off-by: Jeykumar Sankaran <jsa...@codeaurora.org> Reviewed-by: Sean Paul <seanp...@chromium.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_connector.c | 2 +- > drivers/gpu/drm/msm/disp/dpu1/dpu

Re: [Freedreno] [DPU PATCH v2 1/2] drm/msm/dsi: adjust dsi timing for dual dsi mode

if (other_dsi) > + msm_dsi_host_adjust_timing_config(other_dsi->host); > + } > + > } > > static const struct drm_connector_funcs dsi_mgr_connector_funcs = { > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- Sean Paul, Software Engineer, Google / Chromium OS ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [DPU PATCH v3 1/2] drm/msm/dsi: check video mode engine status before waiting

>*/ > dsi_sw_reset(msm_host); > - > + msm_host->enabled = false; I thought this was moving to the start of the function? > return 0; > } > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation

Re: [Freedreno] [DPU PATCH v2 1/2] drm/msm/dsi: check video mode engine status before waiting

On Mon, Apr 16, 2018 at 10:44:57AM -0700, abhin...@codeaurora.org wrote: > Hi Sean > > Thanks for reviewing. > > Reply inline. > > On 2018-04-16 10:07, Sean Paul wrote: > > On Fri, Apr 13, 2018 at 03:04:48PM -0700, abhin...@codeaurora.org wrote: >

Re: [Freedreno] [DPU PATCH v2 1/2] drm/msm/dsi: check video mode engine status before waiting

On Fri, Apr 13, 2018 at 03:04:48PM -0700, abhin...@codeaurora.org wrote: > On 2018-04-13 14:10, abhin...@codeaurora.org wrote: > > Hi Sean > > > > Thanks for the review. > > > > Reply inline. > > > > On 2018-04-13 13:26, Sean Paul wrote: > >

Re: [Freedreno] [DPU PATCH 2/2] drm/panel: add backlight control support for truly panel

On Fri, Apr 13, 2018 at 01:59:29PM -0700, abhin...@codeaurora.org wrote: > Hi Sean > > Thanks for the comments. > > Some replies inline. > > On 2018-04-13 13:46, Sean Paul wrote: > > On Sat, Apr 07, 2018 at 12:06:53AM -0700, Abhinav Kumar wrote: > > > Reg

Re: [Freedreno] [[RFC]DPU PATCH 1/2] drm/bridge: add support for sn65dsi86 bridge driver

On Mon, Apr 16, 2018 at 11:32:50AM +0530, spa...@codeaurora.org wrote: > On 2018-04-14 00:59, Sean Paul wrote: > > On Fri, Apr 13, 2018 at 10:53:00AM +0530, Sandeep Panda wrote: > > > Add support for TI's sn65dsi86 dsi2edp bridge chip. > > > The chip converts DSI trans

Re: [Freedreno] [DPU PATCH 2/2] drm/panel: add backlight control support for truly panel

} > + > + ret = truly_backlight_setup(ctx); > + if (ret) { > + put_device(>dev); > + return ret; > + } > } > > ret = mipi_dsi_attach(dsi); > @@ -504,8 +594,10 @@ static int truly_wqxga_remove(struct mipi_dsi_device > *dsi) > mipi_dsi_detach(dsi); > > /* delete panel only for the DSI1 interface */ > - if (ctx) > + if (ctx) { > truly_wqxga_panel_del(ctx); > + kfree(ctx); > + } > > return 0; > } > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- Sean Paul, Software Engineer, Google / Chromium OS ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [DPU PATCH v2 1/2] drm/msm/dsi: check video mode engine status before waiting

d = false; This should go at the start of the function. Also, it's unclear from this patch, but I assume this is protected by a lock? Sean > return 0; > } > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Pr

Re: [Freedreno] [DPU PATCH 2/2] drm/msm/dsi: Use one connector for dual DSI mode

(id))) > return; > > msm_dsi_host_set_display_mode(host, adjusted_mode); > @@ -704,6 +627,23 @@ struct drm_connector *msm_dsi_manager_connector_init(u8 > id) > return connector; > } > > +bool msm_dsi_manager_validate_current_

Re: [Freedreno] [DPU PATCH 1/2] drm/msm/dsi: adjust dsi timing for dual dsi mode

* DSI host timing structures accordingly. > + */ > + if (is_dual_dsi) { > + msm_dsi_host_adjust_timing_config(host); > + if (other_dsi) > + msm_dsi_host_adjust_timing_config(other_dsi->host); > + } > + > } > >

Re: [Freedreno] [[RFC]DPU PATCH 1/2] drm/bridge: add support for sn65dsi86 bridge driver

lient, > + const struct i2c_device_id *id) > +{ > + struct sn65dsi86 *pdata; > + int ret = 0; > + struct drm_display_mode *mode, *n; > + > + if (!client || !client->dev.of_node) { > + pr_err("invalid input\n"); > +

Re: [Freedreno] [[RFC]DPU PATCH 2/2] dt-bindings: drm/bridge: Document sn65dsi86 bridge bindings

On Fri, Apr 13, 2018 at 1:23 AM Sandeep Panda wrote: > Document the bindings used for the sn65dsi86 DSI to eDP bridge. > Signed-off-by: Sandeep Panda > --- > .../bindings/display/bridge/ti,sn65dsi86.txt | 75 ++ > 1

Re: [Freedreno] [DPU PATCH v2 0/2] Remove DPU RSC support

c > delete mode 100644 drivers/gpu/drm/msm/dpu_rsc_hw.c > delete mode 100644 drivers/gpu/drm/msm/dpu_rsc_priv.h > delete mode 100644 include/linux/dpu_rsc.h > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Colla

Re: [Freedreno] [DPU PATCH 3/3] drm/msm/dsi-staging: Gate bus scale code

ng/dsi_phy.c > index c13e5bb..e712c61 100644 > --- a/drivers/gpu/drm/msm/dsi-staging/dsi_phy.c > +++ b/drivers/gpu/drm/msm/dsi-staging/dsi_phy.c > @@ -17,7 +17,9 @@ > #include > #include > #include > +#ifdef CONFIG_QCOM_BUS_SCALING > #include > +#endif > #include > > #include "msm_drv.h" > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- Sean Paul, Software Engineer, Google / Chromium OS ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [DPU PATCH 1/3] drm/msm: Remove unused variables

On Wed, Mar 28, 2018 at 11:47:46AM +0530, Rajesh Yadav wrote: > Fix compilation errors due to unused variables. > > Signed-off-by: Rajesh Yadav <rya...@codeaurora.org> Reviewed-by: Sean Paul <seanp...@chromium.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c

[Freedreno] [PATCH v4 5/9] drm/msm: Move implicit sync handling to prepare_fb

drm/msm/msm_drv.h @@ -160,6 +160,8 @@ struct msm_format { uint32_t pixel_format; }; +int msm_atomic_prepare_fb(struct drm_plane *plane, + struct drm_plane_state *new_state); int msm_atomic_commit(struct drm_device *dev, struct drm_atomic_state *sta

[Freedreno] [PATCH v4 3/9] drm/msm: Don't subclass drm_atomic_state anymore

-by: Rob Clark <robdcl...@gmail.com> Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 46 drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.h | 22 drivers/gpu/drm/msm/msm_atomic.c | 31 -

[Freedreno] [PATCH v4 4/9] drm/msm: Refactor complete_commit() to look more the helpers

org> Reviewed-by: Archit Taneja <arch...@codeaurora.org> Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/msm_atomic.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_atomic.c b/drivers/gpu/drm/msm/

[Freedreno] [PATCH v4 8/9] drm/msm: Remove msm_commit/worker, use atomic helper commit

in swap_state to avoid abandoned events on disable Changes in v3: - Rebased on Archit's private_obj set Changes in v4: - None Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/msm_atomic.c | 153 +-- drivers/gpu/drm/msm/msm_drv.c| 1 - d

[Freedreno] [PATCH v4 7/9] drm/msm: Issue queued events when disabling crtc

<arch...@codeaurora.org> Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c index 76b96081916f..

[Freedreno] [PATCH v4 1/9] drm/msm/mdp5: Add global state as a private atomic object

-off-by: Rob Clark <robdcl...@gmail.com> Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 87 drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.h | 25 +++ 2 files changed, 112 insertions(+) diff --git a/drivers/gpu/drm/msm

[Freedreno] [PATCH v4 9/9] drm/msm: Switch to atomic_helper_commit()

Now that all of the msm-specific goo is tucked safely away we can switch over to using the atomic helper commit directly. \o/ Changes in v2: - None Changes in v3: - Rebased on Archit's private_obj set Changes in v4: - None Cc: Abhinav Kumar <abhin...@codeaurora.org> Signed-off-by: Sea

[Freedreno] [PATCH v4 2/9] drm/msm/mdp5: Use the new private_obj state

elper patch set Changes in v4: - None Signed-off-by: Archit Taneja <arch...@codeaurora.org> Signed-off-by: Rob Clark <robdcl...@gmail.com> Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 10 -- drivers/gpu/drm/msm/disp/mdp5/

[Freedreno] [PATCH v4 6/9] drm/msm: Mark the crtc->state->event consumed

viewed-by: Archit Taneja <arch...@codeaurora.org> Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 1 + drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c

[Freedreno] [DPU PATCH 3/3] drm/msm: Fix dpu build warnings

A bunch of warning fixes, build is clean now. Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/disp/dpu1/dpu_connector.c | 7 --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.c | 4 ++-- drivers/g

[Freedreno] [PATCH v3 8/8] drm/msm: Switch to atomic_helper_commit()

Now that all of the msm-specific goo is tucked safely away we can switch over to using the atomic helper commit directly. \o/ Changes in v2: - None Changes in v3: - Rebased on Archit's private_obj set Cc: Abhinav Kumar <abhin...@codeaurora.org> Signed-off-by: Sean Paul <seanp...@chr

[Freedreno] [PATCH v3 7/8] drm/msm: Remove msm_commit/worker, use atomic helper commit

in swap_state to avoid abandoned events on disable Changes in v3: - Rebased on Archit's private_obj set Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/msm_atomic.c | 153 +-- drivers/gpu/drm/msm/msm_drv.c| 1 - drivers/gpu/drm/msm/msm

[Freedreno] [PATCH v3 5/8] drm/msm: Mark the crtc->state->event consumed

<arch...@codeaurora.org> Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 1 + drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c b/drivers/gpu

[Freedreno] [PATCH v3 6/8] drm/msm: Issue queued events when disabling crtc

org> Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c index 76b96081916f..10271359789e 100644 -

[Freedreno] [PATCH v3 2/8] drm/msm/mdp5: Use the new private_obj state

helper patch set Signed-off-by: Archit Taneja <arch...@codeaurora.org> Signed-off-by: Rob Clark <robdcl...@gmail.com> Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 10 -- drivers/gpu/drm/msm/disp/mdp5/mdp5_mixer.c |

[Freedreno] [PATCH v2 4/6] drm/msm: Issue queued events when disabling crtc

Ensure that any queued events are issued when disabling the crtc. This avoids timeouts when we come back and wait for dependencies (like the previous frame's flip_done). Changes in v2: - None Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc

[Freedreno] [PATCH v2 3/6] drm/msm: Mark the crtc->state->event consumed

Don't leave the event != NULL once it's consumed, this is used a signal to the atomic helpers that the event will be handled by the driver. Changes in v2: - None Cc: Jeykumar Sankaran <jsa...@codeaurora.org> Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/m

[Freedreno] [PATCH v2 2/6] drm/msm: Refactor complete_commit() to look more the helpers

Factor out the commit_tail() portions of complete_commit() into a separate function to facilitate moving to the atomic helpers in future patches. Changes in v2: - None Cc: Jeykumar Sankaran <jsa...@codeaurora.org> Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers

[Freedreno] [PATCH 2/4] drm/msm: Mark the crtc->state->event consumed

Don't leave the event != NULL once it's consumed, this is used a signal to the atomic helpers that the event will be handled by the driver. Cc: Jeykumar Sankaran <jsa...@codeaurora.org> Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c |

[Freedreno] [PATCH 0/4] drm/msm: Switch to atomic helpers

I originally sent these patches targetted against the msm dpu code, but I've rebased them on msm-next since they're _mostly_ the same. The set is based on 'drm/msm: Use drm_private_obj/state instead of subclassing' which I sent up earlier. The set has been tested on mdp5 db410c. Sean Sean Paul

[Freedreno] [PATCH 3/4] drm/msm: Remove msm_commit/worker, use atomic helper commit

Moving further towards switching fully to the the atomic helpers, this patch removes the hand-rolled worker nonblock commit code and uses the atomic helpers commit_work model. Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/msm_atomic.c

[Freedreno] [PATCH 4/4] drm/msm: Switch to atomic_helper_commit()

Now that all of the msm-specific goo is tucked safely away we can switch over to using the atomic helper commit directly. \o/ Cc: Abhinav Kumar <abhin...@codeaurora.org> Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/msm_at

[Freedreno] [PATCH 1/4] drm/msm: Refactor complete_commit() to look more the helpers

Factor out the commit_tail() portions of complete_commit() into a separate function to facilitate moving to the atomic helpers in future patches. Cc: Jeykumar Sankaran <jsa...@codeaurora.org> Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/msm_a

[Freedreno] [PATCH v4] drm/msm: Use drm_private_obj/state instead of subclassing

eja <arch...@codeaurora.org> Signed-off-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 77 ++- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.h | 11 +-- drivers/gpu/drm/msm/disp/mdp5/mdp5_mixer.c | 12 ++- drivers/gpu/drm/msm/disp/mdp5/mdp5_pipe.c | 28

Re: [Freedreno] [DPU PATCH 2/2] drm/msm: Add hardware catalog file for SDM845

On Wed, Mar 21, 2018 at 04:05:31PM +0530, skoll...@codeaurora.org wrote: > On 2018-03-20 20:47, Sean Paul wrote: > > On Tue, Mar 20, 2018 at 07:13:38PM +0530, skoll...@codeaurora.org wrote: > > > On 2018-03-19 19:29, Sean Paul wrote: > > > > On Wed, Mar 14, 2018

Re: [Freedreno] [DPU PATCH 2/2] drm/msm: Add hardware catalog file for SDM845

On Tue, Mar 20, 2018 at 07:13:38PM +0530, skoll...@codeaurora.org wrote: > On 2018-03-19 19:29, Sean Paul wrote: > > On Wed, Mar 14, 2018 at 11:21:38AM +0530, Sravanthi Kollukuduru wrote: > > > This change adds the hardware catalog information in driver source > > &g

Re: [Freedreno] [DPU PATCH 06/11] drm/msm: Remove msm_commit/kthread, use atomic helper commit

On Mon, Mar 12, 2018 at 04:23:10PM -0400, Sean Paul wrote: > On Thu, Mar 08, 2018 at 05:08:03PM -0800, Jeykumar Sankaran wrote: > > On 2018-03-02 06:56, Sean Paul wrote: > > > On Thu, Mar 01, 2018 at 07:37:10PM -0500, Rob Clark wrote: > > > > On Thu, Mar 1, 2018 at 3:

Re: [Freedreno] [DPU PATCH 2/2] drm/msm: Add hardware catalog file for SDM845

}, > + .format_list = plane_formats_yuv, > + .virt_format_list = plane_formats, > + }; Instead of locating all of these parameters in one file, these should be located in their respective driver file. It also seems like you could separat

[Freedreno] [DPU PATCH v2] drm/msm: Don't duplicate modeset_enables atomic helper

Instead, shuffle things around so we kickoff crtc after enabling encoder during modesets. Also moves the vblank wait to after the frame. Changes in v2: - Remove the encoder.commit hack, it's not required (Jeykumar) Cc: Jeykumar Sankaran <jsa...@codeaurora.org> Signed-off-by: Sean Paul

Re: [Freedreno] [DPU PATCH 02/11] drm/msm: Don't duplicate modeset_enables atomic helper

On Tue, Mar 13, 2018 at 04:57:35PM -0700, Jeykumar Sankaran wrote: > On 2018-03-12 13:21, Sean Paul wrote: > > On Thu, Mar 08, 2018 at 04:56:01PM -0800, Jeykumar Sankaran wrote: > > > On 2018-02-28 11:18, Sean Paul wrote: > > > > Instead, shuffle things around so

[Freedreno] [DPU PATCH] drm/msm: Add pm_runtime_get/put calls to dpu

Ensure that pm_runtime is properly referenced/unreferenced when we need it. Signed-off-by: Sean Paul <seanp...@chromium.org> --- Didn't get a response to my suggestion, so wrote the patch anyways. Thoughts? drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 3 +++ drivers/gpu/drm/msm/dis

Re: [Freedreno] [DPU PATCH 07/11] drm/msm: Use atomic private_obj instead of subclassing

On Thu, Mar 08, 2018 at 05:59:11PM -0800, Jeykumar Sankaran wrote: > On 2018-02-28 11:19, Sean Paul wrote: > > Instead of subclassing atomic state, store driver private data in > > private_obj/state. This allows us to remove the swap_state driver hook > > for mdp5 an

Re: [Freedreno] [DPU PATCH 06/11] drm/msm: Remove msm_commit/kthread, use atomic helper commit

On Thu, Mar 08, 2018 at 05:08:03PM -0800, Jeykumar Sankaran wrote: > On 2018-03-02 06:56, Sean Paul wrote: > > On Thu, Mar 01, 2018 at 07:37:10PM -0500, Rob Clark wrote: > > > On Thu, Mar 1, 2018 at 3:37 PM, <jsa...@codeaurora.org> wrote: > > > >

Re: [Freedreno] [DPU PATCH 02/11] drm/msm: Don't duplicate modeset_enables atomic helper

On Thu, Mar 08, 2018 at 04:56:01PM -0800, Jeykumar Sankaran wrote: > On 2018-02-28 11:18, Sean Paul wrote: > > Instead, shuffle things around so we kickoff crtc after enabling encoder > > during modesets. Also moves the vblank wait to after the frame. >

Re: [Freedreno] [DPU PATCH 01/11] drm/msm: Skip seamless disables in crtc/encoder

On Fri, Mar 02, 2018 at 04:04:24PM -0800, jsa...@codeaurora.org wrote: > On 2018-02-28 11:18, Sean Paul wrote: > > Instead of duplicating whole swaths of atomic helper functions (which > > are already out-of-date), just skip the encoder/crtc disables in the > > .disable hook

Re: [Freedreno] [DPU PATCH] msm/hdcp: Remove redundant stubs/CONFIG

On Tue, Feb 27, 2018 at 11:24:31AM -0500, Sean Paul wrote: > On Mon, Feb 26, 2018 at 03:01:14PM -0800, abhin...@codeaurora.org wrote: > > The change itself is okay. So, Reviewed-by? Sean > > However I am planning to do a bigger cleanup here > > ( removing the entire hdmi_

Re: [Freedreno] [DPU PATCH] drm/msm: Remove dpu_edid_parser

On Mon, Feb 26, 2018 at 02:23:40PM -0800, abhin...@codeaurora.org wrote: > On 2018-02-26 07:36, Sean Paul wrote: > > On Fri, Feb 23, 2018 at 05:48:48PM -0500, Rob Clark wrote: > > > On Fri, Feb 23, 2018 at 5:31 PM, <abhin...@codeaurora.org> wrote: > > > > Th

Re: [Freedreno] [PATCH RESEND 08/10] drm/msm: Sprinkle pm_runtime calls around

On Thu, Mar 08, 2018 at 04:14:38PM -0800, Jeykumar Sankaran wrote: > On 2018-02-21 07:18, Sean Paul wrote: > > Adding missing pm_runtime references where appropriate. > > > > Signed-off-by: Sean Paul <seanp...@chromium.org> > > --- > > driver

Re: [Freedreno] [DPU PATCH v3 2/2] drm/msm: remove partial update support

On Thu, Mar 01, 2018 at 04:52:35PM -0800, Jeykumar Sankaran wrote: > Implementation of partial update in DPU DRM is heavily > dependent on custom properties and dsi hooks. Removing the > support for now. We may need to revisit the support in the > future. > > changes since v1: > - get away

Re: [Freedreno] [DPU PATCH 06/11] drm/msm: Remove msm_commit/kthread, use atomic helper commit

On Thu, Mar 01, 2018 at 07:37:10PM -0500, Rob Clark wrote: > On Thu, Mar 1, 2018 at 3:37 PM, <jsa...@codeaurora.org> wrote: > > On 2018-03-01 07:27, Sean Paul wrote: > >> > >> On Wed, Feb 28, 2018 at 08:07:00PM -0800, jsa...@codeaurora.org wrote: > >>&g

Re: [Freedreno] [[RFC]DPU PATCH] drm/msm/dsi: Use one connector for dual DSI mode

ementations take the master/slave cues from device tree as opposed to hard-coding one or the other (I know of at least one case where DSI_1 was connected to the panel's first channel, whereas DSI_0 was connected to the second channel. Sean > + */ > + if (is_dual_dsi && (DSI_1 == id)) { > + DBG("Skip DSI_1 bridge registration for dual DSI.\n"); > + return false; > + } > + return true; > +} > + > /* initialize bridge */ > struct drm_bridge *msm_dsi_manager_bridge_init(u8 id) > { > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- Sean Paul, Software Engineer, Google / Chromium OS ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [DPU PATCH v2 1/2] drm/msm/dsi-staging: remove support for partial update

what you've changed since the last version? This is super helpful for reviewers. > Change-Id: I02462f520cdf99c8445b18e60212ca46155f9710 I forgot this during my last patchset too, but please try to strip the Change-Id tag. With the commit message changes, Reviewed-by: Sean Paul <seanp...@chr

Re: [Freedreno] [DPU PATCH v2 2/2] drm/msm: remove partial update support

+411,6 @@ struct msm_display_info { > > bool is_primary; > bool is_te_using_watchdog_timer; > - struct msm_roi_caps roi_caps; > -}; > - > -#define MSM_MAX_ROI 4 > - > -/** > - * struct msm_roi_list - list of regions of interest for a drm object > - * @num_rects: number of valid rectangles in the roi array > - * @roi: list of roi rectangles > - */ > -struct msm_roi_list { > - uint32_t num_rects; > - struct drm_clip_rect roi[MSM_MAX_ROI]; > -}; > - > -/** > - * struct - msm_display_kickoff_params - info for display features at kickoff > - * @rois: Regions of interest structure for mapping CRTC to Connector output > - */ > -struct msm_display_kickoff_params { > - struct msm_roi_list *rois; > }; > > /** > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- Sean Paul, Software Engineer, Google / Chromium OS ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [DPU PATCH 06/11] drm/msm: Remove msm_commit/kthread, use atomic helper commit

On Wed, Feb 28, 2018 at 08:07:00PM -0800, jsa...@codeaurora.org wrote: > On 2018-02-28 11:19, Sean Paul wrote: > > Moving further towards switching fully to the the atomic helpers, this > > patch removes the hand-rolled kthread nonblock commit code and uses the > > atomic help

<    2   3   4   5   6   7   8   >