Re: [Freedreno] [PATCH 3/4] drm/msm: Add SYSPROF param

2022-03-03 Thread Stephen Boyd
Quoting Rob Clark (2022-03-03 13:47:14) > On Thu, Mar 3, 2022 at 1:17 PM Rob Clark wrote: > > > > On Thu, Mar 3, 2022 at 12:47 PM Stephen Boyd wrote: > > > > > > Quoting Rob Clark (2022-03-03 11:46:47) > > > > + > > > > + /* then

Re: [Freedreno] [PATCH v5 5/5] drm/msm/dp: rewrite dss_module_power to use bulk clock functions

2022-03-03 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-16 21:55:29) > In order to simplify DP code, drop hand-coded loops over clock arrays, > replacing them with clk_bulk_* functions. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v5 4/5] drm/msm/dp: inline dp_power_clk_set_rate()

2022-03-03 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-16 21:55:28) > Inline the dp_power_clk_set_rate() function, replacing it with the call > to msm_dss_enable_clk(). > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v5 3/5] drm/msm/dp: set stream_pixel rate directly

2022-03-03 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-16 21:55:27) > The only clock for which we set the rate is the "stream_pixel". Rather > than storing the rate and then setting it by looping over all the > clocks, set the clock rate directly. > > Signed-off-by: Dmitry Baryshkov [...] > diff --git

Re: [Freedreno] [PATCH v5 2/5] drm/msm/dp: "inline" dp_ctrl_set_clock_rate("ctrl_link")

2022-03-03 Thread Stephen Boyd
) directly. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v5 1/5] drm/msm/dpu: simplify clocks handling

2022-03-03 Thread Stephen Boyd
andled using devres instead. > > DP implementation is unchanged for now. > > Tested-by: Jessica Zhang # RB3 (sdm845) and RB5 > (qrb5165) > Reviewed-by: Jessica Zhang > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v2] drm/msm/disp/dpu1: add inline rotation support for sc7280 target

2022-03-03 Thread Stephen Boyd
Quoting Vinod Polimera (2022-03-03 03:42:59) > - Some DPU versions support inline rot90. It is supported only for > limited amount of UBWC formats. > - There are two versions of inline rotators, v1 (present on sm8250 and > sm7250) and v2 (sc7280). These versions differ in the list of supported >

Re: [Freedreno] [PATCH v4 4/4] arm64/dts/qcom/sm8250: remove assigned-clock-rate property for mdp clk

2022-03-03 Thread Stephen Boyd
lated value during the usecase. > > Fixes: 7c1dffd471("arm64: dts: qcom: sm8250.dtsi: add display system nodes") > Signed-off-by: Vinod Polimera > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v4 3/4] arm64/dts/qcom/sdm845: remove assigned-clock-rate property for mdp clk

2022-03-03 Thread Stephen Boyd
lated value during the usecase. > > Fixes: 08c2a076d1("arm64: dts: qcom: sdm845: Add dpu to sdm845 dts file") > Signed-off-by: Vinod Polimera > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v4 2/4] arm64/dts/qcom/sc7180: remove assigned-clock-rate property for mdp clk

2022-03-03 Thread Stephen Boyd
lated value during the usecase. > > Fixes: a3db7ad1af("arm64: dts: qcom: sc7180: add display dt nodes") > Signed-off-by: Vinod Polimera > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v4 1/4] arm64/dts/qcom/sc7280: remove assigned-clock-rate property for mdp clk

2022-03-03 Thread Stephen Boyd
lated value during the usecase. > > Changes in v2: > - Remove assigned-clock-rate property and set mdp clk during resume sequence. > - Add fixes tag. > > Changes in v3: > - Remove extra line after fixes tag.(Stephen Boyd) > This changelog goes below triple dash when they ar

Re: [Freedreno] [PATCH v3 0/6] drm/msm/dpu: simplify IRQ helpers

2022-03-03 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-16 20:31:42) > This is the second part of > https://patchwork.freedesktop.org/series/91631/ reworked and cleaned up. > > Changes since v1: v2? > - Fix warning ins dpu_trace.h related to >dpu_core_irq_unregister_callback event Any plans to migrate to

Re: [Freedreno] [PATCH v3 5/6] drm/msm/dpu: remove struct dpu_encoder_irq

2022-03-03 Thread Stephen Boyd
longer needs to remember which function is called. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v3 3/6] drm/msm/dpu: allow just single IRQ callback

2022-03-03 Thread Stephen Boyd
upt handling code. > > Reported-by: kernel test robot > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH 4/4] drm/msm/dpu: drop INTF_EDP from interface type conditions

2022-03-03 Thread Stephen Boyd
mitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH 3/4] drm/msm/dpu: drop obsolete INTF_EDP comment

2022-03-03 Thread Stephen Boyd
s no purpose. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH 2/4] drm/msm/dpu: drop INTF_TYPE_MAX symbol

2022-03-03 Thread Stephen Boyd
mitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH 1/4] drm/msm/dpu: document INTF_EDP/INTF_DP difference

2022-03-03 Thread Stephen Boyd
d DP interfaces handled by the msm/dp > driver. The DPU driver does not make a difference between them. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH 3/4] drm/msm: Add SYSPROF param

2022-03-03 Thread Stephen Boyd
Quoting Rob Clark (2022-03-03 11:46:47) > diff --git a/drivers/gpu/drm/msm/msm_gpu.h b/drivers/gpu/drm/msm/msm_gpu.h > index fde9a29f884e..0ba1dbd4e50f 100644 > --- a/drivers/gpu/drm/msm/msm_gpu.h > +++ b/drivers/gpu/drm/msm/msm_gpu.h > @@ -330,6 +337,24 @@ struct msm_file_private { >

Re: [Freedreno] [PATCH v2 6/6] arm: dts: qcom-msm8974: Drop flags for mdss irqs

2022-03-02 Thread Stephen Boyd
pt number, not two. > Drop the second cell containing (unused) irq flags. > > Fixes: 5a9fc531f6ec ("ARM: dts: msm8974: add display support") > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [RESEND PATCH] dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml

2022-03-01 Thread Stephen Boyd
Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH 5/5] arm64: dts: qcom: sm8250: Drop flags for mdss irqs

2022-03-01 Thread Stephen Boyd
mitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH 4/5] arm64: dts: qcom: sdm845: Drop flags for mdss irqs

2022-03-01 Thread Stephen Boyd
mitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH 3/5] arm64: dts: qcom: sdm660: Drop flags for mdss irqs

2022-03-01 Thread Stephen Boyd
mitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH 2/5] arm64: dts: qcom: sdm630: Drop flags for mdss irqs

2022-03-01 Thread Stephen Boyd
mitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH 1/5] arm64: dts: qcom: msm8996: Drop flags for mdss irqs

2022-03-01 Thread Stephen Boyd
mitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v12 4/4] drm/msm/dp: enable widebus feature for display port

2022-02-25 Thread Stephen Boyd
add const to dp_catalog_hw_revision() > -- add const to msm_dp_wide_bus_available() > > Changes in v12: > -- dp_catalog_hw_revision(const struct dp_catalog *dp_catalog) > -- msm_dp_wide_bus_available(const struct msm_dp *dp_display) > > Signed-off-by: Kuogee Hsieh > Reported-by: kernel test robot > Tested-by: Bjorn Andersson > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v11 4/4] drm/msm/dp: enable widebus feature for display port

2022-02-25 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-02-25 12:45:57) > Widebus feature will transmit two pixel data per pixel clock to interface. > This feature now is required to be enabled to easy migrant to higher > resolution applications in future. However since some legacy chipsets > does not support this feature,

Re: [Freedreno] [PATCH v10 4/4] drm/msm/dp: enable widebus feature for display port

2022-02-25 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-02-22 16:27:40) > diff --git a/drivers/gpu/drm/msm/dp/dp_catalog.c > b/drivers/gpu/drm/msm/dp/dp_catalog.c > index 6ae9b29..c789f4e 100644 > --- a/drivers/gpu/drm/msm/dp/dp_catalog.c > +++ b/drivers/gpu/drm/msm/dp/dp_catalog.c > @@ -483,6 +485,22 @@ int

Re: [Freedreno] [PATCH v10 3/4] drm/msm/dpu: revise timing engine programming to support widebus feature

2022-02-25 Thread Stephen Boyd
N features check. > > Changes in v10: > -- add const inside dpu_encoder_is_widebus_enabled() > -- drop useless parenthesis please > > Signed-off-by: Kuogee Hsieh > Tested-by: Bjorn Andersson > Reviewed-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v2 2/2] drm/msm/disp/dpu1: set mdp clk to the maximum frequency in opp table

2022-02-25 Thread Stephen Boyd
Quoting Vinod Polimera (2022-02-25 07:57:50) > use max clock during resume sequence from the opp table. s/use/Use/ > The clock will be scaled down when framework sends an update. > > Fixes: 62fbdce91("arm64: dts: qcom: sc7280: add display dt nodes") Presumably this is the wrong fixes tag, see

Re: [Freedreno] [PATCH v2 1/2] arm64/dts/qcom/sc7280: remove assigned-clock-rate property for mdp clk

2022-02-25 Thread Stephen Boyd
Quoting Vinod Polimera (2022-02-25 07:57:49) > Kernel clock driver assumes that initial rate is the > max rate for that clock and was not allowing it to scale > beyond the assigned clock value. > > drop the assigned clock rate property and set it > during resume sequence with max value in the opp

Re: [Freedreno] [PATCH v4 3/3] drm/msm/dp: replace DRM_DEBUG_DP marco with drm_dbg_dp

2022-02-24 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-02-17 10:35:30) > Since DRM_DEBUG_DP is deprecated in favor of drm_dbg_dp(NULL, ...), > this patch replace all DRM_DEBUG_DP with drm_dbg_dp(). > > Changes in v4: > -- replace (strucr drm_dev *)NULL with drm_dev > > Signed-off-by: Kuogee Hsieh > -

Re: [Freedreno] [RFC PATCH v2 4/5] drm/msm/dp: replace dp_connector with drm_bridge_connector

2022-02-23 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-02-23 10:27:26) > > On 2/23/2022 10:22 AM, Dmitry Baryshkov wrote: > > On 23/02/2022 20:21, Kuogee Hsieh wrote: > > > > In the panel device node. > > > > Can you please share it too? > > > { >     edp_power_supply: edp_power { >     compatible =

Re: [Freedreno] [v1] arm64/dts/qcom/sc7280: update mdp clk to max supported value to support higher refresh rates

2022-02-22 Thread Stephen Boyd
Quoting Doug Anderson (2022-02-22 13:25:05) > Hi, > > On Tue, Feb 22, 2022 at 12:58 PM Stephen Boyd wrote: > > > > Quoting Vinod Polimera (2022-02-21 05:12:06) > > > Panels with higher refresh rate will need mdp clk above 300Mhz. > > > Select max frequency

Re: [Freedreno] [PATCH v2 4/4] drm/msm/disp/dpu1: add PSR support for eDP interface in dpu driver

2022-02-22 Thread Stephen Boyd
Quoting Vinod Polimera (2022-02-21 06:51:26) > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > index e7c9fe1..ba3240c 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > @@ -951,6 +952,14

Re: [Freedreno] [PATCH v2 2/4] drm/bridge: use atomic enable/disable for bridge callbacks

2022-02-22 Thread Stephen Boyd
Quoting Vinod Polimera (2022-02-21 06:51:24) > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c > index b32295a..5c7dc82 100644 > --- a/drivers/gpu/drm/bridge/panel.c > +++ b/drivers/gpu/drm/bridge/panel.c > @@ -102,30 +136,82 @@ static void panel_bridge_detach(struct

Re: [Freedreno] [PATCH] drm/msm/dp: switch to devm_drm_of_get_bridge

2022-02-22 Thread Stephen Boyd
Quoting José Expósito (2022-02-20 23:33:39) > The function "drm_of_find_panel_or_bridge" has been deprecated in > favor of "devm_drm_of_get_bridge". > > Switch to the new function and reduce boilerplate. > > Signed-off-by: José Expósito > --- Dmitry is rewriting this code in a larger series.

Re: [Freedreno] [v1] arm64/dts/qcom/sc7280: update mdp clk to max supported value to support higher refresh rates

2022-02-22 Thread Stephen Boyd
Quoting Vinod Polimera (2022-02-21 05:12:06) > Panels with higher refresh rate will need mdp clk above 300Mhz. > Select max frequency for mdp clock during bootup, dpu driver will > scale down the clock as per usecase when first update from the framework is > received. > > Signed-off-by: Vinod

Re: [Freedreno] [PATCH v8 4/4] drm/msm/dp: enable widebus feature for display port

2022-02-18 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-02-17 13:36:28) > Widebus feature will transmit two pixel data per pixel clock to interface. > This feature now is required to be enabled to easy migrant to higher s/migrant/migrate/? > resolution applications in future. However since some legacy chipsets s/in/in the/

Re: [Freedreno] [PATCH v8 3/4] drm/msm/dpu: revise timing engine programming to support widebus feature

2022-02-18 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-02-17 13:36:27) > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > index 0d315b4..0c22839 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > @@ -217,6

Re: [Freedreno] [PATCH v8 2/4] drm/msm/dpu: replace BIT(x) with correspond marco define string

2022-02-18 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-02-17 13:36:26) > To improve code readability, this patch replace BIT(x) with > correspond register bit define string > > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v8 1/4] drm/msm/dpu: adjust display_v_end for eDP and DP

2022-02-18 Thread Stephen Boyd
plementation has > only display_h_end adjusted. > > Signed-off-by: Kuogee Hsieh > --- Is this not a problem for me because this is set already to something correct in the hardware? Reviewed-by: Stephen Boyd

Re: [Freedreno] [RFC PATCH v2 4/5] drm/msm/dp: replace dp_connector with drm_bridge_connector

2022-02-18 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-18 14:32:53) > On 19/02/2022 00:31, Kuogee Hsieh wrote: > > > > On 2/11/2022 2:40 PM, Dmitry Baryshkov wrote: > >> There is little point in having both connector and root bridge > >> implementation in the same driver. Move connector's functionality to the > >>

Re: [Freedreno] [RFC PATCH v2 3/5] drm/msm/dp: support finding next bridge even for DP interfaces

2022-02-18 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-11 14:40:04) > It is possible to supply display-connector (bridge) to the DP interface, > add support for parsing it too. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [RFC PATCH v2 1/5] drm/msm/dp: fix panel bridge attachment

2022-02-18 Thread Stephen Boyd
r. > > Fixes: 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for display enable > and disable") > Cc: Kuogee Hsieh > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd > drivers/gpu/drm/msm/dp/dp_drm.c | 21 +++-- > 1 file

Re: [Freedreno] [RFC PATCH v2 2/5] drm/msm/dp: support attaching bridges to the DP encoder

2022-02-18 Thread Stephen Boyd
or with EDID lines for panel autodetect > - eDP encoder ⇒ ptn3460 ⇒ THC63LVD1024 ⇒ DPI panel. > - eDP encoder ⇒ LT8912 ⇒ DSI panel > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v4 3/3] drm/msm/dp: replace DRM_DEBUG_DP marco with drm_dbg_dp

2022-02-17 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-02-17 10:35:30) > Since DRM_DEBUG_DP is deprecated in favor of drm_dbg_dp(NULL, ...), > this patch replace all DRM_DEBUG_DP with drm_dbg_dp(). > > Changes in v4: > -- replace (strucr drm_dev *)NULL with drm_dev Why can't the platform device be used?

Re: [Freedreno] [PATCH v3 3/3] drm/msm/dp: replace DRM_DEBUG_DP marco with drm_dbg_dp

2022-02-16 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-02-02 10:56:39) Please add some commit text > Signed-off-by: Kuogee Hsieh > --- > drivers/gpu/drm/msm/dp/dp_audio.c | 49 +++-- > drivers/gpu/drm/msm/dp/dp_catalog.c | 34 +++- > drivers/gpu/drm/msm/dp/dp_ctrl.c| 106 >

Re: [Freedreno] [PATCH v3 2/3] drm/msm/dp: enhance debug info related to dp phy

2022-02-16 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-02-02 10:56:38) > DP phy should be initialized and exited symmetrically to avoid > clock being stucked at either on or off error. Add debug info > to cover all DP phy to identify clock issues easily. > > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v3 1/3] drm/msm/dp: add connector type to enhance debug messages

2022-02-16 Thread Stephen Boyd
this purpose. > > Changes in v3: > -- replace original patch into 3 patches > > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v2] drm/msm/dp: always add fail-safe mode into connector mode list

2022-02-16 Thread Stephen Boyd
. This patch fixes test > case 4.2.2.1. > > Changes in v2: > -- add Fixes text string > > Fixes: 4b85d405cfe9 ( "drm/msm/dp: reduce link rate if failed at link > training 1") > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v4 2/2] drm/msm/dp: rewrite dss_module_power to use bulk clock functions

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-01-31 13:05:13) > diff --git a/drivers/gpu/drm/msm/dp/dp_parser.h > b/drivers/gpu/drm/msm/dp/dp_parser.h > index 094b39bfed8c..f16072f33cdb 100644 > --- a/drivers/gpu/drm/msm/dp/dp_parser.h > +++ b/drivers/gpu/drm/msm/dp/dp_parser.h > @@ -10,7 +10,6 @@ > #include

Re: [Freedreno] [PATCH v4 1/2] drm/msm/dpu: simplify clocks handling

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-01-31 13:05:12) > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c > index 60fe06018581..4d184122d63e 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c > +++

Re: [Freedreno] [PATCH] drm/msm: populate intf_audio_select() base on hardware capability

2022-02-15 Thread Stephen Boyd
ack function have > to be populated base on hardware chip capability where legacy > chipsets have has_audio_select flag set to true. > > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v3] drm/msm/dpu: Only create debugfs for PRIMARY minor

2022-02-15 Thread Stephen Boyd
current behavior is > unexpected, so change it to only create debugfs files for the PRIMARY > minor. > > Signed-off-by: Bjorn Andersson > [DB: slightly change description and in-patch comment] > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH 6/6] drm/msm/dpu: pass irq to dpu_encoder_helper_wait_for_irq()

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-01 07:10:56) > Pass IRQ number directly rather than passing an index in the dpu_encoder's > irq table. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH 5/6] drm/msm/dpu: remove struct dpu_encoder_irq

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-01 07:10:55) > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h > b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h > index ff2218155b44..803fd6f25da1 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h > +++

Re: [Freedreno] [PATCH 4/6] drm/msm/dpu: get rid of dpu_encoder_helper_(un)register_irq

2022-02-15 Thread Stephen Boyd
r > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH 2/6] drm/msm/dpu: remove always-true argument of dpu_core_irq_read()

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-01 07:10:52) > The argument clear of the function dpu_core_irq_read() is always true. > Remove it. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH 1/6] drm/msm/dpu: remove extra wrappers around dpu_core_irq

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-01 07:10:51) > Remove extra dpu_irq_* wrappers from dpu_kms.c, merge them directly into > dpu_core_irq_* functions. > > Signed-off-by: Dmitry Baryshkov > Reviewed-by: Abhinav Kumar > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v2 7/8] drm/msm/dpu: pull connector from dpu_encoder_phys to dpu_encoder_virt

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-15 18:13:09) > On Wed, 16 Feb 2022 at 05:00, Stephen Boyd wrote: > > > > Quoting Dmitry Baryshkov (2022-02-15 06:16:42) > > > All physical encoders used by virtual encoder share the same connector, > > > so pull the conn

Re: [Freedreno] [PATCH] drm/msm/dpu: drop unused access macros

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-15 06:53:06) > The access macros BLK_foo are not used by the code, drop them. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v2 7/8] drm/msm/dpu: pull connector from dpu_encoder_phys to dpu_encoder_virt

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-15 06:16:42) > All physical encoders used by virtual encoder share the same connector, > so pull the connector field from dpu_encoder_phys into dpu_encoder_virt > structure. What is the benefit? Less code? Clearer association?

Re: [Freedreno] [PATCH v2 6/8] drm/msm/dpu: switch dpu_encoder to use atomic_mode_set

2022-02-15 Thread Stephen Boyd
: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v2 5/8] drm/msm/dpu: encoder: drop unused mode_fixup callback

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-15 06:16:40) > Both cmd and vid backends provide useless mode_fixup() callback. Drop > it. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v2 4/8] drm/msm/dpu: drop bus_scaling_client field

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-15 06:16:39) > We do not use MSM bus client, so drop bus_scaling_client field from > dpu_encoder_virt. > > Reviewed-by: Abhinav Kumar > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v2 3/8] drm/msm/dpu: remove msm_dp cached in dpu_encoder_virt

2022-02-15 Thread Stephen Boyd
Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v2 2/8] drm/msm: move struct msm_display_info to dpu driver

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-15 06:16:37) > The msm_display_info structure is not used by the rest of msm driver, so > move it into the dpu1 (dpu_encoder.h to be precise). > > Reviewed-by: Abhinav Kumar > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v2 1/8] drm/msm/dpu: fix dp audio condition

2022-02-15 Thread Stephen Boyd
rm/msm/dp: add audio support for Display Port on MSM") > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v6 02/35] component: Introduce the aggregate bus_type

2022-02-10 Thread Stephen Boyd
; > > > > On Thu, Jan 27, 2022 at 12:01:08PM -0800, Stephen Boyd wrote: > > > > > The component framework only provides 'bind' and 'unbind' callbacks to > > > > > tell the host driver that it is time to assemble the aggregate driver > > &g

Re: [Freedreno] [PATCH v3 4/4] drm/msm/dp: Add driver support to utilize drm panel

2022-02-09 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-02-09 00:55:32) > Add support in the DP driver to utilize the custom eDP panels > from drm/panels. > > An eDP panel is always connected to the platform. So, the eDP > connector can be reported as always connected. The display mode > will be sourced from the

Re: [Freedreno] [PATCH v3 3/4] drm/panel-edp: Add eDP sharp panel support

2022-02-09 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-02-09 00:55:31) > Add support for the 14" sharp,lq140m1jw46 eDP panel. > > Signed-off-by: Sankeerth Billakanti > --- Can you share the edid-decode for this panel here under the cut "---"? It would help to see the timings and make sure everything matches.

Re: [Freedreno] [PATCH v3 2/4] arm64: dts: qcom: sc7280: Add support for eDP panel on CRD

2022-02-09 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-02-09 00:55:30) > Enable the eDP display panel support without HPD on sc7280 platform. > > Signed-off-by: Sankeerth Billakanti > --- > > Changes in v3: > - Sort the nodes alphabetically > - Use - instead of _ as node names > - Place the backlight and panel

Re: [Freedreno] [PATCH v3 1/4] dt-bindings: display: simple: Add sharp LQ140M1JW46 panel

2022-02-09 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-02-09 00:55:29) > Add support for sharp LQ140M1JW46 display panel. It is a 14" eDP panel > with 1920x1080 display resolution. > > Signed-off-by: Sankeerth Billakanti > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v2] drm/msm/dp: add connector type to enhance debug messages

2022-02-03 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-01-31 18:34:47) > On 27/01/2022 02:46, Kuogee Hsieh wrote: > > DP driver is a generic driver which supports both eDP and DP. > > For debugging purpose it is required to have capabilities to > > differentiate message are generated from eDP or DP. > > This patch do: >

Re: [Freedreno] [PATCH v1 0/3] Add support for eDP PHY on SC7280 platform

2022-02-02 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2021-11-15 23:07:35) > This series adds support for the eDP PHY on Qualcomm SC7280 platform. > The changes are dependent on v4 of the new eDP PHY driver introduced by Bjorn: > https://patchwork.kernel.org/project/linux-arm-msm/list/?series=575135 > > Sankeerth

[Freedreno] [PATCH v6 35/35] component: Remove component_master_ops and friends

2022-01-27 Thread Stephen Boyd
The struct is unused now so drop it along with the functions that use it. Cc: Daniel Vetter Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/componen

[Freedreno] [PATCH v6 34/35] component: Get rid of drm_of_component_probe()

2022-01-27 Thread Stephen Boyd
There aren't any users anymore so drop it. Cc: Laurent Pinchart Cc: Daniel Vetter Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/drm

[Freedreno] [PATCH v6 33/35] ALSA: hda/realtek: Migrate to aggregate driver

2022-01-27 Thread Stephen Boyd
socki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- sound/pci/hda/patch_realtek.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 66

[Freedreno] [PATCH v6 32/35] usb: typec: port-mapper: Migrate to aggregate driver

2022-01-27 Thread Stephen Boyd
ssell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/usb/typec/port-mapper.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/usb/typec/port-mapper.c b/drivers/usb/typec/port-mapper.c index 07d307418b47..33fbebc6a85b 100644 ---

[Freedreno] [PATCH v6 31/35] drm/sprd: Migrate to aggregate driver

2022-01-27 Thread Stephen Boyd
: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/sprd/sprd_drm.c | 48 +++-- 1 file changed, 28 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/sprd/sp

[Freedreno] [PATCH v6 26/35] mei: Migrate to aggregate driver

2022-01-27 Thread Stephen Boyd
Bergmann Cc: Greg Kroah-Hartman Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Cc: Alexander Usyskin Signed-off-by: Stephen Boyd --- drivers/misc/mei/hdcp/mei_hdcp.c | 22 +- drivers/misc/mei/pxp/mei_px

[Freedreno] [PATCH v6 29/35] sound: hdac: Migrate to aggregate driver

2022-01-27 Thread Stephen Boyd
socki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- sound/hda/hdac_component.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/sound/hda/hdac_component.c b/sound/hda/hdac_component.c index bb37e7e0bd79..4e

[Freedreno] [PATCH v6 28/35] fbdev: omap2: Migrate to aggregate driver

2022-01-27 Thread Stephen Boyd
: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/video/fbdev/omap2/omapfb/dss/dss.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dss.c b/drivers/video/fbdev/omap2/omapfb/dss/dss.c index a6b1c1598040..0b

[Freedreno] [PATCH v6 30/35] ASoC: codecs: wcd938x: Migrate to aggregate driver

2022-01-27 Thread Stephen Boyd
; Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- sound/soc/codecs/wcd938x.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index eff200a07d9f..6e1c9f93c819 100644 -

[Freedreno] [PATCH v6 27/35] power: supply: ab8500: Migrate to aggregate driver

2022-01-27 Thread Stephen Boyd
ael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/power/supply/ab8500_charger.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/po

[Freedreno] [PATCH v6 25/35] iommu/mediatek: Migrate to aggregate driver

2022-01-27 Thread Stephen Boyd
; Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/iommu/mtk_iommu.c| 14 +- drivers/iommu/mtk_iommu.h| 6 -- drivers/iommu/mtk_iommu_v1.c | 14 +- drivers/memory/mtk-smi.c | 10 -- 4 files changed, 26

[Freedreno] [PATCH v6 24/35] drm/vc4: Migrate to aggregate driver

2022-01-27 Thread Stephen Boyd
Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/vc4/vc4_drv.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c index 16abc3a3d601..297ecddea

[Freedreno] [PATCH v6 23/35] drm/tilcdc: Migrate to aggregate driver

2022-01-27 Thread Stephen Boyd
; Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_d

[Freedreno] [PATCH v6 18/35] drm/meson: Migrate to aggregate driver

2022-01-27 Thread Stephen Boyd
l King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/meson/meson_drv.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c index 80f1d439841a..2add29b34

[Freedreno] [PATCH v6 20/35] drm/rockchip: Migrate to aggregate driver

2022-01-27 Thread Stephen Boyd
; Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchi

[Freedreno] [PATCH v6 22/35] drm/sun4i: Migrate to aggregate driver

2022-01-27 Thread Stephen Boyd
Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/sun4i/sun4i_drv.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c index b6

[Freedreno] [PATCH v6 21/35] drm/sti: Migrate to aggregate driver

2022-01-27 Thread Stephen Boyd
ana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/sti/sti_drv.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c index c7efb43b83ee..958db315d547 100644 --- a/drivers/gpu/drm/sti/sti_d

[Freedreno] [PATCH v6 19/35] drm/omap: Migrate to aggregate driver

2022-01-27 Thread Stephen Boyd
l King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/omapdrm/dss/dss.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c b/drivers/gpu/drm/omapdrm/dss/dss.c index 69b3e15b9356..96a290a7b

[Freedreno] [PATCH v6 15/35] drm/ingenic: Migrate to aggregate driver

2022-01-27 Thread Stephen Boyd
Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 25 +-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/ingenic/ingenic-dr

[Freedreno] [PATCH v6 17/35] drm/mediatek: Migrate to aggregate driver

2022-01-27 Thread Stephen Boyd
Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index 56

[Freedreno] [PATCH v6 11/35] drm/etnaviv: Migrate to aggregate driver

2022-01-27 Thread Stephen Boyd
socki" Cc: Rob Clark Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c index 0b

[Freedreno] [PATCH v6 16/35] drm/mcde: Migrate to aggregate driver

2022-01-27 Thread Stephen Boyd
ana Kannan Tested-by: Linus Walleij Signed-off-by: Stephen Boyd --- drivers/gpu/drm/mcde/mcde_drv.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/mcde/mcde_drv.c b/drivers/gpu/drm/mcde/mcde_drv.c index 5b5afc6aaf8e..b84793558

[Freedreno] [PATCH v6 14/35] drm/imx: Migrate to aggregate driver

2022-01-27 Thread Stephen Boyd
l King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/imx/imx-drm-core.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c index cb685fe2039b..82645e42b

<    1   2   3   4   5   6   7   8   9   10   >