Can you Cc dri-devel?
Quoting Kuogee Hsieh (2021-06-03 08:40:46)
> Normal DP suspend operation contains two steps, display off followed
> by dp suspend, to complete system wide suspending cycle if display is
> up at that time. In this case, DP phy will be powered off at display
> off. However
Quoting Kuogee Hsieh (2021-06-02 09:43:05)
> Normal DP suspend operation contains two steps, display off followed
> by dp suspend, to complete system wide suspending cycle if display is
> up at that time. In this case, DP phy will be powered off at display
> off. However there is an exception case
03 ("drm/msm/dp: handle irq_hpd with sink_count = 0
> correctly)
> Signed-off-by: Kuogee Hsieh
> ---
Ok, this seems to work and is nice and small
Tested-by: Stephen Boyd
Reviewed-by: Stephen Boyd
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
warning: Excess function parameter
> 'aux' description in 'dp_catalog_aux_reset'
>
> Cc: Rob Clark
> Cc: Sean Paul
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: Chandan Uddaraju
> Cc: Stephen Boyd
> Cc: linux-arm-...@vger.kernel.org
> Cc: dri-de...@lists.freedesktop.org
&
Subject should be
"arm64: dts: qcom: sc7180: Add DisplayPort node"
Quoting Kuogee Hsieh (2021-06-02 14:08:38)
> Add DP device node on sc7180.
>
> Signed-off-by: Kuogee Hsieh
> ---
> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 9
> arch/arm64/boot/dts/qcom/sc7180.dtsi |
Please add dri-de...@lists.freedesktop.org next time
Quoting Kuogee Hsieh (2021-06-01 16:50:08)
> Normal DP suspend operation contains two steps, display off followed
> by dp suspend, to complete system wide suspending cycle if display is
> up at that time. In this case, DP phy will be powered
General note, please Cc dri-devel on freedreno driver patches.
Quoting Kuogee Hsieh (2021-05-26 16:49:49)
> Aux channel is used to perform management function and should be
> running in parallel with main link. Therefore should only power
> down main link and keep aux channel running when power
Quoting Kuogee Hsieh (2021-05-26 11:08:23)
> DP mainlink can be either enabled or disabled at the time of suspend
> happen. Therefore DP phy teared down at suspend should base on mainlink
> status at that instance.
Please add some more details here. The system crashes if you plug in the
HDMI
Quoting khs...@codeaurora.org (2021-05-24 09:33:49)
> On 2021-05-07 14:25, Stephen Boyd wrote:
> > @@ -367,36 +347,38 @@ static ssize_t dp_aux_transfer(struct drm_dp_aux
> > *dp_aux,
> > }
> >
> > ret = dp_aux_cmd_fifo_tx(aux,
Quoting Daniel Vetter (2021-05-20 12:58:52)
> On Wed, May 19, 2021 at 05:25:19PM -0700, Stephen Boyd wrote:
> > @@ -1306,7 +1322,8 @@ static int msm_pdev_probe(struct platform_device
> > *pdev)
> > if (ret)
> > goto fail;
> >
> > -
Quoting Saravana Kannan (2021-05-20 13:20:45)
> On Wed, May 19, 2021 at 5:25 PM Stephen Boyd wrote:
> >
> > - master->parent = parent;
> > - master->ops = ops;
> > - master->match = match;
> > + id = ida_alloc
warning: Excess function parameter
> 'aux' description in 'dp_catalog_aux_reset'
>
> Cc: Rob Clark
> Cc: Sean Paul
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: Chandan Uddaraju
> Cc: Stephen Boyd
> Cc: linux-arm-...@vger.kernel.org
> Cc: dri-de...@lists.freedesktop.org
&
Quoting Doug Anderson (2021-05-21 15:35:33)
> Hi,
>
> On Fri, May 21, 2021 at 3:02 PM Stephen Boyd wrote:
> >
> > Quoting Douglas Anderson (2021-05-21 13:45:50)
> > > Let's use the newly-added nvmem_cell_read_variable_le_u32() to future
> > > proof ourselv
Quoting Douglas Anderson (2021-05-21 13:45:50)
> Let's use the newly-added nvmem_cell_read_variable_le_u32() to future
> proof ourselves a little bit.
>
> Signed-off-by: Douglas Anderson
> ---
> The patch that this depends on is now in mainline so it can be merged
> at will. I'm just sending this
Quoting Stephen Boyd (2021-05-07 14:25:02)
> Here's a few patches that simplify the aux handling code and bubble up
> timeouts and nacks to the upper DRM layers. The goal is to get DRM to
> know that the other side isn't there or that there's been a timeout,
> instead of saying tha
Quoting Bjorn Andersson (2021-05-21 09:00:29)
> On Fri 21 May 05:27 CDT 2021, Krishna Manikandan wrote:
> > diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
> > b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
> [..]
> > + ports:
> > +$ref:
Quoting Krishna Manikandan (2021-05-21 03:27:23)
> Add YAML schema for the device tree bindings for DSI PHY.
>
> Signed-off-by: Krishna Manikandan
>
> Changes in v1:
>- Merge dsi-phy.yaml and dsi-phy-10nm.yaml (Stephen Boyd)
>- Remove qcom,dsi-phy-regulator-l
Quoting Krishna Manikandan (2021-05-21 03:27:22)
> Add YAML schema for the device tree bindings for DSI
>
> Signed-off-by: Krishna Manikandan
>
> Changes in v1:
> - Separate dsi controller bindings to a separate patch (Stephen Boyd)
> - Merge dsi-common-controller.ya
file (Rob Herring)
> - Use unevaluatedProperties and additionalProperties
> wherever required
> - Remove duplicate properties from common yaml files
>
> Changes in v10:
> - Split the patch into separate patches for DPU, DSI and
> PHY (Stephen Boyd)
&g
patch as it does not contain PLL bindings anymore
> - Remove redundant properties
> - Remove use of IRQ flag
> - Fix ports property
>
> Changes in v11:
> - add ports required of both #address-cells and #size-cells
> - add required operating-points-v2
> - add required #so
Quoting Saravana Kannan (2021-05-19 18:27:50)
> On Wed, May 19, 2021 at 5:25 PM Stephen Boyd wrote:
> >
> > This series is from discussion we had on reordering the device lists for
> > drm shutdown paths[1]. I've introduced an 'aggregate' bus that we put
> > the aggreg
in the correct order.
Cc: Daniel Vetter
Cc: "Rafael J. Wysocki"
Cc: Rob Clark
Cc: Russell King
Cc: Saravana Kannan
Signed-off-by: Stephen Boyd
---
drivers/base/component.c | 429 +++---
include/linux/component.h | 60 +-
2 files changed, 359 insertio
shutdown hooks are called.
Cc: Daniel Vetter
Cc: "Rafael J. Wysocki"
Cc: Rob Clark
Cc: Russell King
Cc: Saravana Kannan
Signed-off-by: Stephen Boyd
---
As stated in the cover letter, this isn't perfect but it still works. I
get a warning from runtime PM that the parent device (e
l King
Cc: Saravana Kannan
Signed-off-by: Stephen Boyd
---
drivers/base/component.c | 249 --
include/linux/component.h | 2 +-
2 files changed, 134 insertions(+), 117 deletions(-)
diff --git a/drivers/base/component.c b/drivers/base/component.c
index 5e
: Daniel Vetter
Cc: "Rafael J. Wysocki"
Cc: Rob Clark
Cc: Russell King
Cc: Saravana Kannan
Signed-off-by: Stephen Boyd
---
drivers/base/component.c | 89 +++-
1 file changed, 42 insertions(+), 47 deletions(-)
diff --git a/drivers/base/component.c
This allows aggregate driver writers to use the device passed to their
probe/remove/shutdown functions properly instead of treating it as an
opaque pointer.
Cc: Daniel Vetter
Cc: "Rafael J. Wysocki"
Cc: Rob Clark
Cc: Russell King
Cc: Saravana Kannan
Signed-off-by: Stephen Boyd
--
We left this in place to ease the code diff, but now we can remove it
because the aggregate device parent pointer is the same.
Cc: Daniel Vetter
Cc: "Rafael J. Wysocki"
Cc: Rob Clark
Cc: Russell King
Cc: Saravana Kannan
Signed-off-by: Stephen Boyd
---
drivers/base/compon
This argument isn't used. Drop it.
Cc: Daniel Vetter
Cc: "Rafael J. Wysocki"
Cc: Rob Clark
Cc: Russell King
Cc: Saravana Kannan
Signed-off-by: Stephen Boyd
---
drivers/base/component.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/base/com
[1] https://lore.kernel.org/r/20210508074118.1621729-1-swb...@chromium.org
Stephen Boyd (7):
component: Drop 'dev' argument to component_match_realloc()
component: Rename 'dev' to 'parent'
component: Introduce struct aggregate_device
component: Introduce the aggregate bus_type
component: Use
70e64dc1bbc ("drm/msm/dpu: Convert to a chained irq chip")
> Reported-by: Hulk Robot
> Signed-off-by: Zhen Lei
> ---
Reviewed-by: Stephen Boyd
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
Quoting Leizhen (ThunderTown) (2021-05-08 00:55:04)
>
>
> On 2021/5/8 14:09, Stephen Boyd wrote:
> > Quoting Zhen Lei (2021-05-07 19:42:54)
> >> Fix to return a negative error code from the error handling case instead
> >> of 0, as done elsewhere in this functi
Quoting Zhen Lei (2021-05-07 19:42:54)
> Fix to return a negative error code from the error handling case instead
> of 0, as done elsewhere in this function.
>
> Fixes: 070e64dc1bbc ("drm/msm/dpu: Convert to a chained irq chip")
> Reported-by: Hulk Robot
> Signed-off-by: Zhen Lei
> ---
>
Signed-off-by: Stephen Boyd
---
drivers/gpu/drm/msm/dp/dp_aux.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_aux.c b/drivers/gpu/drm/msm/dp/dp_aux.c
index 91188466cece..b49810396513 100644
--- a/drivers/gpu/drm/msm/dp/dp_aux.c
.
Cc: Dmitry Baryshkov
Cc: Abhinav Kumar
Cc: Kuogee Hsieh
Cc: aravi...@codeaurora.org
Cc: Sean Paul
Stephen Boyd (3):
drm/msm/dp: Simplify aux irq handling code
drm/msm/dp: Shrink locking area of dp_aux_transfer()
drm/msm/dp: Handle aux timeouts, nacks, defers
drivers/gpu/drm/msm/dp
core can figure out that things are just not going
well. The important thing is that we're now returning -ETIMEDOUT when
the message times out and nacks for bad addresses.
Cc: Dmitry Baryshkov
Cc: Abhinav Kumar
Cc: Kuogee Hsieh
Cc: aravi...@codeaurora.org
Cc: Sean Paul
Signed-off-by: Stephen
Cc: Sean Paul
Signed-off-by: Stephen Boyd
---
drivers/gpu/drm/msm/dp/dp_aux.c | 22 --
drivers/gpu/drm/msm/dp/dp_catalog.c | 2 +-
drivers/gpu/drm/msm/dp/dp_catalog.h | 2 +-
3 files changed, 10 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp
Quoting Kuogee Hsieh (2021-04-21 16:37:37)
> Maybe when the cable is disconnected the DP phy should be shutdown and
> some bit in the phy could effectively "cut off" the aux channel and then
> NAKs would start coming through here in the DP controller I/O register
> space. This patch have DP aux
V4:
> -- split this patch as stand alone patch
>
> Signed-off-by: Kuogee Hsieh
Can this patch come before the one previously? And then some fixes tag
be added? Otherwise looks good to me.
Reviewed-by: Stephen Boyd
Tested-by: Stephen Boyd
__
>
> Changes in v3:
> -- restore dp_display_handle_plugged_change() at dp_hpd_unplug_handle().
>
> Changes in v4:
> -- none
>
> Signed-off-by: Kuogee Hsieh
> ---
Reviewed-by: Stephen Boyd
Tested-by: Stephen Boyd
Fixes: c703d5789590 ("drm/msm/
m/dp: reset dp controller only at boot up and
> pm_resume")
> Reported-by: Stephen Boyd
> Reviewed-by: Stephen Boyd
> Tested-by: Stephen Boyd
> Signed-off-by: Kuogee Hsieh
> ---
> drivers/gpu/drm/msm/dp/dp_display.c | 15 ---
> 1 file changed, 8
Quoting khs...@codeaurora.org (2021-05-03 12:23:31)
> On 2021-04-29 20:11, Stephen Boyd wrote:
> > Quoting khs...@codeaurora.org (2021-04-29 10:23:31)
> >> On 2021-04-29 02:26, Stephen Boyd wrote:
> >> > Quoting khs...@codeaurora.org (2021-04-28 10:38:11)
> >&g
Signed-off-by: Stephen Boyd
---
drivers/gpu/drm/msm/msm_fb.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_fb.c b/drivers/gpu/drm/msm/msm_fb.c
index d42f0665359a..90514d3179bb 100644
--- a/drivers/gpu/drm/msm/msm_fb.c
+++ b/drivers/gpu/drm
...@codeaurora.org
Cc: Sean Paul
Signed-off-by: Stephen Boyd
---
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 22 +--
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 38 +--
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 10 ++---
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 6
Use the DPU_DEBUG_PLANE() helper to print the plane number instead of
open coding it.
Cc: Dmitry Baryshkov
Cc: Abhinav Kumar
Cc: Kuogee Hsieh
Cc: aravi...@codeaurora.org
Cc: Sean Paul
Signed-off-by: Stephen Boyd
---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 17 +++--
1 file
that felt appropriate. Please review.
Cc: Dmitry Baryshkov
Cc: Abhinav Kumar
Cc: Kuogee Hsieh
Cc: aravi...@codeaurora.org
Cc: Sean Paul
Stephen Boyd (6):
drm/msm: Move vblank debug prints to drm_dbg_vbl()
drm/msm: Use VERB() for extra verbose logging
drm/msm/dp: Drop malformed debug
useless.
Cc: Dmitry Baryshkov
Cc: Abhinav Kumar
Cc: Kuogee Hsieh
Cc: aravi...@codeaurora.org
Cc: Sean Paul
Signed-off-by: Stephen Boyd
---
drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 16
2 files changed, 9 insertions(+), 9
This print is missing a newline, and doesn't really provide any value.
Drop it.
Cc: Dmitry Baryshkov
Cc: Abhinav Kumar
Cc: Kuogee Hsieh
Cc: aravi...@codeaurora.org
Cc: Sean Paul
Signed-off-by: Stephen Boyd
---
drivers/gpu/drm/msm/dp/dp_panel.c | 1 -
1 file changed, 1 deletion(-)
diff
Put these debug prints in the vblank code into the appropriate vblank
category via drm_dbg_vbl().
Cc: Dmitry Baryshkov
Cc: Abhinav Kumar
Cc: Kuogee Hsieh
Cc: aravi...@codeaurora.org
Cc: Sean Paul
Signed-off-by: Stephen Boyd
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 2
a0
>[ 20.950058] el0_svc+0x20/0x30
>[ 20.953145] el0_sync_handler+0x88/0xb0
>[ 20.957014] el0_sync+0x13c/0x140
>
> The reason for the codepath seems dubious, the atomic suspend/resume
> heplers should handle the power-collapse case. If not, the CRTC's
> atom
Quoting khs...@codeaurora.org (2021-04-29 10:23:31)
> On 2021-04-29 02:26, Stephen Boyd wrote:
> > Quoting khs...@codeaurora.org (2021-04-28 10:38:11)
> >> On 2021-04-27 17:00, Stephen Boyd wrote:
> >> > Quoting aravi...@codeaurora.org (2021-04-21 11:55:21)
&g
Quoting aravi...@codeaurora.org (2021-04-21 11:55:21)
> On 2021-04-21 10:26, khs...@codeaurora.org wrote:
> >>
> >>> +
> >>> mutex_unlock(>event_mutex);
> >>>
> >>> return 0;
> >>> @@ -1496,6 +1502,9 @@ int msm_dp_display_disable(struct msm_dp *dp,
> >>> struct drm_encoder
Quoting Kuogee Hsieh (2021-04-16 10:38:51)
> Maybe when the cable is disconnected the DP phy should be shutdown and
> some bit in the phy could effectively "cut off" the aux channel and then
> NAKs would start coming through here in the DP controller I/O register
> space. This patch have DP aux
Quoting Kuogee Hsieh (2021-04-16 13:27:57)
> Some dongle may generate more than one irq_hpd events in a short period of
> time. This patch will treat those irq_hpd events as single one and service
> only one irq_hpd event.
Why is it bad to get multiple irq_hpd events in a short period of time?
Quoting khs...@codeaurora.org (2021-04-15 15:02:40)
> On 2021-04-15 13:06, Stephen Boyd wrote:
> >
> > Is it really necessary to have this patch at all? I think there are
> > bigger problems with suspend/resume of the DP driver in relation to the
> > kthread stopping.
Quoting khs...@codeaurora.org (2021-04-15 10:37:29)
> On 2021-04-14 14:09, Stephen Boyd wrote:
> > Quoting Kuogee Hsieh (2021-04-13 16:11:44)
> >> Make sure main link is in connection state before start aux
> >> read/write operation to avoid unnecessary long delay due
Quoting Kuogee Hsieh (2021-04-14 14:02:50)
> Initialize audio_comp when audio starts and wait for audio_comp at
> dp_display_disable(). This will take care of both dongle unplugged
> and display off (suspend) cases.
>
> Changes in v2:
> -- add dp_display_start_audio()
>
> Signed-off-by: Kuogee
only at boot up and
> pm_resume")
> Reported-by: Stephen Boyd
> Reviewed-by: Stephen Boyd
> Tested-by: Stephen Boyd
> Signed-off-by: Kuogee Hsieh
> ---
Can you please thread your emailed patches? I see them all as toplevel
messages in my inbox :(
> drivers/gpu/drm/msm
Quoting Kuogee Hsieh (2021-04-13 16:11:44)
> Make sure main link is in connection state before start aux
> read/write operation to avoid unnecessary long delay due to
> main link had been unplugged.
>
> Signed-off-by: Kuogee Hsieh
> ---
> drivers/gpu/drm/msm/dp/dp_aux.c | 5 +
>
Quoting Kuogee Hsieh (2021-04-13 16:11:30)
> At dongle unplug, dp initializes audio_comp followed by sending disconnect
> event notification to audio and to make sure audio had shutdown completely
> by wait for audio completion notification at display_disable(). This patch
Is this
only at boot up and
> pm_resume")
> Reported-by: Stephen Boyd
> Signed-off-by: Kuogee Hsieh
> ---
Reviewed-by: Stephen Boyd
Tested-by: Stephen Boyd
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
Quoting Kuogee Hsieh (2021-04-12 10:03:23)
> At dp_display_disable(), do not re initialize audio_comp if
> hdp_state == ST_DISCONNECT_PENDING (unplug event) to avoid
> race condition which cause 5 second timeout expired.
More details please.
> Also
> add abort mechanism to reduce time spinning
ned-off-by: Kuogee Hsieh
> ---
Also please include
Reported-by: Stephen Boyd
in the next post.
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
Quoting Kuogee Hsieh (2021-04-12 10:02:51)
> At pm_resume check link sisnk_count before update is_connected status
s/sisnk_count/sink_count/
> base on HPD real time link status. Also print out error message only
> when either EV_CONNECT_PENDING_TIMEOUT or EV_DISCONNECT_PENDING_TIMEOUT
> happen.
Quoting Dmitry Baryshkov (2021-04-07 15:57:01)
> On Thu, 8 Apr 2021 at 01:41, Stephen Boyd wrote:
> >
> > Quoting Dmitry Baryshkov (2021-04-06 16:06:06)
> > > devm_clk_hw_register_fixed_factor_release(), the release function for
> > > the devm_clk_
Quoting Dmitry Baryshkov (2021-04-06 16:06:06)
> devm_clk_hw_register_fixed_factor_release(), the release function for
> the devm_clk_hw_register_fixed_factor(), calls
> clk_hw_unregister_fixed_factor(), which will kfree() the clock. However
> after that the devres functions will also kfree the
Quoting Dmitry Baryshkov (2021-04-06 16:06:06)
> devm_clk_hw_register_fixed_factor_release(), the release function for
> the devm_clk_hw_register_fixed_factor(), calls
> clk_hw_unregister_fixed_factor(), which will kfree() the clock. However
> after that the devres functions will also kfree the
Quoting Bernard Zhao (2021-04-07 06:06:21)
> This patch fix coccicheck warning:
> drivers/gpu/drm/msm/dp/dp_link.c:848:5-8: Unneeded variable: "ret". Return
> "0" on line 880
> Also remove unneeded function return value check.
>
> Signed-off-by: Bernard
Quoting Maxime Ripard (2021-03-30 08:35:27)
> Hi Stephen,
>
> On Mon, Mar 29, 2021 at 06:52:01PM -0700, Stephen Boyd wrote:
> > Trimming Cc list way down, sorry if that's too much.
> >
> > Quoting Maxime Ripard (2021-02-19 04:00:30)
> > > Many drivers referen
Trimming Cc list way down, sorry if that's too much.
Quoting Maxime Ripard (2021-02-19 04:00:30)
> Many drivers reference the plane->state pointer in order to get the
> current plane state in their atomic_update or atomic_disable hooks,
> which would be the new plane state in the global atomic
5c273dab308303a5217bd3e767d7083ddb:
>
> drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume
> (2021-03-22 18:52:34 -0700)
>
> are available in the Git repository at:
>
> https://git.linaro.org/people/dmit
Would make it devm_of_clk_add_hw_provider() in the subject
Quoting Dmitry Baryshkov (2021-03-27 04:02:53)
> Use devm_of_clk_add_hw_provider() to register provided clocks. This
> allows dropping the remove function alltogether.
>
> Signed-off-by: Dmitry Baryshkov
> ---
Reviewed-b
Subject should say register instead of registe
Quoting Dmitry Baryshkov (2021-03-27 04:02:52)
> Use devres-enabled version of clock registration functions. This lets us
> remove dsi_pll destroy callbacks completely.
>
> Signed-off-by: Dmitry Baryshkov
> ---
> drivers/gpu/drm/msm/dsi/dsi.h
Quoting Dmitry Baryshkov (2021-03-27 04:02:43)
> Add devm_clk_hw_register_divider() - devres version of
> clk_hw_register_divider().
>
> Signed-off-by: Dmitry Baryshkov
> Reviewed-by: Abhinav Kumar
> ---
Acked-by: Stephen Boyd
___
Quoting Dmitry Baryshkov (2021-03-27 04:02:42)
> Add devm_clk_hw_register_mux() - devres-managed version of
> clk_hw_register_mux().
>
> Signed-off-by: Dmitry Baryshkov
> Reviewed-by: Abhinav Kumar
> ---
Acked-by: Stephen Boyd
___
Quoting Dmitry Baryshkov (2021-03-29 05:00:51)
> From: Jonathan Marek
>
> - Use sm8250 compatibles instead of sdm845 compatibles
>
Does it need the " - " prefix?
> Signed-off-by: Jonathan Marek
> Signed-off-by: Dmitry Baryshkov
>
> Signed-off-by: Dmitry Baryshkov
> ---
Reviewed-by: Stephen Boyd
This will conflict with the yaml changes to this file that are also in
flight.
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
every new compatible in the condition.
>
> Signed-off-by: Jonathan Marek
> Signed-off-by: Dmitry Baryshkov
> ---
Reviewed-by: Stephen Boyd
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
unctions are not supposed to be checked in the normal
> case so delete this code. Also it silences the above Smatch
> warnings that we're checking for NULL when these functions only
> return error pointers.
>
> Reported-by: kernel test robot
> Reported-by: Dan Carpenter
> Signed-of
t; Reported-by: kernel test robot
> Reported-by: Dan Carpenter
> Signed-off-by: Abhinav Kumar
> ---
Reviewed-by: Stephen Boyd
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
rm/msm/dp/dp_power.c:203 dp_power_clk_enable()
> warn: inconsistent indenting
>
> Reported-by: kernel test robot
> Reported-by: Dan Carpenter
> Signed-off-by: Abhinav Kumar
> ---
Reviewed-by: Stephen Boyd
___
Freedreno mailing
er")
Cc: Dmitry Baryshkov
Cc: Fabio Estevam
Cc: Krishna Manikandan
Signed-off-by: Stephen Boyd
---
drivers/gpu/drm/msm/msm_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index a5c6b8c23336..196907689c82 100644
--- a/drivers/g
Quoting Rob Clark (2021-03-24 20:09:37)
> On Wed, Mar 24, 2021 at 6:49 PM Stephen Boyd wrote:
> >
> > Quoting Dmitry Baryshkov (2021-03-18 13:05:44)
> > > if GPU components have failed to bind, shutdown callback would fail with
> > > the following backtrace. Add
Quoting Dmitry Baryshkov (2021-03-18 13:05:44)
> if GPU components have failed to bind, shutdown callback would fail with
> the following backtrace. Add safeguard check to stop that oops from
> happening and allow the board to reboot.
[...]
> diff --git a/drivers/gpu/drm/msm/msm_drv.c
Quoting Bhaskar Chowdhury (2021-03-17 23:26:50)
> s/modueles/modules/ two different places
>
> Signed-off-by: Bhaskar Chowdhury
> ---
Reviewed-by: Stephen Boyd
___
Freedreno mailing list
Freedreno@lists.freedeskt
Maybe subject could be "Ignore debugfs failures, fix indentation, fix
logical error"?
Quoting Abhinav Kumar (2021-03-04 17:31:52)
> Fix the warnings reported by kbot across MSM DP driver.
Which warnings? Can you include them? Or at least list the three things
that are being fixed in this patch?
iable.
Cc: Kuogee Hsieh
Fixes: 9fc418430c65 ("drm/msm/dp: unplug interrupt missed after irq_hpd
handler")
Signed-off-by: Stephen Boyd
---
Noticed by code inspection and based on bug reports where the aux channel
stops working once the commit this is fixing is applied.
drivers/gpu/drm
Quoting khs...@codeaurora.org (2021-02-19 08:39:38)
> On 2021-02-18 15:02, Stephen Boyd wrote:
> > Quoting Kuogee Hsieh (2021-02-18 12:55:04)
> >> Allow supported link rate to be limited to the value specified at
> >> dtsi. If it is not specified, then link rate is deri
Quoting Kuogee Hsieh (2021-02-18 12:55:04)
> Allow supported link rate to be limited to the value specified at
> dtsi. If it is not specified, then link rate is derived from dpcd
> directly. Below are examples,
> link-rate = <162000> for max link rate limited at 1.62G
> link-rate = <27> for
Quoting Kuogee Hsieh (2021-02-17 15:09:57)
> Drop limit link rate at HBR2 to support link rate
> upto HBR3.
>
> Signed-off-by: Kuogee Hsieh
> ---
Should also say
Tested-by: Stephen Boyd
___
Freedreno mailing list
Freedreno@lists.
Quoting Kuogee Hsieh (2021-02-17 15:09:57)
> Drop limit link rate at HBR2 to support link rate
> upto HBR3.
>
> Signed-off-by: Kuogee Hsieh
> ---
Reviewed-by: Stephen Boyd
___
Freedreno mailing list
Freedreno@lists.freede
Quoting Kuogee Hsieh (2021-02-17 08:58:42)
> Add hbr3_hbr2 voltage and pre-emphasis swing table to support
> HBR3 link rate
>
> Signed-off-by: Kuogee Hsieh
> ---
> drivers/gpu/drm/msm/dp/dp_panel.c | 4
> drivers/phy/qualcomm/phy-qcom-qmp.c | 24 ++--
This spans to
Manikandan
Suggested-by: Daniel Vetter
Fixes: b3d91800d9ac ("drm/msm: Fix race condition in msm driver with async
layer updates")
Signed-off-by: Stephen Boyd
---
drivers/gpu/drm/msm/msm_atomic.c | 7 +--
drivers/gpu/drm/msm/msm_kms.h| 8 ++--
2 files changed, 7 insertions(+), 8
Quoting Joe Perches (2021-02-06 21:06:54)
> On Sat, 2021-02-06 at 20:18 -0800, Stephen Boyd wrote:
> > A missing semicolon here causes my external display to stop working.
> > Indeed, missing the semicolon on the return statement leads to
> > dp_panel_update_tu_timings()
@lists.freedesktop.org
Cc: Lee Jones
Fixes: cc9014bf63a4 ("drm/msm/dp/dp_ctrl: Move 'tu' from the stack to the heap")
Signed-off-by: Stephen Boyd
---
drivers/gpu/drm/msm/dp/dp_ctrl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/
after irq_hpd
> handler")
> Signed-off-by: Kuogee Hsieh
> ---
Reviewed-by: Stephen Boyd
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
Quoting Xu Wang (2021-01-29 01:44:16)
> fix semicolon.cocci warnings:
> drivers/gpu/drm/msm/dp/dp_ctrl.c:1161:2-3: Unneeded semicolon
>
> Signed-off-by: Xu Wang
> ---
Reviewed-by: Stephen Boyd
___
Freedreno mailing
Quoting Rob Clark (2021-02-03 09:29:09)
> On Wed, Feb 3, 2021 at 2:10 AM Daniel Vetter wrote:
> >
> > On Tue, Feb 02, 2021 at 08:51:25AM -0800, Rob Clark wrote:
> > > On Tue, Feb 2, 2021 at 7:46 AM Daniel Vetter wrote:
> > > >
> > > > On Mon, Jan
Quoting Bernard Zhao (2021-02-02 04:32:03)
> remove unneeded variable: "rc".
>
> Signed-off-by: Bernard Zhao
> ---
Reviewed-by: Stephen Boyd
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedeskto
in this loop. Let's allocate a dynamic number of
lock_class_keys and assign them to each lock so that lockdep can figure
out an AA deadlock isn't possible here.
Fixes: b3d91800d9ac ("drm/msm: Fix race condition in msm driver with async
layer updates")
Cc: Krishna Manikandan
Signe
in this loop. Let's allocate a dynamic number of
lock_class_keys and assign them to each lock so that lockdep can figure
out an AA deadlock isn't possible here.
Fixes: b3d91800d9ac ("drm/msm: Fix race condition in msm driver with async
layer updates")
Cc: Krishna Manikandan
Signe
801 - 900 of 1045 matches
Mail list logo
