[Freedreno] [PATCH] drm/msm/kms: Make a lock_class_key for each crtc mutex

2021-01-25 Thread Stephen Boyd
in this loop. Let's allocate a dynamic number of lock_class_keys and assign them to each lock so that lockdep can figure out an AA deadlock isn't possible here. Fixes: b3d91800d9ac ("drm/msm: Fix race condition in msm driver with async layer updates") Cc: Krishna Manikandan Signe

Re: [Freedreno] [PATCH v2 0/2] fix missing unplug interrupt problem

2021-01-13 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-01-13 15:52:37) > On 2021-01-13 12:25, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2021-01-13 10:59:58) > >> Both AUX_SW_RESET and DP_SW_RESET clear pending HPD interrupts. > >> Therefore irq_hpd handler should not issues either au

Re: [Freedreno] [PATCH 1/2] drm/msm/dp: postpone irq_hpd event during connection pending state

2021-01-13 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-01-13 15:44:32) > On 2021-01-13 12:22, Stephen Boyd wrote: > > Quoting khs...@codeaurora.org (2021-01-13 09:44:24) > >> On 2021-01-11 11:55, Stephen Boyd wrote: > >> > Quoting Kuogee Hsieh (2021-01-07 12:30:24) > >>

Re: [Freedreno] [PATCH v2 0/2] fix missing unplug interrupt problem

2021-01-13 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-01-13 10:59:58) > Both AUX_SW_RESET and DP_SW_RESET clear pending HPD interrupts. > Therefore irq_hpd handler should not issues either aux or sw reset > to avoid following unplug interrupt be cleared accidentally. > > Kuogee Hsieh (2): > drm/msm/dp: return fail when

Re: [Freedreno] [PATCH 2/2] drm/msm/dp: unplug interrupt missed after irq_hpd handler

2021-01-13 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-01-13 09:48:25) > On 2021-01-11 11:54, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2021-01-07 12:30:25) > >> There is HPD unplug interrupts missed at scenario of an irq_hpd > >> followed by unplug interrupts with around 10 ms

Re: [Freedreno] [PATCH 1/2] drm/msm/dp: postpone irq_hpd event during connection pending state

2021-01-13 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-01-13 09:44:24) > On 2021-01-11 11:55, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2021-01-07 12:30:24) > >> irq_hpd event can only be executed at connected state. Therefore > >> irq_hpd event should be postponed if it happened at co

Re: [Freedreno] [PATCH 1/2] drm/msm/dp: postpone irq_hpd event during connection pending state

2021-01-13 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-01-13 09:44:24) > On 2021-01-11 11:55, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2021-01-07 12:30:24) > >> irq_hpd event can only be executed at connected state. Therefore > >> irq_hpd event should be postponed if it happened at co

Re: [Freedreno] [PATCH 1/2] drm/msm/dp: postpone irq_hpd event during connection pending state

2021-01-11 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-01-07 12:30:24) > irq_hpd event can only be executed at connected state. Therefore > irq_hpd event should be postponed if it happened at connection > pending state. This patch also make sure both link rate and lane Why does it happen at connection pending state? > are

Re: [Freedreno] [PATCH 2/2] drm/msm/dp: unplug interrupt missed after irq_hpd handler

2021-01-11 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-01-07 12:30:25) > There is HPD unplug interrupts missed at scenario of an irq_hpd > followed by unplug interrupts with around 10 ms in between. > Since both AUX_SW_RESET and DP_SW_RESET clear pending HPD interrupts, > irq_hpd handler should not issues either aux or sw

Re: [Freedreno] [PATCH v2] drm/msm/dp: fix connect/disconnect handled at irq_hpd

2020-11-17 Thread Stephen Boyd
in V2: > -- add dp_display_handle_port_ststus_changed() > -- fix kernel test robot complaint > > Reported-by: kernel test robot > Fixes: 26b8d66a399e ("drm/msm/dp: promote irq_hpd handle to handle link > training correctly") > Signed-off-by

Re: [Freedreno] [PATCH] drm/msm/dpu: Remove chatty vbif debug print

2020-11-17 Thread Stephen Boyd
Quoting abhin...@codeaurora.org (2020-11-17 12:34:56) > On 2020-11-17 09:26, Stephen Boyd wrote: > > I don't know what this debug print is for but it is super chatty, > > throwing 8 lines of debug prints in the logs every time we update a > > plane. It looks like it has no va

[Freedreno] [PATCH] drm/msm/dpu: Remove chatty vbif debug print

2020-11-17 Thread Stephen Boyd
I don't know what this debug print is for but it is super chatty, throwing 8 lines of debug prints in the logs every time we update a plane. It looks like it has no value. Let's nuke it so we can get better logs. Cc: Sean Paul Cc: Abhinav Kumar Signed-off-by: Stephen Boyd --- drivers/gpu/drm

Re: [Freedreno] [PATCH] drm/msm/dp: remove duplicate include statement

2020-11-11 Thread Stephen Boyd
Quoting Tian Tao (2020-11-10 23:57:56) > linux/rational.h is included more than once, Remove the one that isn't > necessary. > > Signed-off-by: Tian Tao > --- Reviewed-by: Stephen Boyd ___ Freedreno mailing list Freedreno@lists.freede

Re: [Freedreno] [PATCH 3/3] drm/msm/dp: promote irq_hpd handle to handle link training correctly

2020-11-04 Thread Stephen Boyd
Quoting Kuogee Hsieh (2020-11-03 12:49:02) > Some dongles require link training done at irq_hpd request instead > of plugin request. This patch promote irq_hpd handler to handle link > training and setup hpd_state correctly. > > Fixes: fdaf9a5e3c15 (drm/msm/dp: fixes wrong connection state

Re: [Freedreno] [PATCH] drm/msm/dp: do not notify audio subsystem if sink doesn't support audio

2020-11-02 Thread Stephen Boyd
Quoting abhin...@codeaurora.org (2020-11-02 14:43:33) > Hi Stephen > > Thanks for the review. > > On 2020-11-02 13:19, Stephen Boyd wrote: > > Quoting Abhinav Kumar (2020-10-29 13:55:09) > >> For sinks that do not support audio, there is no need to notify > >

Re: [Freedreno] [PATCH] drm/msm/dp: do not notify audio subsystem if sink doesn't support audio

2020-11-02 Thread Stephen Boyd
Quoting Abhinav Kumar (2020-10-29 13:55:09) > For sinks that do not support audio, there is no need to notify > audio subsystem of the connection event. > > This will make sure that audio routes only to the primary display > when connected to such sinks. > Does this need a Fixes tag? Or it's

Re: [Freedreno] [PATCH] drm/msm/dp: deinitialize mainlink if link training failedo

2020-11-02 Thread Stephen Boyd
Quoting Kuogee Hsieh (2020-10-30 16:22:53) > DP compo phy have to be enable to start link training. When > link training failed phy need to be disabled so that next > link trainng can be proceed smoothly at next plug in. This s/trainng/training/ > patch de initialize mainlink to disable phy if

Re: [Freedreno] [PATCH v2] drm/msm/dp: skip checking LINK_STATUS_UPDATED bit

2020-11-02 Thread Stephen Boyd
Quoting Kuogee Hsieh (2020-10-30 16:23:10) > Some dongle will not clear LINK_STATUS_UPDATED bit after > DPCD read which cause link training failed. This patch $ git grep 'this patch' -- Documentation/process/submitting-patches.rst > just read 6 bytes of DPCD link status from sink and return >

Re: [Freedreno] [PATCH] drm/msm/dp: promote irq_hpd handle to handle link trainign correctly

2020-11-02 Thread Stephen Boyd
Subject has a typo in "training". Quoting Kuogee Hsieh (2020-10-30 16:23:24) > Some dongles, such as Apple, required link training done at irq_hpd s/required/require/ > request instead of plugin request. This patch promote irq_hpd hanlder s/hanlder/handler/ > to handle link training and setup

Re: [Freedreno] [PATCH 3/4] drm/msm: fix -Woverride-init warning

2020-10-26 Thread Stephen Boyd
Fixes: af776a3e1c30 ("drm/msm/dpu: add SM8250 to hw catalog") > Signed-off-by: Arnd Bergmann > --- Reviewed-by: Stephen Boyd ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [PATCH] drm/msm/dp: skip checking LINK_STATUS_UPDATED bit

2020-10-20 Thread Stephen Boyd
Quoting Kuogee Hsieh (2020-10-20 09:59:59) > No need to check LINK_STATuS_UPDATED bit before LINK_STATUS_UPDATED? > return 6 bytes of link status during link training. Why? > This patch also fix phy compliance test link rate > conversion error. How? > > Signed-off-by: Kuogee Hsieh > ---

Re: [Freedreno] [PATCH v3] drm/msm/dp: fixes wrong connection state caused by failure of link train

2020-10-13 Thread Stephen Boyd
also replace ST_SUSPEND_PENDING with ST_DISPLAY_OFF. > > Changes in V2: > -- Add more information to commit message. > > Changes in V3: > -- change base > > Signed-off-by: Kuogee Hsieh > --- Any Fixes tag? Tested-by: Stephen Boyd _

Re: [Freedreno] [PATCH v4] drm/msm/dp: return correct connection status after suspend

2020-10-13 Thread Stephen Boyd
ses link training failed > > Signed-off-by: Kuogee Hsieh > --- Can we add some sort of Fixes tag? Maybe the beginning of this DP driver support? Tested-by: Stephen Boyd ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [PATCH v2] drm/msm/dp: add opp_table corner voting support base on dp_ink_clk rate

2020-10-06 Thread Stephen Boyd
Quoting Rajendra Nayak (2020-10-06 00:31:41) > > On 10/4/2020 3:56 AM, Kuogee Hsieh wrote: > > Set link rate by using OPP set rate api so that CX level will be set > > accordingly based on the link rate. > > > > Changes in v2: > > -- remove dev from dp_ctrl_put() parameters > > -- address review

Re: [Freedreno] [PATCH] drm/msm/dp: fixes wrong connection state caused by failure of link train

2020-10-05 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2020-10-05 11:02:10) > >> + dp_del_event(dp_display, EV_DISCONNECT_PENDING_TIMEOUT); > >> + > >> dp_display_disable(dp_display, 0); > >> > >> rc = dp_display_unprepare(dp); > >> if (rc) > >> DRM_ERROR("DP display

Re: [Freedreno] [PATCH] drm/msm/dp: fixes wrong connection state caused by failure of link train

2020-10-02 Thread Stephen Boyd
Quoting Kuogee Hsieh (2020-10-02 15:09:19) > Connection state is set incorrectly happen at either failure of link train > or cable plugged in while suspended. This patch fixes these problems. > This patch also replace ST_SUSPEND_PENDING with ST_DISPLAY_OFF. > > Signed-off-by: Kuogee Hsieh Any

Re: [Freedreno] [PATCH] drm/msm/dp: add voltage corners voting support base on dp link rate

2020-09-30 Thread Stephen Boyd
Quoting Kuogee Hsieh (2020-09-29 10:10:26) > Set link rate by using OPP set rate api so that CX level will be set > accordingly base on the link rate. s/base/based/ > > Signed-off-by: Kuogee Hsieh > --- > diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c > b/drivers/gpu/drm/msm/dp/dp_ctrl.c >

Re: [Freedreno] [PATCH v2] drm/msm/dp: return correct connection status after suspend

2020-09-28 Thread Stephen Boyd
Quoting Kuogee Hsieh (2020-09-26 13:34:54) > At dp_pm_resume, reinitialize both dp host controller and hpd block dp_pm_resume() > so that hpd connection can be detected at realtime by reading hpd state > status register. Also hpd plug interrupt can be generated accordingly. Can you describe

[Freedreno] [PATCH] drm/msm/dpu: Add newline to printks

2020-09-28 Thread Stephen Boyd
Printk messages need newlines. Add it here. Cc: Abhinav Kumar Cc: Jeykumar Sankaran Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Freedreno] [PATCH v2] drm/msm/dp: fix incorrect function prototype of dp_debug_get()

2020-09-26 Thread Stephen Boyd
2: > - add prototype for msm_dp_debugfs_init() > > Fixes: f913454aae8e ("drm/msm/dp: move debugfs node to > /sys/kernel/debug/dri/*/") > Reported-by: kernel test robot > Signed-off-by: Abhinav Kumar > --- Reviewed-by: Stephen Boyd _

Re: [Freedreno] [PATCH] drm/msm/dp: DisplayPort PHY compliance tests fixup

2020-09-26 Thread Stephen Boyd
est link status process > > Signed-off-by: Tanmay Shah > --- Fixes: 8ede2ecc3e5e ("drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets") Reviewed-by: Stephen Boyd ___ Freedreno mailing list Freedreno@lists.freedesktop.org htt

Re: [Freedreno] [PATCH] drm/msm/dp: fix incorrect function prototype of dp_debug_get()

2020-09-24 Thread Stephen Boyd
nel test robot > Signed-off-by: Abhinav Kumar > --- Reviewed-by: Stephen Boyd Will the compliance testing parts be moved out of debugfs at some point? Just curious what the plan is there. ___ Freedreno mailing list Freedreno@lists.freedesktop

[Freedreno] [PATCH] drm/msm/dp: Sleep properly in dp_hpd_handler kthread

2020-09-17 Thread Stephen Boyd
("drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets") Signed-off-by: Stephen Boyd --- Based on msm-next-dp of https://gitlab.freedesktop.org/drm/msm.git drivers/gpu/drm/msm/dp/dp_display.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/

Re: [Freedreno] [PATCH v5] drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets

2020-09-08 Thread Stephen Boyd
Quoting Kuogee Hsieh (2020-09-04 12:54:39) > add event thread to execute events serially from event queue. Also > timeout mode is supported which allow an event be deferred to be > executed at later time. Both link and phy compliant tests had been > done successfully. > > Changes in v2: > - Fix

[Freedreno] [PATCH 2/2] drm/msm: Drop debug print in _dpu_crtc_setup_lm_bounds()

2020-09-01 Thread Stephen Boyd
Paul Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c index 74

[Freedreno] [PATCH 1/2] drm/msm: Avoid div-by-zero in dpu_crtc_atomic_check()

2020-09-01 Thread Stephen Boyd
Cc: Jordan Crouse Cc: Sean Paul Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/driver

[Freedreno] [PATCH 0/2] A couple drm/msm fixes

2020-09-01 Thread Stephen Boyd
Two small fixes for an UBSAN warning and to make debugging a little easier. Stephen Boyd (2): drm/msm: Avoid div-by-zero in dpu_crtc_atomic_check() drm/msm: Drop debug print in _dpu_crtc_setup_lm_bounds() drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 10 +- 1 file changed, 5 insertions

Re: [Freedreno] [PATCH] drm/msm: enable vblank during atomic commits

2020-08-21 Thread Stephen Boyd
ned-off-by: Rob Clark > --- Tested-by: Stephen Boyd ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [PATCH v3] drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets

2020-08-18 Thread Stephen Boyd
Quoting Kuogee Hsieh (2020-08-18 14:15:46) > add event thread to execute events serially from event queue. Also > timeout mode is supported which allow an event be deferred to be > executed at later time. Both link and phy compliant tests had been > done successfully. > > Changes in v2: > - Fix

Re: [Freedreno] [PATCH v3] arm64: dts: qcom: sc7180: Add DisplayPort HPD pin dt node

2020-08-18 Thread Stephen Boyd
Quoting Tanmay Shah (2020-08-17 20:36:57) > This node defines alternate DP HPD functionality of GPIO. > > Signed-off-by: Tanmay Shah > --- Reviewed-by: Stephen Boyd ___ Freedreno mailing list Freedreno@lists.freedeskt

Re: [Freedreno] [PATCH v6] arm64: dts: qcom: sc7180: Add Display Port dt node

2020-08-17 Thread Stephen Boyd
Quoting Tanmay Shah (2020-08-17 15:53:00) > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi > b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 31b9217bb5bf..bf2f2bb1aa79 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -2440,6 +2447,71 @@

Re: [Freedreno] [PATCH v2] arm64: dts: qcom: sc7180: Add DisplayPort HPD pin dt node

2020-08-17 Thread Stephen Boyd
Quoting Tanmay Shah (2020-08-17 15:59:12) > This node defines alternate DP HPD functionality of GPIO. > > Signed-off-by: Tanmay Shah > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi >

Re: [Freedreno] [PATCH v1] arm64: dts: qcom: sc7180: Add DisplayPort HPD pin dt node

2020-08-17 Thread Stephen Boyd
Quoting Tanmay Shah (2020-08-17 15:45:27) > This node defines alternate DP HPD functionality of GPIO. > > Signed-off-by: Tanmay Shah > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi >

Re: [Freedreno] stable-rc 4.14: arm64: Internal error: Oops: clk_reparent __clk_set_parent_before on db410c

2020-08-12 Thread Stephen Boyd
Quoting Stephen Boyd (2020-07-23 03:26:02) > Quoting Naresh Kamboju (2020-07-23 03:10:37) > > On Thu, 23 Jul 2020 at 13:36, Stephen Boyd wrote: > > > > > > It sounds like maybe you need this patch? > > > > > > bdcf1dc25324 ("clk: Evict unregiste

Re: [Freedreno] [PATCH v5] arm64: dts: qcom: sc7180: Add Display Port dt node

2020-08-11 Thread Stephen Boyd
Quoting Tanmay Shah (2020-08-10 19:15:53) > @@ -2440,6 +2447,71 @@ dsi_phy: dsi-phy@ae94400 { > > status = "disabled"; > }; > + > + msm_dp: displayport-controller@ae9 { > + status =

Re: [Freedreno] [PATCH v9 3/5] drm/msm/dp: add support for DP PLL driver

2020-08-07 Thread Stephen Boyd
Quoting Rob Clark (2020-08-07 08:51:48) > On Fri, Aug 7, 2020 at 8:27 AM Randy Dunlap wrote: > > > > On 8/7/20 12:17 AM, Tanmay Shah wrote: > > > diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig > > > index ea3c4d094d09..cc1392b29022 100644 > > > ---

Re: [Freedreno] [PATCH 8/9] clk: qcom: gcc-sdm660: Fix up gcc_mss_mnoc_bimc_axi_clk

2020-07-27 Thread Stephen Boyd
Quoting Konrad Dybcio (2020-07-26 04:12:05) > Add missing halt_check, hwcg_reg and hwcg_bit properties. > These were likely omitted when porting the driver upstream. > > Signed-off-by: Konrad Dybcio > --- Applied to clk-next ___ Freedreno mailing list

Re: [Freedreno] [PATCH 1/9] clk: qcom: gcc-sdm660: Add missing modem reset

2020-07-27 Thread Stephen Boyd
Quoting Konrad Dybcio (2020-07-26 04:11:58) > This will be required in order to support the > modem upstream. > > Signed-off-by: Konrad Dybcio > --- Applied to clk-next ___ Freedreno mailing list Freedreno@lists.freedesktop.org

Re: [Freedreno] [PATCH 1/9] clk: qcom: gcc-sdm660: Add missing modem reset

2020-07-27 Thread Stephen Boyd
Quoting Konrad Dybcio (2020-07-26 04:11:58) > This will be required in order to support the > modem upstream. > > Signed-off-by: Konrad Dybcio > --- Should have a fixes tag too. > drivers/clk/qcom/gcc-sdm660.c | 1 + > include/dt-bindings/clock/qcom,gcc-sdm660.h | 1 + > 2 files

Re: [Freedreno] [PATCH 8/9] clk: qcom: gcc-sdm660: Fix up gcc_mss_mnoc_bimc_axi_clk

2020-07-27 Thread Stephen Boyd
Quoting Konrad Dybcio (2020-07-26 04:12:05) > Add missing halt_check, hwcg_reg and hwcg_bit properties. > These were likely omitted when porting the driver upstream. > > Signed-off-by: Konrad Dybcio > --- Fixes tag? ___ Freedreno mailing list

Re: [Freedreno] stable-rc 4.14: arm64: Internal error: Oops: clk_reparent __clk_set_parent_before on db410c

2020-07-23 Thread Stephen Boyd
Quoting Naresh Kamboju (2020-07-23 03:10:37) > On Thu, 23 Jul 2020 at 13:36, Stephen Boyd wrote: > > > > Quoting Arnd Bergmann (2020-07-21 02:51:32) > > > __clk_set_parent_before(orphan, parent); > > > > > > None o

Re: [Freedreno] stable-rc 4.14: arm64: Internal error: Oops: clk_reparent __clk_set_parent_before on db410c

2020-07-23 Thread Stephen Boyd
Quoting Arnd Bergmann (2020-07-21 02:51:32) > __clk_set_parent_before(orphan, parent); > > None of the above have changed in stable kernels. > > > [5.633668] pll_28nm_register+0xa4/0x340 [msm] > > [5.637492] msm_dsi_pll_28nm_init+0xc8/0x1d8 [msm] > > [

Re: [Freedreno] [PATCH] drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets

2020-07-20 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2020-07-20 15:48:13) > On 2020-07-20 13:18, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2020-07-07 11:41:25) > >> drivers/gpu/drm/msm/dp/dp_power.c | 32 +- > >> drivers/gpu/drm/msm/dp/dp_power.h | 1 + > >&

Re: [Freedreno] [v3] arm64: dts: sc7180: add nodes for idp display

2020-07-20 Thread Stephen Boyd
Quoting harig...@codeaurora.org (2020-06-29 06:50:09) > On 2020-06-25 06:37, Stephen Boyd wrote: > > Quoting Harigovindan P (2020-02-17 00:58:42) > >> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > >> b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > >> ind

Re: [Freedreno] [PATCH v3] arm64: dts: qcom: sc7180: Add Display Port dt node

2020-07-20 Thread Stephen Boyd
Quoting Tanmay Shah (2020-06-30 12:51:51) > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi > b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 31b9217bb5bf..271d55db62ab 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -2440,6 +2447,44 @@

Re: [Freedreno] [PATCH] drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets

2020-07-20 Thread Stephen Boyd
Quoting Kuogee Hsieh (2020-07-07 11:41:25) > add event thread to execute events serially from event queue. Also > timeout mode is supported which allow an event be deferred to be > executed at later time. Both link and phy compliant tests had been > done successfully. > > This change depends-on

Re: [Freedreno] [v3] arm64: dts: sc7180: add nodes for idp display

2020-06-24 Thread Stephen Boyd
Quoting Harigovindan P (2020-02-17 00:58:42) > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > index 388f50ad4fde..349db8fe78a5 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > @@ -232,6

Re: [Freedreno] [PATCH v2] arm64: dts: qcom: sc7180: Add Display Port dt node

2020-06-18 Thread Stephen Boyd
Quoting Tanmay Shah (2020-06-18 16:21:13) > Enable DP driver for sc7180. Add DP device node on sc7180? This isn't a driver. > > This change depends-on following series: > https://patchwork.freedesktop.org/series/78583/ > and https://patchwork.freedesktop.org/patch/351990/ > > Changes in v2: >

Re: [Freedreno] [PATCH v6 1/5] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon

2020-06-17 Thread Stephen Boyd
Quoting Rob Herring (2020-06-17 08:38:20) > On Tue, Jun 16, 2020 at 5:15 AM Stephen Boyd wrote: > > > > Quoting Tanmay Shah (2020-06-11 18:50:26) > > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml > > > b/Documentation/devicetree/bi

Re: [Freedreno] [PATCH v6 1/5] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon

2020-06-16 Thread Stephen Boyd
Quoting Tanmay Shah (2020-06-11 18:50:26) > diff --git a/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml > b/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml > new file mode 100644 > index ..5fdb9153df00 > --- /dev/null > +++

Re: [Freedreno] [PATCH v6 0/5] Add support for DisplayPort driver on

2020-06-16 Thread Stephen Boyd
Quoting tan...@codeaurora.org (2020-06-15 16:36:52) > On 2020-06-15 16:04, Jeffrey Hugo wrote: > >> > > >> > I've never seen a block diagram for a driver before... > >> > > >> It is here for v5. https://patchwork.freedesktop.org/series/74312/ > > > > I think Stephen is nitpicking your wording,

Re: [Freedreno] [PATCH v6 1/5] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon

2020-06-16 Thread Stephen Boyd
Quoting tan...@codeaurora.org (2020-06-11 13:07:09) > On 2020-06-09 19:15, Stephen Boyd wrote: > > Quoting Tanmay Shah (2020-06-08 20:38:18) > >> diff --git > >> a/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml > >> b/Documentation/devicetree

Re: [Freedreno] [PATCH v6 0/5] Add support for DisplayPort driver on

2020-06-12 Thread Stephen Boyd
Quoting Tanmay Shah (2020-06-11 18:50:25) > These patches add support for Display-Port driver on SnapDragon > hardware. It adds > DP driver and DP PLL driver files along with the needed device-tree > bindings. > > The block diagram of DP driver is shown below: > > >

Re: [Freedreno] [v3] drm/bridge: ti-sn65dsi86: ensure bridge suspend happens during PM sleep

2020-06-11 Thread Stephen Boyd
gt; and it kept the bridge regulators and gpios ON which resulted > in platform not entering into XO shutdown. > > Add changes to force suspend on the runtime device during pm sleep. > > Signed-off-by: Harigovindan P > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v6 2/5] drm: add constant N value in helper file

2020-06-09 Thread Stephen Boyd
6: Change commit message > > Signed-off-by: Chandan Uddaraju > Signed-off-by: Vara Reddy > Signed-off-by: Tanmay Shah > --- Reviewed-by: Stephen Boyd Can you resend this series as an actual patch series? None of the patches have the proper In-Reply-To he

Re: [Freedreno] [PATCH v6 1/5] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon

2020-06-09 Thread Stephen Boyd
Quoting Tanmay Shah (2020-06-08 20:38:18) > diff --git a/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml > b/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml > new file mode 100644 > index 000..5fdb915 > --- /dev/null > +++

Re: [Freedreno] [PATCH v6 4/5] drm/msm/dp: add support for DP PLL driver

2020-06-09 Thread Stephen Boyd
Quoting Tanmay Shah (2020-06-08 20:46:23) > diff --git a/drivers/gpu/drm/msm/dp/dp_catalog.c > b/drivers/gpu/drm/msm/dp/dp_catalog.c > index d02f4eb..2b982f0 100644 > --- a/drivers/gpu/drm/msm/dp/dp_catalog.c > +++ b/drivers/gpu/drm/msm/dp/dp_catalog.c > @@ -5,6 +5,7 @@ > > #define pr_fmt(fmt)

Re: [Freedreno] [v1] drm/msm: add shutdown support for display platform_driver

2020-05-28 Thread Stephen Boyd
Quoting Krishna Manikandan (2020-05-28 01:38:23) > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index e4b750b..7a8953f 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -1322,6 +1322,18 @@ static int msm_pdev_remove(struct

Re: [Freedreno] [v1] drm/bridge: ensure bridge suspend happens during PM sleep

2020-05-12 Thread Stephen Boyd
igovindan P > --- Besides the subject: Reviewed-by: Stephen Boyd ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [DPU PATCH v5 4/5] drm/msm/dp: add support for DP PLL driver

2020-04-23 Thread Stephen Boyd
Quoting Tanmay Shah (2020-03-31 17:30:30) > diff --git a/drivers/gpu/drm/msm/dp/pll/dp_pll_10nm.c > b/drivers/gpu/drm/msm/dp/pll/dp_pll_10nm.c > new file mode 100644 > index 000..aa845d0 > --- /dev/null > +++ b/drivers/gpu/drm/msm/dp/pll/dp_pll_10nm.c > @@ -0,0 +1,401 @@ > +//

Re: [Freedreno] [DPU PATCH v5 2/5] drm: add constant N value in helper file

2020-04-23 Thread Stephen Boyd
Quoting Tanmay Shah (2020-03-31 17:30:28) > From: Chandan Uddaraju > > The constant N value (0x8000) is used by multiple DP There's one driver using it, not multiple. > drivers. Define this value in header file and use this > in the existing i915 display driver. > > Signed-off-by: Chandan

Re: [Freedreno] [DPU PATCH v5 1/5] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon

2020-04-23 Thread Stephen Boyd
Quoting Tanmay Shah (2020-03-31 17:30:27) > diff --git a/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml > b/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml > new file mode 100644 > index 000..761a01d > --- /dev/null > +++

Re: [Freedreno] [PATCH v2] of_device: removed #include that caused a recursion in included headers

2020-04-19 Thread Stephen Boyd
Quoting Hadar Gat (2020-04-16 02:49:03) > Both of_platform.h and of_device.h were included each other. > In of_device.h, removed unneeded #include to of_platform.h > and added include to of_platform.h in the files that needs it. > > Signed-off-by: Hadar Gat > --- Acked-by: S

Re: [Freedreno] [DPU PATCH v4 4/5] drm/msm/dp: add support for DP PLL driver

2020-03-19 Thread Stephen Boyd
Quoting Vara Reddy (2020-03-04 16:10:27) > From: Chandan Uddaraju > > Add the needed DP PLL specific files to support > display port interface on msm targets. > > The DP driver calls the DP PLL driver registration. > The DP driver sets the link and pixel clock sources. > > Changes in v2: > --

Re: [Freedreno] [v2] arm64: dts: sc7180: modify assigned clocks for sc7180 target

2020-03-19 Thread Stephen Boyd
Subject could be "sc7180: update DPU assigned clocks" Quoting Krishna Manikandan (2020-03-16 04:02:42) > Add DISP_CC_MDSS_ROT_CLK and DISP_CC_MDSS_AHB_CLK > in the assigned clocks list for sc7180 target. Why? > > Signed-off-by: Krishna Manikandan Does this need a Fixes: tag? > --- >

Re: [Freedreno] [DPU PATCH v4 1/5] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon

2020-03-18 Thread Stephen Boyd
Quoting Vara Reddy (2020-03-04 16:10:24) > From: Chandan Uddaraju > > Add bindings for Snapdragon DisplayPort and > display-port PLL driver. > > Changes in V2: > Provide details about sel-gpio > > Changes in V4: > Provide details about max dp lanes > Change the commit text > > Signed-off-by:

Re: [Freedreno] [PATCH 2/4] drm/msm/dpu: Refactor rm iterator

2020-02-25 Thread Stephen Boyd
Quoting Drew Davenport (2020-02-19 09:42:25) > Make iterator implementation private, and add function to > query resources assigned to an encoder. > > Signed-off-by: Drew Davenport > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c >

Re: [Freedreno] [PATCH 1/4] drm/msm/dpu: Remove unused function arguments

2020-02-25 Thread Stephen Boyd
Quoting Drew Davenport (2020-02-19 09:42:24) > Several functions arguments in the resource manager are unused, so > remove them. > > Signed-off-by: Drew Davenport > --- Reviewed-by: Stephen Boyd > > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 37 ++

Re: [Freedreno] [v1] arm64: dts: sc7180: add display dt nodes

2020-01-21 Thread Stephen Boyd
Quoting Harigovindan P (2020-01-21 07:52:08) > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi > b/arch/arm64/boot/dts/qcom/sc7180.dtsi > old mode 100644 > new mode 100755 > index 8011c5f..963f5c1 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@

[Freedreno] [PATCH] drm/msm/dpu: Mark various data tables as const

2019-11-19 Thread Stephen Boyd
These structures look like a bunch of data tables that aren't going to change after boot. Let's move them to the const RO section of memory so that they can't be modified at runtime on modern machines. Signed-off-by: Stephen Boyd --- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 30

Re: [Freedreno] [PATCH v1] msm:disp:dpu1: add support for display for SC7180 target

2019-11-19 Thread Stephen Boyd
Quoting Kalyan Thota (2019-11-18 02:47:43) > Add display hw catalog changes for SC7180 target. > > Changes in v1: > > 1) Configure register offsets and capabilities for the > display hw blocks. > > This patch has dependency on the below series > > https://patchwork.kernel.org/patch/11243111/ >

Re: [Freedreno] [PATCH] drm/msm/dpu: ignore NULL clocks

2019-11-16 Thread Stephen Boyd
Quoting Rob Clark (2019-11-14 10:51:50) > From: Rob Clark > > This isn't an error. Also the clk APIs handle the NULL case, so we can > just delete the check. > > Signed-off-by: Rob Clark > Tested-by: Matthias Kaehlcke > ---

Re: [Freedreno] [v2] msm: disp: dpu1: add support to access hw irqs regs depending on revision

2019-11-14 Thread Stephen Boyd
Quoting Shubhashree Dhar (2019-11-13 21:56:16) > Current code assumes that all the irqs registers offsets can be > accessed in all the hw revisions; this is not the case for some > targets that should not access some of the irq registers. What happens if we read the irq registers that we "should

Re: [Freedreno] [PATCH v1 0/2] Add suppport for rm69299 Visionox panel driver and add DSI config to support DSI version

2019-11-14 Thread Stephen Boyd
Quoting Harigovindan P (2019-11-14 02:16:26) > Current patchset adds support for rm69299 visionox panel driver used in MSM > reference platforms > and also adds DSI config that supports the respective DSI version. > > The visionox panel driver supports a resolution of 1080x2248 with 4 lanes and

Re: [Freedreno] [PATCH v1 1/2] drm/panel: add support for rm69299 visionox panel driver

2019-11-14 Thread Stephen Boyd
Quoting Harigovindan P (2019-11-14 02:16:27) > diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c > b/drivers/gpu/drm/panel/panel-visionox-rm69299.c > new file mode 100644 > index 000..faf6d05 > --- /dev/null > +++ b/drivers/gpu/drm/panel/panel-visionox-rm69299.c > @@ -0,0 +1,478 @@

Re: [Freedreno] [PATCH RFC v2 4/5] ARM: dts: qcom: msm8974: add HDMI nodes

2019-10-09 Thread Stephen Boyd
Quoting Brian Masney (2019-10-08 23:05:20) > On Tue, Oct 08, 2019 at 07:21:30PM -0700, Stephen Boyd wrote: > > Quoting Brian Masney (2019-10-06 18:45:08) > > > diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi > > > b/arch/arm/boot/dts/qcom-msm8974.dtsi > > &

Re: [Freedreno] [PATCH RFC v2 5/5] ARM: dts: qcom: msm8974-hammerhead: add support for external display

2019-10-08 Thread Stephen Boyd
Quoting Brian Masney (2019-10-06 18:45:09) > diff --git a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts > b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts > index b607c9ff9e12..380a805cd1f0 100644 > --- a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts > +++

Re: [Freedreno] [PATCH RFC v2 4/5] ARM: dts: qcom: msm8974: add HDMI nodes

2019-10-08 Thread Stephen Boyd
Quoting Brian Masney (2019-10-06 18:45:08) > diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi > b/arch/arm/boot/dts/qcom-msm8974.dtsi > index 7fc23e422cc5..af02eace14e2 100644 > --- a/arch/arm/boot/dts/qcom-msm8974.dtsi > +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi > @@ -1335,6 +1342,77 @@ >

Re: [Freedreno] [PATCH v2 1/3] dt-bindings: power: Convert Generic Power Domain bindings to json-schema

2019-10-03 Thread Stephen Boyd
Quoting Krzysztof Kozlowski (2019-10-02 09:06:30) > Convert Generic Power Domain bindings to DT schema format using > json-schema. The consumer bindings are split to separate file. > > Signed-off-by: Krzysztof Kozlowski > > --- Acke

Re: [PATCH 2/7] dt-bindings: arm-smmu: Add Adreno GPU variant

2019-09-17 Thread Stephen Boyd
Quoting Jordan Crouse (2019-08-20 12:06:27) > Add a compatible string to identify SMMUs that are attached > to Adreno GPU devices that wish to support split pagetables. > > Signed-off-by: Jordan Crouse > --- > > Documentation/devicetree/bindings/iommu/arm,smmu.txt | 7 +++ > 1 file

Re: [Freedreno] [PATCH v2] drivers: qcom: Add BCM vote macro to header

2019-08-19 Thread Stephen Boyd
Quoting Bjorn Andersson (2019-08-19 09:52:55) > On Wed 07 Aug 16:42 PDT 2019, Stephen Boyd wrote: > > > Quoting Jordan Crouse (2019-08-05 13:33:46) > > > The macro to generate a Bus Controller Manager (BCM) TCS command is used > > > by the interconnect driver

Re: [Freedreno] [PATCH v2] drivers: qcom: Add BCM vote macro to header

2019-08-13 Thread Stephen Boyd
Quoting Jordan Crouse (2019-08-13 11:47:17) > On Wed, Aug 07, 2019 at 04:42:31PM -0700, Stephen Boyd wrote: > > Quoting Jordan Crouse (2019-08-05 13:33:46) > > > The macro to generate a Bus Controller Manager (BCM) TCS command is used > > > by the interconnect driver bu

Re: [PATCH v2] drivers: qcom: Add BCM vote macro to header

2019-08-07 Thread Stephen Boyd
pecific file and into the header. > > Signed-off-by: Jordan Crouse > --- Acked-by: Stephen Boyd Unless this is supposed to be applied by me? BTW, I wonder why we need an rpm clk driver much at all nowadays, except maybe for the XO clk state. The big user, from what I can tell, is th

Re: [Freedreno] [PATCH] drm/msm: Use generic bulk clock function

2019-07-25 Thread Stephen Boyd
Quoting Jordan Crouse (2019-07-25 09:53:55) > Remove the homebrewed bulk clock get function and replace it with > devm_clk_bulk_get_all(). > > Signed-off-by: Jordan Crouse > --- Reviewed-by: Stephen Boyd ___ Freedreno mailing

Re: [Freedreno] [PATCH] drm/msm: stop abusing dma_map/unmap for cache

2019-07-18 Thread Stephen Boyd
1 : f000 x0 : >Call trace: > __iommu_dma_unmap+0xb8/0xc0 > iommu_dma_unmap_sg+0x98/0xb8 > put_pages+0x5c/0xf0 [msm] > msm_gem_free_work+0x10c/0x150 [msm] > process_one_work+0x1e0/0x330 > worker_thread+0x40/0x438 >

Re: [Freedreno] [PATCH 1/2] drm/msm/dpu: Use provided drm_minor to initialize debugfs

2019-05-24 Thread Stephen Boyd
Quoting Sean Paul (2019-05-24 10:32:18) > From: Sean Paul > > Instead of reaching into dev->primary for debugfs_root, use the minor > passed into debugfs_init. > > This avoids creating the debug directory under /sys/kernel/debug/ and > instead creates the directory under the correct node in >

Re: [Freedreno] [PATCH v6 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes

2019-01-04 Thread Stephen Boyd
Quoting Rajendra Nayak (2019-01-03 00:45:53) > > On 12/29/2018 6:59 AM, Stephen Boyd wrote: > >> So I am guessing the conclusion is to use a fallback "operating-points-v2" > >> compatible*only* when we do have opp-hz along with qcom,level (as in the > >

[Freedreno] [PATCH] drm/msm/dpu: Convert to a chained irq chip

2019-01-03 Thread Stephen Boyd
an Crouse Cc: Jayant Shekhar Cc: Rajesh Yadav Cc: Jeykumar Sankaran Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 36 ++-- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c b/drivers/gpu/drm/

Re: [Freedreno] [PATCH v6 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-12-28 Thread Stephen Boyd
Quoting Rajendra Nayak (2018-12-20 20:52:34) > > On 12/21/2018 2:59 AM, Stephen Boyd wrote: > > Quoting Rob Herring (2018-12-19 15:47:25) > >> On Wed, Dec 19, 2018 at 4:40 PM Doug Anderson > >> wrote: > >>> On Wed, Dec 19, 2018 at 12:40 PM Doug And

Re: [Freedreno] [PATCH v5 5/8] drm/msm/dsi: 10nm PHY: Get ref clock from the DT

2018-12-20 Thread Stephen Boyd
wed-by: Douglas Anderson > --- Reviewed-by: Stephen Boyd ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

<    5   6   7   8   9   10   11   >