Re: [Freedreno] [v8 4/6] drm/panel-simple: Update validation warnings for eDP panel description

2021-06-28 Thread rajeevny
Hi Laurent, On 27-06-2021 23:48, Laurent Pinchart wrote: Hi Rajeev, On Sat, Jun 26, 2021 at 10:21:06PM +0530, Rajeev Nandan wrote: Do not give a warning for the eDP panels if the "bus_format" is not specified, since most eDP panels can support more than one bus formats and this can be

Re: [Freedreno] [v7 1/5] drm/panel: add basic DP AUX backlight support

2021-06-23 Thread rajeevny
Hi, On 23-06-2021 00:03, Doug Anderson wrote: Hi, On Mon, Jun 21, 2021 at 11:38 AM Sam Ravnborg wrote: > > I cannot see why you need the extra check on ->enabled? > > Would it be sufficient to check backlight_is_blank() only? > > This extra check on bl->enabled flag is added to avoid

Re: [Freedreno] [v7 1/5] drm/panel: add basic DP AUX backlight support

2021-06-21 Thread rajeevny
Hi Sam, On 20-06-2021 15:01, Sam Ravnborg wrote: Hi Rajeev On Sat, Jun 19, 2021 at 04:10:26PM +0530, Rajeev Nandan wrote: Some panels support backlight control over DP AUX channel using VESA's standard backlight control interface. Using new DRM eDP backlight helpers, add support to create and

Re: [Freedreno] [v1 1/3] dt-bindings: msm/dsi: Add yaml schema for 7nm DSI PHY

2021-06-18 Thread rajeevny
On 17-06-2021 20:37, Jonathan Marek wrote: On 6/16/21 1:50 AM, rajee...@codeaurora.org wrote: On 03-06-2021 01:32, rajee...@codeaurora.org wrote: On 02-06-2021 02:28, Rob Herring wrote: On Mon, May 31, 2021 at 07:03:53PM +0530, Rajeev Nandan wrote: + +properties: +  compatible: +   

Re: [Freedreno] [v1 1/3] dt-bindings: msm/dsi: Add yaml schema for 7nm DSI PHY

2021-06-15 Thread rajeevny
On 03-06-2021 01:32, rajee...@codeaurora.org wrote: On 02-06-2021 02:28, Rob Herring wrote: On Mon, May 31, 2021 at 07:03:53PM +0530, Rajeev Nandan wrote: + +properties: + compatible: +oneOf: + - const: qcom,dsi-phy-7nm When would one use this? This is for SM8250. + -

Re: [Freedreno] [v5 1/5] drm/panel: add basic DP AUX backlight support

2021-06-03 Thread rajeevny
On 03-06-2021 05:35, Doug Anderson wrote: Hi, On Sun, May 30, 2021 at 8:57 AM Rajeev Nandan wrote: Other than the two nits (ordering of memory allocation and word wrapping in a comment), this looks good to me. Feel free to add my Reviewed-by tag when you fix the nits. NOTE: Even though

Re: [Freedreno] [v1 1/3] dt-bindings: msm/dsi: Add yaml schema for 7nm DSI PHY

2021-06-02 Thread rajeevny
On 02-06-2021 02:28, Rob Herring wrote: On Mon, May 31, 2021 at 07:03:53PM +0530, Rajeev Nandan wrote: + +properties: + compatible: +oneOf: + - const: qcom,dsi-phy-7nm When would one use this? This is for SM8250. + - const: qcom,dsi-phy-7nm-7280 + - const:

Re: [Freedreno] [v4 1/4] drm/panel-simple: Add basic DPCD backlight support

2021-06-01 Thread rajeevny
On 02-06-2021 03:50, Lyude Paul wrote: oh-looks like my patches just got reviewed, so hopefully I should get a chance to get a look at this in the next day or two :) Hi Lyude, That's great! I have updated v5 [1] of this series addressing Doug's review comments on v4 [2].  Please review

Re: [Freedreno] [v1 2/3] drm/msm/dsi: Add PHY configuration for SC7280

2021-06-01 Thread rajeevny
On 31-05-2021 23:27, Dmitry Baryshkov wrote: On 31/05/2021 16:33, Rajeev Nandan wrote: + .min_pll_rate = 6UL, + .max_pll_rate = (50ULL < ULONG_MAX) ? 50ULL : ULONG_MAX, Could you please follow the patch by Arnd here?

Re: [Freedreno] [v4 1/4] drm/panel-simple: Add basic DPCD backlight support

2021-05-27 Thread rajeevny
Hi, On 25-05-2021 22:48, Doug Anderson wrote: Hi, On Tue, May 25, 2021 at 12:31 AM Rajeev Nandan wrote: @@ -171,6 +172,19 @@ struct panel_desc { /** @connector_type: LVDS, eDP, DSI, DPI, etc. */ int connector_type; + + /** +* @uses_dpcd_backlight: Panel

Re: [Freedreno] [v3 1/2] dt-bindings: backlight: add DisplayPort aux backlight

2021-05-25 Thread rajeevny
Hi, On 18-05-2021 01:51, Doug Anderson wrote: Hi, On Tue, May 11, 2021 at 4:17 PM Doug Anderson wrote: Hi, On Tue, May 11, 2021 at 11:12 AM wrote: > > On 01-05-2021 03:08, Doug Anderson wrote: > > Hi, > > > > On Fri, Apr 30, 2021 at 8:10 AM wrote: > >> > >> On 30-04-2021 02:33, Doug

Re: [Freedreno] [v3 1/2] dt-bindings: backlight: add DisplayPort aux backlight

2021-05-11 Thread rajeevny
On 01-05-2021 03:08, Doug Anderson wrote: Hi, On Fri, Apr 30, 2021 at 8:10 AM wrote: On 30-04-2021 02:33, Doug Anderson wrote: > Hi, > > On Thu, Apr 29, 2021 at 11:04 AM Rob Herring wrote: >> >> On Mon, Apr 26, 2021 at 11:29:15AM +0530, Rajeev Nandan wrote: >> > Add bindings for DisplayPort

Re: [Freedreno] [v3 1/2] dt-bindings: backlight: add DisplayPort aux backlight

2021-04-30 Thread rajeevny
On 30-04-2021 02:33, Doug Anderson wrote: Hi, On Thu, Apr 29, 2021 at 11:04 AM Rob Herring wrote: On Mon, Apr 26, 2021 at 11:29:15AM +0530, Rajeev Nandan wrote: > Add bindings for DisplayPort aux backlight driver. > > Changes in v2: > - New > > Signed-off-by: Rajeev Nandan > --- >

Re: [Freedreno] [v3 2/2] backlight: Add DisplayPort aux backlight driver

2021-04-26 Thread rajeevny
On 26-04-2021 15:19, Jani Nikula wrote: On Mon, 26 Apr 2021, Rajeev Nandan wrote: Add backlight driver for the panels supporting backlight control using DPCD registers on the DisplayPort aux channel. No, please don't do this. I wrote you last week in reply to v1 why I thought merging this