Re: [Freedreno] [PATCH] drm/msm/adreno: Remove VLA usage

2018-08-03 Thread Rob Clark
On Thu, Aug 2, 2018 at 7:24 PM, Kees Cook wrote: > On Fri, Jun 29, 2018 at 2:20 PM, Jordan Crouse wrote: >> On Fri, Jun 29, 2018 at 11:48:18AM -0700, Kees Cook wrote: >>> In the quest to remove all stack VLA usage from the kernel[1], this >>> switches to using a kasprintf()ed buffer. Return paths

Re: [Freedreno] [PATCH] drm/msm/adreno: Remove VLA usage

2018-08-02 Thread Kees Cook
On Fri, Jun 29, 2018 at 2:20 PM, Jordan Crouse wrote: > On Fri, Jun 29, 2018 at 11:48:18AM -0700, Kees Cook wrote: >> In the quest to remove all stack VLA usage from the kernel[1], this >> switches to using a kasprintf()ed buffer. Return paths are updated >> to free the allocation. >> >> [1] >> h

Re: [Freedreno] [PATCH] drm/msm/adreno: Remove VLA usage

2018-07-02 Thread SF Markus Elfring
> @@ -91,12 +93,13 @@ static int zap_shader_load_mdt(struct msm_gpu *gpu, > const char *fwname) > ret = qcom_mdt_load(dev, fw, fwname, GPU_PAS_ID, > mem_region, mem_phys, mem_size, NULL); > } else { > - char newname[strlen("qcom/") + s

Re: [Freedreno] [PATCH] drm/msm/adreno: Remove VLA usage

2018-06-29 Thread Jordan Crouse
On Fri, Jun 29, 2018 at 11:48:18AM -0700, Kees Cook wrote: > In the quest to remove all stack VLA usage from the kernel[1], this > switches to using a kasprintf()ed buffer. Return paths are updated > to free the allocation. > > [1] > https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=q

Re: [Freedreno] [PATCH] drm/msm/adreno: Remove VLA usage

2018-06-29 Thread Jordan Crouse
On Fri, Jun 29, 2018 at 10:47:31PM +0200, Arnd Bergmann wrote: > On Fri, Jun 29, 2018 at 8:48 PM, Kees Cook wrote: > > In the quest to remove all stack VLA usage from the kernel[1], this > > switches to using a kasprintf()ed buffer. Return paths are updated > > to free the allocation. > > > > [1]

Re: [Freedreno] [PATCH] drm/msm/adreno: Remove VLA usage

2018-06-29 Thread Arnd Bergmann
On Fri, Jun 29, 2018 at 8:48 PM, Kees Cook wrote: > In the quest to remove all stack VLA usage from the kernel[1], this > switches to using a kasprintf()ed buffer. Return paths are updated > to free the allocation. > > [1] > https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qpxydaacu1

[Freedreno] [PATCH] drm/msm/adreno: Remove VLA usage

2018-06-29 Thread Kees Cook
In the quest to remove all stack VLA usage from the kernel[1], this switches to using a kasprintf()ed buffer. Return paths are updated to free the allocation. [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qpxydaacu1rq...@mail.gmail.com Signed-off-by: Kees Cook --- drivers/g