Re: [Freedreno] [PATCH] drm/msm/mdp5: Don't leak some plane state

2023-08-04 Thread Dmitry Baryshkov
On Thu, 03 Aug 2023 22:45:21 +0200, Daniel Vetter wrote: > Apparently no one noticed that mdp5 plane states leak like a sieve > ever since we introduced plane_state->commit refcount a few years ago > in 21a01abbe32a ("drm/atomic: Fix freeing connector/plane state too > early by tracking commits,

Re: [Freedreno] [PATCH] drm/msm/mdp5: Don't leak some plane state

2023-08-03 Thread Abhinav Kumar
On 8/3/2023 1:45 PM, Daniel Vetter wrote: Apparently no one noticed that mdp5 plane states leak like a sieve ever since we introduced plane_state->commit refcount a few years ago in 21a01abbe32a ("drm/atomic: Fix freeing connector/plane state too early by tracking commits, v3.") Fix it by

Re: [Freedreno] [PATCH] drm/msm/mdp5: Don't leak some plane state

2023-08-03 Thread Dmitry Baryshkov
On Thu, 3 Aug 2023 at 23:45, Daniel Vetter wrote: > > Apparently no one noticed that mdp5 plane states leak like a sieve > ever since we introduced plane_state->commit refcount a few years ago > in 21a01abbe32a ("drm/atomic: Fix freeing connector/plane state too > early by tracking commits, v3.")

Re: [Freedreno] [PATCH] drm/msm/mdp5: Don't leak some plane state

2023-08-03 Thread Rob Clark
On Thu, Aug 3, 2023 at 1:45 PM Daniel Vetter wrote: > > Apparently no one noticed that mdp5 plane states leak like a sieve > ever since we introduced plane_state->commit refcount a few years ago > in 21a01abbe32a ("drm/atomic: Fix freeing connector/plane state too > early by tracking commits,

[Freedreno] [PATCH] drm/msm/mdp5: Don't leak some plane state

2023-08-03 Thread Daniel Vetter
Apparently no one noticed that mdp5 plane states leak like a sieve ever since we introduced plane_state->commit refcount a few years ago in 21a01abbe32a ("drm/atomic: Fix freeing connector/plane state too early by tracking commits, v3.") Fix it by using the right helpers. Fixes: 21a01abbe32a