Re: [Freedreno] [PATCH] drm/msm: remove unneeded variable

2021-09-03 Thread Dmitry Baryshkov
On 31/08/2021 14:51, cgel@gmail.com wrote: From: Chi Minghao Fix the following coccicheck REVIEW: ./drivers/gpu/drm/msm/edp/edp_ctrl.c:1245:5-8 Unneeded variable Reported-by: Zeal Robot Signed-off-by: Chi Minghao Reviewed-by: Dmitry Baryshkov Glancing on msm/edp, as it was never

Re: [Freedreno] [PATCH] drm/msm: remove unneeded variable

2021-09-03 Thread Lyude Paul
On Fri, 2021-09-03 at 21:31 +0300, Dmitry Baryshkov wrote: > On 02/09/2021 21:40, Lyude Paul wrote: > > Reviewed-by: Lyude Paul > > > > Do you need me to push this? > > We'd pick this up through the msm tree. ah-totally forgot msm had their own tree and didn't go through drm-misc-next. Thanks!

Re: [Freedreno] [PATCH] drm/msm: remove unneeded variable

2021-09-03 Thread Dmitry Baryshkov
On 02/09/2021 21:40, Lyude Paul wrote: Reviewed-by: Lyude Paul Do you need me to push this? We'd pick this up through the msm tree. On Tue, 2021-08-31 at 04:51 -0700, cgel@gmail.com wrote: From: Chi Minghao Fix the following coccicheck REVIEW:

Re: [Freedreno] [PATCH] drm/msm: remove unneeded variable

2021-09-02 Thread Lyude Paul
Reviewed-by: Lyude Paul Do you need me to push this? On Tue, 2021-08-31 at 04:51 -0700, cgel@gmail.com wrote: > From: Chi Minghao > > Fix the following coccicheck REVIEW: > ./drivers/gpu/drm/msm/edp/edp_ctrl.c:1245:5-8 Unneeded variable > > Reported-by: Zeal Robot > Signed-off-by: Chi

[Freedreno] [PATCH] drm/msm: remove unneeded variable

2021-08-31 Thread cgel . zte
From: Chi Minghao Fix the following coccicheck REVIEW: ./drivers/gpu/drm/msm/edp/edp_ctrl.c:1245:5-8 Unneeded variable Reported-by: Zeal Robot Signed-off-by: Chi Minghao --- drivers/gpu/drm/msm/edp/edp_ctrl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

Re: [Freedreno] [PATCH] drm/msm: remove unneeded variable ret

2021-05-25 Thread Dmitry Baryshkov
On 07/04/2021 16:06, Bernard Zhao wrote: This patch fix coccicheck warning: drivers/gpu/drm/msm/dp/dp_link.c:848:5-8: Unneeded variable: "ret". Return "0" on line 880 Also remove unneeded function return value check. Signed-off-by: Bernard Zhao Reviewed-by: Dmitry Baryshkov ---

Re: [Freedreno] [PATCH] drm/msm: remove unneeded variable ret

2021-04-07 Thread Stephen Boyd
Quoting Bernard Zhao (2021-04-07 06:06:21) > This patch fix coccicheck warning: > drivers/gpu/drm/msm/dp/dp_link.c:848:5-8: Unneeded variable: "ret". Return > "0" on line 880 > Also remove unneeded function return value check. > > Signed-off-by: Bernard Zhao > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH] drm/msm: remove unneeded variable ret

2021-04-07 Thread abhinavk
On 2021-04-07 06:06, Bernard Zhao wrote: This patch fix coccicheck warning: drivers/gpu/drm/msm/dp/dp_link.c:848:5-8: Unneeded variable: "ret". Return "0" on line 880 Also remove unneeded function return value check. Signed-off-by: Bernard Zhao Reviewed-by: Abhinav Kumar ---

[Freedreno] [PATCH] drm/msm: remove unneeded variable ret

2021-04-07 Thread Bernard Zhao
This patch fix coccicheck warning: drivers/gpu/drm/msm/dp/dp_link.c:848:5-8: Unneeded variable: "ret". Return "0" on line 880 Also remove unneeded function return value check. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/msm/dp/dp_link.c | 15 +++ 1 file changed, 3

Re: [Freedreno] [PATCH] drm/msm: remove unneeded variable: "rc"

2021-02-02 Thread Stephen Boyd
Quoting Bernard Zhao (2021-02-02 04:32:03) > remove unneeded variable: "rc". > > Signed-off-by: Bernard Zhao > --- Reviewed-by: Stephen Boyd ___ Freedreno mailing list Freedreno@lists.freedesktop.org

[Freedreno] [PATCH] drm/msm: remove unneeded variable: "rc"

2021-02-02 Thread Bernard Zhao
remove unneeded variable: "rc". Signed-off-by: Bernard Zhao --- drivers/gpu/drm/msm/dp/dp_panel.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c index d1780bcac8cc..9cc816663668 100644 ---