Re: [Freedreno] [PATCH 3/8] drm/msm: dpu: Remove vblank_callback from encoder

2018-11-16 Thread Sean Paul
On Wed, Nov 14, 2018 at 02:43:51PM -0500, Sean Paul wrote: > On Wed, Nov 14, 2018 at 11:33:53AM -0800, Jeykumar Sankaran wrote: > > On 2018-11-14 07:13, Sean Paul wrote: > > > On Tue, Nov 13, 2018 at 04:47:22PM -0800, Jeykumar Sankaran wrote: > > > > On 2018-11-13 12:52, Sean Paul wrote: > > > > >

Re: [Freedreno] [PATCH 3/8] drm/msm: dpu: Remove vblank_callback from encoder

2018-11-14 Thread Sean Paul
On Wed, Nov 14, 2018 at 11:33:53AM -0800, Jeykumar Sankaran wrote: > On 2018-11-14 07:13, Sean Paul wrote: > > On Tue, Nov 13, 2018 at 04:47:22PM -0800, Jeykumar Sankaran wrote: > > > On 2018-11-13 12:52, Sean Paul wrote: > > > > From: Sean Paul > > > > > > > > The indirection of registering a

Re: [Freedreno] [PATCH 3/8] drm/msm: dpu: Remove vblank_callback from encoder

2018-11-14 Thread Jeykumar Sankaran
On 2018-11-14 07:13, Sean Paul wrote: On Tue, Nov 13, 2018 at 04:47:22PM -0800, Jeykumar Sankaran wrote: On 2018-11-13 12:52, Sean Paul wrote: > From: Sean Paul > > The indirection of registering a callback and opaque pointer isn't real > useful when there's only one callsite. So instead of

Re: [Freedreno] [PATCH 3/8] drm/msm: dpu: Remove vblank_callback from encoder

2018-11-13 Thread Jeykumar Sankaran
On 2018-11-13 12:52, Sean Paul wrote: From: Sean Paul The indirection of registering a callback and opaque pointer isn't real useful when there's only one callsite. So instead of having the vblank_cb registration, just give encoder a crtc and let it directly call the vblank handler. In a

[Freedreno] [PATCH 3/8] drm/msm: dpu: Remove vblank_callback from encoder

2018-11-13 Thread Sean Paul
From: Sean Paul The indirection of registering a callback and opaque pointer isn't real useful when there's only one callsite. So instead of having the vblank_cb registration, just give encoder a crtc and let it directly call the vblank handler. In a later patch, we'll make use of this further.