Re: [Freedreno] [PATCH v2 06/11] drm: Use state helper instead of plane state pointer in atomic_check

2021-01-25 Thread Maxime Ripard
Hi Ville, On Fri, Jan 22, 2021 at 02:07:22PM +0200, Ville Syrjälä wrote: > On Thu, Jan 21, 2021 at 05:35:31PM +0100, Maxime Ripard wrote: > > Many drivers reference the plane->state pointer in order to get the > > current plane state in their atomic_check hook, which would be the old > > plane

Re: [Freedreno] [PATCH v2 06/11] drm: Use state helper instead of plane state pointer in atomic_check

2021-01-22 Thread Ville Syrjälä
On Thu, Jan 21, 2021 at 05:35:31PM +0100, Maxime Ripard wrote: > Many drivers reference the plane->state pointer in order to get the > current plane state in their atomic_check hook, which would be the old > plane state in the global atomic state since _swap_state hasn't happened > when

[Freedreno] [PATCH v2 06/11] drm: Use state helper instead of plane state pointer in atomic_check

2021-01-21 Thread Maxime Ripard
Many drivers reference the plane->state pointer in order to get the current plane state in their atomic_check hook, which would be the old plane state in the global atomic state since _swap_state hasn't happened when atomic_check is run. Use the drm_atomic_get_old_plane_state helper to get that