Re: [PATCH] drm/msm/dpu: fix the programming of INTF_CFG2_DATA_HCTL_EN

2024-02-19 Thread Dmitry Baryshkov
On Wed, 31 Jan 2024 16:47:36 -0800, Abhinav Kumar wrote: > Currently INTF_CFG2_DATA_HCTL_EN is coupled with the enablement > of widebus but this is incorrect because we should be enabling > this bit independent of widebus except for cases where compression > is enabled in one pixel per clock

Re: [PATCH] drm/msm/dpu: fix the programming of INTF_CFG2_DATA_HCTL_EN

2024-01-31 Thread Abhinav Kumar
On 1/31/2024 5:05 PM, Dmitry Baryshkov wrote: On Thu, 1 Feb 2024 at 02:48, Abhinav Kumar wrote: Currently INTF_CFG2_DATA_HCTL_EN is coupled with the enablement of widebus but this is incorrect because we should be enabling this bit independent of widebus except for cases where compression

Re: [PATCH] drm/msm/dpu: fix the programming of INTF_CFG2_DATA_HCTL_EN

2024-01-31 Thread Dmitry Baryshkov
On Thu, 1 Feb 2024 at 02:48, Abhinav Kumar wrote: > > Currently INTF_CFG2_DATA_HCTL_EN is coupled with the enablement > of widebus but this is incorrect because we should be enabling > this bit independent of widebus except for cases where compression > is enabled in one pixel per clock mode. > >

[PATCH] drm/msm/dpu: fix the programming of INTF_CFG2_DATA_HCTL_EN

2024-01-31 Thread Abhinav Kumar
Currently INTF_CFG2_DATA_HCTL_EN is coupled with the enablement of widebus but this is incorrect because we should be enabling this bit independent of widebus except for cases where compression is enabled in one pixel per clock mode. Fix this by making the condition checks more explicit and