Re: [Freedreno] [PATCH 5/6] drm/atomic: add debugfs file to dump out atomic state

On Fri, Oct 14, 2016 at 7:55 PM, Rob Clark wrote: A short commit message detailing the change and info printed would probably be helpful. Aside from that, Reviewed-by: Sean Paul > Signed-off-by: Rob Clark > --- >

Re: [Freedreno] [PATCH 2/6] drm: add helper for printing to log or seq_file

On Fri, Oct 14, 2016 at 7:55 PM, Rob Clark wrote: > Sometimes it is nice not to duplicate equivalent printk() and > seq_printf() code. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/Makefile| 3 ++- > drivers/gpu/drm/drm_print.c | 54

Re: [Freedreno] [PATCH 6/6] drm/msm/mdp5: add atomic_print_state support

On Fri, Oct 14, 2016 at 7:55 PM, Rob Clark wrote: > We subclass drm_plane_state, so add mdp5_plane_atomic_print_state() to > dump out our own driver specific plane state. > Reviewed-by: Sean Paul > Signed-off-by: Rob Clark > ---

Re: [Freedreno] [PATCH] drm/msm/mdp5: expose "alpha" property

On Mon, Oct 17, 2016 at 10:08:28AM -0400, Rob Clark wrote: > On Mon, Oct 17, 2016 at 2:24 AM, Daniel Vetter wrote: > > On Fri, Oct 14, 2016 at 07:50:13PM -0400, Rob Clark wrote: > >> We had this wired up already internally but initially did not expose the > >> property pending

Re: [Freedreno] [PATCH 2/6] drm: add helper for printing to log or seq_file

On Mon, Oct 17, 2016 at 07:59:51AM -0400, Rob Clark wrote: > On Mon, Oct 17, 2016 at 2:38 AM, Daniel Vetter wrote: > > On Fri, Oct 14, 2016 at 07:55:49PM -0400, Rob Clark wrote: > >> Sometimes it is nice not to duplicate equivalent printk() and > >> seq_printf() code. > >> > >>

Re: [Freedreno] [PATCH 2/6] drm: add helper for printing to log or seq_file

On Mon, Oct 17, 2016 at 2:38 AM, Daniel Vetter wrote: > On Fri, Oct 14, 2016 at 07:55:49PM -0400, Rob Clark wrote: >> Sometimes it is nice not to duplicate equivalent printk() and >> seq_printf() code. >> >> Signed-off-by: Rob Clark > > Ok, maybe I should