Re: [Freedreno] [PATCH 05/13] drm: Add put callback for the coredump printer

2018-07-12 Thread Chris Wilson
Quoting Jordan Crouse (2018-07-12 19:59:22) > Add a put function for the coredump printer to bypass printf() > for constant strings for a speed boost. > > v2: Add EXPORT_SYMBOL for _drm_puts_coredump > Signed-off-by: Jordan Crouse > --- > drivers/gpu/drm/drm_print.c | 43

Re: [Freedreno] [PATCH 07/13] drm/msm/gpu: Convert the GPU show function to use the GPU state

2018-07-12 Thread Chris Wilson
Quoting Jordan Crouse (2018-07-12 19:59:24) > Convert the existing GPU show function to use the GPU state to > dump the information rather than reading it directly from the hardware. > This will require an additional step to capture the state before > dumping it for the existing nodes but it will

Re: [Freedreno] [PATCH 02/13] drm: drm_printer: Add printer for devcoredump

2018-07-12 Thread Daniel Vetter
On Thu, Jul 12, 2018 at 12:59:19PM -0600, Jordan Crouse wrote: > Add a drm printer suitable for use with the read callback for > devcoredump or other suitable buffer based output format that > isn't otherwise covered by seq_file. > > Signed-off-by: Jordan Crouse Hm, why not add seq_file support

Re: [Freedreno] [PATCH 01/13] include: Move ascii85 functions from i915 to linux/ascii85.h

2018-07-12 Thread Chris Wilson
Quoting Jordan Crouse (2018-07-12 19:59:18) > The i915 DRM driver very cleverly used ascii85 encoding for their > GPU state file. Move the encode functions to a general header file to > support other drivers that might be interested in the same > functionality. > > v3: Fix error_puts -> err_puts

Re: [Freedreno] [PATCH 02/13] drm: drm_printer: Add printer for devcoredump

2018-07-12 Thread Chris Wilson
Quoting Jordan Crouse (2018-07-12 19:59:19) > Add a drm printer suitable for use with the read callback for > devcoredump or other suitable buffer based output format that > isn't otherwise covered by seq_file. > > Signed-off-by: Jordan Crouse > --- > drivers/gpu/drm/drm_print.c | 74

[Freedreno] [PATCH v2 19/21] dt-bindings: msm/disp: Add bindings for Snapdragon 845 DPU

2018-07-12 Thread Sean Paul
From: Jeykumar Sankaran Adds bindings for Snapdragon 845 display processing unit Changes in v2: - Use SoC specific compatibles for mdss and dpu - Use assigned-clocks to set initial clock frequency Signed-off-by: Jeykumar Sankaran Signed-off-by: Rajesh Yadav Signed-off-by: Sean Paul ---

Re: [Freedreno] [PATCH 08/13] drm/msm/gpu: Rearrange the code that collects the task during a hang

2018-07-12 Thread Chris Wilson
Quoting Jordan Crouse (2018-07-12 19:59:25) > Do a bit of cleanup to prepare for upcoming changes to pass the > hanging task comm and cmdline to the crash dump function. > > Signed-off-by: Jordan Crouse > --- > drivers/gpu/drm/msm/msm_gpu.c | 18 ++ > 1 file changed, 10

Re: [Freedreno] [PATCH 04/13] drm: Add a -puts() function for the seq_file printer

2018-07-12 Thread Daniel Vetter
On Thu, Jul 12, 2018 at 12:59:21PM -0600, Jordan Crouse wrote: > Add a puts() function to use seq_puts() to help speed up > up print time for constant strings. > > Signed-off-by: Jordan Crouse Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/drm_print.c | 6 ++ >

Re: [Freedreno] [PATCH 03/13] drm: Add drm_puts() to complement drm_printf()

2018-07-12 Thread Daniel Vetter
On Thu, Jul 12, 2018 at 12:59:20PM -0600, Jordan Crouse wrote: > Add drm_puts() for a much faster path to print constant strings > into a drm_printer object with memcpy and friends. This can > shave seconds off of really large outputs such as GPU dumps. > > If the drm_printer object supports a

[Freedreno] [PATCH v2 21/21] arm64: dts: qcom: sdm845: Add dpu to sdm845 dts file

2018-07-12 Thread Sean Paul
DPU is short for the Display Processing Unit. It is the display controller on Qualcomm SDM845 chips. While the dts is pretty sparse for sdm845 atm, the only piece we're missing is the iommu. It's commented out for now, and should be uncommented once support is provided. Changes in v2: - Beefed

[Freedreno] [PATCH 09/13] drm/msm/gpu: Capture the GPU state on a GPU hang

2018-07-12 Thread Jordan Crouse
Capture the GPU state on a GPU hang and store it for later playback via the devcoredump facility. Only one crash state is stored at a time on the assumption that the first hang is usually the most interesting. The existing crash state can be cleared after capturing it and then a new one will be

[Freedreno] [PATCH 12/13] drm/msm/adreno: Add a5xx specific registers for the GPU state

2018-07-12 Thread Jordan Crouse
HLSQ, SP and TP registers are only accessible from a special aperture and to make matters worse the aperture is blocked from the CPU on targets that can support secure rendering. Luckily the GPU hardware has its own purpose built register dumper that can access the registers from the aperture. Add

[Freedreno] [PATCH 02/13] drm: drm_printer: Add printer for devcoredump

2018-07-12 Thread Jordan Crouse
Add a drm printer suitable for use with the read callback for devcoredump or other suitable buffer based output format that isn't otherwise covered by seq_file. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/drm_print.c | 74 + include/drm/drm_print.h |

[Freedreno] [PATCH 03/13] drm: Add drm_puts() to complement drm_printf()

2018-07-12 Thread Jordan Crouse
Add drm_puts() for a much faster path to print constant strings into a drm_printer object with memcpy and friends. This can shave seconds off of really large outputs such as GPU dumps. If the drm_printer object supports a custom puts function then use that otherwise fall back to the slower legacy

[Freedreno] [PATCH 11/13] drm/msm/adreno: Add ringbuffer data to the GPU state

2018-07-12 Thread Jordan Crouse
Add the contents of each ringbuffer to the GPU state and dump the data in the crash file encoded with ascii85. To save space only the used portions of the ringbuffer are dumped. Signed-off-by: Jordan Crouse --- Documentation/gpu/drm-msm-crash-dump.txt | 5 +++

[Freedreno] [PATCH 06/13] drm/msm/gpu: Capture the state of the GPU

2018-07-12 Thread Jordan Crouse
Add the infrastructure to capture the current state of the GPU and store it in memory so that it can be dumped later. For now grab the same basic ringbuffer information and registers that are provided by the debugfs 'gpu' node but obviously this should be extended to capture a much larger set of

[Freedreno] [PATCH 10/13] drm/msm/adreno: Convert the show/crash file format

2018-07-12 Thread Jordan Crouse
Convert the format of the 'show' debugfs file and the crash dump to a format resembling YAML. This should be easier to parse and be more flexible for future changes and expansions. Signed-off-by: Jordan Crouse --- Documentation/gpu/drm-msm-crash-dump.txt | 46

[Freedreno] [PATCH 13/13] drm/msm/gpu: Add the buffer objects from the submit to the crash dump

2018-07-12 Thread Jordan Crouse
For hangs, dump copy out the contents of the buffer objects attached to the guilty submission and print them in the crash dump report. v2: Use %zd to print the size of the buffer correctly Signed-off-by: Jordan Crouse --- Documentation/gpu/drm-msm-crash-dump.txt | 7 +++

[Freedreno] [PATCH 07/13] drm/msm/gpu: Convert the GPU show function to use the GPU state

2018-07-12 Thread Jordan Crouse
Convert the existing GPU show function to use the GPU state to dump the information rather than reading it directly from the hardware. This will require an additional step to capture the state before dumping it for the existing nodes but it will greatly facilitate reusing the same code for dumping

[Freedreno] [PATCH 05/13] drm: Add put callback for the coredump printer

2018-07-12 Thread Jordan Crouse
Add a put function for the coredump printer to bypass printf() for constant strings for a speed boost. v2: Add EXPORT_SYMBOL for _drm_puts_coredump Signed-off-by: Jordan Crouse --- drivers/gpu/drm/drm_print.c | 43 + include/drm/drm_print.h | 2 ++ 2

Re: [Freedreno] [PATCH v12 3/4] iommu/arm-smmu: Add the device_link between masters and smmu

2018-07-12 Thread Vivek Gautam
Hi Rafael, On Wed, Jul 11, 2018 at 4:06 PM, Vivek Gautam wrote: > Hi Rafael, > > > > On 7/11/2018 3:23 PM, Rafael J. Wysocki wrote: >> >> On Sunday, July 8, 2018 7:34:12 PM CEST Vivek Gautam wrote: >>> >>> From: Sricharan R >>> >>> Finally add the device link between the master device and >>>