On Thu, Oct 18, 2018 at 3:59 PM Jordan Crouse wrote:
>
> Do some cleanup in the static inline functions defined in
> dpu_media_info.h by cleaning up gotos and unneeded local
> variables.
>
> Signed-off-by: Jordan Crouse
Reviewed-by: Bruce Wang
> ---
>
On Thu, Oct 18, 2018 at 11:53:59PM +0200, Sam Ravnborg wrote:
> Hi Jordan.
>
> On Thu, Oct 18, 2018 at 01:58:31PM -0600, Jordan Crouse wrote:
> > Outside of superfluous parameter checks the dpu_hw_blk_init()
> > doesn't have any failure paths. Switch it over to be a void
> > function and we can
Hi Jordan,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on robclark/msm-next]
[also build test WARNING on next-20181019]
[cannot apply to v4.19-rc8]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url
On 10/18/2018 03:58 PM, Jordan Crouse wrote:
The functions in dpu_dbg.c aren't used. The two main dump functions
fail after a lookup from dpu_dbg_base.reg_base_list which turns out
to never be populated and once those are removed the rest of the
file doesn't make any sense.
Signed-off-by:
On Fri, Oct 19, 2018 at 12:06:20AM +0200, Sam Ravnborg wrote:
> Hi Jordan.
>
> On Thu, Oct 18, 2018 at 01:58:35PM -0600, Jordan Crouse wrote:
> > Remove more static inline functions that are lightly used and/or
> > very simple and easy to build into the calling functions.
>
> Please explain the
On Thu, Oct 18, 2018 at 3:59 PM Jordan Crouse wrote:
>
> The functions in dpu_dbg.c aren't used. The two main dump functions
> fail after a lookup from dpu_dbg_base.reg_base_list which turns out
> to never be populated and once those are removed the rest of the
> file doesn't make any sense.
>
>
On Fri, Oct 19, 2018 at 02:11:27PM -0400, Bruce Wang wrote:
> On Thu, Oct 18, 2018 at 3:59 PM Jordan Crouse wrote:
> >
> > The functions in dpu_dbg.c aren't used. The two main dump functions
> > fail after a lookup from dpu_dbg_base.reg_base_list which turns out
> > to never be populated and once
