Re: [Freedreno] [PATCH 23/23] drm: Cleanup VBLANK callbacks in struct drm_driver

2020-01-12 Thread Daniel Vetter
On Fri, Jan 10, 2020 at 10:21:27AM +0100, Thomas Zimmermann wrote: > All non-legacy users of VBLANK functions in struct drm_driver have been > converted to use the respective interfaces in struct drm_crtc_funcs. The > remaining users of VBLANK callbacks in struct drm_driver are legacy drivers >

Re: [Freedreno] [PATCH 23/23] drm: Cleanup VBLANK callbacks in struct drm_driver

2020-01-12 Thread Daniel Vetter
On Sun, Jan 12, 2020 at 11:53:12PM +0100, Daniel Vetter wrote: > On Fri, Jan 10, 2020 at 10:21:27AM +0100, Thomas Zimmermann wrote: > > All non-legacy users of VBLANK functions in struct drm_driver have been > > converted to use the respective interfaces in struct drm_crtc_funcs. The > > remaining

Re: [Freedreno] [PATCH 1/3] drm/msm: support firmware-name for zap fw

2020-01-12 Thread Rob Clark
On Wed, Jan 8, 2020 at 8:30 AM Rob Clark wrote: > > On Wed, Jan 8, 2020 at 7:38 AM Tom Rix wrote: > > > > > > On 1/7/20 5:38 PM, Rob Clark wrote: > > > From: Rob Clark > > > > > > Since zap firmware can be device specific, allow for a firmware-name > > > property in the zap node to specify

[Freedreno] [PATCH v2 0/4] drm/msm: use firmware-name to find zap fw

2020-01-12 Thread Rob Clark
From: Rob Clark For devices which use zap fw to take the GPU out of secure mode on reset, the firmware is likely to be signed with a device specific key. Meaning that we can't have a single filesystem (or /lib/firmware) that works on multiple devices. So allow a firmware-name to be specified in

[Freedreno] [PATCH v2 2/4] drm/msm: allow zapfw to not be specified in gpulist

2020-01-12 Thread Rob Clark
From: Rob Clark For newer devices we want to require the path to come from the firmware-name property in the zap-shader dt node. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git

[Freedreno] [PATCH v2 4/4] arm64: dts: sdm845: move gpu zap nodes to per-device dts

2020-01-12 Thread Rob Clark
From: Rob Clark We want to specify per-device firmware-name, so move the zap node into the .dts file for individual boards/devices. This lets us get rid of the /delete-node/ for cheza, which does not use zap. Signed-off-by: Rob Clark --- v2: use 'sdm845' for subdir for devices that use

[Freedreno] [PATCH v2 1/4] drm/msm: support firmware-name for zap fw (v2)

2020-01-12 Thread Rob Clark
From: Rob Clark Since zap firmware can be device specific, allow for a firmware-name property in the zap node to specify which firmware to load, similarly to the scheme used for dsp/wifi/etc. v2: only need a single error msg when we can't load from firmware-name specified path, and fix