Re: [Freedreno] [RESEND PATCH v6 04/14] drm/msm/dpu: Replace definitions for dpu debug macros

2021-08-05 Thread Dmitry Baryshkov
On 21/07/2021 20:55, Sean Paul wrote: From: Sean Paul The debug messages shouldn't be logged as errors when debug categories are enabled. Use the drm logging helpers to do the right thing Signed-off-by: Sean Paul Link:

Re: [Freedreno] [PATCH v5 01/20] drm/sched: Split drm_sched_job_init

2021-08-05 Thread Daniel Vetter
On Thu, Aug 5, 2021 at 3:44 PM Christian König wrote: > Am 05.08.21 um 12:46 schrieb Daniel Vetter: > > This is a very confusingly named function, because not just does it > > init an object, it arms it and provides a point of no return for > > pushing a job into the scheduler. It would be nice

Re: [Freedreno] [PATCH v5 01/20] drm/sched: Split drm_sched_job_init

2021-08-05 Thread Daniel Vetter
On Thu, Aug 5, 2021 at 4:47 PM Christian König wrote: > > Am 05.08.21 um 16:07 schrieb Daniel Vetter: > > On Thu, Aug 5, 2021 at 3:44 PM Christian König > > wrote: > >> Am 05.08.21 um 12:46 schrieb Daniel Vetter: > >>> This is a very confusingly named function, because not just does it > >>>

Re: [Freedreno] [PATCH v5 01/20] drm/sched: Split drm_sched_job_init

2021-08-05 Thread Christian König
Am 05.08.21 um 16:07 schrieb Daniel Vetter: On Thu, Aug 5, 2021 at 3:44 PM Christian König wrote: Am 05.08.21 um 12:46 schrieb Daniel Vetter: This is a very confusingly named function, because not just does it init an object, it arms it and provides a point of no return for pushing a job into

Re: [Freedreno] [PATCH] drm/aperture: Pass DRM driver structure instead of driver name

2021-08-05 Thread Dmitry Baryshkov
On 29/06/2021 16:58, Thomas Zimmermann wrote: Print the name of the DRM driver when taking over fbdev devices. Makes the output to dmesg more consistent. Note that the driver name is only used for printing a string to the kernel log. No UAPI is affected by this change. Signed-off-by: Thomas

Re: [Freedreno] [PATCH v5 05/20] drm/sched: drop entity parameter from drm_sched_push_job

2021-08-05 Thread Christian König
Am 05.08.21 um 12:46 schrieb Daniel Vetter: Originally a job was only bound to the queue when we pushed this, but now that's done in drm_sched_job_init, making that parameter entirely redundant. Remove it. The same applies to the context parameter in lima_sched_context_queue_task, simplify

[Freedreno] [PATCH v3 2/6] drm/msm/dp: reduce link rate if failed at link training 1

2021-08-05 Thread Kuogee Hsieh
Reduce link rate and re start link training if link training 1 failed due to loss of clock recovery done to fix Link Layer CTS case 4.3.1.7. Also only update voltage and pre-emphasis swing level after link training started to fix Link Layer CTS case 4.3.1.6. Changes in V2: -- replaced cr_status

[Freedreno] [PATCH v3 4/6] drm/msm/dp: replug event is converted into an unplug followed by an plug events

2021-08-05 Thread Kuogee Hsieh
Remove special handling of replug interrupt and instead treat replug event as a sequential unplug followed by a plugin event. This is needed to meet the requirements of DP Link Layer CTS test case 4.2.1.3. Changes in V2: -- add fixes statement Changes in V3: -- delete EV_HPD_REPLUG_INT Fixes:

[Freedreno] [PATCH v3 6/6] drm/msm/dp: do not end dp link training until video is ready

2021-08-05 Thread Kuogee Hsieh
Initialize both pre-emphasis and voltage swing level to 0 before start link training and do not end link training until video is ready to reduce the period between end of link training and video start to meet Link Layer CTS requirement. Some dongle main link symbol may become unlocked again if

[Freedreno] [PATCH v3 1/6] drm/msm/dp: use dp_ctrl_off_link_stream during PHY compliance test run

2021-08-05 Thread Kuogee Hsieh
DP cable should always connect to DPU during the entire PHY compliance testing run. Since DP PHY compliance test is executed at irq_hpd event context, dp_ctrl_off_link_stream() should be used instead of dp_ctrl_off(). dp_ctrl_off() is used for unplug event which is triggered when DP cable is dis

[Freedreno] [PATCH v3 0/6] add fixes to pass DP Link Layer compliance test cases

2021-08-05 Thread Kuogee Hsieh
add fixes to pass DP Link Layer compliance test cases Kuogee Hsieh (6): drm/msm/dp: use dp_ctrl_off_link_stream during PHY compliance test run drm/msm/dp: reduce link rate if failed at link training 1 drm/msm/dp: reset aux controller after dp_aux_cmd_fifo_tx() failed. drm/msm/dp: replug

Re: [Freedreno] [PATCH v5 02/20] drm/msm: Fix drm/sched point of no return rules

2021-08-05 Thread Rob Clark
On Thu, Aug 5, 2021 at 3:47 AM Daniel Vetter wrote: > > Originally drm_sched_job_init was the point of no return, after which > drivers must submit a job. I've split that up, which allows us to fix > this issue pretty easily. > > Only thing we have to take care of is to not skip to error paths

[Freedreno] [PATCH v5] drm/msm/dsi: add continuous clock support for 7nm PHY

2021-08-05 Thread Dmitry Baryshkov
Unlike previous generations, 7nm PHYs are required to collaborate with the host for conitnuos clock mode. Add changes neccessary to enable continuous clock mode in the 7nm DSI PHYs. Signed-off-by: Dmitry Baryshkov --- Changes since v4: - Fix the comment regarding

[Freedreno] [PATCH v3 3/6] drm/msm/dp: reset aux controller after dp_aux_cmd_fifo_tx() failed.

2021-08-05 Thread Kuogee Hsieh
Aux hardware calibration sequence requires resetting the aux controller in order for the new setting to take effect. However resetting the AUX controller will also clear HPD interrupt status which may accidentally cause pending unplug interrupt to get lost. Therefore reset aux controller only when

[Freedreno] [PATCH v3 5/6] drm/msm/dp: return correct edid checksum after corrupted edid checksum read

2021-08-05 Thread Kuogee Hsieh
Response with correct edid checksum saved at connector after corrupted edid checksum read. This fixes Link Layer CTS cases 4.2.2.3, 4.2.2.6. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_panel.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

Re: [Freedreno] [PATCH v5 01/20] drm/sched: Split drm_sched_job_init

2021-08-05 Thread Christian König
Am 05.08.21 um 12:46 schrieb Daniel Vetter: This is a very confusingly named function, because not just does it init an object, it arms it and provides a point of no return for pushing a job into the scheduler. It would be nice if that's a bit clearer in the interface. But the real reason is

[Freedreno] [PATCH v2] drm/drv: Remove initialization of static variables

2021-08-05 Thread zhaoxiao
Address the following checkpatch errors: ERROR: do not initialise statics to false FILE: :drivers/gpu/drm/msm/msm_drv.c:21: -static bool reglog = false; FILE: :drivers/gpu/drm/msm/msm_drv.c:31: -bool dumpstate = false; Signed-off-by: zhaoxiao --- v2: change the patch description

Re: [Freedreno] [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy

2021-08-05 Thread Chrisanthus, Anitha
Hi Thomas, > -Original Message- > From: Thomas Zimmermann > Sent: Wednesday, August 4, 2021 12:11 AM > To: Chrisanthus, Anitha ; Sam Ravnborg > > Cc: dan...@ffwll.ch; airl...@linux.ie; alexander.deuc...@amd.com; > christian.koe...@amd.com; liviu.du...@arm.com; brian.star...@arm.com; >

Re: [Freedreno] [PATCH -next v2] drm/msm: Use list_move_tail instead of list_del/list_add_tail in msm_gem.c

2021-08-05 Thread Dmitry Baryshkov
On 09/06/2021 10:28, Baokun Li wrote: Using list_move_tail() instead of list_del() + list_add_tail() in msm_gem.c. Reported-by: Hulk Robot Signed-off-by: Baokun Li Reviewed-by: Dmitry Baryshkov --- V1->V2: CC mailist drivers/gpu/drm/msm/msm_gem.c | 3 +-- 1 file changed, 1

[Freedreno] [PATCH v5 12/20] drm/msm: Use scheduler dependency handling

2021-08-05 Thread Daniel Vetter
drm_sched_job_init is already at the right place, so this boils down to deleting code. Signed-off-by: Daniel Vetter Cc: Rob Clark Cc: Sean Paul Cc: Sumit Semwal Cc: "Christian König" Cc: linux-arm-...@vger.kernel.org Cc: freedreno@lists.freedesktop.org Cc: linux-me...@vger.kernel.org Cc:

[Freedreno] [PATCH v5 16/20] drm/msm: Don't break exclusive fence ordering

2021-08-05 Thread Daniel Vetter
There's only one exclusive slot, and we must not break the ordering. Adding a new exclusive fence drops all previous fences from the dma_resv. To avoid violating the signalling order we err on the side of over-synchronizing by waiting for the existing fences, even if userspace asked us to ignore

[Freedreno] [PATCH v5 05/20] drm/sched: drop entity parameter from drm_sched_push_job

2021-08-05 Thread Daniel Vetter
Originally a job was only bound to the queue when we pushed this, but now that's done in drm_sched_job_init, making that parameter entirely redundant. Remove it. The same applies to the context parameter in lima_sched_context_queue_task, simplify that too. v2: Rebase on top of msm adopting

[Freedreno] [PATCH v5 01/20] drm/sched: Split drm_sched_job_init

2021-08-05 Thread Daniel Vetter
This is a very confusingly named function, because not just does it init an object, it arms it and provides a point of no return for pushing a job into the scheduler. It would be nice if that's a bit clearer in the interface. But the real reason is that I want to push the dependency tracking

[Freedreno] [PATCH v5 02/20] drm/msm: Fix drm/sched point of no return rules

2021-08-05 Thread Daniel Vetter
Originally drm_sched_job_init was the point of no return, after which drivers must submit a job. I've split that up, which allows us to fix this issue pretty easily. Only thing we have to take care of is to not skip to error paths after that. Other drivers do this the same for out-fence and