Re: [Freedreno] [PATCH 1/4] drm/bridge: ti-sn65dsi86: Avoid creating multiple connectors

2021-08-12 Thread Doug Anderson
Hi, On Wed, Aug 11, 2021 at 4:51 PM Rob Clark wrote: > > From: Rob Clark > > If we created our own connector because the driver does not support the > NO_CONNECTOR flag, we don't want the downstream bridge to *also* create > a connector. And if this driver did pass the NO_CONNECTOR flag (and

Re: [Freedreno] [PATCH 2/4] drm/msm/dsi: Support NO_CONNECTOR bridges

2021-08-12 Thread Sam Ravnborg
Hi Rob, On Wed, Aug 11, 2021 at 04:52:48PM -0700, Rob Clark wrote: > From: Rob Clark > > For now, since we have a mix of bridges which support this flag, which > which do *not* support this flag, or work both ways, try it once with > NO_CONNECTOR and then fall back to the old way if that

Re: [Freedreno] [PATCH 1/4] drm/bridge: ti-sn65dsi86: Avoid creating multiple connectors

2021-08-12 Thread Rob Clark
On Thu, Aug 12, 2021 at 9:55 AM Doug Anderson wrote: > > Hi, > > On Wed, Aug 11, 2021 at 4:51 PM Rob Clark wrote: > > > > From: Rob Clark > > > > If we created our own connector because the driver does not support the > > NO_CONNECTOR flag, we don't want the downstream bridge to *also* create >

Re: [Freedreno] [PATCH 1/4] drm/bridge: ti-sn65dsi86: Avoid creating multiple connectors

2021-08-12 Thread Laurent Pinchart
Hi Rob, Thank you for the patch. On Wed, Aug 11, 2021 at 04:52:47PM -0700, Rob Clark wrote: > From: Rob Clark > > If we created our own connector because the driver does not support the > NO_CONNECTOR flag, we don't want the downstream bridge to *also* create > a connector. And if this driver

Re: [Freedreno] [PATCH 2/4] drm/msm/dsi: Support NO_CONNECTOR bridges

2021-08-12 Thread Laurent Pinchart
Hi Rob Thank you for the patch. On Wed, Aug 11, 2021 at 04:52:48PM -0700, Rob Clark wrote: > From: Rob Clark > > For now, since we have a mix of bridges which support this flag, which > which do *not* support this flag, or work both ways, try it once with > NO_CONNECTOR and then fall back to

Re: [Freedreno] [PATCH 4/4] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support

2021-08-12 Thread Doug Anderson
Hi, On Wed, Aug 11, 2021 at 4:51 PM Rob Clark wrote: > > From: Rob Clark > > Slightly awkward to fish out the display_info when we aren't creating > own connector. But I don't see an obvious better way. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 34

Re: [Freedreno] [PATCH 2/4] drm/msm/dsi: Support NO_CONNECTOR bridges

2021-08-12 Thread Rob Clark
On Thu, Aug 12, 2021 at 10:31 AM Sam Ravnborg wrote: > > Hi Rob, > > On Wed, Aug 11, 2021 at 04:52:48PM -0700, Rob Clark wrote: > > From: Rob Clark > > > > For now, since we have a mix of bridges which support this flag, which > > which do *not* support this flag, or work both ways, try it once

[Freedreno] [pull] drm/msm: drm-msm-next-2021-08-12 for v5.15

2021-08-12 Thread Rob Clark
Hi Dave & Daniel, This is the main pull for v5.15, after the early pull request with drm/scheduler conversion: * New a6xx GPU support: a680 and 7c3 * dsi: 7nm phi, sc7280 support, test pattern generator support * mdp4 fixes for older hw like the nexus7 * displayport fixes There will be minor

Re: [Freedreno] [PATCH 3/4] drm/bridge: ti-sn65dsi86: Implement bridge->mode_valid()

2021-08-12 Thread Doug Anderson
Hi, On Wed, Aug 11, 2021 at 4:51 PM Rob Clark wrote: > > From: Rob Clark > > For the brave new world of bridges not creating their own connectors, we > need to implement the max clock limitation via bridge->mode_valid() > instead of connector->mode_valid(). > > Signed-off-by: Rob Clark > --- >

Re: [Freedreno] [PATCH 3/4] drm/bridge: ti-sn65dsi86: Implement bridge->mode_valid()

2021-08-12 Thread Rob Clark
On Thu, Aug 12, 2021 at 11:44 AM Laurent Pinchart wrote: > > Hi Rob, > > Thank you for the patch. > > On Wed, Aug 11, 2021 at 04:52:49PM -0700, Rob Clark wrote: > > From: Rob Clark > > > > For the brave new world of bridges not creating their own connectors, we > > need to implement the max

Re: [Freedreno] [PATCH v5 12/20] drm/msm: Use scheduler dependency handling

2021-08-12 Thread Daniel Vetter
On Thu, Aug 05, 2021 at 12:46:57PM +0200, Daniel Vetter wrote: > drm_sched_job_init is already at the right place, so this boils down > to deleting code. > > Signed-off-by: Daniel Vetter > Cc: Rob Clark > Cc: Sean Paul > Cc: Sumit Semwal > Cc: "Christian König" > Cc:

Re: [Freedreno] [PATCH 4/4] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support

2021-08-12 Thread Laurent Pinchart
Hi Rob, Thank you for the patch. On Wed, Aug 11, 2021 at 04:52:50PM -0700, Rob Clark wrote: > From: Rob Clark > > Slightly awkward to fish out the display_info when we aren't creating > own connector. But I don't see an obvious better way. We need a bit more than this, to support the

Re: [Freedreno] [PATCH 4/4] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support

2021-08-12 Thread Doug Anderson
Laurent, On Thu, Aug 12, 2021 at 12:26 PM Laurent Pinchart wrote: > > Hi Rob, > > Thank you for the patch. > > On Wed, Aug 11, 2021 at 04:52:50PM -0700, Rob Clark wrote: > > From: Rob Clark > > > > Slightly awkward to fish out the display_info when we aren't creating > > own connector. But I

Re: [Freedreno] [PATCH 3/4] drm/bridge: ti-sn65dsi86: Implement bridge->mode_valid()

2021-08-12 Thread Laurent Pinchart
Hi Rob, Thank you for the patch. On Wed, Aug 11, 2021 at 04:52:49PM -0700, Rob Clark wrote: > From: Rob Clark > > For the brave new world of bridges not creating their own connectors, we > need to implement the max clock limitation via bridge->mode_valid() > instead of connector->mode_valid().

Re: [Freedreno] [PATCH 3/4] drm/bridge: ti-sn65dsi86: Implement bridge->mode_valid()

2021-08-12 Thread Laurent Pinchart
Hi Rob, On Thu, Aug 12, 2021 at 12:09:12PM -0700, Rob Clark wrote: > On Thu, Aug 12, 2021 at 11:44 AM Laurent Pinchart wrote: > > On Wed, Aug 11, 2021 at 04:52:49PM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > For the brave new world of bridges not creating their own connectors, we

Re: [Freedreno] [PATCH] drm/msm: Read frame_count and line_count even when disabled.

2021-08-12 Thread Mark Yacoub
On Wed, Aug 11, 2021 at 7:37 PM wrote: > > On 2021-08-11 16:28, Rob Clark wrote: > > On Wed, Aug 11, 2021 at 4:11 PM wrote: > >> > >> On 2021-08-11 11:43, Rob Clark wrote: > >> > On Wed, Aug 11, 2021 at 11:12 AM Mark Yacoub > >> > wrote: > >> >> > >> >> From: Mark Yacoub > >> >> > >> >> [why]

Re: [Freedreno] [PATCH v1 1/2] drm/msm/dp: Add support for SC7280 eDP

2021-08-12 Thread sbillaka
On 2021-08-12 06:11, Stephen Boyd wrote: Quoting Sankeerth Billakanti (2021-08-11 17:08:01) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c index b131fd37..1096c44 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c +++