Re: [Freedreno] [bug report] drm/msm/a6xx: Fix llcc configuration for a660 gpu

2021-10-14 Thread Akhil P Oommen
On 10/12/2021 3:30 PM, Dan Carpenter wrote: Hello Akhil P Oommen, The patch a6f24383f6c0: "drm/msm/a6xx: Fix llcc configuration for a660 gpu" from Jul 30, 2021, leads to the following Smatch static checker warning: drivers/gpu/drm/msm/adreno/a6xx_gpu.c:1480 a6xx_llc_activate()

[Freedreno] Revert "arm64: dts: qcom: sm8250: remove bus clock from the mdss node for sm8250 target"

2021-10-14 Thread Dmitry Baryshkov
From: Amit Pundir This reverts commit 001ce9785c0674d913531345e86222c965fc8bf4. This upstream commit broke AOSP (post Android 12 merge) build on RB5. The device either silently crashes into USB crash mode after android boot animation or we see a blank blue screen with following dpu errors in

Re: [Freedreno] [PATCH v2 06/11] drm/msm/disp/dpu1: Don't use DSC with mode_3d

2021-10-14 Thread Dmitry Baryshkov
On 14/10/2021 16:41, Dmitry Baryshkov wrote: On 07/10/2021 10:08, Vinod Koul wrote: We cannot enable mode_3d when we are using the DSC. So pass configuration to detect DSC is enabled and not enable mode_3d when we are using DSC We add a helper dpu_encoder_helper_get_dsc_mode() to detect dsc

Re: [Freedreno] [PATCH v2 03/11] drm/msm/disp/dpu1: Add support for DSC in pingpong block

2021-10-14 Thread Dmitry Baryshkov
On 07/10/2021 10:08, Vinod Koul wrote: In SDM845, DSC can be enabled by writing to pingpong block registers, so add support for DSC in hw_pp Reviewed-by: Abhinav Kumar Signed-off-by: Vinod Koul Reviewed-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 32

[Freedreno] [PATCH 0/2] drm/msm: fix build error

2021-10-14 Thread Yanteng Si
Include linux/vmalloc.h to fix below errors: error: implicit declaration of function 'vmap'; error: implicit declaration of function 'register_vmap_purge_notifier' error: implicit declaration of function 'unregister_vmap_purge_notifier' Yanteng Si (2): drm/msm: Fix missing include files in

[Freedreno] [PATCH 2/2] drm/msm: Fix missing include files in msm_gem_shrinker.c

2021-10-14 Thread Yanteng Si
Include linux/vmalloc.h to fix below errors: error: implicit declaration of function 'register_vmap_purge_notifier' error: implicit declaration of function 'unregister_vmap_purge_notifier' Signed-off-by: Yanteng Si --- drivers/gpu/drm/msm/msm_gem_shrinker.c | 2 ++ 1 file changed, 2

[Freedreno] [PATCH 1/2] drm/msm: Fix missing include files in msm_gem.c

2021-10-14 Thread Yanteng Si
Include linux/vmalloc.h to fix below errors: error: implicit declaration of function 'vmap' Signed-off-by: Yanteng Si --- drivers/gpu/drm/msm/msm_gem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c index

Re: [Freedreno] [PATCH v2 09/11] drm/msm/disp/dpu1: Add support for DSC in topology

2021-10-14 Thread Dmitry Baryshkov
On 07/10/2021 10:08, Vinod Koul wrote: For DSC to work we typically need a 2,2,1 configuration. This should suffice for resolutions upto 4k. For more resolutions like 8k this won't work. Also, it is better to use 2 LMs and DSC instances as half width results in lesser power consumption as

Re: [Freedreno] [PATCH v2 02/34] component: Introduce the aggregate bus_type

2021-10-14 Thread Daniel Vetter
On Thu, Oct 07, 2021 at 04:42:48PM -0400, Stephen Boyd wrote: > Quoting Greg Kroah-Hartman (2021-10-06 22:37:40) > > On Wed, Oct 06, 2021 at 12:37:47PM -0700, Stephen Boyd wrote: > > > > > > Let's make the component driver into an actual device driver that has > > > probe/remove/shutdown

Re: [Freedreno] [PATCH v2 07/11] drm/msm/disp/dpu1: Add DSC support in hw_ctl

2021-10-14 Thread Dmitry Baryshkov
On 07/10/2021 10:08, Vinod Koul wrote: Later gens of hardware have DSC bits moved to hw_ctl, so configure these bits so that DSC would work there as well Signed-off-by: Vinod Koul --- Changes since v1: - Move this patch from 6 to 7 due to dependency on 6th one - Use DSC indices for

Re: [Freedreno] [PATCH v2 04/11] drm/msm/disp/dpu1: Add DSC support in RM

2021-10-14 Thread Dmitry Baryshkov
On 07/10/2021 10:08, Vinod Koul wrote: This add the bits in RM to enable the DSC blocks Signed-off-by: Vinod Koul --- Changes since v1: - Add _dpu_rm_reserve_dsc() function which checks if DSC is enabled - Fix to use dsc_blks drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 1 +

Re: [Freedreno] Revert "arm64: dts: qcom: sm8250: remove bus clock from the mdss node for sm8250 target"

2021-10-14 Thread Steev Klimaszewski
On 10/14/21 8:54 AM, Dmitry Baryshkov wrote: From: Amit Pundir This reverts commit 001ce9785c0674d913531345e86222c965fc8bf4. This upstream commit broke AOSP (post Android 12 merge) build on RB5. The device either silently crashes into USB crash mode after android boot animation or we see a

Re: [Freedreno] [PATCH v2 05/11] drm/msm/disp/dpu1: Add DSC for SDM845 to hw_catalog

2021-10-14 Thread Dmitry Baryshkov
On 07/10/2021 10:08, Vinod Koul wrote: This adds SDM845 DSC blocks into hw_catalog Signed-off-by: Vinod Koul Reviewed-by: Dmitry Baryshkov --- Changes since v1: - Remove DSC_SDM845_MASK and use 0 as feature mask .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 20 +++

Re: [Freedreno] [PATCH v2 02/11] drm/msm/disp/dpu1: Add support for DSC

2021-10-14 Thread Dmitry Baryshkov
On 07/10/2021 10:08, Vinod Koul wrote: Display Stream Compression (DSC) is one of the hw blocks in dpu, so add support by adding hw blocks for DSC Signed-off-by: Vinod Koul --- Changes since v1: - remove unused variable lp - Update copyright year RFC: - Drop unused enums

Re: [Freedreno] [PATCH v2 06/11] drm/msm/disp/dpu1: Don't use DSC with mode_3d

2021-10-14 Thread Dmitry Baryshkov
On 07/10/2021 10:08, Vinod Koul wrote: We cannot enable mode_3d when we are using the DSC. So pass configuration to detect DSC is enabled and not enable mode_3d when we are using DSC We add a helper dpu_encoder_helper_get_dsc_mode() to detect dsc enabled and pass this to .setup_intf_cfg()

Re: [Freedreno] Revert "arm64: dts: qcom: sm8250: remove bus clock from the mdss node for sm8250 target"

2021-10-14 Thread Steev Klimaszewski
On 10/14/21 10:42 AM, Steev Klimaszewski wrote: On 10/14/21 8:54 AM, Dmitry Baryshkov wrote: From: Amit Pundir This reverts commit 001ce9785c0674d913531345e86222c965fc8bf4. This upstream commit broke AOSP (post Android 12 merge) build on RB5. The device either silently crashes into USB

Re: [Freedreno] Revert "arm64: dts: qcom: sm8250: remove bus clock from the mdss node for sm8250 target"

2021-10-14 Thread Vladimir Zapolskiy
Hi Dmitry, On 10/14/21 4:54 PM, Dmitry Baryshkov wrote: From: Amit Pundir This reverts commit 001ce9785c0674d913531345e86222c965fc8bf4. This upstream commit broke AOSP (post Android 12 merge) build on RB5. The device either silently crashes into USB crash mode after android boot animation or

[Freedreno] [PATCH 1/2] drm/msm/hdmi: use bulk regulator API

2021-10-14 Thread Dmitry Baryshkov
Switch to using bulk regulator API instead of hand coding loops. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi.c | 34 +++ drivers/gpu/drm/msm/hdmi/hdmi.h | 6 ++-- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c| 20 -

[Freedreno] [PATCH 2/2] drm/msm/hdmi: switch to drm_bridge_connector

2021-10-14 Thread Dmitry Baryshkov
Merge old hdmi_bridge and hdmi_connector implementations. Use drm_bridge_connector instead. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Makefile | 2 +- drivers/gpu/drm/msm/hdmi/hdmi.c | 12 +- drivers/gpu/drm/msm/hdmi/hdmi.h | 19 ++-

Re: [Freedreno] Revert "arm64: dts: qcom: sm8250: remove bus clock from the mdss node for sm8250 target"

2021-10-14 Thread Dmitry Baryshkov
On Thu, 14 Oct 2021 at 19:54, Vladimir Zapolskiy wrote: > > Hi Dmitry, > > On 10/14/21 4:54 PM, Dmitry Baryshkov wrote: > > From: Amit Pundir > > > > This reverts commit 001ce9785c0674d913531345e86222c965fc8bf4. > > > > This upstream commit broke AOSP (post Android 12 merge) build > > on RB5.

[Freedreno] [PATCH] ARM: dts: qcom-apq8064: stop using legacy clock names for HDMI

2021-10-14 Thread Dmitry Baryshkov
Stop using legacy clock names (with _clk suffix) for HDMI and HDMI PHY device tree nodes. Signed-off-by: Dmitry Baryshkov --- arch/arm/boot/dts/qcom-apq8064.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi

Re: [Freedreno] [PATCH] drm: msm: fix building without CONFIG_COMMON_CLK

2021-10-14 Thread Dmitry Baryshkov
On 13/10/2021 17:42, Arnd Bergmann wrote: From: Arnd Bergmann When CONFIG_COMMON_CLOCK is disabled, the 8996 specific phy code is left out, which results in a link failure: ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3f0): undefined reference to `msm_hdmi_phy_8996_cfg' This was only

Re: [Freedreno] [PATCH v2 10/11] drm/msm/dsi: Add support for DSC configuration

2021-10-14 Thread Dmitry Baryshkov
On 07/10/2021 10:08, Vinod Koul wrote: When DSC is enabled, we need to configure DSI registers accordingly and configure the respective stream compression registers. Add support to calculate the register setting based on DSC params and timing information and configure these registers.