[Freedreno] [PATCH 3/7] dt-bindings: msm: dsi: Fix power-domains constraint

2022-06-30 Thread Bryan O'Donoghue
The existing msm8916.dtsi does not depend on nor require power-domains. Drop from the list of required. Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings") Signed-off-by: Bryan O'Donoghue --- .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 1 - 1

[Freedreno] [PATCH 1/7] dt-bindings: msm: dsi: Fix phy-name binding

2022-06-30 Thread Bryan O'Donoghue
The driver doesn't care about the name of the phy in DTS. msm8916 has since 2016 named the phy "dsi-phy" with later SoCs taking the name "dsi". There's no reason to have a constraint on the name here, simply to have a name. Remove the redundant const in favour of maxItems: 1. Fixes: 4dbe55c97741

[Freedreno] [PATCH 4/7] dt-bindings: msm: dsi: Add vdd* descriptions back in

2022-06-30 Thread Bryan O'Donoghue
When converting from .txt to .yaml we didn't include descriptions for the existing regulator supplies. - vdd - vdda - vddio Add those descriptions into the yaml now as they were prior to the conversion. Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")

[Freedreno] [PATCH 7/7] dt-bindings: msm: dsi: Add missing qcom, dsi-phy-regulator-ldo-mode

2022-06-30 Thread Bryan O'Donoghue
Add in missing qcom,dsi-phy-regulator-ldo-mode to the 28nm DSI PHY. When converting from .txt to .yaml we missed this one. Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings") Signed-off-by: Bryan O'Donoghue --- .../devicetree/bindings/display/msm/dsi-phy-28nm.yaml

[Freedreno] [PATCH 2/7] dt-bindings: msm: dsi: Fix operating-points-v2 constraint

2022-06-30 Thread Bryan O'Donoghue
The existing msm8916.dtsi does not depend on nor require operating points. Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings") Signed-off-by: Bryan O'Donoghue --- .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 1 - 1 file changed, 1 deletion(-)

[Freedreno] [PATCH 0/7] msm8916/msm8939 DSI controller and DSI PHY bindings fixes

2022-06-30 Thread Bryan O'Donoghue
This series fixes up a number of dtbs checks which are being flagged adding in the msm8939 dtsi. When converting from .txt to .yaml a number of the parameters for the older msm8916 silicon were not transmitted into the yaml. Adding in the msm8939 which is a near 1:1 copy of the msm8916 in terms

[Freedreno] [PATCH 6/7] dt-bindings: msm: dsi: Add missing clocks to 28nm DSI PHY YAML

2022-06-30 Thread Bryan O'Donoghue
Add in missing clock and clock-names declarations to the 28nm DSI PHY. When converting from .txt to .yaml we missed these. Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings") Signed-off-by: Bryan O'Donoghue --- .../bindings/display/msm/dsi-phy-28nm.yaml | 17

Re: [Freedreno] [PATCH v3 2/4] drm/msm/adreno: Add A619 support

2022-06-30 Thread Akhil P Oommen
On 5/28/2022 9:33 PM, Konrad Dybcio wrote: Add support for the Adreno 619 GPU, as found in Snapdragon 690 (SM6350), 480 (SM4350) and 750G (SM7225). Signed-off-by: Konrad Dybcio --- Changes since v2: - Fix some values in a619_build_bw_table (I think I miscopied things last time around..) - Add

Re: [Freedreno] [PATCH v3 1/4] drm/msm/adreno: Remove dead code

2022-06-30 Thread Akhil P Oommen
On 5/28/2022 9:33 PM, Konrad Dybcio wrote: This BUG_ON will never be reached, and there is a comment 20 above explaining why. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c

Re: [Freedreno] [PATCH v3 4/4] drm/msm/adreno: Fix up formatting

2022-06-30 Thread Akhil P Oommen
On 5/28/2022 10:22 PM, Joe Perches wrote: On Sat, 2022-05-28 at 18:03 +0200, Konrad Dybcio wrote: Leading spaces are not something checkpatch likes, and it says so when they are present. Use tabs consistently to indent function body and unwrap a 83-char-long line, as 100 is cool nowadays.

Re: [Freedreno] [PATCH v3 3/4] drm/msm/a6xx: Add speedbin support for A619 GPU

2022-06-30 Thread Akhil P Oommen
On 5/28/2022 9:33 PM, Konrad Dybcio wrote: There are various SKUs of A619, ranging from 565 MHz to 850 MHz, depending on the bin. Add support for distinguishing them, so that proper frequency ranges can be applied, depending on the HW. Signed-off-by: Konrad Dybcio ---

Re: [Freedreno] [PATCH 5/7] dt-bindings: msm: dsi: Fix clock declarations

2022-06-30 Thread Dmitry Baryshkov
On 30 June 2022 15:08:43 GMT+03:00, Bryan O'Donoghue wrote: >When converting from .txt to .yaml dt-binding descriptions we appear to >have missed some of the previous detail on the number and names of >permissible clocks. > >Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for

Re: [Freedreno] [PATCH 1/7] dt-bindings: msm: dsi: Fix phy-name binding

2022-06-30 Thread Dmitry Baryshkov
On 30 June 2022 15:08:39 GMT+03:00, Bryan O'Donoghue wrote: >The driver doesn't care about the name of the phy in DTS. msm8916 has since >2016 named the phy "dsi-phy" with later SoCs taking the name "dsi". > >There's no reason to have a constraint on the name here, simply to have a >name.

Re: [Freedreno] [PATCH 3/7] dt-bindings: msm: dsi: Fix power-domains constraint

2022-06-30 Thread Dmitry Baryshkov
On 30 June 2022 15:08:41 GMT+03:00, Bryan O'Donoghue wrote: >The existing msm8916.dtsi does not depend on nor require power-domains. >Drop from the list of required. > >Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI >bindings") >Signed-off-by: Bryan O'Donoghue

Re: [Freedreno] [PATCH 7/7] dt-bindings: msm: dsi: Add missing qcom, dsi-phy-regulator-ldo-mode

2022-06-30 Thread Dmitry Baryshkov
On 30 June 2022 15:08:45 GMT+03:00, Bryan O'Donoghue wrote: >Add in missing qcom,dsi-phy-regulator-ldo-mode to the 28nm DSI PHY. >When converting from .txt to .yaml we missed this one. > >Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI >bindings") >Signed-off-by: Bryan

Re: [Freedreno] [PATCH 4/7] dt-bindings: msm: dsi: Add vdd* descriptions back in

2022-06-30 Thread Dmitry Baryshkov
On 30 June 2022 15:08:42 GMT+03:00, Bryan O'Donoghue wrote: >When converting from .txt to .yaml we didn't include descriptions for the >existing regulator supplies. > >- vdd >- vdda >- vddio > >Add those descriptions into the yaml now as they were prior to the >conversion. > >Fixes:

Re: [Freedreno] [PATCH 4/7] dt-bindings: msm: dsi: Add vdd* descriptions back in

2022-06-30 Thread Bryan O'Donoghue
On 30/06/2022 18:16, Dmitry Baryshkov wrote: All three descriptions are the same. This looks like a c issue Those are what the previous values were. I'll come up with something less robotic though.

Re: [Freedreno] [PATCH 2/7] dt-bindings: msm: dsi: Fix operating-points-v2 constraint

2022-06-30 Thread Dmitry Baryshkov
On 30 June 2022 15:08:40 GMT+03:00, Bryan O'Donoghue wrote: >The existing msm8916.dtsi does not depend on nor require operating points. > >Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI >bindings") >Signed-off-by: Bryan O'Donoghue Reviewed-by: Dmitry Baryshkov

Re: [Freedreno] [PATCH 6/7] dt-bindings: msm: dsi: Add missing clocks to 28nm DSI PHY YAML

2022-06-30 Thread Dmitry Baryshkov
On 30 June 2022 15:08:44 GMT+03:00, Bryan O'Donoghue wrote: >Add in missing clock and clock-names declarations to the 28nm DSI PHY. >When converting from .txt to .yaml we missed these. > >Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI >bindings") >Signed-off-by: Bryan

Re: [Freedreno] [PATCH 3/7] dt-bindings: msm: dsi: Fix power-domains constraint

2022-06-30 Thread Krzysztof Kozlowski
On 30/06/2022 14:08, Bryan O'Donoghue wrote: > The existing msm8916.dtsi does not depend on nor require power-domains. > Drop from the list of required. That's not good reason. The bindings are about hardware so the question is whether being a part of power domain or toggling power domain on/off

Re: [Freedreno] [PATCH 4/7] dt-bindings: msm: dsi: Add vdd* descriptions back in

2022-06-30 Thread Krzysztof Kozlowski
On 30/06/2022 14:08, Bryan O'Donoghue wrote: > When converting from .txt to .yaml we didn't include descriptions for the > existing regulator supplies. > > - vdd > - vdda > - vddio > > Add those descriptions into the yaml now as they were prior to the > conversion. > > Fixes: 4dbe55c97741

Re: [Freedreno] [PATCH 5/7] dt-bindings: msm: dsi: Fix clock declarations

2022-06-30 Thread Krzysztof Kozlowski
On 30/06/2022 14:08, Bryan O'Donoghue wrote: > When converting from .txt to .yaml dt-binding descriptions we appear to > have missed some of the previous detail on the number and names of > permissible clocks. > > Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI > bindings")

Re: [Freedreno] [PATCH 1/7] dt-bindings: msm: dsi: Fix phy-name binding

2022-06-30 Thread Krzysztof Kozlowski
On 30/06/2022 14:08, Bryan O'Donoghue wrote: > The driver doesn't care about the name of the phy in DTS. msm8916 has since > 2016 named the phy "dsi-phy" with later SoCs taking the name "dsi". > > There's no reason to have a constraint on the name here, simply to have a > name. Remove the

Re: [Freedreno] [PATCH 2/7] dt-bindings: msm: dsi: Fix operating-points-v2 constraint

2022-06-30 Thread Krzysztof Kozlowski
On 30/06/2022 14:08, Bryan O'Donoghue wrote: > The existing msm8916.dtsi does not depend on nor require operating points. > > Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI > bindings") > Signed-off-by: Bryan O'Donoghue > --- Acked-by: Krzysztof Kozlowski Best

Re: [Freedreno] [PATCH 4/7] dt-bindings: msm: dsi: Add vdd* descriptions back in

2022-06-30 Thread Krzysztof Kozlowski
On 30/06/2022 19:30, Bryan O'Donoghue wrote: > On 30/06/2022 18:16, Dmitry Baryshkov wrote: >> >> All three descriptions are the same. This looks like a c issue > > Those are what the previous values were. > No, original TXT had different descriptions: -- vdd-supply: phandle to vdd regulator

Re: [Freedreno] [PATCH 7/7] dt-bindings: msm: dsi: Add missing qcom, dsi-phy-regulator-ldo-mode

2022-06-30 Thread Krzysztof Kozlowski
On 30/06/2022 14:08, Bryan O'Donoghue wrote: > Add in missing qcom,dsi-phy-regulator-ldo-mode to the 28nm DSI PHY. > When converting from .txt to .yaml we missed this one. > > Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI > bindings") > Signed-off-by: Bryan O'Donoghue >

Re: [Freedreno] [PATCH 3/7] dt-bindings: msm: dsi: Fix power-domains constraint

2022-06-30 Thread Bryan O'Donoghue
On 30/06/2022 20:01, Krzysztof Kozlowski wrote: On 30/06/2022 14:08, Bryan O'Donoghue wrote: The existing msm8916.dtsi does not depend on nor require power-domains. Drop from the list of required. That's not good reason. The bindings are about hardware so the question is whether being a part

Re: [Freedreno] [PATCH 3/7] dt-bindings: msm: dsi: Fix power-domains constraint

2022-06-30 Thread Stephan Gerhold
On Thu, Jun 30, 2022 at 08:49:03PM +0100, Bryan O'Donoghue wrote: > On 30/06/2022 20:01, Krzysztof Kozlowski wrote: > > On 30/06/2022 14:08, Bryan O'Donoghue wrote: > > > The existing msm8916.dtsi does not depend on nor require power-domains. > > > Drop from the list of required. > > > > That's

Re: [Freedreno] [PATCH] drm/msm/dp: make eDP panel as the first connected connector

2022-06-30 Thread Dmitry Baryshkov
On 30 June 2022 04:57:35 GMT+03:00, Rob Clark wrote: >On Wed, Jun 29, 2022 at 5:36 PM Doug Anderson wrote: >> >> Hi, >> >> On Tue, Jun 28, 2022 at 1:14 PM Dmitry Baryshkov >> wrote: >> > >> > On 28 June 2022 18:20:06 GMT+03:00, Kuogee Hsieh >> > wrote: >> > >Some userspace presumes that