Re: [Freedreno] [PATCH v2 0/4] drm/msm/adreno: fix runtime PM imbalance at unbind

2023-03-21 Thread Johan Hovold
On Fri, Mar 03, 2023 at 05:48:03PM +0100, Johan Hovold wrote: > As reported by Bjorn, we can end up with an unbalanced runtime PM > disable count if unbind() is called before the DRM device is opened > (e.g. if component bind fails due to the panel driver not having been > loaded yet). > > As

Re: [Freedreno] [PATCH v10 01/15] dma-buf/dma-fence: Add deadline awareness

2023-03-21 Thread Jonas Ådahl
On Fri, Mar 17, 2023 at 08:59:48AM -0700, Rob Clark wrote: > On Fri, Mar 17, 2023 at 3:23 AM Jonas Ådahl wrote: > > > > On Thu, Mar 16, 2023 at 09:28:55AM -0700, Rob Clark wrote: > > > On Thu, Mar 16, 2023 at 2:26 AM Jonas Ådahl wrote: > > > > > > > > On Wed, Mar 15, 2023 at 09:19:49AM -0700,

Re: [Freedreno] [PATCH 00/10] drm/msm: fix bind error handling

2023-03-21 Thread Johan Hovold
On Mon, Mar 06, 2023 at 11:07:12AM +0100, Johan Hovold wrote: > I had reasons to look closer at the MSM DRM driver error handling and > realised that it had suffered from a fair amount of bit rot over the > years. > > Unfortunately, I started fixing this in my 6.2 branch and failed to > notice

Re: [Freedreno] [PATCH v10 01/15] dma-buf/dma-fence: Add deadline awareness

2023-03-21 Thread Rob Clark
On Tue, Mar 21, 2023 at 6:24 AM Jonas Ådahl wrote: > > On Fri, Mar 17, 2023 at 08:59:48AM -0700, Rob Clark wrote: > > On Fri, Mar 17, 2023 at 3:23 AM Jonas Ådahl wrote: > > > > > > On Thu, Mar 16, 2023 at 09:28:55AM -0700, Rob Clark wrote: > > > > On Thu, Mar 16, 2023 at 2:26 AM Jonas Ådahl

Re: [Freedreno] [PATCH] drm/msm/dpu: Fix bit-shifting UB in DPU_HW_VER() macro

2023-03-21 Thread Randy Dunlap
On 3/6/23 01:06, Geert Uytterhoeven wrote: > With gcc-5 and CONFIG_UBSAN_SHIFT=y: > > drivers/gpu/drm/msm/msm_mdss.c: In function 'msm_mdss_enable': > drivers/gpu/drm/msm/msm_mdss.c:296:2: error: case label does not reduce > to an integer constant > case DPU_HW_VER_800: >

Re: [Freedreno] [PATCH 10/10] drm/msm: move include directive

2023-03-21 Thread Dmitry Baryshkov
On 06/03/2023 12:07, Johan Hovold wrote: Move the include of of_address.h to the top of the file where it belongs. Signed-off-by: Johan Hovold Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- With best wishes

Re: [Freedreno] [PATCH 05/10] drm/msm: fix drm device leak on bind errors

2023-03-21 Thread Dmitry Baryshkov
On 06/03/2023 12:07, Johan Hovold wrote: Make sure to free the DRM device also in case of early errors during bind(). Fixes: 2027e5b3413d ("drm/msm: Initialize MDSS irq domain at probe time") Cc: sta...@vger.kernel.org # 5.17 Cc: Dmitry Baryshkov Signed-off-by: Johan Hovold Can we

Re: [Freedreno] [PATCH 00/10] drm/msm: fix bind error handling

2023-03-21 Thread Dmitry Baryshkov
On 21/03/2023 15:02, Johan Hovold wrote: On Mon, Mar 06, 2023 at 11:07:12AM +0100, Johan Hovold wrote: I had reasons to look closer at the MSM DRM driver error handling and realised that it had suffered from a fair amount of bit rot over the years. Unfortunately, I started fixing this in my

Re: [Freedreno] [PATCH 03/10] drm/msm: fix NULL-deref on snapshot tear down

2023-03-21 Thread Dmitry Baryshkov
On 06/03/2023 12:07, Johan Hovold wrote: In case of early initialisation errors and on platforms that do not use the DPU controller, the deinitilisation code can be called with the kms pointer set to NULL. Fixes: 98659487b845 ("drm/msm: add support to take dpu snapshot") Cc:

Re: [Freedreno] [PATCH 04/10] drm/msm: fix NULL-deref on irq uninstall

2023-03-21 Thread Dmitry Baryshkov
On 06/03/2023 12:07, Johan Hovold wrote: In case of early initialisation errors and on platforms that do not use the DPU controller, the deinitilisation code can be called with the kms pointer set to NULL. Fixes: f026e431cf86 ("drm/msm: Convert to Linux IRQ interfaces") Cc:

Re: [Freedreno] [PATCH v2] dt-bindings: display: Drop unneeded quotes

2023-03-21 Thread Miguel Ojeda
On Tue, Mar 21, 2023 at 12:38 AM Rob Herring wrote: > > .../bindings/auxdisplay/holtek,ht16k33.yaml | 2 +- Acked-by: Miguel Ojeda Cheers, Miguel

Re: [Freedreno] [PATCH v6 5/5] arm64: dts: qcom: sm8450: add dp controller

2023-03-21 Thread Konrad Dybcio
On 17.03.2023 16:06, Neil Armstrong wrote: > Add the Display Port controller subnode to the MDSS node. > > Signed-off-by: Neil Armstrong > --- > arch/arm64/boot/dts/qcom/sm8450.dtsi | 79 > > 1 file changed, 79 insertions(+) > > diff --git

[Freedreno] [PATCH] dt-bindings: display: msm: sm8350-mdss: Fix DSI compatible

2023-03-21 Thread Konrad Dybcio
The DSI compatible changed between patchset revisions, but that wasn't reflected in the bindings. Fix it. Fixes: 430e11f42bff ("dt-bindings: display: msm: Add qcom, sm8350-mdss binding") Signed-off-by: Konrad Dybcio --- .../devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml | 2 +- 1