Re: [Freedreno] [DPU PATCH] drm/msm: Remove dpu_edid_parser

2018-02-23 Thread Rob Clark
On Fri, Feb 23, 2018 at 5:31 PM, wrote: > The bitmaps in drm_hdmi_info dont seem to be exposed to userspace. > > Our mode selection logic is in userspace at the moment which means its > better userspace knows which modes support what. > > If we decide to move mode

Re: [Freedreno] [DPU PATCH] drm/mipi: Remove Qualcomm-specific dsi packet header format

2018-02-23 Thread abhinavk
Alright, found it https://cgit.freedesktop.org/~seanpaul/dpu-staging/commit/?h=mtp-testing=34906195473f9e04601c49a45e3fedce0132eb7e Thanks Abhinav On 2018-02-23 07:06, Sean Paul wrote: On Thu, Feb 22, 2018 at 9:28 PM, Abhinav Kumar wrote: Looks good. Can you point us

Re: [Freedreno] [DPU PATCH] drm/msm: Remove dpu_edid_parser

2018-02-23 Thread abhinavk
I am OK with removing some parts of the parser but not entirely. Fundamentally, we went ahead with the parser for a couple of reasons: -> We would like to be able to associate the color format with the mode. This helps us decide that if the same mode supports both RGB/YUV then which one we

Re: [Freedreno] [DPU PATCH] drm/msm: Remove dpu_edid_parser

2018-02-23 Thread abhinavk
The bitmaps in drm_hdmi_info dont seem to be exposed to userspace. Our mode selection logic is in userspace at the moment which means its better userspace knows which modes support what. If we decide to move mode validation entirely to the driver, we can use these bitmaps to validate. But

Re: [Freedreno] [DPU PATCH] drm/msm: Remove dpu_edid_parser

2018-02-23 Thread Sean Paul
On Fri, Feb 23, 2018 at 01:29:03PM -0800, abhin...@codeaurora.org wrote: > I am OK with removing some parts of the parser but not entirely. > > Fundamentally, we went ahead with the parser for a couple of reasons: > > -> We would like to be able to associate the color format with the mode. >

[Freedreno] [DPU PATCH] drm/msm: Remove dpu_edid_parser

2018-02-23 Thread Sean Paul
Use drm_edid to parse the edid instead of the hand rolled dpu version. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/Makefile | 1 - drivers/gpu/drm/msm/dp/dp_audio.c | 22 +- drivers/gpu/drm/msm/dp/dp_display.c | 7 -

Re: [Freedreno] [RFC 4/4] drm/msm/mdp5: writeback support

2018-02-23 Thread Rob Clark
On Fri, Feb 23, 2018 at 11:30 AM, Sean Paul wrote: > On Fri, Feb 23, 2018 at 08:17:54AM -0500, Rob Clark wrote: >> In a way, based on the original writeback patch from Jilai Wang, but a >> lot has shifted around since then. >> >> Signed-off-by: Rob Clark

Re: [Freedreno] [PATCH v7 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

2018-02-23 Thread Vivek Gautam
On Fri, Feb 23, 2018 at 9:10 PM, Jordan Crouse wrote: > On Fri, Feb 23, 2018 at 04:06:39PM +0530, Vivek Gautam wrote: >> On Fri, Feb 23, 2018 at 5:22 AM, Jordan Crouse >> wrote: >> > On Wed, Feb 07, 2018 at 04:01:19PM +0530, Vivek Gautam wrote: >>

Re: [Freedreno] [RFC 1/4] drm: Add writeback connector type

2018-02-23 Thread Sean Paul
On Fri, Feb 23, 2018 at 04:48:58PM +, Liviu Dudau wrote: > On Fri, Feb 23, 2018 at 11:43:29AM -0500, Sean Paul wrote: > > On Fri, Feb 23, 2018 at 11:25:11AM -0500, Rob Clark wrote: > > > On Fri, Feb 23, 2018 at 10:59 AM, Sean Paul wrote: > > > > > > > > Have we

Re: [Freedreno] [RFC 1/4] drm: Add writeback connector type

2018-02-23 Thread Liviu Dudau
On Fri, Feb 23, 2018 at 11:39:06AM -0500, Sean Paul wrote: > On Fri, Feb 23, 2018 at 04:21:05PM +, Liviu Dudau wrote: > > On Fri, Feb 23, 2018 at 10:59:35AM -0500, Sean Paul wrote: > > > On Fri, Feb 23, 2018 at 08:17:51AM -0500, Rob Clark wrote: > > > > From: Brian Starkey

Re: [Freedreno] [RFC 1/4] drm: Add writeback connector type

2018-02-23 Thread Liviu Dudau
On Fri, Feb 23, 2018 at 11:43:29AM -0500, Sean Paul wrote: > On Fri, Feb 23, 2018 at 11:25:11AM -0500, Rob Clark wrote: > > On Fri, Feb 23, 2018 at 10:59 AM, Sean Paul wrote: > > > > > > Have we considered hiding writeback behind a client cap instead? > > > > It is kinda

Re: [Freedreno] [RFC 1/4] drm: Add writeback connector type

2018-02-23 Thread Sean Paul
On Fri, Feb 23, 2018 at 11:25:11AM -0500, Rob Clark wrote: > On Fri, Feb 23, 2018 at 10:59 AM, Sean Paul wrote: > > > > Have we considered hiding writeback behind a client cap instead? > > It is kinda *almost* unneeded, since the connector reports itself as > disconnected.

Re: [Freedreno] [RFC 4/4] drm/msm/mdp5: writeback support

2018-02-23 Thread Sean Paul
On Fri, Feb 23, 2018 at 08:17:54AM -0500, Rob Clark wrote: > In a way, based on the original writeback patch from Jilai Wang, but a > lot has shifted around since then. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/Makefile | 1 + >

Re: [Freedreno] [RFC 1/4] drm: Add writeback connector type

2018-02-23 Thread Rob Clark
On Fri, Feb 23, 2018 at 10:59 AM, Sean Paul wrote: > > Have we considered hiding writeback behind a client cap instead? It is kinda *almost* unneeded, since the connector reports itself as disconnected. I'm not sure what the reason was to drop the cap, but I think it

Re: [Freedreno] [RFC 1/4] drm: Add writeback connector type

2018-02-23 Thread Liviu Dudau
On Fri, Feb 23, 2018 at 10:59:35AM -0500, Sean Paul wrote: > On Fri, Feb 23, 2018 at 08:17:51AM -0500, Rob Clark wrote: > > From: Brian Starkey > > > > Writeback connectors represent writeback engines which can write the > > CRTC output to a memory framebuffer. Add a

Re: [Freedreno] [RFC 2/4] drm: writeback: Add out-fences for writeback connectors

2018-02-23 Thread Sean Paul
On Fri, Feb 23, 2018 at 08:17:52AM -0500, Rob Clark wrote: > From: Brian Starkey > > Add the WRITEBACK_OUT_FENCE_PTR property to writeback connectors, to > enable userspace to get a fence which will signal once the writeback is > complete. It is not allowed to request an

Re: [Freedreno] [PATCH v7 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

2018-02-23 Thread Jordan Crouse
On Fri, Feb 23, 2018 at 04:06:39PM +0530, Vivek Gautam wrote: > On Fri, Feb 23, 2018 at 5:22 AM, Jordan Crouse wrote: > > On Wed, Feb 07, 2018 at 04:01:19PM +0530, Vivek Gautam wrote: > >> From: Sricharan R > >> > >> The smmu device probe/remove

Re: [Freedreno] [DPU PATCH] drm/mipi: Remove Qualcomm-specific dsi packet header format

2018-02-23 Thread Sean Paul
On Thu, Feb 22, 2018 at 9:28 PM, Abhinav Kumar wrote: > Looks good. Can you point us to the fix done in the dsi-staging driver. > All of the downstream changes are in the mtp-testing branch of the dpu-staging tree. The on-list patches are in the for-next-staging, and the

Re: [Freedreno] [RFC 1/4] drm: Add writeback connector type

2018-02-23 Thread Liviu Dudau
On Fri, Feb 23, 2018 at 09:24:10AM -0500, Rob Clark wrote: > On Fri, Feb 23, 2018 at 9:00 AM, Liviu Dudau wrote: > > Hi Rob, > > > > On Fri, Feb 23, 2018 at 08:17:51AM -0500, Rob Clark wrote: > >> From: Brian Starkey > >> > >> Writeback connectors

Re: [Freedreno] [RFC 1/4] drm: Add writeback connector type

2018-02-23 Thread Rob Clark
On Fri, Feb 23, 2018 at 9:00 AM, Liviu Dudau wrote: > Hi Rob, > > On Fri, Feb 23, 2018 at 08:17:51AM -0500, Rob Clark wrote: >> From: Brian Starkey >> >> Writeback connectors represent writeback engines which can write the >> CRTC output to a memory

[Freedreno] [RFC 4/4] drm/msm/mdp5: writeback support

2018-02-23 Thread Rob Clark
In a way, based on the original writeback patch from Jilai Wang, but a lot has shifted around since then. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 23 +-

[Freedreno] [RFC 0/4] drm/msm/mdp5: writeback connector support

2018-02-23 Thread Rob Clark
(Sorry, meant to send this earlier, but got distracted on other things) The first two patches are Brian Starkey's earlier writeback-connector patches, with very minor rebasing to drm-next/v4.16-rc1, plus one small addition to add atomic_commit() vfunc to the connector helpers, so that writeback

Re: [Freedreno] [DPU PATCH] drm/mipi: Remove Qualcomm-specific dsi packet header format

2018-02-23 Thread Abhinav Kumar
Looks good. Can you point us to the fix done in the dsi-staging driver. Thanks Abhinav -Original Message- From: Rob Clark [mailto:robdcl...@gmail.com] Sent: Thursday, February 22, 2018 11:49 AM To: Sean Paul Cc: freedreno ;