Re: [Freedreno] [PATCH 4/5] drm/msm/dsi: implement 6G v2.0+ DSI command broadcast

2018-03-12 Thread Archit Taneja
On Monday 12 March 2018 06:53 PM, Sibi S wrote: From: Archit Taneja I'm a bit uncertain about using this patch in its current state. Some reasons below. Add command broadcast support for DSI 6G v2.0+ controller on SDM845 Signed-off-by: Sibi S

Re: [Freedreno] [PATCH 3/5] drm/msm/dsi: replace version checks with helper functions

2018-03-12 Thread Archit Taneja
On Monday 12 March 2018 06:53 PM, Sibi S wrote: Replace version checks with the helper functions bound to cfg_handler for DSI v2 and DSI 6G 1.x controllers With the ops set up for DSI6G 2.x too: Reviewed-by: Archit Taneja Thanks, Archit Signed-off-by: Sibi S

Re: [Freedreno] [PATCH 2/5] drm/msm/dsi: add implementation for helper functions

2018-03-12 Thread Archit Taneja
On Monday 12 March 2018 06:53 PM, Sibi S wrote: Add dsi host helper function implementation for DSI v2 and DSI 6G 1.x controllers Signed-off-by: Sibi S --- drivers/gpu/drm/msm/dsi/dsi.h | 15 +++ drivers/gpu/drm/msm/dsi/dsi_cfg.c | 44 +--

Re: [Freedreno] [DPU PATCH 10/11] drm/msm: Switch to atomic_helper_commit()

2018-03-12 Thread abhinavk
On 2018-03-12 13:32, Sean Paul wrote: On Thu, Mar 08, 2018 at 07:28:08PM -0800, abhin...@codeaurora.org wrote: On 2018-02-28 11:19, Sean Paul wrote: > Now that all of the msm-specific goo is tucked safely away we can switch > over to using the atomic helper commit directly. \o/ > [Abhinav] Can

Re: [Freedreno] [DPU PATCH] drm/msm: Remove dpu_edid_parser

2018-03-12 Thread abhinavk
On 2018-03-12 13:11, Sean Paul wrote: On Mon, Feb 26, 2018 at 02:23:40PM -0800, abhin...@codeaurora.org wrote: On 2018-02-26 07:36, Sean Paul wrote: > On Fri, Feb 23, 2018 at 05:48:48PM -0500, Rob Clark wrote: > > On Fri, Feb 23, 2018 at 5:31 PM, wrote: > > > The

Re: [Freedreno] [DPU PATCH 07/11] drm/msm: Use atomic private_obj instead of subclassing

2018-03-12 Thread Sean Paul
On Thu, Mar 08, 2018 at 05:59:11PM -0800, Jeykumar Sankaran wrote: > On 2018-02-28 11:19, Sean Paul wrote: > > Instead of subclassing atomic state, store driver private data in > > private_obj/state. This allows us to remove the swap_state driver hook > > for mdp5 and get closer to using the

Re: [Freedreno] [DPU PATCH 06/11] drm/msm: Remove msm_commit/kthread, use atomic helper commit

2018-03-12 Thread Sean Paul
On Thu, Mar 08, 2018 at 05:08:03PM -0800, Jeykumar Sankaran wrote: > On 2018-03-02 06:56, Sean Paul wrote: > > On Thu, Mar 01, 2018 at 07:37:10PM -0500, Rob Clark wrote: > > > On Thu, Mar 1, 2018 at 3:37 PM, wrote: > > > > On 2018-03-01 07:27, Sean Paul wrote: > > > >> > >

Re: [Freedreno] [DPU PATCH 02/11] drm/msm: Don't duplicate modeset_enables atomic helper

2018-03-12 Thread Sean Paul
On Thu, Mar 08, 2018 at 04:56:01PM -0800, Jeykumar Sankaran wrote: > On 2018-02-28 11:18, Sean Paul wrote: > > Instead, shuffle things around so we kickoff crtc after enabling encoder > > during modesets. Also moves the vblank wait to after the frame. > > > > Change-Id:

Re: [Freedreno] [DPU PATCH 01/11] drm/msm: Skip seamless disables in crtc/encoder

2018-03-12 Thread Sean Paul
On Fri, Mar 02, 2018 at 04:04:24PM -0800, jsa...@codeaurora.org wrote: > On 2018-02-28 11:18, Sean Paul wrote: > > Instead of duplicating whole swaths of atomic helper functions (which > > are already out-of-date), just skip the encoder/crtc disables in the > > .disable hooks. > > > > Change-Id:

Re: [Freedreno] [DPU PATCH] msm/hdcp: Remove redundant stubs/CONFIG

2018-03-12 Thread Sean Paul
On Tue, Feb 27, 2018 at 11:24:31AM -0500, Sean Paul wrote: > On Mon, Feb 26, 2018 at 03:01:14PM -0800, abhin...@codeaurora.org wrote: > > The change itself is okay. So, Reviewed-by? Sean > > However I am planning to do a bigger cleanup here > > ( removing the entire hdmi_hdcp.c ). > > > > We

Re: [Freedreno] [DPU PATCH] drm/msm: Remove dpu_edid_parser

2018-03-12 Thread Sean Paul
On Mon, Feb 26, 2018 at 02:23:40PM -0800, abhin...@codeaurora.org wrote: > On 2018-02-26 07:36, Sean Paul wrote: > > On Fri, Feb 23, 2018 at 05:48:48PM -0500, Rob Clark wrote: > > > On Fri, Feb 23, 2018 at 5:31 PM, wrote: > > > > The bitmaps in drm_hdmi_info dont seem to

Re: [Freedreno] [PATCH RESEND 08/10] drm/msm: Sprinkle pm_runtime calls around

2018-03-12 Thread Sean Paul
On Thu, Mar 08, 2018 at 04:14:38PM -0800, Jeykumar Sankaran wrote: > On 2018-02-21 07:18, Sean Paul wrote: > > Adding missing pm_runtime references where appropriate. > > > > Signed-off-by: Sean Paul > > --- > > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 3 +++ > >

Re: [Freedreno] [PATCH 2/5] drm/msm/dsi: add implementation for helper functions

2018-03-12 Thread Jordan Crouse
On Mon, Mar 12, 2018 at 06:53:11PM +0530, Sibi S wrote: > Add dsi host helper function implementation for DSI v2 > and DSI 6G 1.x controllers > > Signed-off-by: Sibi S > --- > drivers/gpu/drm/msm/dsi/dsi.h | 15 +++ > drivers/gpu/drm/msm/dsi/dsi_cfg.c | 44 +--

[Freedreno] [PATCH 1/5] drm/msm/dsi: add dsi host helper functions support

2018-03-12 Thread Sibi S
Add dsi host helper functions support for DSI v2 and DSI 6G 1.x controllers that are under version checks Signed-off-by: Sibi S --- drivers/gpu/drm/msm/dsi/dsi.h | 1 + drivers/gpu/drm/msm/dsi/dsi_cfg.h | 12 2 files changed, 13 insertions(+) diff --git

[Freedreno] [PATCH 0/5] Cleanup excessive DSI host controller version checks

2018-03-12 Thread Sibi S
This patch series aims to create and bind dsi host controller helper functions to functionalities that vary across DSI v2, DSI 6G 1.x and DSI 6G v2.0+ controllers. These functionalities are currently under excessive version checks which is now replaced with the corresponding helper function. This

[Freedreno] [PATCH 4/5] drm/msm/dsi: implement 6G v2.0+ DSI command broadcast

2018-03-12 Thread Sibi S
From: Archit Taneja Add command broadcast support for DSI 6G v2.0+ controller on SDM845 Signed-off-by: Sibi S --- drivers/gpu/drm/msm/dsi/dsi.h | 5 +++ drivers/gpu/drm/msm/dsi/dsi_cfg.c | 14 +++-

[Freedreno] [PATCH 2/5] drm/msm/dsi: add implementation for helper functions

2018-03-12 Thread Sibi S
Add dsi host helper function implementation for DSI v2 and DSI 6G 1.x controllers Signed-off-by: Sibi S --- drivers/gpu/drm/msm/dsi/dsi.h | 15 +++ drivers/gpu/drm/msm/dsi/dsi_cfg.c | 44 +-- drivers/gpu/drm/msm/dsi/dsi_host.c | 250

[Freedreno] [DPU PATCH] drm/msm: fix compilation warnings in display driver

2018-03-12 Thread Sravanthi Kollukuduru
Fix the compilation warnings flagged in display driver. Signed-off-by: Sravanthi Kollukuduru --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 3 --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.c | 4 ++-- 2 files changed, 2 insertions(+), 5 deletions(-) diff