Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

2018-04-18 Thread Bjorn Andersson
On Wed 18 Apr 21:23 PDT 2018, abhin...@codeaurora.org wrote: > Hi Bjorn > Hi Abhinav, > Thanks very much for the detailed response. > You're welcome. > Yes, we decided that userspace hardcoding this node name is not a > strong enough reason to register as another backlight device. > > Had

Re: [Freedreno] [[RFC]DPU PATCH 1/4] drm/bridge: add support for sn65dsi86 bridge driver

2018-04-18 Thread spanda
On 2018-04-18 19:41, Sean Paul wrote: On Wed, Apr 18, 2018 at 05:49:59PM +0530, Sandeep Panda wrote: Add support for TI's sn65dsi86 dsi2edp bridge chip. The chip converts DSI transmitted signal to eDP signal, which is fed to the connected eDP panel. This chip can be controlled via either i2c

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

2018-04-18 Thread Bjorn Andersson
On Tue 17 Apr 17:42 PDT 2018, abhin...@codeaurora.org wrote: > Adding another point. > > On 2018-04-17 17:04, abhin...@codeaurora.org wrote: > > Hi Bjorn > > > > Apologies if the prev reply wasnt clear. > > > > Hope this one is. > > > > reply inline. > > > > On 2018-04-17 14:29, Bjorn

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

2018-04-18 Thread abhinavk
Hi Bjorn Thanks very much for the detailed response. Yes, we decided that userspace hardcoding this node name is not a strong enough reason to register as another backlight device. Had one follow up question though. The QC WLED driver, drivers/leds/leds-qpnp-wled.c is not registering

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

2018-04-18 Thread Bjorn Andersson
On Tue 17 Apr 17:04 PDT 2018, abhin...@codeaurora.org wrote: > Hi Bjorn > > Apologies if the prev reply wasnt clear. > > Hope this one is. > Much better, now we can discuss the actual issues :) > reply inline. > > On 2018-04-17 14:29, Bjorn Andersson wrote: > > On Tue 17 Apr 11:21 PDT 2018,

[Freedreno] [DPU PATCH v3 2/2] drm/msm/dsi: Use one connector for dual DSI mode

2018-04-18 Thread Chandan Uddaraju
Current DSI driver uses two connectors for dual DSI case even though we only have one panel. Fix this by implementing one connector/bridge for dual DSI use case. Use master DSI controllers to register one connector/bridge. Changes in V2: -Removed Change-Id from the commit text tags.

[Freedreno] [DPU PATCH v3 1/2] drm/msm/dsi: adjust dsi timing for dual dsi mode

2018-04-18 Thread Chandan Uddaraju
For dual dsi mode, the horizontal timing needs to be divided by half since both the dsi controllers will be driving this panel. Adjust the pixel clock and DSI timing accordingly. Changes in V2: --Removed Change-Id from the commit text tags. Changes in V3: --Instead of adjusting the DRM mode

[Freedreno] [DPU PATCH v3 0/2] Connector virtualization for Dual-DSI

2018-04-18 Thread Chandan Uddaraju
This patch series adds support to DSI connector virtualization for Dual-DSI configuration. These changes have been tested using dual-dsi truly panel on sdm845 platform. Additional changes that will be needed to have end-to-end functionality: --> DSI6G-v2 changes:

[Freedreno] [PULL] msm fixes/improvements

2018-04-18 Thread Sean Paul
Hey Rob, Here's a few patches from the DPU sets that can go into msm as-is. In addition to these, there is the atomic helper conversion that I am anxious to get in as well. If you'd like, I can round those up into a PR, but the latest version should be bundled up in a set on the ML. I've tested

Re: [Freedreno] [[RFC]DPU PATCH 0/4] Add suppport for sn65dsi86 bridge chip and Innolux 2k edp panel driver

2018-04-18 Thread spanda
On 2018-04-18 19:42, Sean Paul wrote: On Wed, Apr 18, 2018 at 05:49:58PM +0530, Sandeep Panda wrote: Changelog: v3 -> v4: I didn't really bother to do a thorough review given that there are obvious mistakes and ignored feedback, it's a waste of time, tbh. Please go through the previous

Re: [Freedreno] [[RFC]DPU PATCH 1/4] drm/bridge: add support for sn65dsi86 bridge driver

2018-04-18 Thread spanda
On 2018-04-18 19:41, Sean Paul wrote: On Wed, Apr 18, 2018 at 05:49:59PM +0530, Sandeep Panda wrote: Add support for TI's sn65dsi86 dsi2edp bridge chip. The chip converts DSI transmitted signal to eDP signal, which is fed to the connected eDP panel. This chip can be controlled via either i2c

Re: [Freedreno] [[RFC]DPU PATCH 0/4] Add suppport for sn65dsi86 bridge chip and Innolux 2k edp panel driver

2018-04-18 Thread Sean Paul
On Wed, Apr 18, 2018 at 05:49:58PM +0530, Sandeep Panda wrote: > Changelog: > > v3 -> v4: I didn't really bother to do a thorough review given that there are obvious mistakes and ignored feedback, it's a waste of time, tbh. Please go through the previous reviews and resend a more polished

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

2018-04-18 Thread Sean Paul
On Wed, Apr 18, 2018 at 11:52:18AM +0100, Daniel Thompson wrote: > On Tue, Apr 17, 2018 at 05:42:04PM -0700, abhin...@codeaurora.org wrote: > > Adding another point. > > > > On 2018-04-17 17:04, abhin...@codeaurora.org wrote: > > > Hi Bjorn > > > > > > Apologies if the prev reply wasnt clear. >

[Freedreno] [[RFC]DPU PATCH 4/4] dt-bindings: Add Innolux TV123WAM panel bindings

2018-04-18 Thread Sandeep Panda
The Innolux TV123WAM is a 12.3" eDP display panel with 2160x1440 resolution. Signed-off-by: Sandeep Panda --- .../bindings/display/panel/innolux,edp-2k-panel.txt | 21 + 1 file changed, 21 insertions(+) create mode 100644

[Freedreno] [[RFC]DPU PATCH 1/4] drm/bridge: add support for sn65dsi86 bridge driver

2018-04-18 Thread Sandeep Panda
Add support for TI's sn65dsi86 dsi2edp bridge chip. The chip converts DSI transmitted signal to eDP signal, which is fed to the connected eDP panel. This chip can be controlled via either i2c interface or dsi interface. Currently in driver all the control registers are being accessed through i2c

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

2018-04-18 Thread Daniel Thompson
On Tue, Apr 17, 2018 at 05:42:04PM -0700, abhin...@codeaurora.org wrote: > Adding another point. > > On 2018-04-17 17:04, abhin...@codeaurora.org wrote: > > Hi Bjorn > > > > Apologies if the prev reply wasnt clear. > > > > Hope this one is. > > > > reply inline. > > > > On 2018-04-17 14:29,

[Freedreno] [PATCH] drm: Print unadorned pointers

2018-04-18 Thread Alexey Brodkin
After commit ad67b74 ("printk: hash addresses printed with %p") pointers are being hashed when printed. However, this makes debug output completely useless. Switch to %px in order to see the unadorned kernel pointers. This was done with the following one-liner: find drivers/gpu/drm -type f -name

Re: [Freedreno] [PATCH] drm: Print unadorned pointers

2018-04-18 Thread Maarten Lankhorst
Op 18-04-18 om 11:24 schreef Alexey Brodkin: > After commit ad67b74 ("printk: hash addresses printed with %p") > pointers are being hashed when printed. However, this makes > debug output completely useless. Switch to %px in order to see the > unadorned kernel pointers. > > This was done with the