Re: [Freedreno] [PATCH 1/5] drm/msm: Fix improper uses of smp_mb__{before, after}_atomic()

2019-05-09 Thread Andrea Parri
On Mon, Apr 29, 2019 at 10:14:57PM +0200, Andrea Parri wrote: > These barriers only apply to the read-modify-write operations; in > particular, they do not apply to the atomic_set() primitive. > > Replace the barriers with smp_mb()s. > > Fixes: b1fc2839d2f92 ("drm/msm: Implement preemption for A5

Re: [Freedreno] [PATCH 2/3] drm/msm/dpu: Avoid a null de-ref while recovering from kms init fail

2019-05-09 Thread Kristian Høgsberg
On Tue, May 7, 2019 at 12:18 PM Jordan Crouse wrote: > > In the failure path for dpu_kms_init() it is possible to get to the MMU > destroy function with uninitialized MMU structs. Check for NULl and skip s/NULl/NULL > if needed. > > Signed-off-by: Jordan Crouse Reviewed-by: Kristian H. Kristen

Re: [Freedreno] [PATCH v1 2/3] drm/msm: Print all 64 bits of the faulting IOMMU address

2019-05-09 Thread Kristian Høgsberg
On Tue, May 7, 2019 at 11:02 AM Jordan Crouse wrote: > > When we move to 64 bit addressing for a5xx and a6xx targets we will start > seeing pagefaults at larger addresses so format them appropriately in the > log message for easier debugging. Yes please, this has confused me more than once. Revi

Re: [Freedreno] [PATCH RFC 4/6] ARM: dts: msm8974: add display support

2019-05-09 Thread Bjorn Andersson
On Thu 09 May 00:12 PDT 2019, Brian Masney wrote: > On Wed, May 08, 2019 at 08:00:47PM -0700, Bjorn Andersson wrote: > > On Wed 08 May 19:25 PDT 2019, Rob Clark wrote: > > > > > On Wed, May 8, 2019 at 7:16 PM Brian Masney wrote: > > > > > > > > On Mon, May 06, 2019 at 11:39:02PM -0700, Bjorn And

Re: [Freedreno] [PATCH RFC 4/6] ARM: dts: msm8974: add display support

2019-05-09 Thread Rob Clark
On Thu, May 9, 2019 at 12:12 AM Brian Masney wrote: > > On Wed, May 08, 2019 at 08:00:47PM -0700, Bjorn Andersson wrote: > > On Wed 08 May 19:25 PDT 2019, Rob Clark wrote: > > > > > On Wed, May 8, 2019 at 7:16 PM Brian Masney wrote: > > > > > > > > On Mon, May 06, 2019 at 11:39:02PM -0700, Bjorn

Re: [Freedreno] [PATCH RFC 4/6] ARM: dts: msm8974: add display support

2019-05-09 Thread Brian Masney
On Wed, May 08, 2019 at 08:00:47PM -0700, Bjorn Andersson wrote: > On Wed 08 May 19:25 PDT 2019, Rob Clark wrote: > > > On Wed, May 8, 2019 at 7:16 PM Brian Masney wrote: > > > > > > On Mon, May 06, 2019 at 11:39:02PM -0700, Bjorn Andersson wrote: > > > > On Sun 05 May 06:04 PDT 2019, Brian Masne