Re: [Freedreno] [v4,1/3] drm/msm: Add support for GPU cooling

2020-10-29 Thread Akhil P Oommen
On 10/30/2020 2:18 AM, m...@chromium.org wrote: On Thu, Oct 29, 2020 at 01:37:19PM +0530, Akhil P Oommen wrote: Register GPU as a devfreq cooling device so that it can be passively cooled by the thermal framework. Signed-off-by: Akhil P Oommen Reviewed-by: Matthias Kaehlcke Wait, I did not

Re: [Freedreno] [PATCH 1/4] drm: allow drm_atomic_print_state() to accept any drm_printer

2020-10-29 Thread abhinavk
Hi Daniel On 2020-10-22 03:38, Daniel Vetter wrote: On Wed, Oct 21, 2020 at 10:01:45PM -0700, Abhinav Kumar wrote: Currently drm_atomic_print_state() internally allocates and uses a drm_info printer. Allow it to accept any drm_printer type so that the API can be leveraged even for taking drm

[Freedreno] [PATCH v2 4/4] drm/msm/dpu: add dpu_dbg points across dpu driver

2020-10-29 Thread Abhinav Kumar
Add dpu_dbg points across dpu driver to trigger dumps when critical errors are hit. changes in v2: none Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 12 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 5 +++--

[Freedreno] [PATCH v2 3/4] drm/msm: register the base address with dpu_dbg module

2020-10-29 Thread Abhinav Kumar
Register the base address of various dpu sub-modules with the dpu_dbg module so that it can be dumped out during error scenarios. changes in v2: - Fix an issue where the same dsi client was getting registered multiple times to the dpu_dbg module Signed-off-by: Abhinav Kumar ---

[Freedreno] [PATCH v2 2/4] drm/msm/dpu: add support to dump dpu registers

2020-10-29 Thread Abhinav Kumar
Add the dpu_dbg module which adds supports to dump dpu registers which can be used in case of error conditions. changes in v2: Fix kbot errors Reported-by: kernel test robot Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/Makefile | 2 +

[Freedreno] [PATCH v2 1/4] drm: allow drm_atomic_print_state() to accept any drm_printer

2020-10-29 Thread Abhinav Kumar
Currently drm_atomic_print_state() internally allocates and uses a drm_info printer. Allow it to accept any drm_printer type so that the API can be leveraged even for taking drm snapshot. Rename the drm_atomic_print_state() to drm_atomic_print_new_state() so that it reflects its functionality

[Freedreno] [PATCH v2 0/4] Add devcoredump support for DPU

2020-10-29 Thread Abhinav Kumar
This series adds support to use devcoredump for DPU driver. It introduces the dpu_dbg module which assists in the capturing of register dumps during error scenarios. When a display related error happens, the dpu_dbg module captures all the relevant register dumps along with the snapshot of the drm

[Freedreno] [PATCH] drm/msm/dp: do not notify audio subsystem if sink doesn't support audio

2020-10-29 Thread Abhinav Kumar
For sinks that do not support audio, there is no need to notify audio subsystem of the connection event. This will make sure that audio routes only to the primary display when connected to such sinks. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_display.c | 12 ++-- 1

Re: [Freedreno] [v4,1/3] drm/msm: Add support for GPU cooling

2020-10-29 Thread mka
On Thu, Oct 29, 2020 at 01:37:19PM +0530, Akhil P Oommen wrote: > Register GPU as a devfreq cooling device so that it can be passively > cooled by the thermal framework. > > Signed-off-by: Akhil P Oommen > Reviewed-by: Matthias Kaehlcke Wait, I did not post a 'Reviewed-by' tag for this patch!

[Freedreno] [PATCH 1/2] drm: msm: adreno: use DEFINE_DEBUGFS_ATTRIBUTE with debugfs_create_file_unsafe()

2020-10-29 Thread Deepak R Varma
Using DEFINE_DEBUGFS_ATTRIBUTE macro with debugfs_create_file_unsafe() function in place of the debugfs_create_file() function will make the file operation struct "reset" aware of the file's lifetime. Additional details here: https://lists.archive.carbon60.com/linux/kernel/2369498 Issue reported

[Freedreno] [PATCH 2/2] drm: msm: adreno: improve code indentation & alignment

2020-10-29 Thread Deepak R Varma
Align instructions split across multiple lines as per the coding standards. Issue flagged by checkpatch script. Signed-off-by: Deepak R Varma --- Please note: This is a project task specific patch. drivers/gpu/drm/msm/adreno/a5xx_debugfs.c | 10 +- 1 file changed, 5 insertions(+), 5

Re: [Freedreno] [PATCH v4 23/23] drm/msm: Don't implicit-sync if only a single ring

2020-10-29 Thread Daniel Vetter
On Thu, Oct 29, 2020 at 09:59:09AM -0700, Rob Clark wrote: > On Thu, Oct 29, 2020 at 9:14 AM Daniel Vetter wrote: > > > > On Mon, Oct 26, 2020 at 10:34 AM Daniel Vetter wrote: > > > > > > On Fri, Oct 23, 2020 at 08:49:14PM -0700, Rob Clark wrote: > > > > On Fri, Oct 23, 2020 at 11:20 AM Lucas

Re: [Freedreno] [PATCH v4 23/23] drm/msm: Don't implicit-sync if only a single ring

2020-10-29 Thread Rob Clark
On Thu, Oct 29, 2020 at 9:14 AM Daniel Vetter wrote: > > On Mon, Oct 26, 2020 at 10:34 AM Daniel Vetter wrote: > > > > On Fri, Oct 23, 2020 at 08:49:14PM -0700, Rob Clark wrote: > > > On Fri, Oct 23, 2020 at 11:20 AM Lucas Stach > > > wrote: > > > > > > > > On Fr, 2020-10-23 at 09:51 -0700,

Re: [Freedreno] [PATCH v4 23/23] drm/msm: Don't implicit-sync if only a single ring

2020-10-29 Thread Daniel Vetter
On Mon, Oct 26, 2020 at 10:34 AM Daniel Vetter wrote: > > On Fri, Oct 23, 2020 at 08:49:14PM -0700, Rob Clark wrote: > > On Fri, Oct 23, 2020 at 11:20 AM Lucas Stach wrote: > > > > > > On Fr, 2020-10-23 at 09:51 -0700, Rob Clark wrote: > > > > From: Rob Clark > > > > > > > > If there is only a

[Freedreno] [PATCH v4 3/3] dt-bindings: drm/msm/gpu: Add cooling device support

2020-10-29 Thread Akhil P Oommen
Add cooling device support to gpu. A cooling device is bound to a thermal zone to allow thermal mitigation. Signed-off-by: Akhil P Oommen --- Documentation/devicetree/bindings/display/msm/gpu.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git

[Freedreno] [PATCH v4 2/3] arm64: dts: qcom: sc7180: Add gpu cooling support

2020-10-29 Thread Akhil P Oommen
Add cooling-cells property and the cooling maps for the gpu tzones to support GPU cooling. Signed-off-by: Akhil P Oommen Reviewed-by: Matthias Kaehlcke --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 30 +++--- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git

[Freedreno] [PATCH v4 1/3] drm/msm: Add support for GPU cooling

2020-10-29 Thread Akhil P Oommen
Register GPU as a devfreq cooling device so that it can be passively cooled by the thermal framework. Signed-off-by: Akhil P Oommen Reviewed-by: Matthias Kaehlcke --- Changes in v4: 1. Fix gpu cooling map. 2. Add mka's Reviewed-by tag. Changes in v3: 1. Minor fix in

Re: [Freedreno] [v3, 2/3] arm64: dts: qcom: sc7180: Add gpu cooling support

2020-10-29 Thread Akhil P Oommen
On 10/29/2020 6:09 AM, m...@chromium.org wrote: Hi Akhil, On Wed, Oct 28, 2020 at 07:09:53PM +0530, Akhil P Oommen wrote: Add cooling-cells property and the cooling maps for the gpu tzones to support GPU cooling. Signed-off-by: Akhil P Oommen --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 30