Re: [Freedreno] [v3] drm/msm/disp/dpu1: turn off vblank irqs aggressively in dpu

2021-02-12 Thread Rob Clark
On Fri, Feb 12, 2021 at 3:45 AM Kalyan Thota wrote: > > Set the flag vblank_disable_immediate = true to turn off vblank irqs > immediately as soon as drm_vblank_put is requested so that there are > no irqs triggered during idle state. This will reduce cpu wakeups > and help in power saving. > >

Re: [Freedreno] [v2] drm/msm/disp/dpu1: turn off vblank irqs aggressively in dpu driver

2021-02-12 Thread Rob Clark
On Thu, Feb 11, 2021 at 7:31 AM wrote: > > On 2021-02-11 01:56, Rob Clark wrote: > > On Wed, Feb 10, 2021 at 3:41 AM wrote: > >> > >> On 2021-02-01 00:46, Rob Clark wrote: > >> > On Fri, Dec 18, 2020 at 2:27 AM Kalyan Thota > >> > wrote: > >> >> > >> >> Set the flag vblank_disable_immediate =

Re: [Freedreno] [PATCH] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features

2021-02-12 Thread Robert Foss
Hey Nicolas, Thanks for submitting this, making these flags more intuitive is really nice. This looks good to me, feel free to add my r-b. Reviewed-by: Robert Foss On Thu, 11 Feb 2021 at 04:34, Nicolas Boichat wrote: > > Many of the DSI flags have names opposite to their actual effects, >

[Freedreno] [v3] drm/msm/disp/dpu1: turn off vblank irqs aggressively in dpu

2021-02-12 Thread Kalyan Thota
Set the flag vblank_disable_immediate = true to turn off vblank irqs immediately as soon as drm_vblank_put is requested so that there are no irqs triggered during idle state. This will reduce cpu wakeups and help in power saving. To enable vblank_disable_immediate flag the underlying KMS driver

[Freedreno] [v3] drm/msm/disp/dpu1: turn off vblank irqs aggressively in dpu

2021-02-12 Thread Kalyan Thota
From: Kalyan Thota Set the flag vblank_disable_immediate = true to turn off vblank irqs immediately as soon as drm_vblank_put is requested so that there are no irqs triggered during idle state. This will reduce cpu wakeups and help in power saving. To enable vblank_disable_immediate flag the

Re: [Freedreno] [PATCH] drm/msm/dp: Add a missing semi-colon

2021-02-12 Thread Joe Perches
On Mon, 2021-02-08 at 10:57 -0800, Stephen Boyd wrote: > Quoting Joe Perches (2021-02-06 21:06:54) > > Wow, that's really unfortunate that dp_panel_update_tu_timings > > is also void. > > > > Perhaps this as YA checkpatch warning: > > > > --- > > Acked-by: Stephen Boyd Are you acking the