Re: [Freedreno] [PATCH] drm/msm/adreno: make adreno_is_a690()'s argument const

2023-06-14 Thread Doug Anderson
Hi, On Mon, Jun 12, 2023 at 11:25 AM Dmitry Baryshkov wrote: > > Change adreno_is_a690() prototype to accept the const struct adreno_gpu > pointer instead of a non-const one. This fixes the following warning: > > In file included from drivers/gpu/drm/msm/msm_drv.c:33: >

Re: [Freedreno] [PATCH] drm/msm/adreno: make adreno_is_a690()'s argument const

2023-06-14 Thread Rob Clark
On Mon, Jun 12, 2023 at 11:25 AM Dmitry Baryshkov wrote: > > Change adreno_is_a690() prototype to accept the const struct adreno_gpu > pointer instead of a non-const one. This fixes the following warning: > > In file included from drivers/gpu/drm/msm/msm_drv.c:33: >

Re: [Freedreno] [PATCH 2/2] drm/msm/dsi: split dsi_ctrl_config() function

2023-06-14 Thread Marijn Suijten
On 2023-06-15 01:44:02, Dmitry Baryshkov wrote: > It makes no sense to pass NULL parameters to dsi_ctrl_config() in the > disable case. Split dsi_ctrl_config() into enable and disable parts and > drop unused params. > > Signed-off-by: Dmitry Baryshkov Indeed, it makes much more sense to split

Re: [Freedreno] [PATCH 1/2] drm/msm/dsi: dsi_host: drop unused clocks

2023-06-14 Thread Marijn Suijten
On 2023-06-15 01:44:01, Dmitry Baryshkov wrote: > Several source clocks are not used anymore, so stop handling them. > > Signed-off-by: Dmitry Baryshkov Indeed, we were not using these parent clocks for anything. Reviewed-by: Marijn Suijten > --- > drivers/gpu/drm/msm/dsi/dsi_host.c | 33

Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: Add DPU_INTF_DATABUS_WIDEN feature flag for DPU >= 5.0

2023-06-14 Thread Marijn Suijten
On 2023-06-14 14:23:38, Marijn Suijten wrote: > Tested this on SM8350 which actually has DSI 2.5, and it is also > corrupted with this series so something else on this series might be > broken. Never mind, this was a bad conflict-resolve. Jessica's original BURST_MODE patch was RMW'ing

Re: [Freedreno] [PATCH] drm/msm/dsi: Enable BURST_MODE for command mode for DSI 6G v1.3+

2023-06-14 Thread Dmitry Baryshkov
On 13/06/2023 02:37, Jessica Zhang wrote: During a frame transfer in command mode, there could be frequent LP11 <-> HS transitions when multiple DCS commands are sent mid-frame or if the DSI controller is running on slow clock and is throttled. To minimize frame latency due to these transitions,

[Freedreno] [PATCH 2/2] drm/msm/dsi: split dsi_ctrl_config() function

2023-06-14 Thread Dmitry Baryshkov
It makes no sense to pass NULL parameters to dsi_ctrl_config() in the disable case. Split dsi_ctrl_config() into enable and disable parts and drop unused params. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi_host.c | 18 +- 1 file changed, 9 insertions(+), 9

[Freedreno] [PATCH 1/2] drm/msm/dsi: dsi_host: drop unused clocks

2023-06-14 Thread Dmitry Baryshkov
Several source clocks are not used anymore, so stop handling them. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi_host.c | 33 -- 1 file changed, 33 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c

Re: [Freedreno] [PATCH v2 0/3] drm/msm/adreno: GPU support on SC8280XP

2023-06-14 Thread Bjorn Andersson
On Wed, Jun 14, 2023 at 09:03:34AM -0700, Bjorn Andersson wrote: > On Mon, 22 May 2023 18:15:19 -0700, Bjorn Andersson wrote: > > This series introduces support for A690 in the DRM/MSM driver and > > enables it for the two SC8280XP laptops. > > > > Bjorn Andersson (3): > > drm/msm/adreno: Add

Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: Add DPU_INTF_DATABUS_WIDEN feature flag for DPU >= 5.0

2023-06-14 Thread Marijn Suijten
On 2023-06-14 13:39:57, Abhinav Kumar wrote: > On 6/14/2023 12:54 PM, Abhinav Kumar wrote: > > On 6/14/2023 12:35 PM, Abhinav Kumar wrote: > >> On 6/14/2023 5:23 AM, Marijn Suijten wrote: > >>> On 2023-06-14 15:01:59, Dmitry Baryshkov wrote: > On 14/06/2023 14:42, Marijn Suijten wrote: >

Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: Add DPU_INTF_DATABUS_WIDEN feature flag for DPU >= 5.0

2023-06-14 Thread Dmitry Baryshkov
On 14/06/2023 23:39, Abhinav Kumar wrote: On 6/14/2023 12:54 PM, Abhinav Kumar wrote: On 6/14/2023 12:35 PM, Abhinav Kumar wrote: On 6/14/2023 5:23 AM, Marijn Suijten wrote: On 2023-06-14 15:01:59, Dmitry Baryshkov wrote: On 14/06/2023 14:42, Marijn Suijten wrote: On 2023-06-13

Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: Add DPU_INTF_DATABUS_WIDEN feature flag for DPU >= 5.0

2023-06-14 Thread Abhinav Kumar
On 6/14/2023 12:54 PM, Abhinav Kumar wrote: On 6/14/2023 12:35 PM, Abhinav Kumar wrote: On 6/14/2023 5:23 AM, Marijn Suijten wrote: On 2023-06-14 15:01:59, Dmitry Baryshkov wrote: On 14/06/2023 14:42, Marijn Suijten wrote: On 2023-06-13 18:57:11, Jessica Zhang wrote: DPU 5.x+ supports

Re: [Freedreno] [PATCH] drm/msm/dpu: Configure DP INTF/PHY selector

2023-06-14 Thread Kuogee Hsieh
On 6/13/2023 9:07 AM, Bjorn Andersson wrote: On Tue, Jun 13, 2023 at 01:31:40AM +0300, Dmitry Baryshkov wrote: On 13/06/2023 01:10, Bjorn Andersson wrote: From: Bjorn Andersson Some platforms provides a mechanism for configuring the mapping between (one or two) DisplayPort intfs and their

Re: [Freedreno] [PATCH v8 18/18] drm/msm/a6xx: Add A610 speedbin support

2023-06-14 Thread Akhil P Oommen
On Mon, May 29, 2023 at 03:52:37PM +0200, Konrad Dybcio wrote: > > A610 is implemented on at least three SoCs: SM6115 (bengal), SM6125 > (trinket) and SM6225 (khaje). Trinket does not support speed binning > (only a single SKU exists) and we don't yet support khaje upstream. > Hence, add a fuse

Re: [Freedreno] [PATCH v8 17/18] drm/msm/a6xx: Add A619_holi speedbin support

2023-06-14 Thread Akhil P Oommen
On Mon, May 29, 2023 at 03:52:36PM +0200, Konrad Dybcio wrote: > > A619_holi is implemented on at least two SoCs: SM4350 (holi) and SM6375 > (blair). This is what seems to be a first occurrence of this happening, > but it's easy to overcome by guarding the SoC-specific fuse values with >

Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: Add DPU_INTF_DATABUS_WIDEN feature flag for DPU >= 5.0

2023-06-14 Thread Abhinav Kumar
On 6/14/2023 12:35 PM, Abhinav Kumar wrote: On 6/14/2023 5:23 AM, Marijn Suijten wrote: On 2023-06-14 15:01:59, Dmitry Baryshkov wrote: On 14/06/2023 14:42, Marijn Suijten wrote: On 2023-06-13 18:57:11, Jessica Zhang wrote: DPU 5.x+ supports a databus widen mode that allows more data to

Re: [Freedreno] [PATCH v8 16/18] drm/msm/a6xx: Use adreno_is_aXYZ macros in speedbin matching

2023-06-14 Thread Akhil P Oommen
On Mon, May 29, 2023 at 03:52:35PM +0200, Konrad Dybcio wrote: > > Before transitioning to using per-SoC and not per-Adreno speedbin > fuse values (need another patchset to land elsewhere), a good > improvement/stopgap solution is to use adreno_is_aXYZ macros in > place of explicit revision

Re: [Freedreno] [PATCH v8 15/18] drm/msm/a6xx: Use "else if" in GPU speedbin rev matching

2023-06-14 Thread Akhil P Oommen
On Mon, May 29, 2023 at 03:52:34PM +0200, Konrad Dybcio wrote: > > The GPU can only be one at a time. Turn a series of ifs into if + > elseifs to save some CPU cycles. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Konrad Dybcio Reviewed-by: Akhil P Oommen -Akhil > --- >

Re: [Freedreno] [PATCH v8 14/18] drm/msm/a6xx: Fix some A619 tunables

2023-06-14 Thread Akhil P Oommen
On Mon, May 29, 2023 at 03:52:33PM +0200, Konrad Dybcio wrote: > > Adreno 619 expects some tunables to be set differently. Make up for it. > > Fixes: b7616b5c69e6 ("drm/msm/adreno: Add A619 support") > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Konrad Dybcio > --- >

Re: [Freedreno] [PATCH v8 13/18] drm/msm/a6xx: Add A610 support

2023-06-14 Thread Akhil P Oommen
On Mon, May 29, 2023 at 03:52:32PM +0200, Konrad Dybcio wrote: > > A610 is one of (if not the) lowest-tier SKUs in the A6XX family. It > features no GMU, as it's implemented solely on SoCs with SMD_RPM. > What's more interesting is that it does not feature a VDDGX line > either, being powered

Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: Add DPU_INTF_DATABUS_WIDEN feature flag for DPU >= 5.0

2023-06-14 Thread Abhinav Kumar
On 6/14/2023 5:23 AM, Marijn Suijten wrote: On 2023-06-14 15:01:59, Dmitry Baryshkov wrote: On 14/06/2023 14:42, Marijn Suijten wrote: On 2023-06-13 18:57:11, Jessica Zhang wrote: DPU 5.x+ supports a databus widen mode that allows more data to be sent per pclk. Enable this feature flag on

Re: [Freedreno] [PATCH 0/3] drm/msm/adreno: GPU support on SC8280XP

2023-06-14 Thread Bjorn Andersson
On Tue, 7 Feb 2023 19:40:49 -0800, Bjorn Andersson wrote: > This series introduces support for A690 in the DRM/MSM driver and > enables it for the two SC8280XP laptops. > > Bjorn Andersson (3): > drm/msm/adreno: Add Adreno A690 support > arm64: dts: qcom: sc8280xp: Add GPU related nodes >

Re: [Freedreno] [PATCH v4 0/2] drm/msm/adreno: GPU support on SC8280XP

2023-06-14 Thread Bjorn Andersson
On Wed, 14 Jun 2023 07:22:02 -0700, Bjorn Andersson wrote: > With the A690 support merged in the drm/msm driver, this series adds the > DeviceTree pieces to make it go on sc8280xp. > > Note that in order for the GPU driver to probe, the last change > requires (which is now in linux-next): >

Re: [Freedreno] [PATCH v2 0/3] drm/msm/adreno: GPU support on SC8280XP

2023-06-14 Thread Bjorn Andersson
On Mon, 22 May 2023 18:15:19 -0700, Bjorn Andersson wrote: > This series introduces support for A690 in the DRM/MSM driver and > enables it for the two SC8280XP laptops. > > Bjorn Andersson (3): > drm/msm/adreno: Add Adreno A690 support > arm64: dts: qcom: sc8280xp: Add GPU related nodes >

Re: [Freedreno] [PATCH v4 2/2] arm64: dts: qcom: sc8280xp: Enable GPU related nodes

2023-06-14 Thread Bjorn Andersson
On Wed, Jun 14, 2023 at 05:27:24PM +0200, Konrad Dybcio wrote: > On 14.06.2023 16:22, Bjorn Andersson wrote: > > From: Bjorn Andersson > > > > Add memory reservation for the zap-shader and enable the Adreno SMMU, > > GPU clock controller, GMU and the GPU nodes for the SC8280XP CRD and the > >

Re: [Freedreno] [PATCH v4 2/2] arm64: dts: qcom: sc8280xp: Enable GPU related nodes

2023-06-14 Thread Konrad Dybcio
On 14.06.2023 16:22, Bjorn Andersson wrote: > From: Bjorn Andersson > > Add memory reservation for the zap-shader and enable the Adreno SMMU, > GPU clock controller, GMU and the GPU nodes for the SC8280XP CRD and the > Lenovo ThinkPad X13s. > > Tested-by: Steev Klimaszewski > Signed-off-by:

Re: [Freedreno] [PATCH v4 1/2] arm64: dts: qcom: sc8280xp: Add GPU related nodes

2023-06-14 Thread Konrad Dybcio
On 14.06.2023 16:22, Bjorn Andersson wrote: > From: Bjorn Andersson > > Add Adreno SMMU, GPU clock controller, GMU and GPU nodes for the > SC8280XP. > > Tested-by: Steev Klimaszewski > Signed-off-by: Bjorn Andersson > Tested-by: Johan Hovold > Signed-off-by: Bjorn Andersson > ---

[Freedreno] [PATCH v4 2/2] arm64: dts: qcom: sc8280xp: Enable GPU related nodes

2023-06-14 Thread Bjorn Andersson
From: Bjorn Andersson Add memory reservation for the zap-shader and enable the Adreno SMMU, GPU clock controller, GMU and the GPU nodes for the SC8280XP CRD and the Lenovo ThinkPad X13s. Tested-by: Steev Klimaszewski Signed-off-by: Bjorn Andersson Tested-by: Johan Hovold Signed-off-by: Bjorn

[Freedreno] [PATCH v4 1/2] arm64: dts: qcom: sc8280xp: Add GPU related nodes

2023-06-14 Thread Bjorn Andersson
From: Bjorn Andersson Add Adreno SMMU, GPU clock controller, GMU and GPU nodes for the SC8280XP. Tested-by: Steev Klimaszewski Signed-off-by: Bjorn Andersson Tested-by: Johan Hovold Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/sa8540p.dtsi | 8 ++

[Freedreno] [PATCH v4 0/2] drm/msm/adreno: GPU support on SC8280XP

2023-06-14 Thread Bjorn Andersson
With the A690 support merged in the drm/msm driver, this series adds the DeviceTree pieces to make it go on sc8280xp. Note that in order for the GPU driver to probe, the last change requires (which is now in linux-next):

Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: Add DPU_INTF_DATABUS_WIDEN feature flag for DPU >= 5.0

2023-06-14 Thread Marijn Suijten
On 2023-06-14 15:01:59, Dmitry Baryshkov wrote: > On 14/06/2023 14:42, Marijn Suijten wrote: > > On 2023-06-13 18:57:11, Jessica Zhang wrote: > >> DPU 5.x+ supports a databus widen mode that allows more data to be sent > >> per pclk. Enable this feature flag on all relevant chipsets. > >> > >>

Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: Add DPU_INTF_DATABUS_WIDEN feature flag for DPU >= 5.0

2023-06-14 Thread Dmitry Baryshkov
On 14/06/2023 14:42, Marijn Suijten wrote: On 2023-06-13 18:57:11, Jessica Zhang wrote: DPU 5.x+ supports a databus widen mode that allows more data to be sent per pclk. Enable this feature flag on all relevant chipsets. Signed-off-by: Jessica Zhang ---

Re: [Freedreno] [PATCH v5 02/13] fbdev: Add initializer macros for struct fb_ops

2023-06-14 Thread Thomas Zimmermann
Hi Am 14.06.23 um 13:29 schrieb Christian König: Am 30.05.23 um 17:02 schrieb Thomas Zimmermann: For framebuffers in I/O and system memory, add macros that set struct fb_ops to the respective callback functions. For deferred I/O, add macros that generate callback functions with damage

Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: Add DPU_INTF_DATABUS_WIDEN feature flag for DPU >= 5.0

2023-06-14 Thread Marijn Suijten
On 2023-06-13 18:57:11, Jessica Zhang wrote: > DPU 5.x+ supports a databus widen mode that allows more data to be sent > per pclk. Enable this feature flag on all relevant chipsets. > > Signed-off-by: Jessica Zhang > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 3 ++- >

Re: [Freedreno] [PATCH v5 02/13] fbdev: Add initializer macros for struct fb_ops

2023-06-14 Thread Christian König
Am 30.05.23 um 17:02 schrieb Thomas Zimmermann: For framebuffers in I/O and system memory, add macros that set struct fb_ops to the respective callback functions. For deferred I/O, add macros that generate callback functions with damage handling. Add initializer macros that set struct fb_ops

Re: [Freedreno] [PATCH 1/2] drm/msm/dpu: drop SSPP register dumpers

2023-06-14 Thread Marijn Suijten
On 2023-06-14 12:39:13, Marijn Suijten wrote: > > > > - /* add register dump support */ > > > > - dpu_debugfs_create_regset32("src_blk", 0400, > > > > - debugfs_root, > > > > - sblk->src_blk.base + cfg->base, > > > > -

Re: [Freedreno] [2/2] drm: Remove struct drm_driver.gem_prime_mmap

2023-06-14 Thread Thomas Zimmermann
Hi Am 14.06.23 um 10:26 schrieb Sui Jingfeng: Hi, On 2023/6/14 13:34, Thomas Zimmermann wrote: Hi Am 14.06.23 um 04:06 schrieb Sui Jingfeng: On 2023/6/14 01:27, Sui Jingfeng wrote: Wow, so many drivers get nuked! On 2023/6/13 22:51, Thomas Zimmermann wrote: All drivers initialize this

Re: [Freedreno] [PATCH 1/2] drm/msm/dpu: drop SSPP register dumpers

2023-06-14 Thread Marijn Suijten
On 2023-05-21 21:16:39, Marijn Suijten wrote: > On 2023-05-21 20:12:00, Marijn Suijten wrote: > > On 2023-05-21 20:21:46, Dmitry Baryshkov wrote: > > > Drop SSPP-specifig debugfs register dumps in favour of using > > > debugfs/dri/0/kms or devcoredump. > > > > > > Signed-off-by: Dmitry Baryshkov

Re: [Freedreno] [PATCH 0/3] Add support for databus widen mode

2023-06-14 Thread Marijn Suijten
On 2023-06-13 18:57:10, Jessica Zhang wrote: > DPU 5.x+ and DSI 6G 2.5.x+ support a databus-widen mode that allows for > more compressed data to be transferred per pclk. > > This series adds support for enabling this feature for both DPU and DSI > by doing the following: > > 1. Add a

Re: [Freedreno] [PATCH 3/3] drm/msm/dsi: Enable DATABUS_WIDEN for DSI command mode

2023-06-14 Thread Marijn Suijten
On 2023-06-14 10:49:31, Dmitry Baryshkov wrote: > On 14/06/2023 04:57, Jessica Zhang wrote: > > DSI 6G v2.5.x+ supports a data-bus widen mode that allows DSI to send > > 48 bits of compressed data per pclk instead of 24. > > > > For all chipsets that support this mode, enable it whenever DSC is >

Re: [Freedreno] [PATCH 3/3] drm/msm/dsi: Enable DATABUS_WIDEN for DSI command mode

2023-06-14 Thread Marijn Suijten
On 2023-06-13 18:57:13, Jessica Zhang wrote: > DSI 6G v2.5.x+ supports a data-bus widen mode that allows DSI to send > 48 bits of compressed data per pclk instead of 24. > > For all chipsets that support this mode, enable it whenever DSC is > enabled as recommend by the hardware programming

Re: [Freedreno] [PATCH] drm/msm/dsi: Enable BURST_MODE for command mode for DSI 6G v1.3+

2023-06-14 Thread Marijn Suijten
On 2023-06-12 16:37:36, Jessica Zhang wrote: > During a frame transfer in command mode, there could be frequent > LP11 <-> HS transitions when multiple DCS commands are sent mid-frame or > if the DSI controller is running on slow clock and is throttled. To > minimize frame latency due to these

Re: [Freedreno] [PATCH 2/3] drm/msm/dpu: Set DATABUS_WIDEN on command mode encoders

2023-06-14 Thread Dmitry Baryshkov
On 14/06/2023 04:57, Jessica Zhang wrote: Add a DPU INTF op to set the DATABUS_WIDEN register to enable the databus-widen mode datapath. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 3 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 12

Re: [Freedreno] [PATCH 2/2] drm/msm/dpu/catalog: define DSPP blocks found on sdm845

2023-06-14 Thread Sumit Semwal
On Mon, 12 Jun 2023 at 23:55, Dmitry Baryshkov wrote: > > Add definitions of DSPP blocks present on the sdm845 platform. This > should enable color-management on sdm845-bassed devices. > > Signed-off-by: Dmitry Baryshkov > --- > .../msm/disp/dpu1/catalog/dpu_4_0_sdm845.h| 21

Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: Add DPU_INTF_DATABUS_WIDEN feature flag for DPU >= 5.0

2023-06-14 Thread Dmitry Baryshkov
On 14/06/2023 04:57, Jessica Zhang wrote: DPU 5.x+ supports a databus widen mode that allows more data to be sent per pclk. Enable this feature flag on all relevant chipsets. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 3 ++-

Re: [Freedreno] [PATCH 1/2] drm/msm/dpu: do not enable color-management if DSPPs are not available

2023-06-14 Thread Sumit Semwal
On Mon, 12 Jun 2023 at 23:55, Dmitry Baryshkov wrote: > > We can not support color management without DSPP blocks being provided > in the HW catalog. Do not enable color management for CRTCs if num_dspps > is 0. > > Fixes: 4259ff7ae509 ("drm/msm/dpu: add support for pcc color block in dpu >

Re: [Freedreno] [PATCH 3/3] drm/msm/dsi: Enable DATABUS_WIDEN for DSI command mode

2023-06-14 Thread Dmitry Baryshkov
On 14/06/2023 04:57, Jessica Zhang wrote: DSI 6G v2.5.x+ supports a data-bus widen mode that allows DSI to send 48 bits of compressed data per pclk instead of 24. For all chipsets that support this mode, enable it whenever DSC is enabled as recommend by the hardware programming guide. Only