Re: [Freedreno] [PATCH v3 04/11] drm/msm/dpu: drop separate dpu_core_perf_tune overrides

2023-07-10 Thread Dmitry Baryshkov
On 11/07/2023 05:31, Abhinav Kumar wrote: On 7/7/2023 12:39 PM, Dmitry Baryshkov wrote: The values in struct dpu_core_perf_tune are fixed per the core perf mode. Drop the 'tune' values and substitute them with known values when performing perf management. Note: min_bus_vote was not used at

Re: [Freedreno] [PATCH v3 04/11] drm/msm/dpu: drop separate dpu_core_perf_tune overrides

2023-07-10 Thread Abhinav Kumar
On 7/7/2023 12:39 PM, Dmitry Baryshkov wrote: The values in struct dpu_core_perf_tune are fixed per the core perf mode. Drop the 'tune' values and substitute them with known values when performing perf management. Note: min_bus_vote was not used at all, so it is just silently dropped.

Re: [Freedreno] [PATCH v2] drm/msm/dsi: Enable BURST_MODE for command mode for DSI 6G v1.3+

2023-07-10 Thread Dmitry Baryshkov
On 27/06/2023 23:31, Jessica Zhang wrote: During a frame transfer in command mode, there could be frequent LP11 <-> HS transitions when multiple DCS commands are sent mid-frame or if the DSI controller is running on slow clock and is throttled. To minimize frame latency due to these transitions,

Re: [Freedreno] [PATCH] drm/msm/a6xx: Fix misleading comment

2023-07-10 Thread Dmitry Baryshkov
On 30/06/2023 19:20, Rob Clark wrote: From: Rob Clark The range is actually len+1. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [Freedreno] [PATCH RFC v4 1/7] drm: Introduce solid fill DRM plane property

2023-07-10 Thread Jessica Zhang
On 6/30/2023 1:27 AM, Pekka Paalanen wrote: On Thu, 29 Jun 2023 17:25:00 -0700 Jessica Zhang wrote: Document and add support for solid_fill property to drm_plane. In addition, add support for setting and getting the values for solid_fill. To enable solid fill planes, userspace must assign

Re: [Freedreno] [PATCH] drm/client: Send hotplug event after registering a client

2023-07-10 Thread Dmitry Baryshkov
On 10/07/2023 12:10, Thomas Zimmermann wrote: Generate a hotplug event after registering a client to allow the client to configure its display. Remove the hotplug calls from the existing clients for fbdev emulation. This change fixes a concurrency bug between registering a client and receiving

Re: [Freedreno] [PATCH 07/12] drm/msm/adreno: Move speedbin mapping to device table

2023-07-10 Thread Dmitry Baryshkov
On 10/07/2023 22:56, Rob Clark wrote: On Thu, Jul 6, 2023 at 7:54 PM Dmitry Baryshkov wrote: On 07/07/2023 00:10, Rob Clark wrote: From: Rob Clark This simplifies the code. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 171 ++---

Re: [Freedreno] [PATCH 10/12] drm/msm/adreno: Add helper for formating chip-id

2023-07-10 Thread Rob Clark
On Thu, Jul 6, 2023 at 4:36 PM Konrad Dybcio wrote: > > On 6.07.2023 23:10, Rob Clark wrote: > > From: Rob Clark > > > > This is used in a few places, including one that is parsed by userspace > > tools. So let's standardize it a bit better. > > > > Signed-off-by: Rob Clark > > --- > Userspace

Re: [Freedreno] [PATCH RFC v4 2/7] drm: Introduce pixel_source DRM plane property

2023-07-10 Thread Dmitry Baryshkov
On 10/07/2023 22:51, Jessica Zhang wrote: On 6/30/2023 1:27 AM, Pekka Paalanen wrote: On Fri, 30 Jun 2023 03:42:28 +0300 Dmitry Baryshkov wrote: On 30/06/2023 03:25, Jessica Zhang wrote: Add support for pixel_source property to drm_plane and related documentation. This enum property will

Re: [Freedreno] [PATCH 07/12] drm/msm/adreno: Move speedbin mapping to device table

2023-07-10 Thread Rob Clark
On Thu, Jul 6, 2023 at 7:54 PM Dmitry Baryshkov wrote: > > On 07/07/2023 00:10, Rob Clark wrote: > > From: Rob Clark > > > > This simplifies the code. > > > > Signed-off-by: Rob Clark > > --- > > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 171 ++--- > >

Re: [Freedreno] [PATCH RFC v4 2/7] drm: Introduce pixel_source DRM plane property

2023-07-10 Thread Jessica Zhang
On 6/30/2023 1:27 AM, Pekka Paalanen wrote: On Fri, 30 Jun 2023 03:42:28 +0300 Dmitry Baryshkov wrote: On 30/06/2023 03:25, Jessica Zhang wrote: Add support for pixel_source property to drm_plane and related documentation. This enum property will allow user to specify a pixel source for

Re: [Freedreno] [PATCH v1 5/5] drm/msm/dp: move of_dp_aux_populate_bus() to probe for eDP

2023-07-10 Thread Dmitry Baryshkov
[Restored CC list] On Mon, 10 Jul 2023 at 20:08, Kuogee Hsieh wrote: > > > On 7/7/2023 5:32 PM, Dmitry Baryshkov wrote: > > On 08/07/2023 02:52, Kuogee Hsieh wrote: > >> Move of_dp_aux_populate_bus() to dp_display_probe() for eDP > >> from dp_display_bind() so that probe deferral cases can be >

Re: [Freedreno] [PATCH v1 3/5] drm/msm/dp: delete EV_HPD_INIT_SETUP

2023-07-10 Thread Dmitry Baryshkov
On 10/07/2023 19:52, Kuogee Hsieh wrote: On 7/7/2023 5:34 PM, Dmitry Baryshkov wrote: On 08/07/2023 02:52, Kuogee Hsieh wrote: EV_HPD_INIT_SETUP flag is used to trigger the initialization of external DP host controller. Since external DP host controller initialization had been incorporated

Re: [Freedreno] [PATCH v1 4/5] drm/msm/dp: move relevant dp initialization code from bind() to probe()

2023-07-10 Thread Dmitry Baryshkov
On 10/07/2023 19:57, Kuogee Hsieh wrote: On 7/7/2023 5:11 PM, Dmitry Baryshkov wrote: On 08/07/2023 02:52, Kuogee Hsieh wrote: In preparation of moving edp of_dp_aux_populate_bus() to dp_display_probe(), move dp_display_request_irq(), dp->parser->parse() and dp_power_client_init() to

Re: [Freedreno] [PATCH v1 2/5] drm/msm/dp: incorporate pm_runtime framework into DP driver

2023-07-10 Thread Dmitry Baryshkov
On 10/07/2023 19:18, Kuogee Hsieh wrote: On 7/7/2023 5:04 PM, Dmitry Baryshkov wrote: On 08/07/2023 02:52, Kuogee Hsieh wrote: Incorporating pm runtime framework into DP driver so that power and clock resource handling can be centralized allowing easier control of these resources in

Re: [Freedreno] [PATCH v1 1/5] drm/msm/dp: remove pm_runtime_xxx() from dp_power.c

2023-07-10 Thread Dmitry Baryshkov
On 10/07/2023 20:25, Kuogee Hsieh wrote: On 7/9/2023 1:32 PM, Abhinav Kumar wrote: On 7/9/2023 11:00 AM, Dmitry Baryshkov wrote: On Sun, 9 Jul 2023 at 20:22, Abhinav Kumar wrote: On 7/7/2023 5:06 PM, Dmitry Baryshkov wrote: On 08/07/2023 02:52, Kuogee Hsieh wrote: Since both

Re: [Freedreno] [PATCH v1 1/5] drm/msm/dp: remove pm_runtime_xxx() from dp_power.c

2023-07-10 Thread Kuogee Hsieh
On 7/9/2023 1:32 PM, Abhinav Kumar wrote: On 7/9/2023 11:00 AM, Dmitry Baryshkov wrote: On Sun, 9 Jul 2023 at 20:22, Abhinav Kumar wrote: On 7/7/2023 5:06 PM, Dmitry Baryshkov wrote: On 08/07/2023 02:52, Kuogee Hsieh wrote: Since both pm_runtime_resume() and pm_runtime_suspend() are

Re: [Freedreno] [PATCH 2/2] drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet

2023-07-10 Thread Jagan Teki
On Wed, Jul 5, 2023 at 11:09 AM Dmitry Baryshkov wrote: > > [Adding freedreno@ to cc list] > > On Wed, 5 Jul 2023 at 08:31, Jagan Teki wrote: > > > > Hi Amit, > > > > On Wed, Jul 5, 2023 at 10:15 AM Amit Pundir wrote: > > > > > > Hi Marek, > > > > > > On Wed, 5 Jul 2023 at 01:48, Marek Vasut

Re: [Freedreno] [PATCH] drm/client: Send hotplug event after registering a client

2023-07-10 Thread Limonciello, Mario
+regressions On 7/10/2023 04:58, Thomas Zimmermann wrote: Hi Am 10.07.23 um 11:52 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hello Thomas, Generate a hotplug event after registering a client to allow the client to configure its display. Remove the hotplug calls from the

Re: [Freedreno] [PATCH v1 4/5] drm/msm/dp: move relevant dp initialization code from bind() to probe()

2023-07-10 Thread Kuogee Hsieh
On 7/7/2023 5:11 PM, Dmitry Baryshkov wrote: On 08/07/2023 02:52, Kuogee Hsieh wrote: In preparation of moving edp of_dp_aux_populate_bus() to dp_display_probe(), move dp_display_request_irq(), dp->parser->parse() and dp_power_client_init() to dp_display_probe() too. Signed-off-by: Kuogee

Re: [Freedreno] [PATCH v1 3/5] drm/msm/dp: delete EV_HPD_INIT_SETUP

2023-07-10 Thread Kuogee Hsieh
On 7/7/2023 5:34 PM, Dmitry Baryshkov wrote: On 08/07/2023 02:52, Kuogee Hsieh wrote: EV_HPD_INIT_SETUP flag is used to trigger the initialization of external DP host controller. Since external DP host controller initialization had been incorporated into pm_runtime_resume(), this flag become

Re: [Freedreno] [PATCH v1 2/5] drm/msm/dp: incorporate pm_runtime framework into DP driver

2023-07-10 Thread Kuogee Hsieh
On 7/8/2023 7:52 PM, Bjorn Andersson wrote: On Fri, Jul 07, 2023 at 04:52:20PM -0700, Kuogee Hsieh wrote: Incorporating pm runtime framework into DP driver so that power and clock resource handling can be centralized allowing easier control of these resources in preparation of registering aux

Re: [Freedreno] [PATCH v1 2/5] drm/msm/dp: incorporate pm_runtime framework into DP driver

2023-07-10 Thread Kuogee Hsieh
On 7/7/2023 5:04 PM, Dmitry Baryshkov wrote: On 08/07/2023 02:52, Kuogee Hsieh wrote: Incorporating pm runtime framework into DP driver so that power and clock resource handling can be centralized allowing easier control of these resources in preparation of registering aux bus uring probe.

Re: [Freedreno] [PATCH] drm/client: Send hotplug event after registering a client

2023-07-10 Thread Thomas Zimmermann
Hi Am 10.07.23 um 11:52 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hello Thomas, Generate a hotplug event after registering a client to allow the client to configure its display. Remove the hotplug calls from the existing clients for fbdev emulation. This change fixes a

Re: [Freedreno] [PATCH] drm/client: Send hotplug event after registering a client

2023-07-10 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > Generate a hotplug event after registering a client to allow the > client to configure its display. Remove the hotplug calls from the > existing clients for fbdev emulation. This change fixes a concurrency > bug between registering a client and

[Freedreno] [PATCH] drm/client: Send hotplug event after registering a client

2023-07-10 Thread Thomas Zimmermann
Generate a hotplug event after registering a client to allow the client to configure its display. Remove the hotplug calls from the existing clients for fbdev emulation. This change fixes a concurrency bug between registering a client and receiving events from the DRM core. The bug is present in

Re: [Freedreno] [PATCH 1/5] dt-bindings: display: msm: dp-controller: document SM8250 compatible

2023-07-10 Thread Krzysztof Kozlowski
On 09/07/2023 06:19, Dmitry Baryshkov wrote: > It looks like DP controlled on SM8250 is the same as DP controller on > SM8350. Use the SM8350 compatible as fallback for SM8250. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof