Re: [PATCH v2 1/3] dt-bindings: display: msm: dp-controller: document X1E80100 compatible

2024-02-25 Thread Krzysztof Kozlowski
On 24/02/2024 23:34, Dmitry Baryshkov wrote: > On Thu, 22 Feb 2024 at 17:55, Abel Vesa wrote: >> >> Add the X1E80100 to the list of compatibles and document the is-edp >> flag. The controllers are expected to operate in DP mode by default, >> and this flag can be used to select eDP mode. >> >>

Re: [PATCH RFC 01/12] kbuild: create destination directory for _shipped handling

2024-02-25 Thread Masahiro Yamada
On Mon, Feb 26, 2024 at 11:11 AM Dmitry Baryshkov wrote: > > The driver might decide to put the _shipped files to the subdir. Please stop this sentence. This sounds like we are not learning. https://lore.kernel.org/all/CAHk-=wgSEi_ZrHdqr=20xv+d6dr5G895CbOAi8ok+7-CQUN=f...@mail.gmail.com/

Re: [PATCH RFC 00/12] drm/msm: add support for regenerating shipped xml.h headers

2024-02-25 Thread Masahiro Yamada
| 37 +- > .../mdp5.xml.h => registers/mdp5.xml.h_shipped}| 39 +- > .../gpu/drm/msm/registers/mdp_common.xml.h_shipped | 114 ++ > drivers/gpu/drm/msm/registers/sfpb.xml.h_shipped | 67 + > drivers/gpu/drm/msm/registers/xml/dsi.xml | 390 ++ > drivers/gp

[PATCH v4 3/3] drm/msm/dpu: capture snapshot on the first commit_done timeout

2024-02-25 Thread Dmitry Baryshkov
In order to debug commit_done timeouts, capture the devcoredump state when the first timeout occurs after the encoder has been enabled. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 9 + 1 file changed, 9 insertions(+)

[PATCH v4 2/3] drm/msm/dpu: split dpu_encoder_wait_for_event into two functions

2024-02-25 Thread Dmitry Baryshkov
Stop multiplexing several events via the dpu_encoder_wait_for_event() function. Split it into two distinct functions two allow separate handling of those events. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 70

[PATCH v4 1/3] drm/msm/dpu: make "vblank timeout" more useful

2024-02-25 Thread Dmitry Baryshkov
We have several reports of vblank timeout messages. However after some debugging it was found that there might be different causes to that. To allow us to identify the DPU block that gets stuck, include the actual CTL_FLUSH value into the timeout message. Reviewed-by: Abhinav Kumar

[PATCH v4 0/3] drm/msm/dpu: debug commit_done timeouts

2024-02-25 Thread Dmitry Baryshkov
for new funcsions (Abhinav) - Link to v3: https://lore.kernel.org/r/20240225-fd-dpu-debug-timeout-v3-0-252f2b21c...@linaro.org Changes in v3: - Capture the snapshot only on the first comit_done timeout (Abhinav) - Link to v2: https://lore.kernel.org/r/20240208-fd-dpu-debug-timeout-v2-1-9f907f1bd

[PATCH RFC 12/12] drm/msm: sync shipped headers database

2024-02-25 Thread Dmitry Baryshkov
Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/registers/dsi.xml.h_shipped| 38 --- .../drm/msm/registers/dsi_phy_10nm.xml.h_shipped | 37 --- .../drm/msm/registers/dsi_phy_14nm.xml.h_shipped | 37 --- .../drm/msm/registers/dsi_phy_20nm.xml.h_shipped | 37

[PATCH RFC 11/12] drm/msm: tie regeneration of shipped headers

2024-02-25 Thread Dmitry Baryshkov
Finally add support for regeneration of the shipped autogenerated register headers. Pass DRM_MSM_GENERATE_HEADERS=1 to make to force regeneration. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Makefile | 27 +++

[PATCH RFC 06/12] drm/msm/headergen: import source files from freedreno/envytools

2024-02-25 Thread Dmitry Baryshkov
Import headergen2 sources at the commit d88cafa3ac3e ("freedreno/decode: try harder to not crash in disasm") from https://gitlab.freedesktop.org/freedreno/envytools. This tool has been used to generate drm/msm header files from the corresponding XML files. This required committing changes to the

[PATCH RFC 08/12] drm/msm/headergen: don't output full file paths

2024-02-25 Thread Dmitry Baryshkov
In order to reduce noise, include just the file name into the generated file headers. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/headergen2/headergen2.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/headergen2/headergen2.c

[PATCH RFC 09/12] drm/msm/headergen: generate _shipped files

2024-02-25 Thread Dmitry Baryshkov
Change headergen semantics to generate the .xml.h_shipped files instead of just generating headers. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/headergen2/headergen2.c | 33 +++-- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git

[PATCH RFC 07/12] drm/msm/headergen: use asprintf instead of custom aprintf

2024-02-25 Thread Dmitry Baryshkov
Replace custom aprintf() function with the standard asprintf(). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/headergen2/aprintf.c | 38 drivers/gpu/drm/msm/headergen2/rnn.c | 5 - drivers/gpu/drm/msm/headergen2/util.h| 2 -- 3 files

[PATCH RFC 04/12] drm/msm/dsi: drop mmss_cc.xml.h

2024-02-25 Thread Dmitry Baryshkov
The mmss_cc.xml.h file describes bits of the MMSS clock controller on APQ8064 / MSM8960 platforms. They are not used by the driver and do not belong to the DRM MSM driver. Drop the file. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/mmss_cc.xml.h | 131

[PATCH RFC 05/12] drm/msm: use _shipped suffix for all xml.h files

2024-02-25 Thread Dmitry Baryshkov
Move non-GPU xml.h files into the ./registers subdir and add the _shipped suffix. The GPU files are left intact for now, since they require processing via a gen_headers.py, while display headers are regenerated using headergen2 Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Makefile

[PATCH RFC 02/12] drm/msm/mdp5: add writeback block bases

2024-02-25 Thread Dmitry Baryshkov
In order to stop patching the mdp5 headers, import definitions for the writeback blocks. This part is extracted from the old Rob's patch. Co-developed-by: Rob Clark Signed-off-by: Rob Clark Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.h | 11 +++ 1 file

[PATCH RFC 01/12] kbuild: create destination directory for _shipped handling

2024-02-25 Thread Dmitry Baryshkov
The driver might decide to put the _shipped files to the subdir. In such case the cmd_copy might fail because the destination directory is not present. Call mkdir -p to make sure that the destination directory is present. Signed-off-by: Dmitry Baryshkov --- scripts/Makefile.lib | 2 +- 1 file

[PATCH RFC 03/12] drm/msm/hdmi: drop qfprom.xml.h

2024-02-25 Thread Dmitry Baryshkov
The qfprom.xml.h contains definitions for the nvmem code. They are not used in the existing code. Also if we were to use them later, we should have used nvmem cell API instead of using these defs. Drop the file. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/qfprom.xml.h | 61

[PATCH RFC 00/12] drm/msm: add support for regenerating shipped xml.h headers

2024-02-25 Thread Dmitry Baryshkov
egisters/xml/sfpb.xml | 17 + scripts/Makefile.lib |2 +- 47 files changed, 8034 insertions(+), 587 deletions(-) --- base-commit: ffa0c87f172bf7a0132aa960db412f8d63b2f533 change-id: 20240225-fd-xml-shipped-ba9a321cdedf Best regards, -- Dmitry Baryshkov

Re: [PATCH v3 3/3] drm/msm/dpu: capture snapshot on the first commit_done timeout

2024-02-25 Thread Abhinav Kumar
On 2/25/2024 11:57 AM, Abhinav Kumar wrote: On 2/25/2024 6:12 AM, Dmitry Baryshkov wrote: In order to debug commit_done timeouts, capture the devcoredump state when the first timeout occurs after the encoder has been enabled. Signed-off-by: Dmitry Baryshkov ---  

Re: [PATCH v3 2/3] drm/msm/dpu: split dpu_encoder_wait_for_event into two functions

2024-02-25 Thread Abhinav Kumar
On 2/25/2024 12:52 PM, Dmitry Baryshkov wrote: On Sun, 25 Feb 2024 at 21:49, Abhinav Kumar wrote: On 2/25/2024 6:12 AM, Dmitry Baryshkov wrote: Stop multiplexing several events via the dpu_encoder_wait_for_event() function. Split it into two distinct functions two allow separate

Re: [PATCH v3 1/3] drm/msm/dpu: make "vblank timeout" more useful

2024-02-25 Thread Abhinav Kumar
On 2/25/2024 12:57 PM, Dmitry Baryshkov wrote: On Sun, 25 Feb 2024 at 21:44, Abhinav Kumar wrote: On 2/25/2024 6:12 AM, Dmitry Baryshkov wrote: We have several reports of vblank timeout messages. However after some debugging it was found that there might be different causes to that. To

Re: [PATCH v3 1/3] drm/msm/dpu: make "vblank timeout" more useful

2024-02-25 Thread Dmitry Baryshkov
On Sun, 25 Feb 2024 at 21:44, Abhinav Kumar wrote: > > > > On 2/25/2024 6:12 AM, Dmitry Baryshkov wrote: > > We have several reports of vblank timeout messages. However after some > > debugging it was found that there might be different causes to that. > > To allow us to identify the DPU block

Re: [PATCH v3 2/3] drm/msm/dpu: split dpu_encoder_wait_for_event into two functions

2024-02-25 Thread Dmitry Baryshkov
On Sun, 25 Feb 2024 at 21:49, Abhinav Kumar wrote: > > > > On 2/25/2024 6:12 AM, Dmitry Baryshkov wrote: > > Stop multiplexing several events via the dpu_encoder_wait_for_event() > > function. Split it into two distinct functions two allow separate > > handling of those events. > > > > I

Re: [PATCH v3 3/3] drm/msm/dpu: capture snapshot on the first commit_done timeout

2024-02-25 Thread Abhinav Kumar
On 2/25/2024 6:12 AM, Dmitry Baryshkov wrote: In order to debug commit_done timeouts, capture the devcoredump state when the first timeout occurs after the encoder has been enabled. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 9 + 1 file

Re: [PATCH v3 2/3] drm/msm/dpu: split dpu_encoder_wait_for_event into two functions

2024-02-25 Thread Abhinav Kumar
On 2/25/2024 6:12 AM, Dmitry Baryshkov wrote: Stop multiplexing several events via the dpu_encoder_wait_for_event() function. Split it into two distinct functions two allow separate handling of those events. I understand the idea but would handling of those events be really distinct? Like

Re: [PATCH v3 1/3] drm/msm/dpu: make "vblank timeout" more useful

2024-02-25 Thread Abhinav Kumar
On 2/25/2024 6:12 AM, Dmitry Baryshkov wrote: We have several reports of vblank timeout messages. However after some debugging it was found that there might be different causes to that. To allow us to identify the DPU block that gets stuck, include the actual CTL_FLUSH value into the timeout

Re: [PATCH v7 00/36] drm/connector: Create HDMI Connector infrastructure

2024-02-25 Thread Dmitry Baryshkov
Hi Maxime, On Thu, 22 Feb 2024 at 20:14, Maxime Ripard wrote: > > Hi, > > Here's a series that creates some extra infrastructure specifically > targeted at HDMI controllers. > > The idea behind this series came from a recent discussion on IRC during > which we discussed infoframes generation of

[PATCH v3 2/3] drm/msm/dpu: split dpu_encoder_wait_for_event into two functions

2024-02-25 Thread Dmitry Baryshkov
Stop multiplexing several events via the dpu_encoder_wait_for_event() function. Split it into two distinct functions two allow separate handling of those events. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 74 +

[PATCH v3 3/3] drm/msm/dpu: capture snapshot on the first commit_done timeout

2024-02-25 Thread Dmitry Baryshkov
In order to debug commit_done timeouts, capture the devcoredump state when the first timeout occurs after the encoder has been enabled. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH v3 1/3] drm/msm/dpu: make "vblank timeout" more useful

2024-02-25 Thread Dmitry Baryshkov
We have several reports of vblank timeout messages. However after some debugging it was found that there might be different causes to that. To allow us to identify the DPU block that gets stuck, include the actual CTL_FLUSH value into the timeout message. Signed-off-by: Dmitry Baryshkov ---

[PATCH v3 0/3] drm/msm/dpu: debug commit_done timeouts

2024-02-25 Thread Dmitry Baryshkov
In order to debug commit_done timeouts ([1]) display the sticky bits of the CTL_FLUSH register and capture the devcore dump when the first such timeout occurs. [1] https://gitlab.freedesktop.org/drm/msm/-/issues/33 Signed-off-by: Dmitry Baryshkov --- Changes in v3: - Capture the snapshot only