Re: [Freedreno] [PATCH 1/2] drm/msm: add missing header dependencies

2016-10-24 Thread Arnd Bergmann
8:6: warning: no previous prototype for > 'msm_debugfs_cleanup' [-Wmissing-prototypes] > > In fact, these functions are declared in > drivers/gpu/drm/msm/msm_debugfs.h. > So this patch adds missing header dependencies. > > Signed-off-by: Baoyou Xie <baoyou@linaro.org> >

[Freedreno] [PATCH 2/2] drm: add more MMU dependencies

2017-01-11 Thread Arnd Bergmann
89938 ("drm: fix compilations issues introduced by "drm: allow to use mmuless SoC"") Fixes: 62a0d98a188c ("drm: allow to use mmuless SoC") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/gpu/drm/armada/Kconfig | 2 +- drivers/gpu/drm/etnaviv/Kconfig |

[Freedreno] [PATCH] drm/msm: adreno: fix build error without debugfs

2016-11-30 Thread Arnd Bergmann
'? This adds a missing #ifdef. Fixes: b5f103ab98c7 ("drm/msm: gpu: Add A5XX target support") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/dri

[Freedreno] [PATCH] drm/msm: add stubs for msm_{perf, rd}_debugfs_cleanup

2017-03-20 Thread Arnd Bergmann
. Fixes: 85eac4700ede ("drm/msm: Remove msm_debugfs_cleanup()") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/gpu/drm/msm/msm_drv.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h index b51fb0d70f43..b88

[Freedreno] [PATCH 3/3] drm/msm: use %z format modifier for printing size_t

2017-08-03 Thread Arnd Bergmann
'unsigned int' [-Werror=format=] The warning it otherwise harmless as size_t is always the same size as unsigned long in all supported architectures, but gcc doesn't know that. Fixes: c2fceabca6d5 ("drm/msm: Support multiple ringbuffers") Signed-off-by: Arnd Bergmann <a...@arndb.de>

[Freedreno] [PATCH 2/3] drm/msm/mdp5: mark runtime_pm functions as __maybe_unused

2017-08-03 Thread Arnd Bergmann
: d68fe15b1878 ("drm/msm/mdp5: Use runtime PM get/put API instead of toggling clocks") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.

[Freedreno] [PATCH 2/2] drm/msm: gpu: don't abuse dma_alloc for non-DMA allocations

2017-07-26 Thread Arnd Bergmann
("drm/msm: gpu: Enable zap shader for A5XX") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- I think we want this to be applied for 4.13, as the upstream code that was added in the merge window is seriously broken without it --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 71 --

Re: [Freedreno] [PATCH 2/2] drm/msm: gpu: don't abuse dma_alloc for non-DMA allocations

2017-07-26 Thread Arnd Bergmann
On Jul 26, 2017 6:35 PM, "Jordan Crouse" wrote: > > if (!IS_ENABLED(CONFIG_ARCH_QCOM)) > > return -EINVAL; > > > > + np = of_get_child_by_name(dev->of_node, "zap-shader"); > > + if (!np) > > + return -ENODEV; > > + > > + np =

[Freedreno] [PATCH v3] drm/msm: gpu: don't abuse dma_alloc for non-DMA allocations

2017-07-26 Thread Arnd Bergmann
("drm/msm: gpu: Enable zap shader for A5XX") Acked-and-Tested-by: Jordan Crouse <jcro...@codeaurora.org> Signed-off-by: Arnd Bergmann <a...@arndb.de> --- I think we want this to be applied for 4.13, as the upstream code that was added in the merge window is seriously broken without

[Freedreno] [PATCH 1/2] drm/msm: gpu: don't abuse dma_alloc for non-DMA allocations

2017-06-20 Thread Arnd Bergmann
once it is no longer needed is probably better anyway. Fixes: 7c65817e6d38 ("drm/msm: gpu: Enable zap shader for A5XX") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dri

[Freedreno] [PATCH 2/2] drm/msm: gpu: call qcom_mdt interfaces only for ARCH_QCOM

2017-06-20 Thread Arnd Bergmann
for CONFIG_QCOM_MDT_LOADER can then go away, which also improves compile-time coverage and makes the code a little nicer to read. Fixes: 7c65817e6d38 ("drm/msm: gpu: Enable zap shader for A5XX") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/gpu/drm/msm/Kconfig

[Freedreno] [PATCH] drm/msm/rd: fix msm_rd_dump_submit() prototype

2017-11-27 Thread Arnd Bergmann
of the stub function the same way as the regualar prototype. Fixes: 998b9a588314 ("drm/msm/rd: allow adding addition msg to top of dump") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/gpu/drm/msm/msm_drv.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[Freedreno] [PATCH] drm/msm: fix msm_rd_dump_submit prototype

2017-11-02 Thread Arnd Bergmann
of 'msm_rd_dump_submit' from incompatible pointer type [-Werror=incompatible-pointer-types] This changes the second one to match the first again. Fixes: 2165e2b9cba2 ("drm/msm: split rd debugfs file") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/gpu/drm/msm/msm_

[Freedreno] [PATCH] drm: msm: avoid false-positive -Wmaybe-uninitialized warning

2017-12-04 Thread Arnd Bergmann
] It's relatively clear from reading the source that this cannot happen, and older compilers get it right. This rearranges the code remove the two affected variables, which reliably avoids the problem. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane

Re: [Freedreno] [PATCH] drm: msm: avoid false-positive -Wmaybe-uninitialized warning

2017-12-04 Thread Arnd Bergmann
On Mon, Dec 4, 2017 at 5:36 PM, Laurent Pinchart <laurent.pinch...@ideasonboard.com> wrote: > Hi Arnd, > > Thank you for the patch. > > On Monday, 4 December 2017 16:44:23 EET Arnd Bergmann wrote: >> gcc-8 -fsanitize-coverage=trace-pc produces a false-positive warning

[Freedreno] [PATCH] drm/msm: avoid using 'timespec'

2018-06-18 Thread Arnd Bergmann
. Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/msm/msm_drv.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h index b2da1fbf81e0..cc8977476a41 100644 --- a/drivers/gpu/drm/msm/msm_drv.h +++ b/drivers/gpu/drm/msm

Re: [Freedreno] [PATCH] drm/msm/adreno: Remove VLA usage

2018-06-29 Thread Arnd Bergmann
, though using a fixed-length string is probably just as well here, given that the 'fwname' variable is always set to the constant string "a530_zap.mdt" at the moment, which is not very long. Reviewed-by: Arnd Bergmann Arnd ___ Freedreno mail

[Freedreno] [PATCH 2/2] drm/msm/adreno: fix nvmem related link error

2018-01-15 Thread Arnd Bergmann
bin then, so we don't need a hard dependency. Fixes: f56d9df656c4 ("drm/msm/adreno: Read the speed bins for a5xx targets") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/gpu/drm/msm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/Kconfig b

[Freedreno] [PATCH] drm/msm/gpu: avoid deprecated do_gettimeofday

2018-07-26 Thread Arnd Bergmann
()) instead, but as this timestamp appears to only be used for humans rather than compared with other timestamps, the real time domain is probably good enough. Fixes: e43b045e2c82 ("drm/msm/gpu: Capture the state of the GPU") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/

[Freedreno] [PATCH 1/2] drm/msm/gpu: fix msm_gpu_crashstate_capture stub prototype

2018-08-13 Thread Arnd Bergmann
); ^~ drivers/gpu/drm/msm/msm_gpu.c:370:13: note: declared here static void msm_gpu_crashstate_capture(struct msm_gpu *gpu, char *comm, Change the stub to match the normal function. Fixes: cdb95931dea3 ("drm/msm/gpu: Add the buffer objects from the submit to the crash dump") Signed-of

[Freedreno] [PATCH] drm/msm: mark PM functions as __maybe_unused

2018-07-24 Thread Arnd Bergmann
but not used [-Werror=unused-function] This marks them as __maybe_unused to let the compiler drop the functions without complaining. Fixes: 591225291ca2 ("drm/msm: Add SDM845 DPU support") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 4 ++-- 1 file

Re: [Freedreno] [PATCH] drm/msm: avoid using 'timespec'

2018-07-10 Thread Arnd Bergmann
On Tue, Jul 10, 2018 at 10:47 PM, Sean Paul wrote: > On Mon, Jun 18, 2018 at 05:39:42PM +0200, Arnd Bergmann wrote: >> The timespec structure and associated interfaces are deprecated and will >> be removed in the future because of the y2038 overflow. >> >> T

[Freedreno] [PATCH] drm/msm: fix building without debugfs

2018-02-26 Thread Arnd Bergmann
pointer. Fixes: 331dc0bc195b ("drm/msm: add a5xx specific debugfs") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/gpu/drm/msm/adreno/adreno_device.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adr

[Freedreno] [PATCH] drm/msm: fix arm64 build error

2018-12-10 Thread Arnd Bergmann
64/include/asm/memory.h:51: note: this is the location of the previous definition #define VA_START (UL(0x) - \ Rename this and the related macros with a GPU_ prefix. Fixes: 1c0088f255ae ("drm/msm: implement a2xx mmu") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/m

[Freedreno] [PATCH 0/7] v4.19-stable randconfig fixes

2018-12-14 Thread Arnd Bergmann
fixing the code correctly in each of these cases, but if you disagree, applying the mainline change should work equally well, so decide for yourself. Arnd Arnd Bergmann (5): scsi: raid_attrs: fix unused variable warning slimbus: ngd: mark PM functions as __maybe_unused [stable-4.19]

[Freedreno] [PATCH 7/7] [stable-4.19] drm/msm: fix address space warning

2018-12-14 Thread Arnd Bergmann
arge patch, this just fixes the warning by using the correct type. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/msm/disp/dpu1/dpu_dbg.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/di

Re: [Freedreno] [PATCH 4/4] drm/msm: bump UAPI version

2018-11-30 Thread Arnd Bergmann
On Fri, Nov 30, 2018 at 4:31 PM Rob Clark wrote: > > On Fri, Nov 30, 2018 at 10:12 AM Arnd Bergmann wrote: > > > > On Fri, Nov 30, 2018 at 4:02 PM Rob Clark wrote: > > > > > > Signed-off-by: Rob Clark > > > --- > > > drivers/gpu/drm/msm/

Re: [Freedreno] [PATCH 2/4] drm/msm: rework GEM_INFO ioctl

2018-11-30 Thread Arnd Bergmann
On Fri, Nov 30, 2018 at 4:02 PM Rob Clark wrote: > > - > -#define MSM_INFO_FLAGS (MSM_INFO_IOVA) > +/* Get or set GEM buffer info. The requested value can be passed > + * directly in 'value', or for data larger than 64b 'value' is a > + * pointer to userspace buffer, with 'len' specifying the

Re: [Freedreno] [PATCH 4/4] drm/msm: bump UAPI version

2018-11-30 Thread Arnd Bergmann
On Fri, Nov 30, 2018 at 4:02 PM Rob Clark wrote: > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/msm_drv.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index 6ebbd5010722..782cc33916d6 100644

[Freedreno] [PATCH] drm/msm: include linux/sched/task.h

2019-09-18 Thread Arnd Bergmann
Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/msm/msm_gpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c index a052364a5d74..edd45f434ccd 100644 --- a/drivers/gpu/drm/msm/msm_gpu.c +++ b/drivers/gpu/drm/msm/msm_gpu.c @@ -

[Freedreno] [PATCH 00/16] drivers: y2038 updates

2019-11-08 Thread Arnd Bergmann
at https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git/log/?h=y2038-endgame Arnd Arnd Bergmann (16): staging: exfat: use prandom_u32() for i_generation fat: use prandom_u32() for i_generation net: sock: use __kernel_old_timespec instead of timespec dlm: use SO_SNDTIMEO_NEW

[Freedreno] [PATCH 14/16] drm/msm: avoid using 'timespec'

2019-11-08 Thread Arnd Bergmann
. Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/msm/msm_drv.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h index 71547e756e29..740bf7c70d8f 100644 --- a/drivers/gpu/drm/msm/msm_drv.h +++ b/drivers/gpu/drm/msm

[Freedreno] [PATCH v2 00/24] drivers, fs: y2038 updates

2019-12-13 Thread Arnd Bergmann
/20191108213257.3097633-1-a...@arndb.de/ Arnd Bergmann (24): Input: input_event: fix struct padding on sparc64 fat: use prandom_u32() for i_generation dlm: use SO_SNDTIMEO_NEW instead of SO_SNDTIMEO_OLD xtensa: ISS: avoid struct timeval um: ubd: use 64-bit time_t where possible acct: stop using

[Freedreno] [PATCH v2 12/24] drm/msm: avoid using 'timespec'

2019-12-13 Thread Arnd Bergmann
. Reviewed-by: Jordan Crouse Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/msm/msm_drv.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h index 71547e756e29..740bf7c70d8f 100644 --- a/drivers/gpu/drm/msm/msm_drv.h

[Freedreno] [PATCH] drm/msm: fix link error without CONFIG_DEBUG_FS

2020-04-08 Thread Arnd Bergmann
t;drm/msm: devcoredump should dump MSM_SUBMIT_BO_DUMP buffers") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/msm/msm_gem.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_gem.h b/drivers/gpu/drm/msm/msm_gem.h index 30584eaf8cc8..eb4aeaf29

[Freedreno] [PATCH 3/4] drm/msm: fix -Woverride-init warning

2020-10-26 Thread Arnd Bergmann
From: Arnd Bergmann There is one harmless duplicate initialization that causes a warning with 'make W=1': drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:122:19: warning: initialized field overwritten [-Woverride-init] 122 | .max_linewidth = 4096, | ^~~~ drivers/gpu

Re: [Freedreno] arm64: Internal error: Oops: qcom_iommu_tlb_inv_context free_io_pgtable_ops on db410c

2020-07-20 Thread Arnd Bergmann
On Mon, Jul 20, 2020 at 8:36 AM Naresh Kamboju wrote: > > This kernel oops while boot linux mainline kernel on arm64 db410c device. > > metadata: > git branch: master > git repo: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > git commit:

Re: [Freedreno] stable-rc 4.14: arm64: Internal error: Oops: clk_reparent __clk_set_parent_before on db410c

2020-07-21 Thread Arnd Bergmann
On Tue, Jul 21, 2020 at 10:32 AM Naresh Kamboju wrote: > > Kernel Internal oops while booting stable-rc 4.14 kernel on qcom db410c device > this problem happened only once on this specific platform. > and rcu_preempt detected stalls on CPUs/tasks detected after this and > board hung. > >

[Freedreno] [PATCH] drm/msm: add IOMMU_SUPPORT dependency

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann The iommu pgtable support is only available when IOMMU support is built into the kernel: WARNING: unmet direct dependencies detected for IOMMU_IO_PGTABLE Depends on [n]: IOMMU_SUPPORT [=n] Selected by [y]: - DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] &

[Freedreno] [PATCH] drm/msm/a6xx: add CONFIG_QCOM_LLCC dependency

2021-01-03 Thread Arnd Bergmann
From: Arnd Bergmann When LLCC support is in a loadable module, the adreno support cannot be built-in: aarch64-linux-ld: drivers/gpu/drm/msm/adreno/a6xx_gpu.o: in function `a6xx_gpu_init': a6xx_gpu.c:(.text+0xe0): undefined reference to `llcc_slice_getd' a6xx_gpu.c:(.text+0xe0): relocation

[Freedreno] [PATCH] drm/msm/dsi: fix 32-bit clang warning

2021-05-14 Thread Arnd Bergmann
From: Arnd Bergmann clang is a little overzealous with warning about a constant conversion in an untaken branch of a ternary expression: drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c:975:48: error: implicit conversion from 'unsigned long long' to 'unsigned long' changes value from 50

Re: [Freedreno] [PATCH] drm/msm: Avoid potential overflow in timeout_to_jiffies()

2021-09-17 Thread Arnd Bergmann
s: 6cedb8b377bb ("drm/msm: avoid using 'timespec'") > Signed-off-by: Marek Vasut > Cc: Arnd Bergmann > Cc: Jordan Crouse > Cc: Rob Clark > Cc: sta...@vger.kernel.org # 5.6+ > --- Acked-by: Arnd Bergmann

[Freedreno] [PATCH] drm/msm/gpu: fix link failure with QCOM_SCM=m

2021-08-02 Thread Arnd Bergmann
From: Arnd Bergmann Another missed dependency when SCM is a loadable module and adreno is built-in: drivers/gpu/drm/msm/adreno/adreno_gpu.o: In function `adreno_zap_shader_load': adreno_gpu.c:(.text+0x1e8): undefined reference to `qcom_scm_is_available' drivers/gpu/drm/msm/adreno/a5xx_gpu.o

Re: [Freedreno] [PATCH] drm/msm/gpu: fix link failure with QCOM_SCM=m

2021-08-04 Thread Arnd Bergmann
On Mon, Aug 2, 2021 at 4:53 PM Arnd Bergmann wrote: > > From: Arnd Bergmann > > Another missed dependency when SCM is a loadable module > and adreno is built-in: > > drivers/gpu/drm/msm/adreno/adreno_gpu.o: In function `adreno_zap_shader_load': > adreno_gpu.c:(.text+0x1

Re: [Freedreno] mmotm 2021-10-05-19-53 uploaded (drivers/gpu/drm/msm/hdmi/hdmi_phy.o)

2021-10-13 Thread Arnd Bergmann
On Wed, Oct 13, 2021 at 12:54 PM Arnd Bergmann wrote: > On Thu, Oct 7, 2021 at 11:51 AM Geert Uytterhoeven > wrote: > > -msm-$(CONFIG_DRM_FBDEV_EMULATION) += msm_fbdev.o > -msm-$(CONFIG_COMMON_CLK) += disp/mdp4/mdp4_lvds_pll.o > -msm-$(CONFIG_COMMON_CLK) += hdmi/hdmi

Re: [Freedreno] mmotm 2021-10-05-19-53 uploaded (drivers/gpu/drm/msm/hdmi/hdmi_phy.o)

2021-10-13 Thread Arnd Bergmann
On Thu, Oct 7, 2021 at 11:51 AM Geert Uytterhoeven wrote: > On Wed, Oct 6, 2021 at 9:28 AM Christian König > wrote: > > Am 06.10.21 um 09:20 schrieb Stephen Rothwell: > > > On Tue, 5 Oct 2021 22:48:03 -0700 Randy Dunlap > > > wrote: > > >> on i386: > > >> > > >> ld:

[Freedreno] [PATCH] drm: msm: fix building without CONFIG_COMMON_CLK

2021-10-13 Thread Arnd Bergmann
From: Arnd Bergmann When CONFIG_COMMON_CLOCK is disabled, the 8996 specific phy code is left out, which results in a link failure: ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3f0): undefined reference to `msm_hdmi_phy_8996_cfg' This was only exposed after it became possible to build

Re: [Freedreno] [PATCH] drm: msm: fix building without CONFIG_COMMON_CLK

2021-10-18 Thread Arnd Bergmann
On Mon, Oct 18, 2021 at 1:40 PM Christian König wrote: > >> I have absolutely no idea how a platform can have IOMMU but no MMU > >> support but it indeed seems to be the case here. > > Huh? > > > > Parisc has config MMU def_bool y? > > Then why vmap isn't available? > > See the mail thread:

Re: [Freedreno] [PATCH] [RFC] qcom_scm: hide Kconfig symbol

2021-09-28 Thread Arnd Bergmann
On Tue, Sep 28, 2021 at 9:05 AM Kalle Valo wrote: > Arnd Bergmann writes: > > From: Arnd Bergmann > I assume I can continue to build test ATH10K_SNOC with x86 as before? > That's important for me. If yes, then: > > Acked-by: Kalle Valo > > -- > https://patc

[Freedreno] [PATCH 2/2] [v2] qcom_scm: hide Kconfig symbol

2021-09-28 Thread Arnd Bergmann
From: Arnd Bergmann Now that SCM can be a loadable module, we have to add another dependency to avoid link failures when ipa or adreno-gpu are built-in: aarch64-linux-ld: drivers/net/ipa/ipa_main.o: in function `ipa_probe': ipa_main.c:(.text+0xfc4): undefined reference to `qcom_scm_is_available

[Freedreno] [PATCH] drm/msm/submit: fix overflow check on 64-bit architectures

2021-09-27 Thread Arnd Bergmann
From: Arnd Bergmann The overflow check does causes a warning from clang-14 when 'sz' is a type that is smaller than size_t: drivers/gpu/drm/msm/msm_gem_submit.c:217:10: error: result of comparison of constant 18446744073709551615 with expression of type 'unsigned int' is always false [-Werror

Re: [Freedreno] [PATCH] [RFC] qcom_scm: hide Kconfig symbol

2021-09-29 Thread Arnd Bergmann
On Wed, Sep 29, 2021 at 11:51 AM Will Deacon wrote: > On Mon, Sep 27, 2021 at 05:22:13PM +0200, Arnd Bergmann wrote: > > > > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig > > index 124c41adeca1..989c83acbfee 100644 > > --- a/drivers/iommu/Kconfig >

Re: [Freedreno] [PATCH] [RFC] qcom_scm: hide Kconfig symbol

2021-09-29 Thread Arnd Bergmann
On Wed, Sep 29, 2021 at 4:46 PM Bjorn Andersson wrote: > > On Wed 29 Sep 05:04 CDT 2021, Arnd Bergmann wrote: > > > On Wed, Sep 29, 2021 at 11:51 AM Will Deacon wrote: > > > On Mon, Sep 27, 2021 at 05:22:13PM +0200, Arnd Bergmann wrote: > > > > > >

[Freedreno] [PATCH v2 2/2] qcom_scm: hide Kconfig symbol

2021-10-07 Thread Arnd Bergmann
From: Arnd Bergmann Now that SCM can be a loadable module, we have to add another dependency to avoid link failures when ipa or adreno-gpu are built-in: aarch64-linux-ld: drivers/net/ipa/ipa_main.o: in function `ipa_probe': ipa_main.c:(.text+0xfc4): undefined reference to `qcom_scm_is_available

[Freedreno] [PATCH v2 1/2] firmware: include drivers/firmware/Kconfig unconditionally

2021-10-07 Thread Arnd Bergmann
From: Arnd Bergmann Compile-testing drivers that require access to a firmware layer fails when that firmware symbol is unavailable. This happened twice this week: - My proposed to change to rework the QCOM_SCM firmware symbol broke on ppc64 and others. - The cs_dsp firmware patch added

[Freedreno] [PATCH] [RFC] qcom_scm: hide Kconfig symbol

2021-09-27 Thread Arnd Bergmann
From: Arnd Bergmann Now that SCM can be a loadable module, we have to add another dependency to avoid link failures when ipa or adreno-gpu are built-in: aarch64-linux-ld: drivers/net/ipa/ipa_main.o: in function `ipa_probe': ipa_main.c:(.text+0xfc4): undefined reference to `qcom_scm_is_available

Re: [Freedreno] [PATCH] [RFC] qcom_scm: hide Kconfig symbol

2021-09-27 Thread Arnd Bergmann
On Mon, Sep 27, 2021 at 10:42 PM Bjorn Andersson wrote: > On Mon 27 Sep 13:15 PDT 2021, Arnd Bergmann wrote: > > On Mon, Sep 27, 2021 at 9:52 PM Bjorn Andersson > > wrote: > > > > An easier option might be to find a way to build QCOM_SCM without > > RESET_CONTRO

Re: [Freedreno] [PATCH] [RFC] qcom_scm: hide Kconfig symbol

2021-09-27 Thread Arnd Bergmann
On Mon, Sep 27, 2021 at 9:52 PM Bjorn Andersson wrote: > On Mon 27 Sep 08:22 PDT 2021, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > - To avoid a circular dependency chain involving RESET_CONTROLLER > >and PINCTRL_SUNXI, change the 'depends on RESET_CONTR

[Freedreno] [PATCH] drm/msm/dp: fix missing #include

2021-10-26 Thread Arnd Bergmann
From: Arnd Bergmann Some randconfig builds fail when drm/drm_bridge.h is not included implicitly in this file: drivers/gpu/drm/msm/dp/dp_parser.c:279:25: error: implicit declaration of function 'devm_drm_panel_bridge_add' [-Werror,-Wimplicit-function-declaration] parser->panel_bri

[Freedreno] [PATCH] drm/msm/a6xx: add QMP dependency

2023-10-16 Thread Arnd Bergmann
From: Arnd Bergmann When QMP is in a loadable module, the A6xx GPU driver fails to link as built-in: x86_64-linux-ld: drivers/gpu/drm/msm/adreno/a6xx_gmu.o: in function `a6xx_gmu_resume': a6xx_gmu.c:(.text+0xd62): undefined reference to `qmp_send' Add the usual dependency that still allows

[Freedreno] [PATCH] drm/msm/gpu: Add proper DEVFREQ_GOV_SIMPLE_ONDEMAND dependency

2023-01-18 Thread Arnd Bergmann
From: Arnd Bergmann DRM_MSM can no longer be built when devfreq is disabled: WARNING: unmet direct dependencies detected for DEVFREQ_GOV_SIMPLE_ONDEMAND Depends on [n]: PM_DEVFREQ [=n] Selected by [y]: - DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QC

[Freedreno] [PATCH] drm/msm/a6xx: add CONFIG_PM dependency

2023-03-24 Thread Arnd Bergmann
From: Arnd Bergmann Selecting CONFIG_PM_GENERIC_DOMAINS causes a build failure when CONFIG_PM is not enabled: WARNING: unmet direct dependencies detected for PM_GENERIC_DOMAINS Depends on [n]: PM [=n] Selected by [m]: - DRM_MSM [=m] && HAS_IOMEM [=y] && DRM [=m] &

[PATCH] drm/msm: remove an unused-but-set variable

2024-04-05 Thread Arnd Bergmann
From: Arnd Bergmann The modification to a6xx_get_shader_block() had no effect other than causing a warning: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable 'out' set but not used [-Werror,-Wunused-but-set-variable] u64 out = dumper->iova + A6XX_CD_DATA_OFF