Re: [Freedreno] [PATCH v2 07/18] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC

2022-11-08 Thread Krzysztof Kozlowski
On 08/11/2022 13:46, Dmitry Baryshkov wrote: > On 08/11/2022 02:56, Bryan O'Donoghue wrote: >> Currently we do not differentiate between the various users of the >> qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one >> compatible string but, the hardware does have some

Re: [Freedreno] [PATCH v2 06/18] dt-bindings: msm: dsi-controller-main: Alphanumerically sort compatible enum

2022-11-08 Thread Krzysztof Kozlowski
On 08/11/2022 00:56, Bryan O'Donoghue wrote: > Sort the order of the compatible strings alphanumerically. > > Cc: Rob Clark > Cc: Abhinav Kumar > Cc: Dmitry Baryshkov > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter > Cc: Rob Herring > Cc: Krzysz

Re: [Freedreno] [PATCH v2 05/18] dt-bindings: msm: dsi-controller-main: Fix description of core clock

2022-11-08 Thread Krzysztof Kozlowski
On 08/11/2022 00:56, Bryan O'Donoghue wrote: > There's a typo in describing the core clock as an 'escape' clock. The > accurate description is 'core'. > > Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI > bindings") > Cc: Rob Clark Acked-by

Re: [Freedreno] [PATCH v2 03/18] dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in

2022-11-08 Thread Krzysztof Kozlowski
gs: msm: dsi: add yaml schemas for DSI > bindings") > Cc: Rob Clark > Cc: Abhinav Kumar > Cc: Dmitry Baryshkov > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter > Cc: Rob Herring > Cc: Krzysztof Kozlowski > Cc: linux-arm-...@vger.kernel.org >

Re: [Freedreno] [PATCH v2 02/18] dt-bindings: msm: dsi-controller-main: Fix power-domain constraint

2022-11-08 Thread Krzysztof Kozlowski
he apq8064 so we shouldn't > be marking power-domain as required in yaml checks. > > Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI > bindings") > Reviewed-by: Dmitry Baryshkov > Cc: Rob Clark > Cc: Abhinav Kumar > Cc: Dmitry Baryshkov >

Re: [Freedreno] [PATCH v9 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-11-08 Thread Krzysztof Kozlowski
On 24/10/2022 18:42, Dmitry Baryshkov wrote: > Move properties common to all MDSS DT nodes to the mdss-common.yaml. > > This extends qcom,msm8998-mdss schema to allow interconnect nodes, which > will be added later, once msm8998 gains interconnect support. (...) > +minItems: 1 > +

Re: [Freedreno] [PATCH v9 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml

2022-11-08 Thread Krzysztof Kozlowski
On 24/10/2022 18:42, Dmitry Baryshkov wrote: > Move properties common to all DPU DT nodes to the dpu-common.yaml. > > Note, this removes description of individual DPU port@ nodes. However > such definitions add no additional value. The reg values do not > correspond to hardware INTF indices. The

Re: [Freedreno] [PATCH v3 3/8] dt-bindings: display/msm: add support for the display on SM8450

2022-11-08 Thread Krzysztof Kozlowski
On 04/11/2022 14:03, Dmitry Baryshkov wrote: > Add DPU and MDSS schemas to describe MDSS and DPU blocks on the Qualcomm > SM8450 platform. > > Signed-off-by: Dmitry Baryshkov > --- > .../bindings/display/msm/qcom,sm8450-dpu.yaml | 132 +++ > .../display/msm/qcom,sm8450-mdss.yaml |

Re: [Freedreno] [PATCH v1 3/5] arm64: dts: qcom: sm8450-hdk: enable display hardware

2022-11-07 Thread Krzysztof Kozlowski
On 07/11/2022 11:46, Konrad Dybcio wrote: > > > On 06/11/2022 05:30, Bjorn Andersson wrote: >> On Fri, Nov 04, 2022 at 04:13:56PM +0300, Dmitry Baryshkov wrote: >>> Enable MDSS/DPU/DSI0 on SM8450-HDK device. Note, there is no panel >>> configuration (yet). >>> >>> Signed-off-by: Dmitry Baryshkov

Re: [Freedreno] [PATCH v1 5/5] arm64: dts: qcom: sm8450-hdk: Enable HDMI Display

2022-11-04 Thread Krzysztof Kozlowski
remote-endpoint = <_a>; > + data-lanes = <0 1 2 3>; > + }; > + }; > + }; > + Drop blank line. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v1 4/5] arm64: dts: qcom: sm8450-hdk: Add LT9611uxc HDMI bridge

2022-11-04 Thread Krzysztof Kozlowski
On 04/11/2022 09:13, Dmitry Baryshkov wrote: > From: Vinod Koul > > Add the LT9611uxc DSI-HDMI bridge and supplies > > Signed-off-by: Vinod Koul > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 61 + > 1 file changed, 61

Re: [Freedreno] [PATCH v1 2/5] arm64: dts: qcom: sm8450: add display hardware devices

2022-11-04 Thread Krzysztof Kozlowski
On 04/11/2022 09:13, Dmitry Baryshkov wrote: > Add devices tree nodes describing display hardware on SM8450: > - Display Clock Controller > - MDSS > - MDP > - two DSI controllers and DSI PHYs > > This does not provide support for DP controllers present on SM8450. > > Signed-off-by: Dmitry

Re: [Freedreno] [PATCH] dt-bindings: qcom: add another exception to the device naming rule

2022-11-04 Thread Krzysztof Kozlowski
1 file changed, 1 insertion(+) Thanks Dmitry! Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v2 3/8] dt-bindings: display/msm: add support for the display on SM8450

2022-11-04 Thread Krzysztof Kozlowski
On 04/11/2022 08:45, Dmitry Baryshkov wrote: > On 03/11/2022 17:03, Krzysztof Kozlowski wrote: >> On 02/11/2022 19:13, Dmitry Baryshkov wrote: >>> Add DPU and MDSS schemas to describe MDSS and DPU blocks on the Qualcomm >>> SM8450 platform. >>>

Re: [Freedreno] [PATCH v2 3/8] dt-bindings: display/msm: add support for the display on SM8450

2022-11-04 Thread Krzysztof Kozlowski
On 04/11/2022 08:34, Dmitry Baryshkov wrote: > On 03/11/2022 17:03, Krzysztof Kozlowski wrote: >> On 02/11/2022 19:13, Dmitry Baryshkov wrote: >>> Add DPU and MDSS schemas to describe MDSS and DPU blocks on the Qualcomm >>> SM8450 platform. >>>

Re: [Freedreno] [PATCH v2 3/8] dt-bindings: display/msm: add support for the display on SM8450

2022-11-03 Thread Krzysztof Kozlowski
On 02/11/2022 19:13, Dmitry Baryshkov wrote: > Add DPU and MDSS schemas to describe MDSS and DPU blocks on the Qualcomm > SM8450 platform. > > Signed-off-by: Dmitry Baryshkov > --- > .../bindings/display/msm/qcom,sm8450-dpu.yaml | 132 +++ > .../display/msm/qcom,sm8450-mdss.yaml |

Re: [Freedreno] [PATCH v2 2/8] dt-bindings: display/msm: add sm8350 and sm8450 DSI PHYs

2022-11-03 Thread Krzysztof Kozlowski
On 02/11/2022 19:13, Dmitry Baryshkov wrote: > SM8350 and SM8450 platforms use the same driver and same bindings as the > existing 7nm DSI PHYs. Add corresponding compatibility strings. > > Signed-off-by: Dmitry Baryshkov > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v2 1/8] dt-bindings: display/msm/dsi-controller-main: allow defining opp-table

2022-11-03 Thread Krzysztof Kozlowski
On 02/11/2022 19:13, Dmitry Baryshkov wrote: > Allow defining DSI OPP table inside the DSI controller node. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [RESEND PATCH v1] dt-bindings: display/msm: convert MDP5 schema to YAML format

2022-11-03 Thread Krzysztof Kozlowski
On 02/11/2022 18:08, Dmitry Baryshkov wrote: > Convert the mdp5.txt into the yaml format. Changes to the existing (txt) > schema: > - MSM8996 has additional "iommu" clock, define it separately > - Add new properties used on some of platforms: >- interconnects, interconnect-names >-

Re: [Freedreno] [RFC PATCH v2 04/11] dt-bindings: arm-smmu: add special case for Google Cheza platform

2022-11-02 Thread Krzysztof Kozlowski
o arm,smmu.yaml schema. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [RFC PATCH v2 03/11] dt-bindings: arm-smmu: fix clocks/clock-names schema

2022-11-02 Thread Krzysztof Kozlowski
On 02/11/2022 14:44, Dmitry Baryshkov wrote: > Rework clocks/clock-names properties schema to property describe s/property/properly/ with that: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [RFC PATCH v2 03/11] dt-bindings: arm-smmu: fix clocks/clock-names schema

2022-11-02 Thread Krzysztof Kozlowski
On 02/11/2022 14:44, Dmitry Baryshkov wrote: > Rework clocks/clock-names properties schema to property describe > possible usage cases. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [RFC PATCH v2 01/11] arm64: dts: qcom: msm8996: change order of SMMU clocks on this platform

2022-11-02 Thread Krzysztof Kozlowski
On 02/11/2022 14:44, Dmitry Baryshkov wrote: > Change order of SMMU clocks to match the schema. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v1 9/9] arm64: dts: qcom: sm8350-hdk: Enable lt9611uxc dsi-hdmi bridge

2022-10-28 Thread Krzysztof Kozlowski
On 28/10/2022 08:08, Robert Foss wrote: > The sm8350-hdk ships with the LT9611 UXC DSI/HDMI bridge chip. > > In order to toggle the board to enable the HDMI output, > switch #7 & #8 on the rightmost multi-switch package have > to be toggled to On. > > Signed-off-by: Robert Foss > --- >

Re: [Freedreno] [PATCH v1 8/9] arm64: dts: qcom: sm8350-hdk: Enable display & dsi nodes

2022-10-28 Thread Krzysztof Kozlowski
On 28/10/2022 08:08, Robert Foss wrote: > Enable the display subsystem and the dsi0 output for > the sm8350-hdk board. > > Signed-off-by: Robert Foss > --- > arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git

Re: [Freedreno] [PATCH v1 7/9] arm64: dts: qcom: sm8350: Add display system nodes

2022-10-28 Thread Krzysztof Kozlowski
On 28/10/2022 08:08, Robert Foss wrote: > Add mdss, mdss_mdp, dsi0, dsi0_phy nodes. With these > nodes the display subsystem is configured to support > one DSI output. > > Signed-off-by: Robert Foss > --- > arch/arm64/boot/dts/qcom/sm8350.dtsi | 196 ++- > 1 file

Re: [Freedreno] [RFC PATCH 3/9] dt-bindings: arm-smmu: Add generic qcom, smmu-500 bindings

2022-10-22 Thread Krzysztof Kozlowski
; Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [RFC PATCH 1/9] dt-bindings: arm-smmu: Add missing Qualcomm SMMU compatibles

2022-10-22 Thread Krzysztof Kozlowski
On 21/10/2022 12:55, Dmitry Baryshkov wrote: > Add missing compatibles used for Adreno SMMU on sc7280 and sm8450 > platforms and for the Qualcomm v2 SMMU used on SDM630 platform. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [RFC PATCH 1/9] dt-bindings: arm-smmu: Add missing Qualcomm SMMU compatibles

2022-10-22 Thread Krzysztof Kozlowski
On 22/10/2022 05:17, Dmitry Baryshkov wrote: > On 22/10/2022 03:59, Krzysztof Kozlowski wrote: >> On 21/10/2022 12:55, Dmitry Baryshkov wrote: >>> Add missing compatibles used for Adreno SMMU on sc7280 and sm8450 >>> platforms and for the Qualcomm v2 SMMU used on SDM6

Re: [Freedreno] [RFC PATCH 1/9] dt-bindings: arm-smmu: Add missing Qualcomm SMMU compatibles

2022-10-21 Thread Krzysztof Kozlowski
On 21/10/2022 12:55, Dmitry Baryshkov wrote: > Add missing compatibles used for Adreno SMMU on sc7280 and sm8450 > platforms and for the Qualcomm v2 SMMU used on SDM630 platform. > > Signed-off-by: Dmitry Baryshkov > --- > Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 11 +++ >

Re: [Freedreno] [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-10-03 Thread Krzysztof Kozlowski
On 23/09/2022 22:32, Dmitry Baryshkov wrote: > On 22/09/2022 15:28, Krzysztof Kozlowski wrote: >> On 22/09/2022 13:46, Dmitry Baryshkov wrote: >>>>> - ranges: true >>>>> +maxItems: 2 >>>>> >>>>> interconnects: >

Re: [Freedreno] [PATCH 2/2] arm64: dts: qcom: msm8996: change HDMI PHY node name to generic one

2022-09-29 Thread Krzysztof Kozlowski
On 24/09/2022 11:43, Dmitry Baryshkov wrote: > Change HDMI PHY node name from custom 'hdmi-phy' to the generic 'phy'. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 1/2] ARM: dts: qcom-apq8064: change HDMI PHY node name to generic one

2022-09-29 Thread Krzysztof Kozlowski
On 24/09/2022 11:43, Dmitry Baryshkov wrote: > Change HDMI PHY node names from custom 'hdmi-phy' to the generic 'phy'. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v2 1/7] dt-bindings: msm/dp: Add SDM845 and SC8280XP compatibles

2022-09-26 Thread Krzysztof Kozlowski
On 26/09/2022 17:13, Rob Herring wrote: > On Thu, Sep 22, 2022 at 05:37:39PM +0200, Krzysztof Kozlowski wrote: >> On 22/09/2022 02:14, Bjorn Andersson wrote: >>> On Tue, Sep 20, 2022 at 09:09:13AM +0200, Krzysztof Kozlowski wrote: >>>> On 19/09/2022 23:18, Bjorn Ande

Re: [Freedreno] [PATCH v2 1/2] dt-bindings: display/msm: Add QCM2290 DSI phy

2022-09-25 Thread Krzysztof Kozlowski
On 24/09/2022 11:15, Dmitry Baryshkov wrote: > On 24/09/2022 12:12, Krzysztof Kozlowski wrote: >> On 24/09/2022 10:51, Dmitry Baryshkov wrote: >>> From: Loic Poulain >>> >>> QCM2290 platform uses the 14nm DSI PHY driver. >>> >>> Signed-o

Re: [Freedreno] [PATCH v8 01/12] dt-bindings: display/msm: split qcom, mdss bindings

2022-09-24 Thread Krzysztof Kozlowski
On Sat, 24 Sep 2022 15:36:00 +0300, Dmitry Baryshkov wrote: > Split Mobile Display SubSystem (MDSS) root node bindings to the separate > yaml file. Changes to the existing (txt) schema: > - Added optional "vbif_nrt_phys" region used by msm8996 > - Made "bus" and "vsync" clocks optional (they are

Re: [Freedreno] [PATCH v8 03/12] dt-bindings: display/msm: add interconnects property to qcom, mdss-smd845

2022-09-24 Thread Krzysztof Kozlowski
ted in the > schema. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Dmitry Baryshkov > --- > .../devicetree/bindings/display/msm/dpu-sdm845.yaml| 10 ++ > 1 file changed, 10 insertions(+) > Running 'make dtbs_check' with the schema in this patch gives the follow

Re: [Freedreno] [PATCH 9/9] arm64: dts: qcom: sm8250: change DSI PHY node name to generic one

2022-09-24 Thread Krzysztof Kozlowski
On 24/09/2022 11:01, Dmitry Baryshkov wrote: > Change DSI PHY node names from custom 'dsi-phy' to the generic 'phy'. > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 8/9] arm64: dts: qcom: sdm845: change DSI PHY node name to generic one

2022-09-24 Thread Krzysztof Kozlowski
On 24/09/2022 11:01, Dmitry Baryshkov wrote: > Change DSI PHY node names from custom 'dsi-phy' to the generic 'phy'. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 7/9] arm64: dts: qcom: sdm660: change DSI PHY node name to generic one

2022-09-24 Thread Krzysztof Kozlowski
On 24/09/2022 11:01, Dmitry Baryshkov wrote: > Change DSI PHY node names from custom 'dsi-phy' to the generic 'phy'. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 6/9] arm64: dts: qcom: sdm630: change DSI PHY node name to generic one

2022-09-24 Thread Krzysztof Kozlowski
On 24/09/2022 11:01, Dmitry Baryshkov wrote: > Change DSI PHY node names from custom 'dsi-phy' to the generic 'phy'. > > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sdm630.dtsi | 2 +- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 5/9] arm64: dts: qcom: sc7180: change DSI PHY node name to generic one

2022-09-24 Thread Krzysztof Kozlowski
On 24/09/2022 11:01, Dmitry Baryshkov wrote: > Change DSI PHY node names from custom 'dsi-phy' to the generic 'phy'. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 4/9] arm64: dts: qcom: msm8996: change DSI PHY node name to generic one

2022-09-24 Thread Krzysztof Kozlowski
On 24/09/2022 11:01, Dmitry Baryshkov wrote: > Change DSI PHY node names from custom 'dsi-phy' to the generic 'phy'. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 3/9] arm64: dts: qcom: msm8916: change DSI PHY node name to generic one

2022-09-24 Thread Krzysztof Kozlowski
On 24/09/2022 11:01, Dmitry Baryshkov wrote: > Change DSI PHY node names from custom 'dsi-phy' to the generic 'phy'. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 2/9] ARM: dts: qcom-msm8974: change DSI PHY node name to generic one

2022-09-24 Thread Krzysztof Kozlowski
On 24/09/2022 11:01, Dmitry Baryshkov wrote: > Change DSI PHY node names from custom 'dsi-phy' to the generic 'phy'. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 1/9] ARM: dts: qcom-apq8064: change DSI PHY node name to generic one

2022-09-24 Thread Krzysztof Kozlowski
On 24/09/2022 11:01, Dmitry Baryshkov wrote: > Change DSI PHY node names from custom 'dsi-phy' to the generic 'phy'. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 0/9] arm: dts: qcom: rename DSI PHY nodes

2022-09-24 Thread Krzysztof Kozlowski
On 24/09/2022 11:20, Dmitry Baryshkov wrote: > On 24/09/2022 12:11, Krzysztof Kozlowski wrote: >> On 24/09/2022 11:00, Dmitry Baryshkov wrote: >>> Historically DSI PHY device tree nodes used the dsi-phy@ names. Replace >>> them with generic phy@ names. >>> >&

Re: [Freedreno] [PATCH v2 1/2] dt-bindings: display/msm: Add QCM2290 DSI phy

2022-09-24 Thread Krzysztof Kozlowski
On 24/09/2022 10:51, Dmitry Baryshkov wrote: > From: Loic Poulain > > QCM2290 platform uses the 14nm DSI PHY driver. > > Signed-off-by: Loic Poulain > [DB: changed compat to follow the agreed scheme] Bjorn asked to keep consistency in other case:

Re: [Freedreno] [PATCH 0/9] arm: dts: qcom: rename DSI PHY nodes

2022-09-24 Thread Krzysztof Kozlowski
On 24/09/2022 11:00, Dmitry Baryshkov wrote: > Historically DSI PHY device tree nodes used the dsi-phy@ names. Replace > them with generic phy@ names. > > Dmitry Baryshkov (9): > ARM: dts: qcom-apq8064: change DSI PHY node name to generic one dsi-phy is similar to other generic names (usb-phy,

Re: [Freedreno] [PATCH v2 1/7] dt-bindings: msm/dp: Add SDM845 and SC8280XP compatibles

2022-09-22 Thread Krzysztof Kozlowski
On 22/09/2022 02:14, Bjorn Andersson wrote: > On Tue, Sep 20, 2022 at 09:09:13AM +0200, Krzysztof Kozlowski wrote: >> On 19/09/2022 23:18, Bjorn Andersson wrote: >>> On Sat, Sep 17, 2022 at 06:03:27PM +0100, Krzysztof Kozlowski wrote: >>>> On 16/09/2022 21:00, Bjo

Re: [Freedreno] [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-09-22 Thread Krzysztof Kozlowski
On 22/09/2022 13:46, Dmitry Baryshkov wrote: >>> - ranges: true >>> +maxItems: 2 >>> >>> interconnects: >>> -items: >>> - - description: Interconnect path from mdp0 port to the data bus >>> - - description: Interconnect path from mdp1 port to the data bus >>> +

Re: [Freedreno] [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-09-22 Thread Krzysztof Kozlowski
On 22/09/2022 13:47, Dmitry Baryshkov wrote: missing allOf >>> >>> Rob asked to remove this while reviewing v6 ([1]). And indeed the >>> allOf's around a single $ref do not seem to be necessary >> >> He commented on one of properties, not top-level, maybe it is different >> case for

Re: [Freedreno] [PATCH v7 06/12] dt-bindings: display/msm: split dpu-sc7180 into DPU and MDSS parts

2022-09-22 Thread Krzysztof Kozlowski
On 22/09/2022 12:30, Dmitry Baryshkov wrote: >>> +display-subsystem@ae0 { >>> +#address-cells = <1>; >>> +#size-cells = <1>; >>> +compatible = "qcom,sc7180-mdss"; >>> +reg = <0xae0 0x1000>; >>> +reg-names = "mdss"; >>> +power-domains = <

Re: [Freedreno] [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-09-22 Thread Krzysztof Kozlowski
On 22/09/2022 09:53, Dmitry Baryshkov wrote: > On Thu, 22 Sept 2022 at 10:05, Krzysztof Kozlowski > wrote: >> >> On 15/09/2022 15:37, Dmitry Baryshkov wrote: >>> Move properties common to all MDSS DT nodes to the mdss-common.yaml. >>> >>> T

Re: [Freedreno] [PATCH v7 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml

2022-09-22 Thread Krzysztof Kozlowski
On 22/09/2022 09:50, Dmitry Baryshkov wrote: > On Thu, 22 Sept 2022 at 10:02, Krzysztof Kozlowski > wrote: >> >> On 15/09/2022 15:37, Dmitry Baryshkov wrote: >>> Move properties common to all DPU DT nodes to the dpu-common.yaml. >>> >>> Note, this remo

Re: [Freedreno] [PATCH v7 12/12] dt-bindings: display/msm: add support for the display on SM8250

2022-09-22 Thread Krzysztof Kozlowski
On 15/09/2022 15:37, Dmitry Baryshkov wrote: > Add DPU and MDSS schemas to describe MDSS and DPU blocks on the Qualcomm > SM8250 platform. > > Signed-off-by: Dmitry Baryshkov > --- > .../bindings/display/msm/mdss-common.yaml | 4 +- > .../bindings/display/msm/qcom,sm8250-dpu.yaml | 92

Re: [Freedreno] [PATCH v7 11/12] dt-bindings: display/msm: add missing device nodes to mdss-* schemas

2022-09-22 Thread Krzysztof Kozlowski
On 15/09/2022 15:37, Dmitry Baryshkov wrote: > Add missing device nodes (DSI, PHYs, DP/eDP) to the existing MDSS > schemas. > > Reviewed-by: Rob Herring > Signed-off-by: Dmitry Baryshkov > --- > .../display/msm/qcom,msm8998-mdss.yaml| 12 + >

Re: [Freedreno] [PATCH v7 06/12] dt-bindings: display/msm: split dpu-sc7180 into DPU and MDSS parts

2022-09-22 Thread Krzysztof Kozlowski
On 15/09/2022 15:37, Dmitry Baryshkov wrote: > In order to make the schema more readable, split dpu-sc7180 into the DPU > and MDSS parts, each one describing just a single device binding. > > Signed-off-by: Dmitry Baryshkov Thank you for your patch. There is something to discuss/improve. >

Re: [Freedreno] [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-09-22 Thread Krzysztof Kozlowski
On 15/09/2022 15:37, Dmitry Baryshkov wrote: > Move properties common to all MDSS DT nodes to the mdss-common.yaml. > > This extends qcom,msm8998-mdss schema to allow interconnect nodes, which > will be added later, once msm8998 gains interconnect support. > > Signed-off-by: Dmitry Baryshkov >

Re: [Freedreno] [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-09-22 Thread Krzysztof Kozlowski
On 15/09/2022 15:37, Dmitry Baryshkov wrote: > Move properties common to all MDSS DT nodes to the mdss-common.yaml. > > This extends qcom,msm8998-mdss schema to allow interconnect nodes, which > will be added later, once msm8998 gains interconnect support. > > Signed-off-by: Dmitry Baryshkov >

Re: [Freedreno] [PATCH v7 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml

2022-09-22 Thread Krzysztof Kozlowski
On 15/09/2022 15:37, Dmitry Baryshkov wrote: > Move properties common to all DPU DT nodes to the dpu-common.yaml. > > Note, this removes description of individual DPU port@ nodes. However > such definitions add no additional value. The reg values do not > correspond to hardware INTF indices. The

Re: [Freedreno] [PATCH v7 03/12] dt-bindings: display/msm: add interconnects property to qcom, mdss-smd845

2022-09-22 Thread Krzysztof Kozlowski
On 15/09/2022 15:37, Dmitry Baryshkov wrote: > Add interconnects required for the SDM845 MDSS device tree node. This > change was made in the commit c8c61c09e38b ("arm64: dts: qcom: sdm845: > Add interconnects property for display"), but was not reflected in the > schema.

Re: [Freedreno] [PATCH v2 1/7] dt-bindings: msm/dp: Add SDM845 and SC8280XP compatibles

2022-09-20 Thread Krzysztof Kozlowski
On 19/09/2022 23:18, Bjorn Andersson wrote: > On Sat, Sep 17, 2022 at 06:03:27PM +0100, Krzysztof Kozlowski wrote: >> On 16/09/2022 21:00, Bjorn Andersson wrote: >>> From: Bjorn Andersson >>> >>> Add compatibles for the DisplayPort and Embedded Displ

Re: [Freedreno] [PATCH v2 1/7] dt-bindings: msm/dp: Add SDM845 and SC8280XP compatibles

2022-09-17 Thread Krzysztof Kozlowski
icinc SoB (unless you also take ownership). Acked-by: Krzysztof Kozlowski \ Best regards, Krzysztof

Re: [Freedreno] [PATCH v6 01/12] dt-bindings: display/msm: split qcom, mdss bindings

2022-09-15 Thread Krzysztof Kozlowski
On 15/09/2022 12:50, Dmitry Baryshkov wrote: > On 11/09/2022 22:19, Krzysztof Kozlowski wrote: >> On 11/09/2022 20:36, Krzysztof Kozlowski wrote: >> >>>> If your child schema fails, the referencing schema fails as well... >>> >>> >>> Although

Re: [Freedreno] [PATCH v6 01/12] dt-bindings: display/msm: split qcom, mdss bindings

2022-09-11 Thread Krzysztof Kozlowski
On 11/09/2022 20:36, Krzysztof Kozlowski wrote: >> If your child schema fails, the referencing schema fails as well... > > > Although now with DSI-PHY I cannot reproduce it and I am pretty sure I > reproduced it with DPU controllers after modifying the DTS to lack a > pr

Re: [Freedreno] [PATCH v6 01/12] dt-bindings: display/msm: split qcom, mdss bindings

2022-09-11 Thread Krzysztof Kozlowski
On 11/09/2022 20:36, Krzysztof Kozlowski wrote: >> /home/krzk/dev/linux/linux/out/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dtb: >> dsi@c994000: 'vdda-supply' does not match any of the regexes: >> 'pinctrl-[0-9]+' >> >> >> >> If your child schema f

Re: [Freedreno] [PATCH v6 01/12] dt-bindings: display/msm: split qcom, mdss bindings

2022-09-11 Thread Krzysztof Kozlowski
On 11/09/2022 20:32, Krzysztof Kozlowski wrote: > On 11/09/2022 19:45, Dmitry Baryshkov wrote: >> On Sun, 11 Sept 2022 at 16:57, Krzysztof Kozlowski >> wrote: >>> >>> On 11/09/2022 15:45, Dmitry Baryshkov wrote: >>>> On Sun, 11 Sept 2

Re: [Freedreno] [PATCH v6 01/12] dt-bindings: display/msm: split qcom, mdss bindings

2022-09-11 Thread Krzysztof Kozlowski
On 11/09/2022 19:45, Dmitry Baryshkov wrote: > On Sun, 11 Sept 2022 at 16:57, Krzysztof Kozlowski > wrote: >> >> On 11/09/2022 15:45, Dmitry Baryshkov wrote: >>> On Sun, 11 Sept 2022 at 14:27, Krzysztof Kozlowski >>> wrote: >>>>

Re: [Freedreno] [PATCH v6 01/12] dt-bindings: display/msm: split qcom, mdss bindings

2022-09-11 Thread Krzysztof Kozlowski
On 11/09/2022 15:45, Dmitry Baryshkov wrote: > On Sun, 11 Sept 2022 at 14:27, Krzysztof Kozlowski > wrote: >> >> On 10/09/2022 14:54, Dmitry Baryshkov wrote: >>>> >>>> However I think there is no such problem, as Dmitry said, that ref >>>> c

Re: [Freedreno] [PATCH v6 01/12] dt-bindings: display/msm: split qcom, mdss bindings

2022-09-11 Thread Krzysztof Kozlowski
On 10/09/2022 14:54, Dmitry Baryshkov wrote: >> >> However I think there is no such problem, as Dmitry said, that ref >> changes anything. There will be always failure - either from parent >> schema (using $ref) or from device child schema (the one which actually >> misses the property). > >

Re: [Freedreno] [PATCH v6 01/12] dt-bindings: display/msm: split qcom, mdss bindings

2022-09-10 Thread Krzysztof Kozlowski
On 10/09/2022 00:23, Rob Herring wrote: This should be ref to dsi-controller-main.yaml... or based on previous Rob's feedback you dropped it everywhere in children? >>> >>> I don't think I said. I thought about it some, as yes, we normally have >>> done as you suggested. The

Re: [Freedreno] [RFC PATCH 0/3] Limit pluggable display modes

2022-09-09 Thread Krzysztof Kozlowski
On 08/09/2022 20:05, Dmitry Baryshkov wrote: > > On 30/08/2022 06:33, Abhinav Kumar wrote: >> As reported on https://gitlab.freedesktop.org/drm/msm/-/issues/17, currently >> there is no mechanism to limit the display output to the pluggable displays >> and it lets users connect any monitor on any

Re: [Freedreno] [PATCH v6 06/12] dt-bindings: display/msm: split dpu-sc7180 into DPU and MDSS parts

2022-09-08 Thread Krzysztof Kozlowski
On 08/09/2022 15:44, Krzysztof Kozlowski wrote: >> + interconnects: >> +maxItems: 1 >> + >> + interconnect-names: >> +maxItems: 1 >> + >> +patternProperties: >> + "^display-controller@[0-9a-f]+$": >> +type: object &

Re: [Freedreno] [PATCH v6 06/12] dt-bindings: display/msm: split dpu-sc7180 into DPU and MDSS parts

2022-09-08 Thread Krzysztof Kozlowski
On 01/09/2022 12:23, Dmitry Baryshkov wrote: > In order to make the schema more readable, split dpu-sc7180 into the DPU > and MDSS parts, each one describing just a single device binding. > > Signed-off-by: Dmitry Baryshkov Thank you for your patch. There is something to discuss/improve. > -

Re: [Freedreno] [PATCH v6 01/12] dt-bindings: display/msm: split qcom, mdss bindings

2022-09-08 Thread Krzysztof Kozlowski
On 01/09/2022 12:23, Dmitry Baryshkov wrote: > Split Mobile Display SubSystem (MDSS) root node bindings to the separate > yaml file. Changes to the existing (txt) schema: > - Added optional "vbif_nrt_phys" region used by msm8996 > - Made "bus" and "vsync" clocks optional (they are not used by

Re: [Freedreno] [PATCH v5 5/6] dt-bindings: drm/msm/gpu: Add optional resets

2022-08-30 Thread Krzysztof Kozlowski
lank line (Krzysztof) FWIW: Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v4 03/10] dt-bindings: display/msm: move qcom, sc7180-mdss schema to mdss.yaml

2022-08-25 Thread Krzysztof Kozlowski
On 25/08/2022 15:40, Dmitry Baryshkov wrote: >>> clock-names: >>> items: >>> + - const: bus >>> - const: iface >>> - - const: ahb >>> + - const: rot >>> + - const: lut >>> - const: core >>> + - const: vsync >> >> All these changes point that

Re: [Freedreno] [PATCH v4 03/10] dt-bindings: display/msm: move qcom, sc7180-mdss schema to mdss.yaml

2022-08-25 Thread Krzysztof Kozlowski
On 25/08/2022 12:50, Dmitry Baryshkov wrote: > Move schema for qcom,sc7180-mdss from dpu-sc7180.yaml to mdss.yaml so > that the dpu file describes only the DPU schema. MDSS grows to unmanagable file. I don't think we will be able to keep it maintained. You will have many if-else defining subnodes

Re: [Freedreno] [PATCH v4 02/10] dt-bindings: display/msm: move qcom, sdm845-mdss schema to mdss.yaml

2022-08-25 Thread Krzysztof Kozlowski
On 25/08/2022 12:50, Dmitry Baryshkov wrote: > Move schema for qcom,sdm845-mdss from dpu-sdm845.yaml to mdss.yaml so > that the dpu file describes only the DPU schema. > > Signed-off-by: Dmitry Baryshkov > --- > .../bindings/display/msm/dpu-sdm845.yaml | 135 +++-- >

Re: [Freedreno] [PATCH v4 01/10] dt-bindings: display/msm: split qcom, mdss bindings

2022-08-25 Thread Krzysztof Kozlowski
On 25/08/2022 12:50, Dmitry Baryshkov wrote: (...) > +minItems: 1 > +maxItems: 4 > + > + clock-names: > +minItems: 1 > +maxItems: 4 > + > + "#address-cells": > +const: 1 > + > + "#size-cells": > +const: 1 > + > + ranges: > +true > + > + resets: > +items: > +

Re: [Freedreno] [PATCH v4 01/10] dt-bindings: display/msm: split qcom, mdss bindings

2022-08-25 Thread Krzysztof Kozlowski
; - Dropped the "lut" clock. It was added to the schema by mistake (it is >a part of mdp4 schema, not the mdss). > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

[Freedreno] [PATCH 3/5] dt-bindings: clock: drop minItems equal to maxItems

2022-08-25 Thread Krzysztof Kozlowski
minItems, if missing, are implicitly equal to maxItems, so drop redundant piece to reduce size of code. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/clock/cirrus,cs2000-cp.yaml | 1 - .../devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.yaml | 2

[Freedreno] [PATCH 5/5] dt-bindings: display: drop minItems equal to maxItems

2022-08-25 Thread Krzysztof Kozlowski
minItems, if missing, are implicitly equal to maxItems, so drop redundant piece to reduce size of code. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml | 1 - .../devicetree/bindings/display/msm/dsi-controller-main.yaml| 2

[Freedreno] [PATCH 2/5] dt-bindings: ata: drop minItems equal to maxItems

2022-08-25 Thread Krzysztof Kozlowski
minItems, if missing, are implicitly equal to maxItems, so drop redundant piece to reduce size of code. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml | 1 - .../devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml | 2

[Freedreno] [PATCH 4/5] dt-bindings: crypto: drop minItems equal to maxItems

2022-08-25 Thread Krzysztof Kozlowski
minItems, if missing, are implicitly equal to maxItems, so drop redundant piece to reduce size of code. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings

[Freedreno] [PATCH 1/5] dt-bindings: socionext, uniphier-system-cache: drop minItems equal to maxItems

2022-08-25 Thread Krzysztof Kozlowski
minItems, if missing, are implicitly equal to maxItems, so drop redundant piece to reduce size of code. Signed-off-by: Krzysztof Kozlowski --- .../bindings/arm/socionext/socionext,uniphier-system-cache.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings

Re: [Freedreno] [PATCH] dt-bindings: display: Add missing (unevaluated|additional)Properties on child nodes

2022-08-25 Thread Krzysztof Kozlowski
On 23/08/2022 17:56, Rob Herring wrote: > In order to ensure only documented properties are present, node schemas > must have unevaluatedProperties or additionalProperties set to false > (typically). > > Signed-off-by: Rob Herring Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

[Freedreno] [PATCH v2 5/5] dt-bindings: display/msm: dpu-sdm845: add missing DPU opp-table

2022-08-24 Thread Krzysztof Kozlowski
The 'display-controller' child (DPU) of Display SubSystem (MDSS) uses opp-table, so reference it which allows restricting DPU schema to fixed list of properties. Fixes: 3d7a0dd8f39b ("dt-bindings: msm: disp: add yaml schemas for DPU bindings") Signed-off-by: Krzysztof Kozlowski ---

Re: [Freedreno] [PATCH v4 5/6] dt-bindings: drm/msm/gpu: Add optional resets

2022-08-23 Thread Krzysztof Kozlowski
On 19/08/2022 19:40, Akhil P Oommen wrote: > Documentation/devicetree/bindings/display/msm/gpu.yaml | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml > b/Documentation/devicetree/bindings/display/msm/gpu.yaml > index

Re: [Freedreno] [PATCH v2 06/11] dt-bindings: display/msm: move qcom, sc7180-mdss schema to mdss.yaml

2022-08-23 Thread Krzysztof Kozlowski
On 22/08/2022 22:04, Dmitry Baryshkov wrote: >>> required: >>> - compatible >>> - reg >>> @@ -177,7 +204,19 @@ patternProperties: >>> # TODO: add reference once the mdp5 is converted >>> >>> "^display-controller@(0|[1-9a-f][0-9a-f]*)$": >>> -$ref: dpu-sdm845.yaml >>> +

Re: [Freedreno] [PATCH 3/4] dt-bindings: display/msm/gmu: account for different GMU variants

2022-08-23 Thread Krzysztof Kozlowski
On 22/08/2022 20:58, Dmitry Baryshkov wrote: > On 06/07/2022 18:52, Krzysztof Kozlowski wrote: >> On 06/07/2022 16:52, Dmitry Baryshkov wrote: >>> Make display/msm/gmu.yaml describe all existing GMU variants rather than >>> just the 630.2 (SDM845) version of it. &g

Re: [Freedreno] [PATCH] arm64: dts: qcom: sm8250: move DSI opp table to the dsi0 node

2022-08-23 Thread Krzysztof Kozlowski
On 22/08/2022 22:11, Dmitry Baryshkov wrote: > It makes no sense to have the OPP table for the DSI controllers in the > DSI1 PHY node. Move it to more logical dsi0 device node. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v3 5/5] arm64: dts: qcom: sc7280: Add Reset support for gpu

2022-08-19 Thread Krzysztof Kozlowski
On 18/08/2022 23:18, Akhil P Oommen wrote: > Add support for Reset using GPUCC driver for GPU. This helps to ensure > that GPU state is reset by making sure that CX head switch is collapsed. > > Signed-off-by: Akhil P Oommen > --- > > (no changes since v1) > >

Re: [Freedreno] [PATCH v2 4/5] clk: qcom: gpucc-sc7280: Add cx collapse reset support

2022-08-18 Thread Krzysztof Kozlowski
On 17/08/2022 17:57, Akhil P Oommen wrote: > Allow a consumer driver to poll for cx gdsc collapse through Reset > framework. > > Signed-off-by: Akhil P Oommen > --- > > Changes in v2: > - Minor update to use the updated custom reset ops implementation > > drivers/clk/qcom/gpucc-sc7280.c | 10

Re: [Freedreno] [PATCH v2 2/5] clk: qcom: Allow custom reset ops

2022-08-18 Thread Krzysztof Kozlowski
On 17/08/2022 17:57, Akhil P Oommen wrote: Thank you for your patch. There is something to discuss/improve. > > return regmap_update_bits(rst->regmap, map->reg, mask, 0); > diff --git a/drivers/clk/qcom/reset.h b/drivers/clk/qcom/reset.h > index 2a08b5e..d4213b4 100644 > ---

[Freedreno] [PATCH v2 4/5] dt-bindings: display/msm: dpu-sc7280: add missing DPU opp-table

2022-08-17 Thread Krzysztof Kozlowski
The 'display-controller' child (DPU) of Display SubSystem (MDSS) uses opp-table, so reference it which allows restricting DPU schema to fixed list of properties. Fixes: 57fd4f34ddac ("dt-bindings: msm: add DT bindings for sc7280") Signed-off-by: Krzysztof Kozlowski --- Cc: Dmitry Bar

[Freedreno] [PATCH v2 1/5] dt-bindings: display/msm: dpu-msm8998: add missing DPU opp-table

2022-08-17 Thread Krzysztof Kozlowski
The 'display-controller' child (DPU) of Display SubSystem (MDSS) uses opp-table, so reference it which allows restricting DPU schema to fixed list of properties. Fixes: 6e986a8f1cf1 ("dt-bindings: display: msm: Add binding for msm8998 dpu") Signed-off-by: Krzysztof Kozlowski ---

[Freedreno] [PATCH v2 3/5] dt-bindings: display/msm: dpu-sc7180: add missing DPU opp-table

2022-08-17 Thread Krzysztof Kozlowski
The 'display-controller' child (DPU) of Display SubSystem (MDSS) uses opp-table, so reference it which allows restricting DPU schema to fixed list of properties. Fixes: 3d7a0dd8f39b ("dt-bindings: msm: disp: add yaml schemas for DPU bindings") Signed-off-by: Krzysztof Kozlowski ---

[Freedreno] [PATCH v2 2/5] dt-bindings: display/msm: dpu-qcm2290: add missing DPU opp-table

2022-08-17 Thread Krzysztof Kozlowski
The 'display-controller' child (DPU) of Display SubSystem (MDSS) uses opp-table, so reference it which allows restricting DPU schema to fixed list of properties. Fixes: 164f69d9d45a ("dt-bindings: msm: disp: add yaml schemas for QCM2290 DPU bindings") Signed-off-by: Krzysztof Kozlowski

<    1   2   3   4   >