Re: [Freedreno] graph connection to node is not bidirectional kernel-5.6.0-rc6

2020-03-19 Thread Vinay Simha B N 
rob,

issue got resolved. the problem was end node of the panel had the label.

- panel2: eppendorf {
+ lvds-out {

https://github.com/vinaysimhabn/kernel-msm/commit/a7bf9ccd0b61cb355fe7fa768e65b6f04cfa686f

thanks.

On Thu, Mar 19, 2020 at 10:46 PM Vinay Simha B N  wrote:
>
> On Thu, Mar 19, 2020 at 10:36 PM Rob Herring  wrote:
> >
> > On Thu, Mar 19, 2020 at 9:56 AM Vinay Simha B N  wrote:
> > >
> > > On Thu, Mar 19, 2020 at 9:16 PM Rob Herring  wrote:
> > > >
> > > > On Thu, Mar 19, 2020 at 1:31 AM Vinay Simha B N  
> > > > wrote:
> > > > >
> > > > > hi,
> > > > >
> > > > > I am getting the endpoint' is not bidirectional(d2l_in, dsi0_out)
> > > > > warning in compilation, built boot image works on qcom apq8016-ifc6309
> > > > > board with the dsi->bridge->lvds panel.
> > > > > Because of this warning i cannot create a .yaml documentation 
> > > > > examples.
> > > > > Please suggest.
> > > > >
> > > > > tc_bridge: bridge@f {
> > > >
> > > >  
> > > >
> > > > > arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi:253.28-255.9: Warning
> > > > > (graph_endpoint): /soc/i2c@78b8000/bridge@39/ports/port@0/endpoint:
> > > >
> > > >  ^
> > > >
> > > > Looks like you have 2 different bridges.
> > > >
> > > i had two bridges, if we disable one bridge also we get the warning
> > >
> > > arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi:333.53-335.35: Warning
> > > (graph_endpoint): /soc/auo,b101xtn01/port/endpoint: graph connection
> > > to node '/soc/i2c@78b8000/bridge@f/ports/port@1/endpoint' is not
> > > bidirectional
> >
> > You can't just disable nodes. To switch which bridge is enabled, you
> > already have to modify remote-endpoint at the other end. So the
> > requirement is you have to modify both 'remote-endpoint' properties
> > (or really all 3).
> >
> > The other options is if you want both connections described, then you
> > need 2 'endpoint' nodes to connect both bridges.
> even after removing one bridge(dsi2hdmi) in the device tree, currently
> using only one bridge(dsi2lvds), i do still get the compilation warning.
>
>  graph connection
>  to node '/soc/i2c@78b8000/bridge@f/ports/port@1/endpoint' is not
> bidirectional
>
> This compilation warning does not cause any problem with the boot image 
> created
> dsi -> dsi2lvds bridge-> lvds panel . Able to get the display properly.
>
> https://github.com/vinaysimhabn/kernel-msm/blob/08e4821646b5c128559c506a5777d8782f1ff79e/Documentation/devicetree/bindings/display/bridge/toshiba%2Ctc358775.yaml
>
> But while creating documentation yaml, it is not allowing to add this 
> examples.
> --
> regards,
> vinaysimha



-- 
regards,
vinaysimha
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] graph connection to node is not bidirectional kernel-5.6.0-rc6

2020-03-19 Thread Vinay Simha B N 
On Thu, Mar 19, 2020 at 10:36 PM Rob Herring  wrote:
>
> On Thu, Mar 19, 2020 at 9:56 AM Vinay Simha B N  wrote:
> >
> > On Thu, Mar 19, 2020 at 9:16 PM Rob Herring  wrote:
> > >
> > > On Thu, Mar 19, 2020 at 1:31 AM Vinay Simha B N  
> > > wrote:
> > > >
> > > > hi,
> > > >
> > > > I am getting the endpoint' is not bidirectional(d2l_in, dsi0_out)
> > > > warning in compilation, built boot image works on qcom apq8016-ifc6309
> > > > board with the dsi->bridge->lvds panel.
> > > > Because of this warning i cannot create a .yaml documentation examples.
> > > > Please suggest.
> > > >
> > > > tc_bridge: bridge@f {
> > >
> > >  
> > >
> > > > arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi:253.28-255.9: Warning
> > > > (graph_endpoint): /soc/i2c@78b8000/bridge@39/ports/port@0/endpoint:
> > >
> > >  ^
> > >
> > > Looks like you have 2 different bridges.
> > >
> > i had two bridges, if we disable one bridge also we get the warning
> >
> > arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi:333.53-335.35: Warning
> > (graph_endpoint): /soc/auo,b101xtn01/port/endpoint: graph connection
> > to node '/soc/i2c@78b8000/bridge@f/ports/port@1/endpoint' is not
> > bidirectional
>
> You can't just disable nodes. To switch which bridge is enabled, you
> already have to modify remote-endpoint at the other end. So the
> requirement is you have to modify both 'remote-endpoint' properties
> (or really all 3).
>
> The other options is if you want both connections described, then you
> need 2 'endpoint' nodes to connect both bridges.
even after removing one bridge(dsi2hdmi) in the device tree, currently
using only one bridge(dsi2lvds), i do still get the compilation warning.

 graph connection
 to node '/soc/i2c@78b8000/bridge@f/ports/port@1/endpoint' is not
bidirectional

This compilation warning does not cause any problem with the boot image created
dsi -> dsi2lvds bridge-> lvds panel . Able to get the display properly.

https://github.com/vinaysimhabn/kernel-msm/blob/08e4821646b5c128559c506a5777d8782f1ff79e/Documentation/devicetree/bindings/display/bridge/toshiba%2Ctc358775.yaml

But while creating documentation yaml, it is not allowing to add this examples.
-- 
regards,
vinaysimha
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] graph connection to node is not bidirectional kernel-5.6.0-rc6

2020-03-19 Thread Vinay Simha B N 
On Thu, Mar 19, 2020 at 9:16 PM Rob Herring  wrote:
>
> On Thu, Mar 19, 2020 at 1:31 AM Vinay Simha B N  wrote:
> >
> > hi,
> >
> > I am getting the endpoint' is not bidirectional(d2l_in, dsi0_out)
> > warning in compilation, built boot image works on qcom apq8016-ifc6309
> > board with the dsi->bridge->lvds panel.
> > Because of this warning i cannot create a .yaml documentation examples.
> > Please suggest.
> >
> > tc_bridge: bridge@f {
>
>  
>
> > arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi:253.28-255.9: Warning
> > (graph_endpoint): /soc/i2c@78b8000/bridge@39/ports/port@0/endpoint:
>
>  ^
>
> Looks like you have 2 different bridges.
>
i had two bridges, if we disable one bridge also we get the warning

arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi:333.53-335.35: Warning
(graph_endpoint): /soc/auo,b101xtn01/port/endpoint: graph connection
to node '/soc/i2c@78b8000/bridge@f/ports/port@1/endpoint' is not
bidirectional

> Rob



-- 
regards,
vinaysimha
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

[Freedreno] graph connection to node is not bidirectional kernel-5.6.0-rc6

2020-03-19 Thread Vinay Simha B N 
hi,

I am getting the endpoint' is not bidirectional(d2l_in, dsi0_out)
warning in compilation, built boot image works on qcom apq8016-ifc6309
board with the dsi->bridge->lvds panel.
Because of this warning i cannot create a .yaml documentation examples.
Please suggest.

tc_bridge: bridge@f {
status = "okay";
ports {
#address-cells = <1>;
#size-cells = <0>;

port@0 {
reg = <0>;
d2l_in: endpoint {
remote-endpoint = <_out>;
};
};
};

dsi@1a98000 {
status = "okay";
...
ports {
port@1 {
dsi0_out:endpoint {
remote-endpoint = <_in>;
data-lanes = <0 1 2 3>;
};
};
};
};

https://github.com/vinaysimhabn/kernel-msm/blob/1cbd104cca4ebfb111c92e939ca09f82aac00aa1/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
https://github.com/vinaysimhabn/kernel-msm/blob/08e4821646b5c128559c506a5777d8782f1ff79e/Documentation/devicetree/bindings/display/bridge/toshiba%2Ctc358775.yaml

arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi:253.28-255.9: Warning
(graph_endpoint): /soc/i2c@78b8000/bridge@39/ports/port@0/endpoint:
graph connection to node
'/soc/mdss@1a0/dsi@1a98000/ports/port@1/endpoint' is not
bidirectional
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi:333.53-335.35: Warning
(graph_endpoint): /soc/auo,b101xtn01/port/endpoint: graph connection
to node '/soc/i2c@78b8000/bridge@f/ports/port@1/endpoint' is not
bidirectional

-- 
regards,
vinaysimha
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] Freedreno Digest, Vol 73, Issue 27

2020-03-11 Thread Vinay Simha B N 
On Wed, Mar 11, 2020 at 5:30 PM  wrote:
>
> Send Freedreno mailing list submissions to
> freedreno@lists.freedesktop.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
> https://lists.freedesktop.org/mailman/listinfo/freedreno
> or, via email, send a message with subject or body 'help' to
> freedreno-requ...@lists.freedesktop.org
>
> You can reach the person managing the list at
> freedreno-ow...@lists.freedesktop.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of Freedreno digest..."
>
>
> Today's Topics:
>
>1. [PATCH v6 0/2] Add support for rm69299 Visionox panel driver
>   and add devicetree bindings for visionox panel (Harigovindan P)
>2. [PATCH v6 2/2] drm/panel: add support for rm69299 visionox
>   panel driver (Harigovindan P)
>3. [PATCH v6 1/2] dt-bindings: display: add visionox rm69299
>   panel variant (Harigovindan P)
>
>
> --
>
> Message: 1
> Date: Wed, 11 Mar 2020 14:28:05 +0530
> From: Harigovindan P 
> To: dri-de...@lists.freedesktop.org, linux-arm-...@vger.kernel.org,
> freedreno@lists.freedesktop.org, devicet...@vger.kernel.org
> Cc: Harigovindan P , robdcl...@gmail.com,
> seanp...@chromium.org, s...@poorly.run
> Subject: [Freedreno] [PATCH v6 0/2] Add support for rm69299 Visionox
> panel driver and add devicetree bindings for visionox panel
> Message-ID: <20200311085807.21984-1-harig...@codeaurora.org>
>
> Adding support for visionox rm69299 panel driver and adding bindings for the 
> same panel.
>
> Harigovindan P (2):
>   dt-bindings: display: add visionox rm69299 panel variant
>   drm/panel: add support for rm69299 visionox panel driver
>
>  .../display/panel/visionox,rm69299.yaml   |  77 +
>  drivers/gpu/drm/panel/Kconfig |   8 +
>  drivers/gpu/drm/panel/Makefile|   1 +
>  .../gpu/drm/panel/panel-visionox-rm69299.c| 295 ++
>  4 files changed, 381 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/display/panel/visionox,rm69299.yaml
>  create mode 100644 drivers/gpu/drm/panel/panel-visionox-rm69299.c
>
> --
> 2.25.1
>
>
>
> --
>
> Message: 2
> Date: Wed, 11 Mar 2020 14:28:07 +0530
> From: Harigovindan P 
> To: dri-de...@lists.freedesktop.org, linux-arm-...@vger.kernel.org,
> freedreno@lists.freedesktop.org, devicet...@vger.kernel.org
> Cc: Harigovindan P , robdcl...@gmail.com,
> seanp...@chromium.org, s...@poorly.run
> Subject: [Freedreno] [PATCH v6 2/2] drm/panel: add support for rm69299
> visionox panel driver
> Message-ID: <20200311085807.21984-3-harig...@codeaurora.org>
>
> Add support for Visionox panel driver.
>
> Signed-off-by: Harigovindan P 
> ---
>
> Changes in v2:
> - Dropping redundant space in Kconfig(Sam Ravnborg).
> - Changing structure for include files(Sam Ravnborg).
> - Removing backlight related code and functions(Sam Ravnborg).
> - Removing repeated printing of error message(Sam Ravnborg).
> - Adding drm_connector as an argument for get_modes function.
> Changes in v3:
> - Adding arguments for drm_panel_init to support against mainline.
> Changes in v4:
> - Removing error messages from regulator_set_load.
> - Removing dev struct entry.
> - Removing checks.
> - Dropping empty comment lines.
> Changes in v5:
> - Removing unused struct member variables.
> - Removing blank lines.
> - Fixed indentation.
> - Invoking dsi_detach and panel_remove while early exiting from probe.
> Changes in v6:
> - Changed "35597" to "rm69299" for power_on function.
> - Removing rm69299_config since it supports single type of panel for 
> now.
> - Fixed alignment.
> - Using goto statements when regulator_set_load fails.
>
>  drivers/gpu/drm/panel/Kconfig |   8 +
>  drivers/gpu/drm/panel/Makefile|   1 +
>  .../gpu/drm/panel/panel-visionox-rm69299.c| 295 ++
>  3 files changed, 304 insertions(+)
>  create mode 100644 drivers/gpu/drm/panel/panel-visionox-rm69299.c
>
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index ae44ac2ec106..7b696f304a99 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -389,6 +389,14 @@ config DRM_PANEL_TRULY_NT35597_WQXGA
>   Say Y here if you want to enable support for Truly NT35597 WQXGA 
> Dual DSI
>   Video Mode panel
>
> +config DRM_PANEL_VISIONOX_RM69299
> +   tristate "Visionox RM69299"
> +   depends on OF
> +   depends on DRM_MIPI_DSI
> +   help
> + Say Y here if you want to enable support for Visionox
> + RM69299  DSI Video Mode panel.
> +
>  config DRM_PANEL_XINPENG_XPP055C272
> tristate "Xinpeng

Re: [Freedreno] drm : adv7511 module unload crash

2019-02-28 Thread Vinay Simha B N 
rob,

i had tied up temperature sensor and dsi2hdmi with thermal sensors,
hdmi hpd to polling mode
https://github.com/vinaysimha/kernel-msm/commit/8d010a82ab5c2e3bd1f536c8bf5ea0bfe55eee55

But when dsibridge disables it does not disable the reguators of adv
chip, regulator use_count will go from 2 to 1, still these regulators
held by the i2c, since adv accessed through i2c, _detect will stop if
regulator manually disables from 1 to 0.

In the interrupt context of temperature sensor will load the adv7511
module and i want to unload the module when temperature goes out of
range. in this case regulators will not be enabled to the adv. but in
this kernel crash and need to debug.

Does both polling and interrupt method can be optimized?

On Thu, Feb 28, 2019 at 5:30 PM Rob Clark  wrote:
>
> Looks like a spot where we don't drain a workqueue on unload.  In
> general, I'd say unload is not well tested and there is a lot that can
> go wrong.  It's also not something that really happens in the real
> world.  Patches welcome, but I don't think it is the highest priority.
>
> BR,
> -R
>
> On Wed, Feb 27, 2019 at 6:45 AM Vinay Simha B N  wrote:
> >
> > hi,
> >
> > manually trying to load and unload the adv7511 module,
> > modprobe adv7511 - works
> > rmmod adv7511 - crashes.
> >
> > any suggestion why module unload crashing? is it not possible to
> > load/unload module for drm framework?
> >
> >77.326091] Workqueue: dsi_drm_work dsi_hpd_worker [msm]
> > [   77.362360] task: 89fcb800 task.stack: 0805
> > [   77.367665] PC is at 0x010b258c
> > [   77.373264] LR is at 0x010b258c
> > [   77.377083] pc : [] lr : []
> > pstate: 6145
> > [   77.385625] sp : 08053c80
> > [   77.393149] x29: 08053c80 x28: 
> > [   77.397809] x27: 8eb08078 x26: 090e09e0
> > [   77.402384] x25: 0001 x24: 00c8d3f8
> > [   77.407293] x23: 00c8d428 x22: 80003c1612b8
> > [   77.412520] x21: 80003c1622b8 x20: 80003c162018
> > [   77.417732] x19: 0001 x18: 0010
> > [   77.422968] x17:  x16: 
> > [   77.428169] x15: 0006 x14: 8925694f
> > [   77.433383] x13: 0925695d x12: 08b7c098
> > [   77.438607] x11: 0040 x10: 80003d400270
> > [   77.443860] x9 : 80003d4002e8 x8 : 
> > [   77.449087] x7 : 003f x6 : 0001
> > [   77.454303] x5 :  x4 : 34ceb000
> > [   77.459556] x3 :  x2 : 80003d320800
> > [   77.464804] x1 :  x0 : ff92
> > [   77.470050] Process kworker/u8:0 (pid: 5, stack limit = 
> > 0x0805)
> > [   77.475463] Call trace:
> > [   77.482153] Exception stack(0x08053b40 to 0x08053c80)
> > [   77.486146] 3b40: ff92 
> > 80003d320800 
> > [   77.491644] 3b60: 34ceb000 
> > 0001 003f
> > [   77.499488] 3b80:  80003d4002e8
> > 80003d400270 0040
> > [   77.507349] 3ba0: 08b7c098 0925695d
> > 8925694f 0006
> > [   77.515217] 3bc0:  
> > 0010 0001
> > [   77.523007] 3be0: 80003c162018 80003c1622b8
> > 80003c1612b8 00c8d428
> > [   77.530814] 3c00: 00c8d3f8 0001
> > 090e09e0 8eb08078
> > [   77.538620] 3c20:  08053c80
> > 010b258c 08053c80
> > [   77.546385] 3c40: 010b258c 6145
> > 08053c80 010b258c
> > [   77.554143] 3c60:  80003c162018
> > 08053c80 010b258c
> > [   77.561933] [] 0x010b258c
> > [   77.569782] []
> > drm_helper_probe_detect_ctx+0x84/0xd0 [drm_kms_helper]
> > [   77.574585] []
> > drm_helper_hpd_irq_event+0x98/0x140 [drm_kms_helper]
> > [   77.582643] [] dsi_hpd_worker+0x14/0x20 [msm]
> > [   77.590395] [] process_one_work+0x1cc/0x328
> > [   77.596035] [] worker_thread+0x50/0x450
> > [   77.601796] [] kthread+0xfc/0x128
> > [   77.607038] [] ret_from_fork+0x10/0x18
> > [   77.611590] Code: bad PC value
> > [   77.616996] ---[ end trace a867a6e04ca3e227 ]---
> >
> > --
> > regards,
> > vinaysimha
> > ___
> > Freedreno mailing list
> > Freedreno@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/freedreno



-- 
regards,
vinaysimha
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

[Freedreno] drm : adv7511 module unload crash

2019-02-27 Thread Vinay Simha B N 
hi,

manually trying to load and unload the adv7511 module,
modprobe adv7511 - works
rmmod adv7511 - crashes.

any suggestion why module unload crashing? is it not possible to
load/unload module for drm framework?

   77.326091] Workqueue: dsi_drm_work dsi_hpd_worker [msm]
[   77.362360] task: 89fcb800 task.stack: 0805
[   77.367665] PC is at 0x010b258c
[   77.373264] LR is at 0x010b258c
[   77.377083] pc : [] lr : []
pstate: 6145
[   77.385625] sp : 08053c80
[   77.393149] x29: 08053c80 x28: 
[   77.397809] x27: 8eb08078 x26: 090e09e0
[   77.402384] x25: 0001 x24: 00c8d3f8
[   77.407293] x23: 00c8d428 x22: 80003c1612b8
[   77.412520] x21: 80003c1622b8 x20: 80003c162018
[   77.417732] x19: 0001 x18: 0010
[   77.422968] x17:  x16: 
[   77.428169] x15: 0006 x14: 8925694f
[   77.433383] x13: 0925695d x12: 08b7c098
[   77.438607] x11: 0040 x10: 80003d400270
[   77.443860] x9 : 80003d4002e8 x8 : 
[   77.449087] x7 : 003f x6 : 0001
[   77.454303] x5 :  x4 : 34ceb000
[   77.459556] x3 :  x2 : 80003d320800
[   77.464804] x1 :  x0 : ff92
[   77.470050] Process kworker/u8:0 (pid: 5, stack limit = 0x0805)
[   77.475463] Call trace:
[   77.482153] Exception stack(0x08053b40 to 0x08053c80)
[   77.486146] 3b40: ff92 
80003d320800 
[   77.491644] 3b60: 34ceb000 
0001 003f
[   77.499488] 3b80:  80003d4002e8
80003d400270 0040
[   77.507349] 3ba0: 08b7c098 0925695d
8925694f 0006
[   77.515217] 3bc0:  
0010 0001
[   77.523007] 3be0: 80003c162018 80003c1622b8
80003c1612b8 00c8d428
[   77.530814] 3c00: 00c8d3f8 0001
090e09e0 8eb08078
[   77.538620] 3c20:  08053c80
010b258c 08053c80
[   77.546385] 3c40: 010b258c 6145
08053c80 010b258c
[   77.554143] 3c60:  80003c162018
08053c80 010b258c
[   77.561933] [] 0x010b258c
[   77.569782] []
drm_helper_probe_detect_ctx+0x84/0xd0 [drm_kms_helper]
[   77.574585] []
drm_helper_hpd_irq_event+0x98/0x140 [drm_kms_helper]
[   77.582643] [] dsi_hpd_worker+0x14/0x20 [msm]
[   77.590395] [] process_one_work+0x1cc/0x328
[   77.596035] [] worker_thread+0x50/0x450
[   77.601796] [] kthread+0xfc/0x128
[   77.607038] [] ret_from_fork+0x10/0x18
[   77.611590] Code: bad PC value
[   77.616996] ---[ end trace a867a6e04ca3e227 ]---

-- 
regards,
vinaysimha
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

[Freedreno] toshiba tc358775 dsi2lvds bridge - backlight and standby to resume not proper

2018-05-23 Thread VINAY SIMHA B N 
hi,

i had implemented the toshiba tc358775 dsi2lvds driver with apq8016 ,
facing two problems. please suggest.

1) display backlight problem - earlier by hard-coding the  panel mode
values in the bridge driver, display backlight was working fine, but
after handling by panel method, display backlight is very low, i had
not added backlight in the panel-simple driver, since it is handled by
led@7

2) standby to resume - when system goes to standby and comes back by
pressing vol+/vol-/power button sometimes display does not comes
properly

below is the bridge driver and devicetree

bridge_driver
https://github.com/vinaysimhabn/msm/blob/11511971ba414ff9f7d428d8acd7ba5fb5b4946b/drivers/gpu/drm/bridge/tc358775.c

device tree
https://github.com/vinaysimhabn/msm/blob/ec759fa71fbfaf9278f9783be4290b317ef91b43/arch/arm64/boot/dts/qcom/apq8016-sbc-lvds.dtsi

Regards,
vinay simha
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

[Freedreno] toshiba tc358775 dsi2lvds brige - panel port mapping failing

2018-05-22 Thread VINAY SIMHA B N 
hi,

i am trying to add support for dsi2lvds toshiba tc358775 driver ,
testing with apq8016 - ifc6309 board.

if i hardcode the panel modes, driver works.
trying to add the port method to the bridge and panel, it is failing
at the drm_of_find_panel_or_bridge. please suggest

while compiling the dtsi files, get some warnings
arch/arm64/boot/dts/qcom/apq8016-sbc-lvds.dtb: Warning
(graph_endpoint): /soc/i2c@78b8000/bridge@0f/ports/port@1/endpoint:
graph connection to node '/soc/panel-in' is not bidirectional
arch/arm64/boot/dts/qcom/apq8016-sbc-lvds.dtb: Warning
(graph_endpoint): /soc/panel-in/port/endpoint: graph connection to
node '/soc/i2c@78b8000/bridge@0f/ports/port@1/endpoint' is not
bidirectional

dtsi -
https://github.com/vinaysimhabn/msm/blob/a662442b63f2c1c943953107a239d4fe1c25f46c/arch/arm64/boot/dts/qcom/apq8016-sbc-lvds.dtsi

bridge driver file -
https://github.com/vinaysimhabn/msm/blob/a662442b63f2c1c943953107a239d4fe1c25f46c/drivers/gpu/drm/bridge/tc358775.c

It is failing in the bridge probe

 /* port@1 is the output port */
ret = drm_of_find_panel_or_bridge(dev->of_node, 1, 0, >panel, NULL);
if (ret && ret != -ENODEV)
{
pr_debug(" panel port failed \n");
return ret;
}

i2c@78b8000 {
/* On High speed expansion */
label = "HS-I2C2";
status = "okay";

tc_bridge: bridge@0f {
status = "okay";

compatible = "toshiba,tc358775";
reg = <0x0f>;

tc,dsi-lanes = <4>;

stby-gpio = < 99 GPIO_ACTIVE_LOW>;
reset-gpio = < 72 GPIO_ACTIVE_LOW>;

ports {
#address-cells = <1>;
#size-cells = <0>;

port@0 {
reg = <0>;
d2l_in: endpoint {

remote-endpoint = <_out>;
};
};

port@1 {
reg = <1>;
d2l_out: endpoint {

remote-endpoint = <_in>;
};
};
   };
 };
};

panel_in: panel-in {
   status = "okay";
   compatible = "innolux,n116bge";
power-supply = <_l14>;

  port {
lvds0_in: endpoint {
remote-endpoint = <_out>;
};
};
};



Regards,
vinay simha
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] apq8016 : 4.14 kernel dsi bridge/panel not working

2018-04-12 Thread Vinay Simha B N 
dsi is not initialized in lk, since no panel get selected.
[6400] [6400] Device tree exact match the board: <247 65560 0 0x2> == <247
24 2 0x1>
[6410] [6410] Best match DTB tags 247/00010018/0x0002/0/2000
b/0/0/0/908b7326/cbdb
[6420] [6420] Using pmic info 0x2000b/0x0/0x0/0x0 for device
0x2000b/0x0/0x0/0x0
[6430] [6430] target_display_panel_node:510: hw_id=24 panel_name=""
[190] [190] Neither 'config' nor 'frp' partition found
[190] [190] Display Init: Start
[200] [200] Not able to search the panel:
[200] [200] Display not enabled for 24 HW type
[200] [200] Target panel init not found!
[210] [210] Display Init: Done

i even tried adding in cmdline for clk_ignore_unused=1 pd_ignore_unused=1.
in this case display will note come even for reboot/resume from suspend.

actually dsi2lvds working in kernel-v4.4.23(kernel-16.09 linaro release)

i do observer the same behaviour in kernel-v4.9.56 (kernel -17.09 linaro
relase) and kernel-v4.14.15(kernel-18.01 linaro relase).

so looks like there are some diffs between v4.4.23 - v4.9.56


On Thu, Apr 12, 2018 at 5:45 AM, Rob Clark <robdcl...@gmail.com> wrote:

> I'm not sure if this is any way related to (since you mentioned
> regression btwn 4.9 and 4.14):
>
> https://lists.freedesktop.org/archives/dri-devel/2018-April/172152.html
>
> given the mention of working when resume from suspend, I might suggest
> to try disabling bootloader enabling the display (ie. for splash
> screen), since that can cause plenty of issues
>
> BR,
> -R
>
> On Wed, Apr 11, 2018 at 12:38 PM, Vinay Simha B N <simha...@gmail.com>
> wrote:
> > hi,
> >
> > we have apq8016 : IFC6309 board (ref : 410c snapdragon), dsi2lvds
> interfaced
> > to the board, dsi2lvds working fine in 4.9 kernel  , but the same
> dsi2lvds
> > driver in 4.14 kernel it works only when system comes resumes from
> suspend
> > or when i issue the reboot command.
> > It does not works when it boots, please suggest.
> >
> > attached kernel log
> > https://pastebin.com/TUNWecQR
> >
> > kernel src
> > https://github.com/vinaysimhabn/msm/commits/kernel-18.01-lvdsv1.0
> >
> >
> > --
> > regards,
> > vinaysimha
> >
> > ___
> > Freedreno mailing list
> > Freedreno@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/freedreno
> >
>



-- 
regards,
vinaysimha
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

[Freedreno] apq8064 : dsi1

2017-05-23 Thread Vinay Simha B N 
hi,

i am trying to enable dsi1 in apq8064, added dsi1: mdss_dsi@580 in
qcom-apq8064.dtsi

for some reason the 0x0580 is not accessible , all the dsi1 controller
registers values are 0.

i checked the mmss register releated to dsi1 iface_clk and bus_clk are
enabled.
MMSS_AHB_EN 0408 : d565feee

any clocks/regulators related to dsi1 are  missing to access the dsi1
registers?

-- 
regards,
vinaysimha
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [PATCH] drm/msm/hdmi: redefinitions of macros not required

2017-03-21 Thread Vinay Simha B N 
hi,

Could you please give some feedback or review comments for this patch

On 3/14/17, Vinay Simha BN  wrote:
> 4 macros already defined in hdmi.h,
> which is not required to redefine in hdmi_audio.c
>
> Signed-off-by: Vinay Simha BN 
> ---
>  drivers/gpu/drm/msm/hdmi/hdmi_audio.c | 7 ---
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
> b/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
> index a54d3bb..8177e85 100644
> --- a/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
> +++ b/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
> @@ -18,13 +18,6 @@
>  #include 
>  #include "hdmi.h"
>
> -
> -/* Supported HDMI Audio channels */
> -#define MSM_HDMI_AUDIO_CHANNEL_2 0
> -#define MSM_HDMI_AUDIO_CHANNEL_4 1
> -#define MSM_HDMI_AUDIO_CHANNEL_6 2
> -#define MSM_HDMI_AUDIO_CHANNEL_8 3
> -
>  /* maps MSM_HDMI_AUDIO_CHANNEL_n consts used by audio driver to # of
> channels: */
>  static int nchannels[] = { 2, 4, 6, 8 };
>
> --
> 2.7.4
>
>


-- 
regards,
vinaysimha
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno