[Freedreno] [PATCH -next] drm/msm/dsi: Fix return value check in msm_dsi_host_set_display_mode()

[weiyj_lk]

From: Wei Yongjun 

In case of error, the function drm_mode_duplicate() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Signed-off-by: Wei Yongjun 
---
 drivers/gpu/drm/msm/dsi/dsi_host.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c 
b/drivers/gpu/drm/msm/dsi/dsi_host.c
index a3e47ad8..97e5a4d 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_host.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
@@ -2245,9 +2245,9 @@ int msm_dsi_host_set_display_mode(struct mipi_dsi_host 
*host,
}
 
msm_host->mode = drm_mode_duplicate(msm_host->dev, mode);
-   if (IS_ERR(msm_host->mode)) {
+   if (!msm_host->mode) {
pr_err("%s: cannot duplicate mode\n", __func__);
-   return PTR_ERR(msm_host->mode);
+   return -ENOMEM;
}
 
return 0;



___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

[Freedreno] [PATCH -next] drm/msm/hdmi: use PTR_ERR_OR_ZERO() to simplify the code

[weiyj_lk]

From: Wei Yongjun 

Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR.

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Signed-off-by: Wei Yongjun 
---
 drivers/gpu/drm/msm/hdmi/hdmi.c | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c
index 33bf52c..9737207 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi.c
@@ -537,10 +537,7 @@ static int msm_hdmi_register_audio_driver(struct hdmi 
*hdmi, struct device *dev)
 PLATFORM_DEVID_AUTO,
 &codec_data,
 sizeof(codec_data));
-   if (IS_ERR(hdmi->audio_pdev))
-   return PTR_ERR(hdmi->audio_pdev);
-
-   return 0;
+   return PTR_ERR_OR_ZERO(hdmi->audio_pdev);
 }
 
 static int msm_hdmi_bind(struct device *dev, struct device *master, void *data)




___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno