Re: [PATCH 3/3] ASoC: hdmi-codec: drop drm/drm_edid.h include

2024-01-05 Thread Alex Deucher
Cc: Jonas Karlman > Cc: Jernej Skrabec > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: linux-so...@vger.kernel.org > Acked-by: Maxime Ripard > Signed-off-by: Jani Nikula Series is: Acked-by: Alex Deucher > --- > drivers/gpu/drm/bridge/lontium-lt9611.c| 1 + &g

Re: [Freedreno] [PATCH 00/20] remove I2C_CLASS_DDC support

2023-11-16 Thread Alex Deucher
On Mon, Nov 13, 2023 at 3:55 PM Wolfram Sang wrote: > > > > We're not in a hurry. It's just my experience with patch series' affecting > > multiple subsystems that typically the decision was to apply the full > > series via one tree. Also to avoid inquires from maintainers like: > > Shall I take

Re: [Freedreno] [PATCH 0/9] drm: Annotate structs with __counted_by

2023-10-02 Thread Alex Deucher
On Mon, Oct 2, 2023 at 5:20 AM Christian König wrote: > > Am 29.09.23 um 21:33 schrieb Kees Cook: > > On Fri, 22 Sep 2023 10:32:05 -0700, Kees Cook wrote: > >> This is a batch of patches touching drm for preparing for the coming > >> implementation by GCC and Clang of the __counted_by attribute.

Re: [Freedreno] [PATCH 1/9] drm/amd/pm: Annotate struct smu10_voltage_dependency_table with __counted_by

2023-09-25 Thread Alex Deucher
On Mon, Sep 25, 2023 at 10:07 AM Alex Deucher wrote: > > On Mon, Sep 25, 2023 at 2:30 AM Christian König > wrote: > > > > Am 22.09.23 um 19:41 schrieb Alex Deucher: > > > On Fri, Sep 22, 2023 at 1:32 PM Kees Cook wrote: > > >> Prepare for

Re: [Freedreno] [PATCH 1/9] drm/amd/pm: Annotate struct smu10_voltage_dependency_table with __counted_by

2023-09-25 Thread Alex Deucher
On Mon, Sep 25, 2023 at 2:30 AM Christian König wrote: > > Am 22.09.23 um 19:41 schrieb Alex Deucher: > > On Fri, Sep 22, 2023 at 1:32 PM Kees Cook wrote: > >> Prepare for the coming implementation by GCC and Clang of the __counted_by > >> attribute. Fl

Re: [Freedreno] [PATCH 2/9] drm/amdgpu/discovery: Annotate struct ip_hw_instance with __counted_by

2023-09-22 Thread Alex Deucher
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct ip_hw_instance. > > [1] > https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Alex Deuch

Re: [Freedreno] [PATCH 1/9] drm/amd/pm: Annotate struct smu10_voltage_dependency_table with __counted_by

2023-09-22 Thread Alex Deucher
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct > smu10_voltage_dependency_table. > > [1] > https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci &

Re: [Freedreno] [PATCH -next 1/7] drm/amdkfd: Remove unnecessary NULL values

2023-08-09 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 9, 2023 at 2:15 AM Christian König wrote: > > Am 09.08.23 um 05:44 schrieb Ruan Jinjie: > > The NULL initialization of the pointers assigned by kzalloc() first is > > not necessary, because if the kzalloc() failed, the pointers will be > > assigned NULL, otherwise

Re: [Freedreno] [PATCH 2/2] drm: Remove struct drm_driver.gem_prime_mmap

2023-06-13 Thread Alex Deucher
eries is: Reviewed-by: Alex Deucher > --- > Documentation/gpu/todo.rst | 9 - > drivers/accel/ivpu/ivpu_drv.c | 1 - > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 - > drivers/gpu/drm/drm_fbdev_dma.c | 6 +---

Re: [Freedreno] [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-17 Thread Alex Deucher
On Mon, Apr 17, 2023 at 9:43 AM Rob Clark wrote: > > On Mon, Apr 17, 2023 at 4:10 AM Tvrtko Ursulin > wrote: > > > > > > On 16/04/2023 08:48, Daniel Vetter wrote: > > > On Fri, Apr 14, 2023 at 06:40:27AM -0700, Rob Clark wrote: > > >> On Fri, Apr 14, 2023 at 1:57 AM Tvrtko Ursulin > > >> wrote:

Re: [Freedreno] [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-13 Thread Alex Deucher
On Wed, Apr 12, 2023 at 10:42 AM Tvrtko Ursulin wrote: > > > On 11/04/2023 23:56, Rob Clark wrote: > > From: Rob Clark > > > > Add support to dump GEM stats to fdinfo. > > > > v2: Fix typos, change size units to match docs, use div_u64 > > v3: Do it in core > > > > Signed-off-by: Rob Clark > >

Re: [Freedreno] [PATCH v2 0/2] drm: fdinfo memory stats

2023-04-12 Thread Alex Deucher
On Wed, Apr 12, 2023 at 4:10 PM Rob Clark wrote: > > On Wed, Apr 12, 2023 at 5:47 AM Rodrigo Vivi wrote: > > > > On Wed, Apr 12, 2023 at 10:11:32AM +0200, Daniel Vetter wrote: > > > On Wed, Apr 12, 2023 at 01:36:52AM +0300, Dmitry Baryshkov wrote: > > > > On 11/04/2023 21:28, Rob Clark wrote: >

Re: [Freedreno] [PATCH 00/22] drm: Review of mode copies

2022-03-15 Thread Alex Deucher
On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä wrote: > > On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote: > > drm: Add drm_mode_init() > > drm/bridge: Use drm_mode_copy() > > drm/imx: Use drm_mode_duplicate() > > drm/panel: Use drm_mode_duplicate() > > drm/vc4: Use

Re: [Freedreno] [PATCH] drm/msm: fix compilation when COMMON_CLK is disabled

2021-10-07 Thread Alex Deucher
On Thu, Oct 7, 2021 at 5:13 AM Christian König wrote: > > We can't even compile test without this > > Fixes: b3ed524f84f5 ("drm/msm: allow compile_test on !ARM") > Signed-off-by: Christian König Acked-by: Alex Deucher > --- > drivers/gpu/drm/msm/Kconfig | 2 +-

Re: [Freedreno] [PATCH 00/14] drm/hdcp: Pull HDCP auth/exchange/check into

2021-09-13 Thread Alex Deucher
On Mon, Sep 13, 2021 at 1:57 PM Sean Paul wrote: > > From: Sean Paul > > Hello, > This patchset pulls the HDCP protocol auth/exchange/check logic out from > i915 into a HDCP helper library which drivers can use to implement the > proper protocol and UAPI interactions for achieving HDCP. > >

Re: [Freedreno] [PATCH 09/14] drm/radeon: Convert to Linux IRQ interfaces

2021-08-02 Thread Alex Deucher
irectly or inlined. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/radeon/radeon_drv.c | 4 --- > drivers/gpu/drm/radeon/radeon_irq_kms.c | 44 + > drivers/gpu/drm/radeon/radeon_kms.h | 4 --- > 3 files

Re: [Freedreno] [PATCH 01/14] drm/amdgpu: Convert to Linux IRQ interfaces

2021-07-28 Thread Alex Deucher
izaton in thi case. The DRM IRQ > > midlayer does not handle this correctly. > > > > Signed-off-by: Thomas Zimmermann > > Alex needs to take a look at this as well, but of hand the patch is > Acked-by: Christian König . Looks good to me as well: Reviewed-by: Alex Deucher

Re: [Freedreno] Tested

2021-05-10 Thread Alex Deucher
Sorry, what patch are you referring to? Alex On Mon, May 10, 2021 at 4:04 AM wrote: > > I have tested this on my end and it resolves the 120hz problem. > > Tested-By: Ryan Houdek ___ Freedreno mailing list Freedreno@lists.freedesktop.org

Re: [Freedreno] [PATCH v4 04/22] drm/amdgpu: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-02-03 Thread Alex Deucher
On Thu, Jan 23, 2020 at 9:00 AM Thomas Zimmermann wrote: > > The callback struct drm_driver.get_scanout_position() is deprecated in > favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert > amdgpu over. > > Signed-off-by: Thomas Zimmermann Reviewe

Re: [Freedreno] [PATCH v4 10/22] drm/radeon: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-02-03 Thread Alex Deucher
> Signed-off-by: Thomas Zimmermann Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/radeon/atombios_crtc.c | 1 + > drivers/gpu/drm/radeon/radeon_display.c | 13 + > drivers/gpu/drm/radeon/radeon_drv.c | 11 --- > drivers/gpu/drm/radeon/radeon

Re: [Freedreno] [PATCH 02/23] drm/amdgpu: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-01-15 Thread Alex Deucher
On Wed, Jan 15, 2020 at 4:41 AM Thomas Zimmermann wrote: > > Hi > > Am 13.01.20 um 19:52 schrieb Alex Deucher: > > On Fri, Jan 10, 2020 at 4:21 AM Thomas Zimmermann > > wrote: > >> > >> The callback struct drm_driver.get_scanout_positi

Re: [Freedreno] [PATCH 17/23] drm/radeon: Convert to CRTC VBLANK callbacks

2020-01-13 Thread Alex Deucher
On Fri, Jan 10, 2020 at 4:22 AM Thomas Zimmermann wrote: > > VBLANK callbacks in struct drm_driver are deprecated in favor of > their equivalents in struct drm_crtc_funcs. Convert radeon over. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Alex Deucher > --- > d

Re: [Freedreno] [PATCH 12/23] drm/amdgpu: Convert to CRTC VBLANK callbacks

2020-01-13 Thread Alex Deucher
On Fri, Jan 10, 2020 at 4:22 AM Thomas Zimmermann wrote: > > VBLANK callbacks in struct drm_driver are deprecated in favor of > their equivalents in struct drm_crtc_funcs. Convert amdgpu over. I think I'd prefer to just update the signatures of the relevant functions rather than wrapping them.

Re: [Freedreno] [PATCH 05/23] drm/radeon: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-01-13 Thread Alex Deucher
On Fri, Jan 10, 2020 at 4:22 AM Thomas Zimmermann wrote: > > The callback struct drm_driver.get_scanout_position() is deprecated in > favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert > radeon over. > I'd prefer to just change the signature of radeon_get_crtc_scanoutpos() to

Re: [Freedreno] [PATCH 02/23] drm/amdgpu: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-01-13 Thread Alex Deucher
On Fri, Jan 10, 2020 at 4:21 AM Thomas Zimmermann wrote: > > The callback struct drm_driver.get_scanout_position() is deprecated in > favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert > amdgpu over. > I would prefer to just change the signature of

Re: [Freedreno] [PATCH RESEND 02/14] drm/radeon: Provide ddc symlink in connector sysfs directory

2019-08-27 Thread Alex Deucher
On Mon, Aug 26, 2019 at 3:26 PM Andrzej Pietrasiewicz wrote: > > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Acked-by: Alex Deucher > --- > drivers/gpu/drm/radeon/radeon_connectors.c | 143 +++-- >

Re: [Freedreno] [PATCH v6 22/24] drm/amdgpu: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Alex Deucher
On Fri, Jul 26, 2019 at 3:42 PM Andrzej Pietrasiewicz wrote: > > Hi Alex, > > > W dniu 26.07.2019 o 21:28, Alex Deucher pisze: > > On Fri, Jul 26, 2019 at 1:28 PM Andrzej Pietrasiewicz > > wrote: > >> > >> Use the ddc pointer provided by the generi

Re: [Freedreno] [PATCH v6 22/24] drm/amdgpu: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Alex Deucher
/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c With those updated as well: Acked-by: Alex Deucher > --- > .../gpu/drm/amd/amdgpu/amdgpu_connectors.c| 96 ++- > 1 file changed, 70 insertions(+), 26 deletions(-) >

Re: [Freedreno] [PATCH v6 23/24] drm/radeon: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Alex Deucher
On Fri, Jul 26, 2019 at 1:29 PM Andrzej Pietrasiewicz wrote: > > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Acked-by: Alex Deucher > --- > drivers/gpu/drm/radeon/radeon_connectors.c | 142 +++-- >

Re: [Freedreno] [PATCH v3 21/22] drm/amdgpu: Provide ddc symlink in connector sysfs directory

2019-07-05 Thread Alex Deucher
On Thu, Jul 4, 2019 at 9:17 AM Andrzej Pietrasiewicz wrote: > > W dniu 02.07.2019 o 22:54, Alex Deucher pisze: > > On Fri, Jun 28, 2019 at 12:31 PM Andrzej Pietrasiewicz > > wrote: > >> > >> Use the ddc pointer provided by the generic connector. > >&

Re: [Freedreno] [PATCH v3 21/22] drm/amdgpu: Provide ddc symlink in connector sysfs directory

2019-07-02 Thread Alex Deucher
On Fri, Jun 28, 2019 at 12:31 PM Andrzej Pietrasiewicz wrote: > > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz > --- > .../gpu/drm/amd/amdgpu/amdgpu_connectors.c| 70 ++- > 1 file changed, 51 insertions(+), 19 deletions(-) >

Re: [Freedreno] [PATCH] drm: remove redundant 'default n' from Kconfig

2019-04-12 Thread Alex Deucher
people that a bare 'default n' is > redundant. > ... > > Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Alex Deucher for amdgpu and drm. > --- > drivers/gpu/drm/Kconfig |5 - > drivers/gpu/drm/amd/amdgpu/Kconfig |1 - > drivers/gpu/

Re: [Freedreno] [PATCH] drm: Split out drm_probe_helper.h

2019-01-15 Thread Alex Deucher
e there's no other driver who'll blow up accidentally because > someone else is doing a drmP.h cleanup. Laurent maybe? > > Jani, ack on this? > -Daniel amdgpu and radeon: Acked-by: Alex Deucher ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [PATCH] fix double ;;s in code

2018-02-20 Thread Alex Deucher
On Tue, Feb 20, 2018 at 3:03 AM, Jani Nikula wrote: > On Mon, 19 Feb 2018, Pavel Machek wrote: >> On Mon 2018-02-19 16:41:35, Daniel Vetter wrote: >>> Yeah, pls split this into one patch per area, with a suitable patch >>> subject prefix. Look at git

Re: [Freedreno] [PATCH 00/11] drm/msm: A5XX preemption

2017-02-06 Thread Alex Deucher
On Mon, Feb 6, 2017 at 12:59 PM, Daniel Vetter wrote: > On Mon, Feb 06, 2017 at 10:39:28AM -0700, Jordan Crouse wrote: >> This series of patches implements multiple ringbuffers and preemption for >> Adreno >> A5XX targets. Preemption allows a command to be interrupted at