Re: (subset) [PATCH v2 0/3] DisplayPort support for SM6350/SM7225

2024-04-21 Thread Bjorn Andersson
series (mostly just wiring up TCPM and the SBU > mux). > > [...] Applied, thanks! [3/3] arm64: dts: qcom: sm6350: Add DisplayPort controller commit: 62f87a3cac4e70fa916914a359d3f045a5ad8b9b Best regards, -- Bjorn Andersson

Re: [PATCH] drm/msm: Drop msm_read/writel

2024-04-11 Thread Bjorn Andersson
On Thu, Apr 11, 2024 at 04:31:41AM +0300, Dmitry Baryshkov wrote: > On Wed, Apr 10, 2024 at 11:52:52PM +0200, Konrad Dybcio wrote: [..] > > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h > > b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h > > index e4275d3ad581..5a5dc3faa971 100644 > > ---

Re: [PATCH v2 6/6] drm/msm/dp: Use function arguments for audio operations

2024-04-09 Thread Bjorn Andersson
On Mon, Apr 08, 2024 at 02:31:45PM -0700, Abhinav Kumar wrote: > On 3/28/2024 7:40 AM, Bjorn Andersson wrote: > > From: Bjorn Andersson > > > > The dp_audio read and write operations uses members in struct dp_catalog > > for passing arguments and return va

Re: [PATCH 2/6] soc: qcom: smem: Add pcode/fcode getters

2024-04-09 Thread Bjorn Andersson
On Fri, Apr 05, 2024 at 10:41:30AM +0200, Konrad Dybcio wrote: > Introduce getters for SoC product and feature codes and export them. > Thought I commented on this already, but I don't see my reply... Can you please elaborate on what this stuff is, such that we have a track record in the

Re: [PATCH v3] drm/msm/dp: call dp_hpd_plug_handle()/unplug_handle() directly for external HPD

2024-04-08 Thread Bjorn Andersson
On Tue, Apr 09, 2024 at 01:07:57AM +0300, Dmitry Baryshkov wrote: > On Tue, 9 Apr 2024 at 00:23, Abhinav Kumar wrote: > > On 4/8/2024 2:12 PM, Dmitry Baryshkov wrote: > > > On Mon, 8 Apr 2024 at 22:43, Abhinav Kumar > > > wrote: > > >> On 4/7/2024 11:48 AM

Re: [PATCH v3] drm/msm/dp: call dp_hpd_plug_handle()/unplug_handle() directly for external HPD

2024-04-08 Thread Bjorn Andersson
On Mon, Apr 08, 2024 at 12:43:34PM -0700, Abhinav Kumar wrote: > > > On 4/7/2024 11:48 AM, Bjorn Andersson wrote: > > On Fri, Apr 05, 2024 at 08:15:47PM -0700, Abhinav Kumar wrote: > > > From: Kuogee Hsieh > > [..] > > > diff --git a/drivers/gpu/drm/msm/d

Re: [PATCH v3] drm/msm/dp: call dp_hpd_plug_handle()/unplug_handle() directly for external HPD

2024-04-07 Thread Bjorn Andersson
On Fri, Apr 05, 2024 at 08:15:47PM -0700, Abhinav Kumar wrote: > From: Kuogee Hsieh [..] > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index d80f89581760..bfb6dfff27e8 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++

[PATCH v2] drm/msm/dp: Remove now unused connector_type from desc

2024-04-05 Thread Bjorn Andersson
Now that the connector_type is dynamically determined, the connector_type of the struct msm_dp_desc is unused. Clean it up. Remaining duplicate entries are squashed. Signed-off-by: Bjorn Andersson --- This cleans up after, and hence depends on, https://lore.kernel.org/all/20240324-x1e80100

Re: [PATCH] phy: qcom: qmp-combo: Fix register base for QSERDES_DP_PHY_MODE

2024-04-04 Thread Bjorn Andersson
tion in the commit why this is changed, so I suspect it was an > oversight or happened while being extracted from some other series. Thanks for catching that, I wrote that patch long before Johan did the rename of "pcs" to "dp_dp_phy", and must have missed that while later reba

Re: (subset) [PATCH v3 0/4] arm64: dts: fix several display-related schema warnings

2024-04-04 Thread Bjorn Andersson
ls commit: 7fb5680b589d5eae64ada1d917b6ff2dab82f5ae [3/4] arm64: dts: qcom: sc8180x: Drop flags for mdss irqs commit: 580701ec27f61e0996dd5fcd23b091b6bf6933e3 [4/4] arm64: dts: qcom: sc8180x: add dp_p1 register blocks to DP nodes commit: 1106ea2266d11ebd97c3493a0c36a45272bfb67a Best reg

Re: [PATCH] drm/msm/dp: Remove now unused connector_type from desc

2024-03-29 Thread Bjorn Andersson
On Fri, Mar 29, 2024 at 07:23:07AM +0200, Dmitry Baryshkov wrote: > On Fri, 29 Mar 2024 at 06:02, Bjorn Andersson > wrote: > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > > b/drivers/gpu/drm/msm/dp/dp_display.c [..] > > static const struct msm_dp

[PATCH] drm/msm/dp: Remove now unused connector_type from desc

2024-03-28 Thread Bjorn Andersson
Now that the connector_type is dynamically determined, the connector_type of the struct msm_dp_desc is unused. Clean it up. Signed-off-by: Bjorn Andersson --- This cleans up after, and hence depends on, https://lore.kernel.org/all/20240324-x1e80100-display-refactor-connector-v4-1-e0ebaea66

Re: [PATCH v1] drm/msm/dp: use dp_hpd_plug_handle() and dp_hpd_unplug_handle() directly

2024-03-28 Thread Bjorn Andersson
On Thu, Mar 28, 2024 at 02:21:14PM -0700, Abhinav Kumar wrote: > > > On 3/28/2024 1:58 PM, Stephen Boyd wrote: > > Quoting Abhinav Kumar (2024-03-28 13:24:34) > > > + Johan and Bjorn for FYI > > > > > > On 3/28/2024 1:04 PM, Kuogee Hsieh wrote: > > > > For internal HPD case, hpd_event_thread is

[PATCH v2 5/6] drm/msm/dp: Use function arguments for timing configuration

2024-03-28 Thread Bjorn Andersson
From: Bjorn Andersson dp_catalog_panel_timing_cfg() takes 4 arguments, which are passed from the calling function through members of struct dp_catalog. No state is maintained other than across this call, so switch to function arguments to clean up the code. Reviewed-by: Dmitry Baryshkov

[PATCH v2 6/6] drm/msm/dp: Use function arguments for audio operations

2024-03-28 Thread Bjorn Andersson
From: Bjorn Andersson The dp_audio read and write operations uses members in struct dp_catalog for passing arguments and return values. This adds unnecessary complexity to the implementation, as it turns out after detangling the logic that no state is actually held in these variables. Clean

[PATCH v2 3/6] drm/msm/dp: Remove unused defines and members

2024-03-28 Thread Bjorn Andersson
From: Bjorn Andersson Throughout the Qualcomm Displayport driver a number of defines and struct members has become unused, but lingers in the code. Remove these. Reviewed-by: Dmitry Baryshkov Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/dp/dp_audio.c | 5 - drivers/gpu/drm

[PATCH v2 4/6] drm/msm/dp: Use function arguments for aux writes

2024-03-28 Thread Bjorn Andersson
From: Bjorn Andersson The dp_aux write operations takes the data to be operated on through a member of struct dp_catalog, rather than as an argument to the function. No state is maintained other than across the calling of the functions, so replace this member with a function argument. Reviewed

[PATCH v2 2/6] drm/msm/dp: Removed fixed nvid "support"

2024-03-28 Thread Bjorn Andersson
From: Bjorn Andersson The "desc" member of struct dp_panel is zero-initialized during allocation and never assigned, resulting in dp_ctrl_use_fixed_nvid() never returning true. This returned boolean value is passed around but never acted upon. Perform constant propagation and remove

[PATCH v2 1/6] drm/msm/dp: Drop unused dp_debug struct

2024-03-28 Thread Bjorn Andersson
From: Bjorn Andersson The members of struct dp_debug are no longer used, so the only purpose of this struct is as a type of the return value of dp_debug_get(), to signal success/error. Drop the struct in favor of signalling the result of initialization using an int, then merge dp_debug_get

[PATCH v2 0/6] drm/msm/dp: Spring cleaning

2024-03-28 Thread Bjorn Andersson
Spring is in the air, clean out some dust that has accumulated in the Qualcomm DP driver. Signed-off-by: Bjorn Andersson --- Changes in v2: - Merge dp_debug_get() and dp_debug_init() - Link to v1: https://lore.kernel.org/r/20240326-msm-dp-cleanup-v1-0-e775556ec...@quicinc.com --- Bjorn

Re: [PATCH v4 2/2] drm/msm/dp: Add support for the X1E80100

2024-03-26 Thread Bjorn Andersson
mitry Baryshkov > Signed-off-by: Abel Vesa Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/gpu/drm/msm/dp/dp_display.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c >

Re: [PATCH v4 1/2] drm/msm/dp: Add support for determining the eDP/DP mode from DT

2024-03-26 Thread Bjorn Andersson
cribed in DT, therefore, assume it's eDP if panel node > is present. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Abel Vesa > --- > drivers/gpu/drm/msm/dp/dp_display.c | 29 - > 1 file changed, 28 insertions(+), 1 deletion(-) > >

[PATCH 6/6] drm/msm/dp: Use function arguments for audio operations

2024-03-26 Thread Bjorn Andersson
From: Bjorn Andersson The dp_audio read and write operations uses members in struct dp_catalog for passing arguments and return values. This adds unnecessary complexity to the implementation, as it turns out after detangling the logic that no state is actually held in these variables. Clean

[PATCH 5/6] drm/msm/dp: Use function arguments for timing configuration

2024-03-26 Thread Bjorn Andersson
From: Bjorn Andersson dp_catalog_panel_timing_cfg() takes 4 arguments, which are passed from the calling function through members of struct dp_catalog. No state is maintained other than across this call, so switch to function arguments to clean up the code. Signed-off-by: Bjorn Andersson

[PATCH 4/6] drm/msm/dp: Use function arguments for aux writes

2024-03-26 Thread Bjorn Andersson
From: Bjorn Andersson The dp_aux write operations takes the data to be operated on through a member of struct dp_catalog, rather than as an argument to the function. No state is maintained other than across the calling of the functions, so replace this member with a function argument. Signed

[PATCH 3/6] drm/msm/dp: Remove unused defines and members

2024-03-26 Thread Bjorn Andersson
From: Bjorn Andersson Throughout the Qualcomm Displayport driver a number of defines and struct members has become unused, but lingers in the code. Remove these. Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/dp/dp_audio.c | 5 - drivers/gpu/drm/msm/dp/dp_catalog.c | 1

[PATCH 0/6] drm/msm/dp: Spring cleaning

2024-03-26 Thread Bjorn Andersson
Spring is in the air, clean out some dust that has accumulated in the Qualcomm DP driver. Signed-off-by: Bjorn Andersson --- Bjorn Andersson (6): drm/msm/dp: Drop unused dp_debug struct drm/msm/dp: Removed fixed nvid "support" drm/msm/dp: Remove unused defines a

[PATCH 2/6] drm/msm/dp: Removed fixed nvid "support"

2024-03-26 Thread Bjorn Andersson
From: Bjorn Andersson The "desc" member of struct dp_panel is zero-initialized during allocation and never assigned, resulting in dp_ctrl_use_fixed_nvid() never returning true. This returned boolean value is passed around but never acted upon. Perform constant propagation and remove

[PATCH 1/6] drm/msm/dp: Drop unused dp_debug struct

2024-03-26 Thread Bjorn Andersson
From: Bjorn Andersson The members of struct dp_debug are no longer used, so the only purpose of this struct is as a type of the return value of dp_debug_get(), to signal success/error. Drop the struct in favor of signalling the result of initialization using an int. Signed-off-by: Bjorn

Re: [PATCH v3 1/2] drm/msm/dp: Add support for determining the eDP/DP mode from DT

2024-03-22 Thread Bjorn Andersson
On Fri, Mar 22, 2024 at 03:22:22PM +0200, Abel Vesa wrote: > Instead of relying on different compatibles for eDP and DP, lookup > the panel node in devicetree to figure out the connector type and > then pass on that information to the PHY. External DP is not described > in DT, therefore, assume

Re: [PATCH v2 2/3] drm/msm/dp: Add support for setting the eDP mode from devicetree

2024-02-27 Thread Bjorn Andersson
-off-by: Abel Vesa Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/gpu/drm/msm/dp/dp_ctrl.c| 11 +++ > drivers/gpu/drm/msm/dp/dp_ctrl.h| 1 + > drivers/gpu/drm/msm/dp/dp_display.c | 17 ++--- > 3 files changed, 26 insertions(+), 3 delet

Re: [PATCH 3/9] arm64: dts: qcom: sc7280: Enable MDP turbo mode

2024-02-22 Thread Bjorn Andersson
t; >> > > >> > > >> > > >> On 2/22/24 00:41, Dmitry Baryshkov wrote: > > >>> On Thu, 22 Feb 2024 at 01:19, Bjorn Andersson > > >>> wrote: > > >>>> > > >>>> The max frequency listed in the DPU

Re: [PATCH 6/9] arm64: dts: qcom: qcs6490-rb3gen2: Enable USB role switching

2024-02-21 Thread Bjorn Andersson
On Thu, Feb 22, 2024 at 01:50:12AM +0200, Dmitry Baryshkov wrote: > On Thu, 22 Feb 2024 at 01:19, Bjorn Andersson > wrote: > > > > With the ADSP remoteproc loaded pmic_glink can be introduced and wired > > up to provide role and orientation switching signals. >

Re: [PATCH 1/9] drm/msm/dp: Add DP support to combo instance in SC7280

2024-02-21 Thread Bjorn Andersson
On Thu, Feb 22, 2024 at 01:38:45AM +0200, Dmitry Baryshkov wrote: > On Thu, 22 Feb 2024 at 01:19, Bjorn Andersson > wrote: > > > > When upstreamed the SC7280 DP controllers where described as one being > > DP and one eDP, but they can infact both be DP or eDP. >

Re: [PATCH RFC 3/3] drm/msm/dp: Add support for the X1E80100

2024-02-21 Thread Bjorn Andersson
On Wed, Feb 21, 2024 at 12:50:33AM +0200, Abel Vesa wrote: > Add the X1E80100 DP descs and compatible. This platform will be using > a single compatible for both eDP and DP mode. The actual mode will > be set in devicetree via is-edp flag. > > Signed-off-by: Abel Vesa > --- >

Re: [PATCH RFC 1/3] dt-bindings: display: msm: dp-controller: document X1E80100 compatible

2024-02-21 Thread Bjorn Andersson
On Wed, Feb 21, 2024 at 12:50:31AM +0200, Abel Vesa wrote: > Add the X1E80100 to the list of compatibles and docoment the is-edp s/docoment/document/ > flag. This new flag will be used from now on to dictate the mode from s/from now on// Perhaps cleaner to spell out that the controllers are

Re: [PATCH RFC 2/3] drm/msm/dp: Add support for setting the eDP mode from devicetree

2024-02-21 Thread Bjorn Andersson
On Wed, Feb 21, 2024 at 12:50:32AM +0200, Abel Vesa wrote: > diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.h > b/drivers/gpu/drm/msm/dp/dp_ctrl.h > index fa014cee7e21..a10d1b19d172 100644 > --- a/drivers/gpu/drm/msm/dp/dp_ctrl.h > +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.h > @@ -32,6 +32,7 @@ struct

Re: [PATCH 6/6] phy: qcom-qmp-combo: fix type-c switch registration

2024-02-21 Thread Bjorn Andersson
PHY subsystem should be reworked to address this (i.e. by > separating initialisation and registration of the PHY). > > Fixes: 2851117f8f42 ("phy: qcom-qmp-combo: Introduce orientation switching") > Cc: sta...@vger.kernel.org # 6.5 > Cc: Bjorn Andersson > Sign

Re: [PATCH 5/6] phy: qcom-qmp-combo: fix drm bridge registration

2024-02-21 Thread Bjorn Andersson
ion of the PHY). > > Fixes: 35921910bbd0 ("phy: qcom: qmp-combo: switch to DRM_AUX_BRIDGE") > Fixes: 1904c3f578dc ("phy: qcom-qmp-combo: Introduce drm_bridge") > Cc: sta...@vger.kernel.org # 6.5 > Cc: Bjorn Andersson > Cc: Dmitry Baryshkov > Signed-off-

Re: [PATCH 4/6] soc: qcom: pmic_glink: Fix boot when QRTR=m

2024-02-21 Thread Bjorn Andersson
kov > Signed-off-by: Rob Clark > Link: https://lore.kernel.org/r/20231213210644.8702-1-robdcl...@gmail.com > [ johan: rebase on 6.8-rc4, amend commit message and mention DRM ] > Fixes: 58ef4ece1e41 ("soc: qcom: pmic_glink: Introduce base PMIC GLINK > driver") > Cc: sta...@vger.

Re: [PATCH 3/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free

2024-02-21 Thread Bjorn Andersson
ild devices, this is also a requirement due to a long-standing issue > in driver core that can otherwise lead to a probe deferral loop (see > fbc35b45f9f6 ("Add documentation on meaning of -EPROBE_DEFER")). > > Fixes: 080b4e24852b ("soc: qcom: pmic_glink: Introduce

Re: [PATCH 2/6] drm/bridge: aux-hpd: separate allocation and registration

2024-02-21 Thread Bjorn Andersson
dy wrong in this regard. Reviewed-by: Bjorn Andersson Regards, Bjorn

Re: [PATCH 1/6] drm/bridge: aux-hpd: fix OF node leaks

2024-02-21 Thread Bjorn Andersson
; Cc: Dmitry Baryshkov > Cc: Neil Armstrong > Signed-off-by: Johan Hovold Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/gpu/drm/bridge/aux-hpd-bridge.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/aux-hpd-bridge.c &g

[PATCH 4/9] arm64: dts: qcom: qcs6490-rb3gen2: Add DP output

2024-02-21 Thread Bjorn Andersson
The RB3Gen2 board comes with a mini DP connector, describe this, enable MDSS, DP controller and the PHY that drives this. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 23 +++ 1 file changed, 23 insertions(+) diff --git a/arch/arm64/boot

[PATCH 9/9] arm64: defconfig: Enable sc7280 display and gpu clock controllers

2024-02-21 Thread Bjorn Andersson
Enable the SC7280 display and gpu clock controllers to enable display support on the QCS6490 RB3gen2. Signed-off-by: Bjorn Andersson --- arch/arm64/configs/defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index

[PATCH 7/9] arm64: dts: qcom: qcs6490-rb3gen2: Introduce USB redriver

2024-02-21 Thread Bjorn Andersson
The RB3gen2 has a USB redriver on APPS_I2C, enable the bus and introduce the redriver. The plumbing with other components is kept separate for clarity. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 14 ++ 1 file changed, 14 insertions(+) diff

[PATCH 5/9] arm64: dts: qcom: qcs6490-rb3gen2: Enable adsp and cdsp

2024-02-21 Thread Bjorn Andersson
Define firmware paths and enable the ADSP and CDSP remoteprocs. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490

[PATCH 8/9] arm64: dts: qcom: qcs6490-rb3gen2: Enable USB Type-C display

2024-02-21 Thread Bjorn Andersson
With MDSS, pmic_glink, and the redriver in place, wire up the various components to enable USB Type-C display on the RB3gen2. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 63 +++- 1 file changed, 61 insertions(+), 2 deletions(-) diff

[PATCH 2/9] arm64: dts: qcom: sc7280: Make eDP/DP controller default DP

2024-02-21 Thread Bjorn Andersson
instance and make it eDP for the SC7280 qcard. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 2 ++ arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch

[PATCH 3/9] arm64: dts: qcom: sc7280: Enable MDP turbo mode

2024-02-21 Thread Bjorn Andersson
The max frequency listed in the DPU opp-table is 506MHz, this is not sufficient to drive a 4k@60 display, resulting in constant underrun. Add the missing MDP_CLK turbo frequency of 608MHz to the opp-table to fix this. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 5

[PATCH 1/9] drm/msm/dp: Add DP support to combo instance in SC7280

2024-02-21 Thread Bjorn Andersson
-edp to a dedicated list, to ensure existing DeviceTree will continue to select eDP. Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/dp/dp_display.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp

[PATCH 0/9] arm64: dts: qcom: qcs6490-rb3gen2: Enable two displays

2024-02-21 Thread Bjorn Andersson
on https://lore.kernel.org/linux-arm-msm/20240220-x1e80100-display-v4-0-971afd9de...@linaro.org/ Signed-off-by: Bjorn Andersson --- Bjorn Andersson (9): drm/msm/dp: Add DP support to combo instance in SC7280 arm64: dts: qcom: sc7280: Make eDP/DP controller default DP arm64: dts

[PATCH 6/9] arm64: dts: qcom: qcs6490-rb3gen2: Enable USB role switching

2024-02-21 Thread Bjorn Andersson
With the ADSP remoteproc loaded pmic_glink can be introduced and wired up to provide role and orientation switching signals. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 48 +++- 1 file changed, 47 insertions(+), 1 deletion(-) diff

Re: [PATCH] arm64: dts: qcom: sm6115: fix USB PHY configuration

2024-02-20 Thread Bjorn Andersson
, thanks! [1/1] arm64: dts: qcom: sm6115: fix USB PHY configuration commit: f176168bcb95bd1fdd32f5a794e68b7a36ac8740 Best regards, -- Bjorn Andersson

Re: (subset) [PATCH v4 0/6] SDM670 display subsystem support

2023-12-18 Thread Bjorn Andersson
om: sdm670: add display subsystem commit: 5f8ba4f28ddb432c8a9720c337f9047e38fa7e36 Best regards, -- Bjorn Andersson

Re: [PATCH 3/3] ARM: qcom: merge remaining subplatforms into sensible Kconfig entry

2023-12-15 Thread Bjorn Andersson
On Thu, Dec 07, 2023 at 03:55:00PM +0300, Dmitry Baryshkov wrote: > Three remaining Qualcomm platforms have special handling of the > TEXT_OFFSET to reserve the memory at the beginnig of the system RAM, see > the commit 9e775ad19f52 ("ARM: 7012/1: Set proper TEXT_OFFSET for newer > MSMs"). This is

Re: [PATCH] drm/msm/dp: call dp_display_get_next_bridge() during probe

2023-12-11 Thread Bjorn Andersson
r module", and we stash the return value of devm_drm_of_get_bridge(dev, dev->of_node, 1, 0) in parser->next_brigde, so that we 5 lines below this call can move it into dp->next_bridge. As such, I'd like to propose that we change devm_dp_parser_find_next_bridge() to just take

Re: (subset) [PATCH v3 00/12] RB1/QCM2290 features

2023-12-08 Thread Bjorn Andersson
ndings: firmware: qcom,scm: Allow interconnect for everyone commit: 56fdc35ef067c8dffee22038dd3a84bb3fa6d2a4 Best regards, -- Bjorn Andersson

Re: [PATCH 3/3] arm64: dts: qcom: sm8650: Add DisplayPort device nodes

2023-12-07 Thread Bjorn Andersson
On Thu, Dec 07, 2023 at 05:37:19PM +0100, Neil Armstrong wrote: > diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi > b/arch/arm64/boot/dts/qcom/sm8650.dtsi [..] > + > + mdss_dp0: displayport-controller@af54000 { > + compatible = "qcom,sm8650-dp"; >

Re: [PATCH v2 0/4] Adreno 643 + fixes

2023-12-07 Thread Bjorn Andersson
e9206ce7b19f2735f6e [4/4] arm64: dts: qcom: sc7280: Add 0xac Adreno speed bin commit: 6a7f8c635dab30233df93b5566d4169ed956b71b Best regards, -- Bjorn Andersson

Re: [Freedreno] [PATCH v3 2/2] drm/msm/dpu: Add mutex lock in control vblank irq

2023-12-05 Thread Bjorn Andersson
On Mon, Dec 04, 2023 at 11:22:24AM -0800, Abhinav Kumar wrote: > > > On 12/3/2023 7:31 PM, Bjorn Andersson wrote: > > On Fri, Dec 01, 2023 at 11:43:36AM -0800, Abhinav Kumar wrote: > > > > > > > > > On 12/1/2023 8:22 AM, Bjorn Andersson wrote: > &

Re: [Freedreno] [PATCH v3 2/2] drm/msm/dpu: Add mutex lock in control vblank irq

2023-12-03 Thread Bjorn Andersson
On Fri, Dec 01, 2023 at 11:43:36AM -0800, Abhinav Kumar wrote: > > > On 12/1/2023 8:22 AM, Bjorn Andersson wrote: > > On Fri, Dec 01, 2023 at 10:34:50AM +0200, Dmitry Baryshkov wrote: > > > On Fri, 1 Dec 2023 at 05:47, Bjorn Andersson > > > wrote: > >

Re: [Freedreno] (subset) [PATCH v3 00/12] RB1/QCM2290 features

2023-12-02 Thread Bjorn Andersson
10-rb1: Enable CAN bus controller commit: 252bc7ad359478dba8d77bce9502f2cc7bb547a3 [12/12] arm64: dts: qcom: qrb2210-rb1: add wifi variant property commit: b6a56a5a25d6273729b2b5139d58e3d390318ed2 Best regards, -- Bjorn Andersson

Re: [Freedreno] [PATCH] drm/msm/dpu: Add missing safe_lut_tbl in sc8180x catalog

2023-12-01 Thread Bjorn Andersson
On Fri, Dec 01, 2023 at 09:06:45AM +0100, Johan Hovold wrote: > On Thu, Nov 30, 2023 at 04:35:01PM -0800, Bjorn Andersson wrote: > > Similar to SC8280XP, the misconfigured SAFE logic causes rather > > significant delays in __arm_smmu_tlb_sync(), resulting in poor > > p

Re: [Freedreno] [PATCH v3 2/2] drm/msm/dpu: Add mutex lock in control vblank irq

2023-12-01 Thread Bjorn Andersson
On Fri, Dec 01, 2023 at 10:34:50AM +0200, Dmitry Baryshkov wrote: > On Fri, 1 Dec 2023 at 05:47, Bjorn Andersson > wrote: > > On Thu, Nov 30, 2023 at 05:40:55PM -0800, Paloma Arellano wrote: [..] > > > @@ -2386,6 +2390,7 @@ struct drm_encoder *dpu_encoder_init(struct

Re: [Freedreno] [PATCH v3 2/2] drm/msm/dpu: Add mutex lock in control vblank irq

2023-11-30 Thread Bjorn Andersson
On Thu, Nov 30, 2023 at 05:40:55PM -0800, Paloma Arellano wrote: > Add a missing mutex lock to control vblank irq. Thus prevent race > conditions when registering/unregistering the irq callback. > I'm guessing that the mutex is needed because vblank_refcount, while being an atomic_t, doesn't

Re: [Freedreno] [PATCH] drm/msm/dpu: Add missing safe_lut_tbl in sc8180x catalog

2023-11-30 Thread Bjorn Andersson
On Thu, Nov 30, 2023 at 04:35:01PM -0800, Bjorn Andersson wrote: > Similar to SC8280XP, the misconfigured SAFE logic causes rather > significant delays in __arm_smmu_tlb_sync(), resulting in poor > performance for things such as USB. > > Introduce appropriate SAFE values for SC8

[Freedreno] [PATCH] drm/msm/dpu: Add missing safe_lut_tbl in sc8180x catalog

2023-11-30 Thread Bjorn Andersson
t;) Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h index e07f4c8c25b9..9ffc8804a

[Freedreno] [PATCH] drm/msm/adreno: Fix A680 chip id

2023-11-30 Thread Bjorn Andersson
itch to chip-id for identifying GPU") Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/adreno/adreno_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c index f62ab5257e66.

[Freedreno] [PATCH] drm/msm/dpu: Add missing safe_lut_tbl in sc8280xp catalog

2023-10-30 Thread Bjorn Andersson
") Cc: sta...@vger.kernel.org Suggested-by: Doug Anderson Suggested-by: Rob Clark Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h b/drive

Re: [Freedreno] [RFC PATCH 1/2] clk: qcom: implement RCG2 'parked' clock support

2023-10-26 Thread Bjorn Andersson
On Wed, Oct 04, 2023 at 03:31:24AM +0300, Dmitry Baryshkov wrote: > clk_rcg2_shared_ops implements support for the case of the RCG which > must not be completely turned off. However its design has one major > drawback: it doesn't allow us to properly implement the is_enabled > callback, which

Re: [Freedreno] [PATCH v5 5/6] soc: qcom: pmic-glink: switch to DRM_AUX_HPD_BRIDGE

2023-10-25 Thread Bjorn Andersson
On Thu, Oct 26, 2023 at 01:28:06AM +0300, Dmitry Baryshkov wrote: > Use the freshly defined DRM_AUX_HPD_BRIDGE instead of open-coding the > same functionality for the DRM bridge chain termination. > Reviewed-by: Bjorn Andersson Acked-by: Bjorn Andersson Regards, Bjorn

Re: [Freedreno] [PATCH] soc: qcom: pmic_glink: fix connector type to be DisplayPort

2023-10-16 Thread Bjorn Andersson
On Wed, Oct 11, 2023 at 01:52:29AM +0300, Dmitry Baryshkov wrote: > As it was pointed out by Simon Ser, the DRM_MODE_CONNECTOR_USB connector > is reserved for the GUD devices. Other drivers (i915, amdgpu) use > DRM_MODE_CONNECTOR_DisplayPort even if the DP stream is handled by the > USB-C altmode.

Re: [Freedreno] [PATCH v2 0/4] arm64: dts: qcom: qrb5165-rb5: enable DP support

2023-09-19 Thread Bjorn Andersson
rd USB-C redriver commit: d342e1c993bd7589cad9d2da099c6a9c652ecb9f [3/4] arm64: dts: qcom: qrb5165-rb5: enable displayport controller commit: 96387ee7534dc449be35a9bb98b7668da2bed545 [4/4] arm64: dts: qcom: qrb5165-rb5: enable DP altmode commit: b3dea914127e9065df003002ed13a2ef40d19877 Best regards, -- Bjorn Andersson

Re: [Freedreno] (subset) [PATCH 0/5] arm64: dts: qcom: qrb5165-rb5: enable DP support

2023-09-19 Thread Bjorn Andersson
rd USB-C redriver commit: d342e1c993bd7589cad9d2da099c6a9c652ecb9f [4/5] arm64: dts: qcom: qrb5165-rb5: enable displayport controller commit: 96387ee7534dc449be35a9bb98b7668da2bed545 [5/5] arm64: dts: qcom: qrb5165-rb5: enable DP altmode commit: b3dea914127e9065df003002ed13a2ef40d19877 Best regards, -- Bjorn Andersson

Re: [Freedreno] [PATCH v2 1/4] arm64: dts: qcom: sm8250: Add DisplayPort device node

2023-09-19 Thread Bjorn Andersson
On Thu, Aug 17, 2023 at 05:59:37PM +0300, Dmitry Baryshkov wrote: > Declare the displayport controller present on the Qualcomm SM8250 SoC. > > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 89 > 1 file changed, 89 insertions(+) > >

Re: [Freedreno] (subset) [PATCH v4 00/17] drm/msm: Add SM6125 MDSS/DPU hardware and enable Sony Xperia 10 II panel

2023-09-19 Thread Bjorn Andersson
2260a76963bd18d9ae603e77cdd0eba [17/17] arm64: dts: qcom: sm6125-seine: Configure MDSS, DSI and panel commit: 5078dfe3c5c7b8d2d6494c26de81a4f3d4a5a3d7 Best regards, -- Bjorn Andersson

Re: [Freedreno] [RFC PATCH v1 07/12] soc: qcom: pmic_glink_altmode: report that this is a Type-C connector

2023-09-04 Thread Bjorn Andersson
with this going through the USB tree. Acked-by: Bjorn Andersson Regards, Bjorn

Re: [Freedreno] [RFC PATCH v1 06/12] soc: qcom: pmic_glink_altmode: fix DRM connector type

2023-09-04 Thread Bjorn Andersson
t;USB-n". Similarly, it looks quite reasonable that the output on my laptop are eDP-1, USB-1 and USB-2. But, if this is not the way its intended to be used, feel free to pick this together with the other patches. Acked-by: Bjorn Andersson Regards, Bjorn

Re: [Freedreno] [RFC PATCH v1 00/12] drm, usb/typec: uABI for USB-C DisplayPort connectors

2023-09-04 Thread Bjorn Andersson
On Mon, Sep 04, 2023 at 12:41:38AM +0300, Dmitry Baryshkov wrote: > During the discussion regarding DisplayPort wrapped in the USB-C > connectors (via the USB-C altmode) it was pointed out that currently > there is no good way to let userspace know if the DRM connector in > question is the

Re: [Freedreno] (subset) [PATCH v6 1/2] dt-bindings: display/msm: mdss-common: add memory-region property

2023-08-18 Thread Bjorn Andersson
Applied, thanks! [2/2] arm64: dts: qcom: sdm845-db845c: Mark cont splash memory region as reserved commit: 110e70fccce4f22b53986ae797d665ffb1950aa6 Best regards, -- Bjorn Andersson

Re: [Freedreno] [PATCH -next] drm/msm/adreno: adreno_gpu: Switch to memdup_user_nul() helper

2023-08-10 Thread Bjorn Andersson
On Thu, Aug 10, 2023 at 08:04:24PM +0800, Ruan Jinjie wrote: > Use memdup_user_nul() helper instead of open-coding to simplify the code. > > Signed-off-by: Ruan Jinjie Reviewed-by: Bjorn Andersson Regards, Bjorn

Re: [Freedreno] [PATCH 0/5] arm64: dts: qcom: qrb5165-rb5: enable DP support

2023-07-21 Thread Bjorn Andersson
On Tue, Jul 18, 2023 at 09:09:41AM +0300, Dmitry Baryshkov wrote: > On 18/07/2023 07:37, Bjorn Andersson wrote: > > On Sun, Jul 09, 2023 at 07:19:21AM +0300, Dmitry Baryshkov wrote: > > > Implement DisplayPort support for the Qualcomm RB5 platform. > > > > > >

Re: [Freedreno] [PATCH] drm/msm: Check for the GPU IOMMU during bind

2023-07-20 Thread Bjorn Andersson
On Mon, Jul 10, 2023 at 03:20:44AM +0530, Akhil P Oommen wrote: > On Fri, Jul 07, 2023 at 08:27:18PM +0300, Dmitry Baryshkov wrote: > > > > On 07/07/2023 18:03, Jordan Crouse wrote: > > > On Thu, Jul 06, 2023 at 09:55:13PM +0300, Dmitry Baryshkov wrote: > > > > > > > > On 10/03/2023 00:20,

Re: [Freedreno] [PATCH 0/5] arm64: dts: qcom: qrb5165-rb5: enable DP support

2023-07-17 Thread Bjorn Andersson
On Sun, Jul 09, 2023 at 07:19:21AM +0300, Dmitry Baryshkov wrote: > Implement DisplayPort support for the Qualcomm RB5 platform. > > Note: while testing this, I had link training issues with several > dongles with DP connectors. Other DisplayPort-USB-C dongles (with HDMI > or VGA connectors) work

Re: [Freedreno] (subset) [PATCH v2 0/8] MDSS reg bus interconnect

2023-07-13 Thread Bjorn Andersson
e6cb00d6c3f3a8e1b67fd242e639b3c3 Best regards, -- Bjorn Andersson

Re: [Freedreno] (subset) [PATCH v3 0/7] Display support for MSM8226

2023-07-09 Thread Bjorn Andersson
.] Applied, thanks! [7/7] ARM: dts: qcom: msm8226: Add mdss nodes commit: d5fb01ad5eb449ccfd950e946a882639cad168b3 Best regards, -- Bjorn Andersson

Re: [Freedreno] [PATCH 1/5] dt-bindings: display: msm: dp-controller: document SM8250 compatible

2023-07-09 Thread Bjorn Andersson
On Sun, Jul 09, 2023 at 07:19:22AM +0300, Dmitry Baryshkov wrote: > It looks like DP controlled on SM8250 is the same as DP controller on > SM8350. Use the SM8350 compatible as fallback for SM8250. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Bjorn Andersson Re

Re: [Freedreno] [PATCH v1 4/5] drm/msm/dp: move relevant dp initialization code from bind() to probe()

2023-07-08 Thread Bjorn Andersson
On Fri, Jul 07, 2023 at 04:52:22PM -0700, Kuogee Hsieh wrote: > In preparation of moving edp of_dp_aux_populate_bus() to > dp_display_probe(), move dp_display_request_irq(), > dp->parser->parse() and dp_power_client_init() to dp_display_probe() > too. > > Signed-off-by: Kuogee Hsieh > --- >

Re: [Freedreno] [PATCH v1 2/5] drm/msm/dp: incorporate pm_runtime framework into DP driver

2023-07-08 Thread Bjorn Andersson
On Fri, Jul 07, 2023 at 04:52:20PM -0700, Kuogee Hsieh wrote: > Incorporating pm runtime framework into DP driver so that power > and clock resource handling can be centralized allowing easier > control of these resources in preparation of registering aux bus > uring probe. > > Signed-off-by:

Re: [Freedreno] [PATCH v1 1/5] drm/msm/dp: remove pm_runtime_xxx() from dp_power.c

2023-07-08 Thread Bjorn Andersson
On Fri, Jul 07, 2023 at 04:52:19PM -0700, Kuogee Hsieh wrote: > Since both pm_runtime_resume() and pm_runtime_suspend() are not > populated at dp_pm_ops. Those pm_runtime_get/put() functions within > dp_power.c will not have any effects in addition to increase/decrease > power counter. Also

Re: [Freedreno] [PATCH v2 0/3] drm/msm/adreno: GPU support on SC8280XP

2023-06-14 Thread Bjorn Andersson
On Wed, Jun 14, 2023 at 09:03:34AM -0700, Bjorn Andersson wrote: > On Mon, 22 May 2023 18:15:19 -0700, Bjorn Andersson wrote: > > This series introduces support for A690 in the DRM/MSM driver and > > enables it for the two SC8280XP laptops. > > > > Bjorn Andersson (3)

Re: [Freedreno] [PATCH 0/3] drm/msm/adreno: GPU support on SC8280XP

2023-06-14 Thread Bjorn Andersson
On Tue, 7 Feb 2023 19:40:49 -0800, Bjorn Andersson wrote: > This series introduces support for A690 in the DRM/MSM driver and > enables it for the two SC8280XP laptops. > > Bjorn Andersson (3): > drm/msm/adreno: Add Adreno A690 support > arm64: dts: qcom: sc8280xp: Add

Re: [Freedreno] [PATCH v4 0/2] drm/msm/adreno: GPU support on SC8280XP

2023-06-14 Thread Bjorn Andersson
On Wed, 14 Jun 2023 07:22:02 -0700, Bjorn Andersson wrote: > With the A690 support merged in the drm/msm driver, this series adds the > DeviceTree pieces to make it go on sc8280xp. > > Note that in order for the GPU driver to probe, the last change > requires (which is now in linux

Re: [Freedreno] [PATCH v2 0/3] drm/msm/adreno: GPU support on SC8280XP

2023-06-14 Thread Bjorn Andersson
On Mon, 22 May 2023 18:15:19 -0700, Bjorn Andersson wrote: > This series introduces support for A690 in the DRM/MSM driver and > enables it for the two SC8280XP laptops. > > Bjorn Andersson (3): > drm/msm/adreno: Add Adreno A690 support > arm64: dts: qcom: sc8280xp: Add

Re: [Freedreno] [PATCH v4 2/2] arm64: dts: qcom: sc8280xp: Enable GPU related nodes

2023-06-14 Thread Bjorn Andersson
On Wed, Jun 14, 2023 at 05:27:24PM +0200, Konrad Dybcio wrote: > On 14.06.2023 16:22, Bjorn Andersson wrote: > > From: Bjorn Andersson > > > > Add memory reservation for the zap-shader and enable the Adreno SMMU, > > GPU clock controller, GMU and the GPU

[Freedreno] [PATCH v4 2/2] arm64: dts: qcom: sc8280xp: Enable GPU related nodes

2023-06-14 Thread Bjorn Andersson
From: Bjorn Andersson Add memory reservation for the zap-shader and enable the Adreno SMMU, GPU clock controller, GMU and the GPU nodes for the SC8280XP CRD and the Lenovo ThinkPad X13s. Tested-by: Steev Klimaszewski Signed-off-by: Bjorn Andersson Tested-by: Johan Hovold Signed-off-by: Bjorn

[Freedreno] [PATCH v4 1/2] arm64: dts: qcom: sc8280xp: Add GPU related nodes

2023-06-14 Thread Bjorn Andersson
From: Bjorn Andersson Add Adreno SMMU, GPU clock controller, GMU and GPU nodes for the SC8280XP. Tested-by: Steev Klimaszewski Signed-off-by: Bjorn Andersson Tested-by: Johan Hovold Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/sa8540p.dtsi | 8 ++ arch/arm64/boot/dts/qcom

[Freedreno] [PATCH v4 0/2] drm/msm/adreno: GPU support on SC8280XP

2023-06-14 Thread Bjorn Andersson
) - Corrected opp-level for highest gpu opp - Added dma-coherent to gpu smmu Changes since v1: - Dropped gmu_pdc_seq region from , as it shouldn't have been used. - Added missing compatible to _smmu. - Dropped aoss_qmp clock in and _smmu. Bjorn Andersson (2): arm64: dts: qcom: sc8280xp: Add GPU

Re: [Freedreno] [PATCH v4 0/2] arm64: dts: qcom: add DP Controller to SM8550 DTS

2023-06-13 Thread Bjorn Andersson
port on the QRD > board will be sent later. > > [...] Applied, thanks! [1/2] arm64: dts: qcom: sm8550: fix low_svs RPMhPD labels commit: bbde65f9da9291a77636e1467b28f27ced1b4ece [2/2] arm64: dts: qcom: sm8550: add display port nodes commit: 66adfbc4d33993865a180016db73520a15e754c9

  1   2   3   4   5   6   7   >