Re: [Freedreno] [PATCH v4 4/4] drm/msm/dp: dp_link_parse_sink_count() return immediately if aux read failed

2021-12-01 Thread khsieh
On 2021-11-24 23:32, Dmitry Baryshkov wrote: On 04/05/2021 07:35, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-04-21 16:37:38) Add checking aux read/write status at both dp_link_parse_sink_count() and dp_link_parse_sink_status_filed() to avoid long timeout delay if s/filed/field/ dp aux

Re: [Freedreno] [PATCH v4] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-11-15 Thread khsieh
On 2021-11-09 13:38, Kuogee Hsieh wrote: From: Kuogee Hsieh Current DP drivers have regulators, clocks, irq and phy are grouped together within a function and executed not in a symmetric manner. This increase difficulty of code maintenance and limited code scalability. This patch divided the

Re: [Freedreno] [PATCH v3] arm64: dts: qcom: sc7280: Add Display Port node

2021-11-15 Thread khsieh
On 2021-11-02 16:44, Kuogee Hsieh wrote: From: Kuogee Hsieh Signed-off-by: Kuogee Hsieh --- Anyone has comments on this patch? Changes in v2: -- move fixes of dp_phy reg property to other patch Changes in v3: -- delete "qcom,sc7180-dp" from msm_dp node

Re: [Freedreno] [PATCH] drm/msm/dp: Avoid unpowered AUX xfers that caused crashes

2021-11-09 Thread khsieh
On 2021-11-09 10:04, Douglas Anderson wrote: If you happened to try to access `/dev/drm_dp_aux` devices provided by the MSM DP AUX driver too early at bootup you could go boom. Let's avoid that by only allowing AUX transfers when the controller is powered up. Specifically the crash that was

Re: [Freedreno] [PATCH v3 6/6] drm/msm/dp: Remove the hpd init delay for eDP

2021-10-29 Thread khsieh
On 2021-10-27 23:38, Stephen Boyd wrote: Quoting Sankeerth Billakanti (2021-10-27 18:54:48) DP driver needs a 10 second delay before phy_init so that the usb combo phy initializes and sets up the necessary clocks for usb devices such as keyboard and mouse. eDP controller uses a standalone phy

Re: [Freedreno] [PATCH v2 4/4] arm64: dts: qcom: sc7280: add edp display dt nodes

2021-10-25 Thread khsieh
On 2021-10-21 11:44, Stephen Boyd wrote: Quoting Krishna Manikandan (2021-10-20 06:58:53) From: Sankeerth Billakanti Add edp controller and phy DT nodes for sc7280. Signed-off-by: Sankeerth Billakanti Signed-off-by: Krishna Manikandan Some comments below Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH] drm/msm/dp: Shorten SETUP timeout

2021-10-11 Thread khsieh
On 2021-10-08 09:44, Bjorn Andersson wrote: On Fri 08 Oct 09:07 PDT 2021, khs...@codeaurora.org wrote: On 2021-10-07 15:34, Stephen Boyd wrote: > Quoting khs...@codeaurora.org (2021-10-07 13:28:12) > > On 2021-10-07 13:06, Bjorn Andersson wrote: > > > On Thu 07 Oct 12:51 PDT 2021,

Re: [Freedreno] [PATCH] drm/msm/dp: Shorten SETUP timeout

2021-10-08 Thread khsieh
On 2021-10-07 15:34, Stephen Boyd wrote: Quoting khs...@codeaurora.org (2021-10-07 13:28:12) On 2021-10-07 13:06, Bjorn Andersson wrote: > On Thu 07 Oct 12:51 PDT 2021, khs...@codeaurora.org wrote: > >> On 2021-10-06 10:31, Bjorn Andersson wrote: >> > On Wed 06 Oct 08:37 PDT 2021,

Re: [Freedreno] [PATCH] drm/msm/dp: Shorten SETUP timeout

2021-10-07 Thread khsieh
On 2021-10-07 13:06, Bjorn Andersson wrote: On Thu 07 Oct 12:51 PDT 2021, khs...@codeaurora.org wrote: On 2021-10-06 10:31, Bjorn Andersson wrote: > On Wed 06 Oct 08:37 PDT 2021, khs...@codeaurora.org wrote: > > > On 2021-10-05 19:10, Bjorn Andersson wrote: > > > On Tue 05 Oct 16:04 PDT 2021,

Re: [Freedreno] [PATCH] drm/msm/dp: Shorten SETUP timeout

2021-10-07 Thread khsieh
On 2021-10-06 10:31, Bjorn Andersson wrote: On Wed 06 Oct 08:37 PDT 2021, khs...@codeaurora.org wrote: On 2021-10-05 19:10, Bjorn Andersson wrote: > On Tue 05 Oct 16:04 PDT 2021, khs...@codeaurora.org wrote: > > > On 2021-10-05 15:36, Stephen Boyd wrote: > > > Quoting Bjorn Andersson

Re: [Freedreno] [PATCH] drm/msm/dp: Shorten SETUP timeout

2021-10-06 Thread khsieh
On 2021-10-05 19:10, Bjorn Andersson wrote: On Tue 05 Oct 16:04 PDT 2021, khs...@codeaurora.org wrote: On 2021-10-05 15:36, Stephen Boyd wrote: > Quoting Bjorn Andersson (2021-10-05 14:40:38) > > On Tue 05 Oct 11:45 PDT 2021, Stephen Boyd wrote: > > > > > Quoting Bjorn Andersson (2021-10-04

Re: [Freedreno] [PATCH] drm/msm/dp: Shorten SETUP timeout

2021-10-05 Thread khsieh
On 2021-10-05 15:36, Stephen Boyd wrote: Quoting Bjorn Andersson (2021-10-05 14:40:38) On Tue 05 Oct 11:45 PDT 2021, Stephen Boyd wrote: > Quoting Bjorn Andersson (2021-10-04 19:37:50) > > Found in the middle of a patch from Sankeerth was the reduction of the > > INIT_SETUP timeout from 10s to

Re: [Freedreno] [PATCH v2 3/5] drm/msm/dp: Support up to 3 DP controllers

2021-09-28 Thread khsieh
On 2021-08-27 10:14, Bjorn Andersson wrote: On Fri 27 Aug 00:20 CDT 2021, Stephen Boyd wrote: Quoting Bjorn Andersson (2021-08-25 16:42:31) > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index 2c7de43f655a..4a6132c18e57 100644 > ---

Re: [Freedreno] [PATCH v3] drm/dp_mst: Fix return code on sideband message failure

2021-09-07 Thread khsieh
On 2021-08-30 09:58, Lyude Paul wrote: On Mon, 2021-08-30 at 08:56 -0700, khs...@codeaurora.org wrote: On 2021-08-25 09:26, Lyude Paul wrote: > The patch was pushed yes (was part of drm-misc-next-2021-07-29), seems > like it > just hasn't trickled down to linus's branch quite yet. Hi Stephen

Re: [Freedreno] [PATCH v3] drm/dp_mst: Fix return code on sideband message failure

2021-08-30 Thread khsieh
On 2021-08-25 09:26, Lyude Paul wrote: The patch was pushed yes (was part of drm-misc-next-2021-07-29), seems like it just hasn't trickled down to linus's branch quite yet. Hi Stephen B, Would you mind back porting this patch to V5.10 branch? It will have lots of helps for us to support

Re: [Freedreno] [PATCH] phy: qcom-qmp: add support for voltage and pre emphesis swing

2021-08-27 Thread khsieh
On 2021-08-25 10:49, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-08-24 16:29:35) Add voltage and pre emphesis swing tables so that voltage and Is it "pre-emphasis"? pre emphsis swing level can be configured base on link rate. This one is also different. Signed-off-by: Kuogee Hsieh

Re: [Freedreno] [PATCH v3] drm/dp_mst: Fix return code on sideband message failure

2021-08-25 Thread khsieh
On 2021-07-27 15:44, Lyude Paul wrote: Nice timing, you literally got me as I was 2 minutes away from leaving work for the day :P. I will go ahead and push it now. Hi Lyude, Had you pushed this patch yet? We still did not see this patch at msm-nex and v5.10 branch. Thanks, BTW - in the

Re: [Freedreno] [PATCH v2] drm/msm/dp: add drm debug logs to dp_pm_resume/suspend

2021-08-10 Thread khsieh
On 2021-08-10 12:23, Stephen Boyd wrote: Quoting khs...@codeaurora.org (2021-08-10 12:18:02) On 2021-08-10 11:33, Stephen Boyd wrote: > Quoting Kuogee Hsieh (2021-08-10 08:29:22) >> Changes in V2: >> -- correct Fixes text >> -- drop commit text >> >> Fixes: 601f0479c583 ("drm/msm/dp: add logs

Re: [Freedreno] [PATCH v2] drm/msm/dp: add drm debug logs to dp_pm_resume/suspend

2021-08-10 Thread khsieh
On 2021-08-10 11:33, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-08-10 08:29:22) Changes in V2: -- correct Fixes text -- drop commit text Fixes: 601f0479c583 ("drm/msm/dp: add logs across DP driver for ease of debugging") Signed-off-by: Kuogee Hsieh ---

Re: [Freedreno] [PATCH v3] drm/msm/dp: update is_connected status base on sink count at dp_pm_resume()

2021-08-04 Thread khsieh
On 2021-08-03 12:05, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-08-03 09:25:13) Currently at dp_pm_resume() is_connected state is decided base on hpd connection status only. This will put is_connected in wrongly "true" state at the scenario that dongle attached to DUT but without hmdi

Re: [Freedreno] [PATCH v3] drm/dp_mst: Fix return code on sideband message failure

2021-07-27 Thread khsieh
On 2021-07-27 12:21, Lyude Paul wrote: On Thu, 2021-07-22 at 15:28 -0700, khs...@codeaurora.org wrote: It looks like this patch is good to go (mainlined). Anything needed from me to do? Thanks, Do you have access for pushing this patch? If not let me know and I can go ahead and push it to

Re: [Freedreno] [PATCH v3] drm/dp_mst: Fix return code on sideband message failure

2021-07-22 Thread khsieh
On 2021-07-22 10:53, Lyude Paul wrote: On Tue, 2021-07-13 at 15:24 -0700, khs...@codeaurora.org wrote: On 2021-07-07 01:37, Jani Nikula wrote: > On Tue, 06 Jul 2021, Kuogee Hsieh wrote: > > From: Rajkumar Subbiah > > > > Commit 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing + >

Re: [Freedreno] [PATCH v3] drm/dp_mst: Fix return code on sideband message failure

2021-07-13 Thread khsieh
On 2021-07-07 01:37, Jani Nikula wrote: On Tue, 06 Jul 2021, Kuogee Hsieh wrote: From: Rajkumar Subbiah Commit 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing + selftests") added some debug code for sideband message tracing. But it seems to have unintentionally changed the

Re: [Freedreno] [PATCH 5/7] drm/msm/dp: return correct edid checksum after corrupted edid checksum read

2021-07-09 Thread khsieh
On 2021-07-08 00:14, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-07-06 10:20:18) Response with correct edid checksum saved at connector after corrupted edid checksum read. This fixes Link Layer CTS cases 4.2.2.3, 4.2.2.6. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_panel.c

Re: [Freedreno] [PATCH 2/7] drm/msm/dp: reduce link rate if failed at link training 1

2021-07-09 Thread khsieh
On 2021-07-08 00:33, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-07-06 10:20:15) Reduce link rate and re start link training if link training 1 failed due to loss of clock recovery done to fix Link Layer CTS case 4.3.1.7. Also only update voltage and pre-emphasis swing level after link

Re: [Freedreno] [PATCH 7/7] drm/msm/dp: retrain link when loss of symbol lock detected

2021-07-09 Thread khsieh
On 2021-07-08 00:21, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-07-06 10:20:20) Main link symbol locked is achieved at end of link training 2. Some dongle main link symbol may become unlocked again if host did not end link training soon enough after completion of link training 2. Host have

Re: [Freedreno] [PATCH 3/7] drm/msm/dp: reset aux controller after dp_aux_cmd_fifo_tx() failed.

2021-07-08 Thread khsieh
On 2021-07-08 00:34, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-07-06 10:20:16) Aux hardware calibration sequence requires resetting the aux controller in order for the new setting to take effect. However resetting the AUX controller will also clear HPD interrupt status which may

Re: [Freedreno] [PATCH 1/7] drm/msm/dp: use dp_ctrl_off_link_stream during PHY compliance test run

2021-07-08 Thread khsieh
On 2021-07-08 00:03, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-07-06 10:20:14) DP cable should always connect to DPU during the entire PHY compliance testing run. Since DP PHY compliance test is executed at irq_hpd event context, dp_ctrl_off_link_stream() should be used instead of

Re: [Freedreno] [PATCH v2] arm64/dts/qcom/sc7180: Add Display Port dt node

2021-06-25 Thread khsieh
On 2021-06-22 19:52, Bjorn Andersson wrote: On Tue 22 Jun 15:23 CDT 2021, Stephen Boyd wrote: Quoting Bjorn Andersson (2021-06-18 14:41:50) > On Fri 18 Jun 15:49 CDT 2021, Stephen Boyd wrote: > > > Quoting khs...@codeaurora.org (2021-06-10 09:54:05) > > > On 2021-06-08 16:10, Bjorn Andersson

Re: [Freedreno] [PATCH v2] arm64/dts/qcom/sc7180: Add Display Port dt node

2021-06-10 Thread khsieh
On 2021-06-08 16:10, Bjorn Andersson wrote: On Tue 08 Jun 17:44 CDT 2021, Stephen Boyd wrote: Quoting Bjorn Andersson (2021-06-08 15:34:01) > On Tue 08 Jun 17:29 CDT 2021, Stephen Boyd wrote: > > > Quoting Bjorn Andersson (2021-06-08 15:26:23) > > > On Tue 08 Jun 17:15 CDT 2021, Stephen Boyd

Re: [Freedreno] [PATCH v2] arm64/dts/qcom/sc7180: Add Display Port dt node

2021-06-07 Thread khsieh
On 2021-06-05 22:07, Bjorn Andersson wrote: On Thu 03 Jun 16:56 CDT 2021, khs...@codeaurora.org wrote: On 2021-06-03 09:53, Bjorn Andersson wrote: > On Thu 03 Jun 11:09 CDT 2021, Kuogee Hsieh wrote: [..] > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi [..] > > +

Re: [Freedreno] [PATCH v5] drm/msm/dp: power off DP phy at suspend

2021-06-03 Thread khsieh
On 2021-06-03 13:22, Stephen Boyd wrote: Can you Cc dri-devel? Sorry for dropping this cc. Should I re submit this v5 with cc=dri-devel? Quoting Kuogee Hsieh (2021-06-03 08:40:46) Normal DP suspend operation contains two steps, display off followed by dp suspend, to complete system wide

Re: [Freedreno] [PATCH v2] arm64/dts/qcom/sc7180: Add Display Port dt node

2021-06-03 Thread khsieh
On 2021-06-03 09:53, Bjorn Andersson wrote: On Thu 03 Jun 11:09 CDT 2021, Kuogee Hsieh wrote: Add DP device node on sc7180. Changes in v2: -- replace msm_dp with dp -- replace dp_opp_table with opp_table I'm sorry for those suggestions, I don't like either one of them. And for everything

Re: [Freedreno] [PATCH v2] arm64/dts/qcom/sc7180: Add Display Port dt node

2021-06-03 Thread khsieh
On 2021-06-03 09:53, Bjorn Andersson wrote: On Thu 03 Jun 11:09 CDT 2021, Kuogee Hsieh wrote: Add DP device node on sc7180. Changes in v2: -- replace msm_dp with dp -- replace dp_opp_table with opp_table I'm sorry for those suggestions, I don't like either one of them. And for everything

Re: [Freedreno] [PATCH v3] drm/msm/dp: power off DP phy at suspend

2021-06-02 Thread khsieh
On 2021-06-01 19:00, Stephen Boyd wrote: Please add dri-de...@lists.freedesktop.org next time Quoting Kuogee Hsieh (2021-06-01 16:50:08) Normal DP suspend operation contains two steps, display off followed by dp suspend, to complete system wide suspending cycle if display is up at that time.

Re: [Freedreno] [PATCH] drm/msm/dp: keep aux channel up when power of dp phy

2021-05-27 Thread khsieh
On 2021-05-26 21:29, Stephen Boyd wrote: General note, please Cc dri-devel on freedreno driver patches. Quoting Kuogee Hsieh (2021-05-26 16:49:49) Aux channel is used to perform management function and should be running in parallel with main link. Therefore should only power down main link and

Re: [Freedreno] [PATCH] drm/msm/dp: power off DP phy base on mainlink status at suspend

2021-05-26 Thread khsieh
On 2021-05-26 15:30, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-05-26 11:08:23) DP mainlink can be either enabled or disabled at the time of suspend happen. Therefore DP phy teared down at suspend should base on mainlink status at that instance. Please add some more details here. The

Re: [Freedreno] [PATCH 3/3] drm/msm/dp: Handle aux timeouts, nacks, defers

2021-05-24 Thread khsieh
On 2021-05-07 14:25, Stephen Boyd wrote: Let's look at the irq status bits after a transfer and see if we got a nack or a defer or a timeout, instead of telling drm layers that everything was fine, while still printing an error message. I wasn't sure about NACK+DEFER so I lumped all those

Re: [Freedreno] [PATCH 3/3] drm/msm/dp: Handle aux timeouts, nacks, defers

2021-05-24 Thread khsieh
On 2021-05-24 12:19, Stephen Boyd wrote: Quoting khs...@codeaurora.org (2021-05-24 09:33:49) On 2021-05-07 14:25, Stephen Boyd wrote: > @@ -367,36 +347,38 @@ static ssize_t dp_aux_transfer(struct drm_dp_aux > *dp_aux, > } > > ret = dp_aux_cmd_fifo_tx(aux, msg); > - > if (ret <

Re: [Freedreno] [PATCH 3/3] drm/msm/dp: Handle aux timeouts, nacks, defers

2021-05-24 Thread khsieh
On 2021-05-07 14:25, Stephen Boyd wrote: Let's look at the irq status bits after a transfer and see if we got a nack or a defer or a timeout, instead of telling drm layers that everything was fine, while still printing an error message. I wasn't sure about NACK+DEFER so I lumped all those

Re: [Freedreno] [PATCH 2/3] drm/msm/dp: Shrink locking area of dp_aux_transfer()

2021-05-24 Thread khsieh
On 2021-05-07 14:25, Stephen Boyd wrote: We don't need to hold the lock to inspect the message we're going to transfer, and we don't need to clear the busy flag either. Take the lock later and bail out earlier if conditions aren't met. Cc: Dmitry Baryshkov Cc: Abhinav Kumar Cc: Kuogee Hsieh

Re: [Freedreno] [PATCH 1/3] drm/msm/dp: Simplify aux irq handling code

2021-05-24 Thread khsieh
On 2021-05-07 14:25, Stephen Boyd wrote: We don't need to stash away 'isr' in the aux structure to pass to two functions. Let's use a local variable instead. And we can complete the completion variable in one place instead of two to simplify the code. Cc: Dmitry Baryshkov Cc: Abhinav Kumar

Re: [Freedreno] [PATCH 0/3] drm/msm/dp: Simplify aux code

2021-05-21 Thread khsieh
On 2021-05-21 14:57, Stephen Boyd wrote: Quoting Stephen Boyd (2021-05-07 14:25:02) Here's a few patches that simplify the aux handling code and bubble up timeouts and nacks to the upper DRM layers. The goal is to get DRM to know that the other side isn't there or that there's been a timeout,

Re: [Freedreno] [PATCH 1/2] drm/msm/dp: service only one irq_hpd if there are multiple irq_hpd pending

2021-05-03 Thread khsieh
On 2021-04-29 20:11, Stephen Boyd wrote: Quoting khs...@codeaurora.org (2021-04-29 10:23:31) On 2021-04-29 02:26, Stephen Boyd wrote: > Quoting khs...@codeaurora.org (2021-04-28 10:38:11) >> On 2021-04-27 17:00, Stephen Boyd wrote: >> > Quoting aravi...@codeaurora.org (2021-04-21 11:55:21) >>

Re: [Freedreno] [PATCH 1/2] drm/msm/dp: service only one irq_hpd if there are multiple irq_hpd pending

2021-04-29 Thread khsieh
On 2021-04-29 02:26, Stephen Boyd wrote: Quoting khs...@codeaurora.org (2021-04-28 10:38:11) On 2021-04-27 17:00, Stephen Boyd wrote: > Quoting aravi...@codeaurora.org (2021-04-21 11:55:21) >> On 2021-04-21 10:26, khs...@codeaurora.org wrote: >> >> >> >>> + >> >>>

Re: [Freedreno] [PATCH 1/2] drm/msm/dp: service only one irq_hpd if there are multiple irq_hpd pending

2021-04-28 Thread khsieh
On 2021-04-27 17:00, Stephen Boyd wrote: Quoting aravi...@codeaurora.org (2021-04-21 11:55:21) On 2021-04-21 10:26, khs...@codeaurora.org wrote: >> >>> + >>> mutex_unlock(>event_mutex); >>> >>> return 0; >>> @@ -1496,6 +1502,9 @@ int msm_dp_display_disable(struct msm_dp *dp, >>>

Re: [Freedreno] [PATCH v3 3/3] drm/msm/dp: check main link status before start aux read

2021-04-21 Thread khsieh
On 2021-04-20 16:38, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-04-16 10:38:51) Maybe when the cable is disconnected the DP phy should be shutdown and some bit in the phy could effectively "cut off" the aux channel and then NAKs would start coming through here in the DP controller I/O

Re: [Freedreno] [PATCH 1/2] drm/msm/dp: service only one irq_hpd if there are multiple irq_hpd pending

2021-04-21 Thread khsieh
On 2021-04-20 15:01, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-04-16 13:27:57) Some dongle may generate more than one irq_hpd events in a short period of time. This patch will treat those irq_hpd events as single one and service only one irq_hpd event. Why is it bad to get multiple

Re: [Freedreno] [PATCH v2 3/3] drm/msm/dp: check main link status before start aux read

2021-04-15 Thread khsieh
On 2021-04-15 13:06, Stephen Boyd wrote: Quoting khs...@codeaurora.org (2021-04-15 10:37:29) On 2021-04-14 14:09, Stephen Boyd wrote: > Quoting Kuogee Hsieh (2021-04-13 16:11:44) >> Make sure main link is in connection state before start aux >> read/write operation to avoid unnecessary long

Re: [Freedreno] [PATCH v2 2/3] drm/msm/dp: initialize audio_comp when audio starts

2021-04-15 Thread khsieh
On 2021-04-14 14:22, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-04-14 14:02:50) Initialize audio_comp when audio starts and wait for audio_comp at dp_display_disable(). This will take care of both dongle unplugged and display off (suspend) cases. Changes in v2: -- add

Re: [Freedreno] [PATCH v2 3/3] drm/msm/dp: check main link status before start aux read

2021-04-15 Thread khsieh
On 2021-04-14 14:09, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-04-13 16:11:44) Make sure main link is in connection state before start aux read/write operation to avoid unnecessary long delay due to main link had been unplugged. Signed-off-by: Kuogee Hsieh ---

Re: [Freedreno] [PATCH v2 2/3] drm/msm/dp: do not re initialize of audio_comp at display_disable()

2021-04-14 Thread khsieh
On 2021-04-13 20:17, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-04-13 16:11:30) At dongle unplug, dp initializes audio_comp followed by sending disconnect event notification to audio and to make sure audio had shutdown completely by wait for audio completion notification at

Re: [Freedreno] [PATCH v2 2/2] drm/msm/dp: add supported max link rate specified from dtsi

2021-02-22 Thread khsieh
On 2021-02-22 08:55, Sean Paul wrote: On Mon, Feb 22, 2021 at 11:31 AM wrote: On 2021-02-19 14:46, Stephen Boyd wrote: > Quoting khs...@codeaurora.org (2021-02-19 08:39:38) >> On 2021-02-18 15:02, Stephen Boyd wrote: >> > Quoting Kuogee Hsieh (2021-02-18 12:55:04) >> >> Allow supported link

Re: [Freedreno] [PATCH v2 2/2] drm/msm/dp: add supported max link rate specified from dtsi

2021-02-22 Thread khsieh
On 2021-02-19 14:46, Stephen Boyd wrote: Quoting khs...@codeaurora.org (2021-02-19 08:39:38) On 2021-02-18 15:02, Stephen Boyd wrote: > Quoting Kuogee Hsieh (2021-02-18 12:55:04) >> Allow supported link rate to be limited to the value specified at >> dtsi. If it is not specified, then link rate

Re: [Freedreno] [PATCH v2 2/2] drm/msm/dp: add supported max link rate specified from dtsi

2021-02-19 Thread khsieh
On 2021-02-18 15:02, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-02-18 12:55:04) Allow supported link rate to be limited to the value specified at dtsi. If it is not specified, then link rate is derived from dpcd directly. Below are examples, link-rate = <162000> for max link rate limited at

Re: [Freedreno] [PATCH 1/2] drm/msm/dp: postpone irq_hpd event during connection pending state

2021-01-14 Thread khsieh
On 2021-01-13 16:00, Stephen Boyd wrote: Quoting khs...@codeaurora.org (2021-01-13 15:44:32) On 2021-01-13 12:22, Stephen Boyd wrote: > Quoting khs...@codeaurora.org (2021-01-13 09:44:24) >> On 2021-01-11 11:55, Stephen Boyd wrote: >> > Quoting Kuogee Hsieh (2021-01-07 12:30:24) >> >> irq_hpd

Re: [Freedreno] [PATCH v2 0/2] fix missing unplug interrupt problem

2021-01-13 Thread khsieh
On 2021-01-13 12:25, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-01-13 10:59:58) Both AUX_SW_RESET and DP_SW_RESET clear pending HPD interrupts. Therefore irq_hpd handler should not issues either aux or sw reset to avoid following unplug interrupt be cleared accidentally. Kuogee Hsieh (2):

Re: [Freedreno] [PATCH 2/2] drm/msm/dp: unplug interrupt missed after irq_hpd handler

2021-01-13 Thread khsieh
On 2021-01-13 12:23, Stephen Boyd wrote: Quoting khs...@codeaurora.org (2021-01-13 09:48:25) On 2021-01-11 11:54, Stephen Boyd wrote: > Quoting Kuogee Hsieh (2021-01-07 12:30:25) >> There is HPD unplug interrupts missed at scenario of an irq_hpd >> followed by unplug interrupts with around 10

Re: [Freedreno] [PATCH 1/2] drm/msm/dp: postpone irq_hpd event during connection pending state

2021-01-13 Thread khsieh
On 2021-01-13 12:22, Stephen Boyd wrote: Quoting khs...@codeaurora.org (2021-01-13 09:44:24) On 2021-01-11 11:55, Stephen Boyd wrote: > Quoting Kuogee Hsieh (2021-01-07 12:30:24) >> irq_hpd event can only be executed at connected state. Therefore >> irq_hpd event should be postponed if it

Re: [Freedreno] [PATCH 2/2] drm/msm/dp: unplug interrupt missed after irq_hpd handler

2021-01-13 Thread khsieh
On 2021-01-11 11:54, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-01-07 12:30:25) There is HPD unplug interrupts missed at scenario of an irq_hpd followed by unplug interrupts with around 10 ms in between. Since both AUX_SW_RESET and DP_SW_RESET clear pending HPD interrupts, irq_hpd handler

Re: [Freedreno] [PATCH 1/2] drm/msm/dp: postpone irq_hpd event during connection pending state

2021-01-13 Thread khsieh
On 2021-01-11 11:55, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-01-07 12:30:24) irq_hpd event can only be executed at connected state. Therefore irq_hpd event should be postponed if it happened at connection pending state. This patch also make sure both link rate and lane Why does it

Re: [Freedreno] [PATCH] drm/msm/dp: deinitialize mainlink if link training failedo

2020-11-03 Thread khsieh
On 2020-11-02 12:59, Stephen Boyd wrote: Quoting Kuogee Hsieh (2020-10-30 16:22:53) DP compo phy have to be enable to start link training. When link training failed phy need to be disabled so that next link trainng can be proceed smoothly at next plug in. This s/trainng/training/ patch de

Re: [Freedreno] [PATCH] drm/msm/dp: promote irq_hpd handle to handle link trainign correctly

2020-11-03 Thread khsieh
On 2020-11-02 11:29, Stephen Boyd wrote: Subject has a typo in "training". Quoting Kuogee Hsieh (2020-10-30 16:23:24) Some dongles, such as Apple, required link training done at irq_hpd s/required/require/ request instead of plugin request. This patch promote irq_hpd hanlder

Re: [Freedreno] [PATCH] drm/msm/dp: skip checking LINK_STATUS_UPDATED bit

2020-10-30 Thread khsieh
On 2020-10-20 15:15, Stephen Boyd wrote: Quoting Kuogee Hsieh (2020-10-20 09:59:59) No need to check LINK_STATuS_UPDATED bit before LINK_STATUS_UPDATED? return 6 bytes of link status during link training. Why? This patch also fix phy compliance test link rate conversion error. How?

Re: [Freedreno] [PATCH v2] drm/msm/dp: add opp_table corner voting support base on dp_ink_clk rate

2020-10-10 Thread khsieh
On 2020-10-06 00:31, Rajendra Nayak wrote: On 10/4/2020 3:56 AM, Kuogee Hsieh wrote: Set link rate by using OPP set rate api so that CX level will be set accordingly based on the link rate. Changes in v2: -- remove dev from dp_ctrl_put() parameters -- address review comments This needs to go

Re: [Freedreno] [PATCH] drm/msm/dp: fixes wrong connection state caused by failure of link train

2020-10-05 Thread khsieh
On 2020-10-02 19:12, Stephen Boyd wrote: Quoting Kuogee Hsieh (2020-10-02 15:09:19) Connection state is set incorrectly happen at either failure of link train or cable plugged in while suspended. This patch fixes these problems. This patch also replace ST_SUSPEND_PENDING with ST_DISPLAY_OFF.

Re: [Freedreno] [PATCH] drm/msm/dp: add voltage corners voting support base on dp link rate

2020-10-03 Thread khsieh
On 2020-09-30 09:24, Rajendra Nayak wrote: On 9/30/2020 1:54 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2020-09-29 10:10:26) Set link rate by using OPP set rate api so that CX level will be set accordingly base on the link rate. s/base/based/ Signed-off-by: Kuogee Hsieh --- diff --git

Re: [Freedreno] [PATCH] drm/msm/dp: Sleep properly in dp_hpd_handler kthread

2020-09-17 Thread khsieh
On 2020-09-17 15:44, Stephen Boyd wrote: We shouldn't be waiting for an event here with a timeout of 100ms when we're not in the 'timeout' arm of the if condition. Instead we should be sleeping in the interruptible state (S) until something happens and we need to wakeup. Right now this kthread

Re: [Freedreno] [PATCH v3] drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets

2020-08-18 Thread khsieh
On 2020-08-18 14:59, Stephen Boyd wrote: Quoting Kuogee Hsieh (2020-08-18 14:15:46) add event thread to execute events serially from event queue. Also timeout mode is supported which allow an event be deferred to be executed at later time. Both link and phy compliant tests had been done

Re: [Freedreno] [PATCH] drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets

2020-07-21 Thread khsieh
On 2020-07-20 19:57, Rob Clark wrote: On Mon, Jul 20, 2020 at 4:32 PM Stephen Boyd wrote: Quoting khs...@codeaurora.org (2020-07-20 15:48:13) > On 2020-07-20 13:18, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2020-07-07 11:41:25) > >> drivers/gpu/drm/msm/dp/dp_power.c | 32 +- >

Re: [Freedreno] [PATCH] drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets

2020-07-20 Thread khsieh
On 2020-07-20 13:18, Stephen Boyd wrote: Quoting Kuogee Hsieh (2020-07-07 11:41:25) add event thread to execute events serially from event queue. Also timeout mode is supported which allow an event be deferred to be executed at later time. Both link and phy compliant tests had been done