Re: [Freedreno] [PATCH] drm/msm: check for equals 0 only

2019-04-25 Thread Rob Clark
On Thu, Apr 25, 2019 at 7:09 AM Nicholas Mc Guire wrote: > > wait_for_completion_timeout() returns 0 on timeout and aleast 1 otherwise > so checking for < makes no sense here. > > Signed-off-by: Nicholas Mc Guire > --- > > Problem located with an experimental coccinelle script > > While this

Re: [Freedreno] [PATCH] drm/msm: check for equals 0 only

2019-04-25 Thread Abhinav Kumar
On 2019-04-25 07:03, Nicholas Mc Guire wrote: wait_for_completion_timeout() returns 0 on timeout and aleast 1 otherwise so checking for < makes no sense here. Signed-off-by: Nicholas Mc Guire Reviewed-by: Abhinav Kumar --- Problem located with an experimental coccinelle script While this

[Freedreno] [PATCH] drm/msm: check for equals 0 only

2019-04-25 Thread Nicholas Mc Guire
wait_for_completion_timeout() returns 0 on timeout and aleast 1 otherwise so checking for < makes no sense here. Signed-off-by: Nicholas Mc Guire --- Problem located with an experimental coccinelle script While this check does no harm in this form - it should be fixed anyway to comply with