Re: [Freedreno] [PATCH v1 1/5] drm/msm/dp: remove pm_runtime_xxx() from dp_power.c

2023-07-10 Thread Dmitry Baryshkov
On 10/07/2023 20:25, Kuogee Hsieh wrote: On 7/9/2023 1:32 PM, Abhinav Kumar wrote: On 7/9/2023 11:00 AM, Dmitry Baryshkov wrote: On Sun, 9 Jul 2023 at 20:22, Abhinav Kumar wrote: On 7/7/2023 5:06 PM, Dmitry Baryshkov wrote: On 08/07/2023 02:52, Kuogee Hsieh wrote: Since both

Re: [Freedreno] [PATCH v1 1/5] drm/msm/dp: remove pm_runtime_xxx() from dp_power.c

2023-07-10 Thread Kuogee Hsieh
On 7/9/2023 1:32 PM, Abhinav Kumar wrote: On 7/9/2023 11:00 AM, Dmitry Baryshkov wrote: On Sun, 9 Jul 2023 at 20:22, Abhinav Kumar wrote: On 7/7/2023 5:06 PM, Dmitry Baryshkov wrote: On 08/07/2023 02:52, Kuogee Hsieh wrote: Since both pm_runtime_resume() and pm_runtime_suspend() are

Re: [Freedreno] [PATCH v1 1/5] drm/msm/dp: remove pm_runtime_xxx() from dp_power.c

2023-07-09 Thread Abhinav Kumar
On 7/9/2023 11:00 AM, Dmitry Baryshkov wrote: On Sun, 9 Jul 2023 at 20:22, Abhinav Kumar wrote: On 7/7/2023 5:06 PM, Dmitry Baryshkov wrote: On 08/07/2023 02:52, Kuogee Hsieh wrote: Since both pm_runtime_resume() and pm_runtime_suspend() are not populated at dp_pm_ops. Those

Re: [Freedreno] [PATCH v1 1/5] drm/msm/dp: remove pm_runtime_xxx() from dp_power.c

2023-07-09 Thread Dmitry Baryshkov
On Sun, 9 Jul 2023 at 20:22, Abhinav Kumar wrote: > > > > On 7/7/2023 5:06 PM, Dmitry Baryshkov wrote: > > On 08/07/2023 02:52, Kuogee Hsieh wrote: > >> Since both pm_runtime_resume() and pm_runtime_suspend() are not > >> populated at dp_pm_ops. Those pm_runtime_get/put() functions within > >>

Re: [Freedreno] [PATCH v1 1/5] drm/msm/dp: remove pm_runtime_xxx() from dp_power.c

2023-07-09 Thread Abhinav Kumar
On 7/8/2023 7:34 PM, Bjorn Andersson wrote: On Fri, Jul 07, 2023 at 04:52:19PM -0700, Kuogee Hsieh wrote: Since both pm_runtime_resume() and pm_runtime_suspend() are not populated at dp_pm_ops. Those pm_runtime_get/put() functions within dp_power.c will not have any effects in addition to

Re: [Freedreno] [PATCH v1 1/5] drm/msm/dp: remove pm_runtime_xxx() from dp_power.c

2023-07-09 Thread Abhinav Kumar
On 7/7/2023 5:06 PM, Dmitry Baryshkov wrote: On 08/07/2023 02:52, Kuogee Hsieh wrote: Since both pm_runtime_resume() and pm_runtime_suspend() are not populated at dp_pm_ops. Those pm_runtime_get/put() functions within dp_power.c will not have any effects in addition to increase/decrease

Re: [Freedreno] [PATCH v1 1/5] drm/msm/dp: remove pm_runtime_xxx() from dp_power.c

2023-07-08 Thread Bjorn Andersson
On Fri, Jul 07, 2023 at 04:52:19PM -0700, Kuogee Hsieh wrote: > Since both pm_runtime_resume() and pm_runtime_suspend() are not > populated at dp_pm_ops. Those pm_runtime_get/put() functions within > dp_power.c will not have any effects in addition to increase/decrease > power counter. Also

Re: [Freedreno] [PATCH v1 1/5] drm/msm/dp: remove pm_runtime_xxx() from dp_power.c

2023-07-07 Thread Dmitry Baryshkov
On 08/07/2023 02:52, Kuogee Hsieh wrote: Since both pm_runtime_resume() and pm_runtime_suspend() are not populated at dp_pm_ops. Those pm_runtime_get/put() functions within dp_power.c will not have any effects in addition to increase/decrease power counter. Lie. Also pm_runtime_xxx() should

[Freedreno] [PATCH v1 1/5] drm/msm/dp: remove pm_runtime_xxx() from dp_power.c

2023-07-07 Thread Kuogee Hsieh
Since both pm_runtime_resume() and pm_runtime_suspend() are not populated at dp_pm_ops. Those pm_runtime_get/put() functions within dp_power.c will not have any effects in addition to increase/decrease power counter. Also pm_runtime_xxx() should be executed at top layer. Signed-off-by: Kuogee