Re: [Freedreno] [v3 2/2] backlight: Add DisplayPort aux backlight driver

2021-04-30 Thread Lyude Paul
JFYI for anyone who is interested, I will be respinning my patches for adding backlight helpers very soon since we've got pretty much all of the prep work for it upstream now On Mon, 2021-04-26 at 12:49 +0300, Jani Nikula wrote: > On Mon, 26 Apr 2021, Rajeev Nandan wrote: > > Add backlight

Re: [Freedreno] [v3 2/2] backlight: Add DisplayPort aux backlight driver

2021-04-26 Thread rajeevny
On 26-04-2021 15:19, Jani Nikula wrote: On Mon, 26 Apr 2021, Rajeev Nandan wrote: Add backlight driver for the panels supporting backlight control using DPCD registers on the DisplayPort aux channel. No, please don't do this. I wrote you last week in reply to v1 why I thought merging this

Re: [Freedreno] [v3 2/2] backlight: Add DisplayPort aux backlight driver

2021-04-26 Thread Jani Nikula
On Mon, 26 Apr 2021, Rajeev Nandan wrote: > Add backlight driver for the panels supporting backlight control > using DPCD registers on the DisplayPort aux channel. No, please don't do this. I wrote you last week in reply to v1 why I thought merging this would not be a good idea [1]. Why have

[Freedreno] [v3 2/2] backlight: Add DisplayPort aux backlight driver

2021-04-26 Thread Rajeev Nandan
Add backlight driver for the panels supporting backlight control using DPCD registers on the DisplayPort aux channel. Changes in v2: - New (most of the code reused from drm_dp_aux_backlight.c of v1) Changes in v3: - Add missing ';' to fix module compilation (kernel test bot) Signed-off-by: