Re: [PATCH v3] phy/qcom-qmp-combo: propagate correct return value at phy_power_on()

2024-04-03 Thread Stephen Boyd
Quoting Abhinav Kumar (2024-04-03 14:28:52) > > > On 4/3/2024 1:04 PM, Stephen Boyd wrote: > > Quoting Abhinav Kumar (2024-04-03 12:58:50) > >> > >> > >> On 4/3/2024 12:51 PM, Stephen Boyd wrote: > >>> Quoting Kuogee Hsieh (2024-03-29 12:50:35) > Currently qmp_combo_dp_power_on() always

Re: [PATCH v3] phy/qcom-qmp-combo: propagate correct return value at phy_power_on()

2024-04-03 Thread Abhinav Kumar
On 4/3/2024 1:04 PM, Stephen Boyd wrote: Quoting Abhinav Kumar (2024-04-03 12:58:50) On 4/3/2024 12:51 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2024-03-29 12:50:35) Currently qmp_combo_dp_power_on() always return 0 in regardless of return value of cfg->configure_dp_phy(). This patch

Re: [PATCH v3] phy/qcom-qmp-combo: propagate correct return value at phy_power_on()

2024-04-03 Thread Stephen Boyd
Quoting Abhinav Kumar (2024-04-03 12:58:50) > > > On 4/3/2024 12:51 PM, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2024-03-29 12:50:35) > >> Currently qmp_combo_dp_power_on() always return 0 in regardless of > >> return value of cfg->configure_dp_phy(). This patch propagate > >> return value of

Re: [PATCH v3] phy/qcom-qmp-combo: propagate correct return value at phy_power_on()

2024-04-03 Thread Abhinav Kumar
On 4/3/2024 12:51 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2024-03-29 12:50:35) Currently qmp_combo_dp_power_on() always return 0 in regardless of return value of cfg->configure_dp_phy(). This patch propagate return value of cfg->configure_dp_phy() all the way back to caller. Is this

Re: [PATCH v3] phy/qcom-qmp-combo: propagate correct return value at phy_power_on()

2024-04-03 Thread Stephen Boyd
Quoting Kuogee Hsieh (2024-03-29 12:50:35) > Currently qmp_combo_dp_power_on() always return 0 in regardless of > return value of cfg->configure_dp_phy(). This patch propagate > return value of cfg->configure_dp_phy() all the way back to caller. Is this found via code inspection or because the

Re: [PATCH v3] phy/qcom-qmp-combo: propagate correct return value at phy_power_on()

2024-04-03 Thread Dmitry Baryshkov
On Wed, Apr 03, 2024 at 10:22:37AM -0700, Kuogee Hsieh wrote: > Dmitry, > > Any more comments? > > On 3/29/2024 12:50 PM, Kuogee Hsieh wrote: > > Currently qmp_combo_dp_power_on() always return 0 in regardless of > > return value of cfg->configure_dp_phy(). This patch propagate > > return value

Re: [PATCH v3] phy/qcom-qmp-combo: propagate correct return value at phy_power_on()

2024-04-03 Thread Kuogee Hsieh
Dmitry, Any more comments? On 3/29/2024 12:50 PM, Kuogee Hsieh wrote: Currently qmp_combo_dp_power_on() always return 0 in regardless of return value of cfg->configure_dp_phy(). This patch propagate return value of cfg->configure_dp_phy() all the way back to caller. Changes in V3: -- add v2

[PATCH v3] phy/qcom-qmp-combo: propagate correct return value at phy_power_on()

2024-03-29 Thread Kuogee Hsieh
Currently qmp_combo_dp_power_on() always return 0 in regardless of return value of cfg->configure_dp_phy(). This patch propagate return value of cfg->configure_dp_phy() all the way back to caller. Changes in V3: -- add v2 changes log Changes in V2: -- add Fixes tag -- add dev_err() to