[Freedreno] [PATCH 07/12] drm/msm: Handle drm_atomic_helper_swap_state failure

2017-07-19 Thread Maarten Lankhorst
drm_atomic_helper_swap_state() will be changed to interruptible waiting in the next few commits, so all drivers have to be changed to handling failure. MSM has its own busy tracking, which means the swap_state call can be done with stall = false, in which case it should never return an error. Hand

Re: [Freedreno] [PATCH 07/12] drm/msm: Handle drm_atomic_helper_swap_state failure

2017-07-19 Thread Archit Taneja
On 07/19/2017 01:10 PM, Maarten Lankhorst wrote: drm_atomic_helper_swap_state() will be changed to interruptible waiting in the next few commits, so all drivers have to be changed to handling failure. MSM has its own busy tracking, which means the swap_state call can be done with stall = false

Re: [Freedreno] [PATCH 14/16] drm/msm: Convert to use new iterator macros, v2.

2017-07-19 Thread Archit Taneja
On 07/12/2017 04:15 PM, Maarten Lankhorst wrote: Op 12-07-17 om 11:48 schreef Daniel Vetter: On Wed, Jul 12, 2017 at 10:13:42AM +0200, Maarten Lankhorst wrote: for_each_obj_in_state is about to be removed, so convert to the new iterator macros. Just like in omap, use crtc_state->active inste

Re: [Freedreno] [PATCH 07/12] drm/msm: Handle drm_atomic_helper_swap_state failure

2017-07-19 Thread Maarten Lankhorst
Op 19-07-17 om 11:24 schreef Archit Taneja: > > > On 07/19/2017 01:10 PM, Maarten Lankhorst wrote: >> drm_atomic_helper_swap_state() will be changed to interruptible waiting >> in the next few commits, so all drivers have to be changed to handling >> failure. >> >> MSM has its own busy tracking, wh

Re: [Freedreno] [PATCH] drm/msm/mdp5: Fix compilation warnings

2017-07-19 Thread Chris Wilson
Quoting Viresh Kumar (2017-06-29 10:19:59) > Following compilation warnings were observed for these files: > > CC [M] drivers/gpu/drm/msm/mdp/mdp5/mdp5_mdss.o > drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c: In function 'blend_setup': > drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c:223:7: warning: missin

Re: [Freedreno] [PATCH] drm/msm/mdp5: Fix compilation warnings

2017-07-19 Thread Viresh Kumar
On 19-07-17, 13:13, Chris Wilson wrote: > Quoting Viresh Kumar (2017-06-29 10:19:59) > > diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c > > b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c > > index 7d3741215387..0ee9bd0041cd 100644 > > --- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c > > +++ b/

[Freedreno] [PATCH v2 5/7] drm/msm: Convert to use new iterator macros, v2.

2017-07-19 Thread Maarten Lankhorst
for_each_obj_in_state is about to be removed, so convert to the new iterator macros. Just like in omap, use crtc_state->active instead of crtc_state->enable when waiting for completion. Changes since v1: - Fix compilation. Signed-off-by: Maarten Lankhorst Cc: Rob Clark Cc: Archit Taneja Cc: V