Re: [Freedreno] [PATCH RESEND 02/10] drm/msm: Include the dpu_dbg header in msm_drv.c

2018-03-08 Thread Jeykumar Sankaran
On 2018-02-21 07:18, Sean Paul wrote: We'll need to clean up these conditionals further, but at least fix the compilation error. Signed-off-by: Sean Paul Reviewed-by: Jeykumar Sankaran --- drivers/gpu/drm/msm/msm_drv.c | 3 +++ 1 file

Re: [Freedreno] [PATCH RESEND 04/10] drm/msm: Remove smmu driver init/cleanup from msm_drv

2018-03-08 Thread Jeykumar Sankaran
On 2018-02-21 07:18, Sean Paul wrote: Leftover bits from the initial removal of smmu. Signed-off-by: Sean Paul Reviewed-by: Jeykumar Sankaran --- drivers/gpu/drm/msm/msm_drv.c | 6 -- 1 file changed, 6 deletions(-) diff --git

Re: [Freedreno] [PATCH RESEND 05/10] drm/msm: Defer probe if display component not found

2018-03-08 Thread Jeykumar Sankaran
On 2018-02-21 07:18, Sean Paul wrote: The downstream driver relies on Makefile ordering of files to ensure components probe in the right order. This took me entirely too long to sort out, so don't rely on that any longer. Signed-off-by: Sean Paul Reviewed-by: Jeykumar

Re: [Freedreno] [DPU PATCH] drm: Remove duplicate ycbcr420 parsing

2018-03-08 Thread abhinavk
On 2018-03-08 16:48, Jeykumar Sankaran wrote: On 2018-02-21 10:30, Sean Paul wrote: Introduced in the dpu patch series, this duplicaates the already existing do_y420vdb_modes function. Signed-off-by: Sean Paul Reviewed-by: Jeykumar Sankaran

Re: [Freedreno] [DPU PATCH 03/11] drm/msm: Refactor complete_commit() to look more the helpers

2018-03-08 Thread Jeykumar Sankaran
On 2018-02-28 11:18, Sean Paul wrote: Factor out the commit_tail() portions of complete_commit() into a separate function to facilitate moving to the atomic helpers in future patches. Change-Id: I4b858ad9fe356b31ed0ed9eecdb394a61048e39c Signed-off-by: Sean Paul

Re: [Freedreno] [PATCH RESEND 01/10] drm/msm: Add displayport files to Makefile

2018-03-08 Thread Jeykumar Sankaran
On 2018-02-21 07:18, Sean Paul wrote: Still behind a config flag, and ymmv when trying to build them, but they're present at least. Signed-off-by: Sean Paul Reviewed-by: Jeykumar Sankaran --- drivers/gpu/drm/msm/Makefile | 14 ++

Re: [Freedreno] [PATCH RESEND 02/10] drm/msm: Include the dpu_dbg header in msm_drv.c

2018-03-08 Thread Jeykumar Sankaran
On 2018-02-21 07:18, Sean Paul wrote: We'll need to clean up these conditionals further, but at least fix the compilation error. Signed-off-by: Sean Paul Reviewed by Jeykumar Sankaran --- drivers/gpu/drm/msm/msm_drv.c | 3 +++ 1 file changed, 3 insertions(+) diff

Re: [Freedreno] [DPU PATCH 02/11] drm/msm: Don't duplicate modeset_enables atomic helper

2018-03-08 Thread Jeykumar Sankaran
On 2018-02-28 11:18, Sean Paul wrote: Instead, shuffle things around so we kickoff crtc after enabling encoder during modesets. Also moves the vblank wait to after the frame. Change-Id: I16c7b7f9390d04f6050aa20e17a5335fbf49eba3 Signed-off-by: Sean Paul ---

Re: [Freedreno] [DPU PATCH 06/11] drm/msm: Remove msm_commit/kthread, use atomic helper commit

2018-03-08 Thread Jeykumar Sankaran
On 2018-03-02 06:56, Sean Paul wrote: On Thu, Mar 01, 2018 at 07:37:10PM -0500, Rob Clark wrote: On Thu, Mar 1, 2018 at 3:37 PM, wrote: > On 2018-03-01 07:27, Sean Paul wrote: >> >> On Wed, Feb 28, 2018 at 08:07:00PM -0800, jsa...@codeaurora.org wrote: >>> >>> On

Re: [Freedreno] [PATCH RESEND 10/10] drm/msm: Restore msm_atomic_check hook

2018-03-08 Thread Jeykumar Sankaran
On 2018-02-21 07:18, Sean Paul wrote: Somehow this got lost, put it back. We might want to re-evaluate whether this is actually necessary, but for now let's actually use the thing. Signed-off-by: Sean Paul Reviewed-by: Jeykumar Sankaran ---

Re: [Freedreno] [DPU PATCH 09/11] drm/msm: Remove prepare_fence kms_function

2018-03-08 Thread abhinavk
On 2018-02-28 11:19, Sean Paul wrote: This is the last piece that is keeping us from matching the atomic helper commit function. By removing this (now unused) hook, we can switch to drm_atomic_helper_commit() Change-Id: I081056a6e1689807871f5deedc76499bb91b6969 Signed-off-by: Sean Paul

Re: [Freedreno] [DPU PATCH 07/11] drm/msm: Use atomic private_obj instead of subclassing

2018-03-08 Thread Jeykumar Sankaran
On 2018-02-28 11:19, Sean Paul wrote: Instead of subclassing atomic state, store driver private data in private_obj/state. This allows us to remove the swap_state driver hook for mdp5 and get closer to using the atomic helpers entirely. Change-Id: I65a4a2887593ae257d584e00b352b5daf00e4e61

Re: [Freedreno] [DPU PATCH 10/11] drm/msm: Switch to atomic_helper_commit()

2018-03-08 Thread abhinavk
On 2018-02-28 11:19, Sean Paul wrote: Now that all of the msm-specific goo is tucked safely away we can switch over to using the atomic helper commit directly. \o/ [Abhinav] Can we say something like "Move remaining msm-specific operations to private handles and switch to atomic helper commit

Re: [Freedreno] [PATCH 2/2] arm64: dts: sdm845: Support GPU/GMU

2018-03-08 Thread Viresh Kumar
On 08-03-18, 13:14, Jordan Crouse wrote: > It seems to me that performance_state has a direct relationship with genpd > which is good for CPU votes but in this case, we're just passing along raw > data > to an independent microcontroller. The 'qcom,arc-level' is used to construct > the actual