Re: [Freedreno] [DPU PATCH v2 1/2] drm/msm/dsi: check video mode engine status before waiting

Hi Sean Thanks for the review. Reply inline. On 2018-04-13 13:26, Sean Paul wrote: On Tue, Apr 10, 2018 at 06:54:06PM -0700, Abhinav Kumar wrote: Make sure the video mode engine is on before waiting for the video done interrupt. Otherwise it leads to silent timeouts increasing display turn

Re: [Freedreno] [DPU PATCH 1/2] drm/msm/dsi: adjust dsi timing for dual dsi mode

On Tue, Apr 10, 2018 at 06:16:07PM -0700, Chandan Uddaraju wrote: > For dual dsi mode, the horizontal timing needs > to be divided by half since both the dsi controllers > will be driving this panel. Adjust the pixel clock and > DSI timing accordingly. > > Change-Id:

Re: [Freedreno] [[RFC]DPU PATCH 1/2] drm/bridge: add support for sn65dsi86 bridge driver

On Fri, Apr 13, 2018 at 10:53:00AM +0530, Sandeep Panda wrote: > Add support for TI's sn65dsi86 dsi2edp bridge chip. > The chip converts DSI transmitted signal to eDP signal, > which is fed to the connected eDP panel. > > This chip can be controlled via either i2c interface or > dsi interface.

Re: [Freedreno] [DPU PATCH v2 1/2] drm/msm/dsi: check video mode engine status before waiting

On Tue, Apr 10, 2018 at 06:54:06PM -0700, Abhinav Kumar wrote: > Make sure the video mode engine is on before waiting > for the video done interrupt. > > Otherwise it leads to silent timeouts increasing display > turn ON time. > > Changes in v2: > - Replace pr_err with dev_err > - Changed error

Re: [Freedreno] [DPU PATCH 2/2] drm/msm/dsi: Use one connector for dual DSI mode

On Tue, Apr 10, 2018 at 06:16:08PM -0700, Chandan Uddaraju wrote: > Current DSI driver uses two connectors for dual DSI case even > though we only have one panel. Fix this by implementing one > connector/bridge for dual DSI use case. Use master DSI > controllers to register one connector/bridge. >

Re: [Freedreno] [DPU PATCH 2/2] drm/panel: add backlight control support for truly panel

On Sat, Apr 07, 2018 at 12:06:53AM -0700, Abhinav Kumar wrote: > Register truly panel as a backlight led device and > provide methods to control its backlight operation. > > Signed-off-by: Abhinav Kumar > --- > drivers/gpu/drm/panel/panel-truly-dual-dsi.c | 96 >

Re: [Freedreno] [DPU PATCH v2 2/2] drm/msm/dsi: implement auto PHY timing calculator for 10nm PHY

On 2018-04-13 13:29, Sean Paul wrote: On Tue, Apr 10, 2018 at 06:54:07PM -0700, Abhinav Kumar wrote: Currently the DSI PHY timings are hard-coded for a specific panel for the 10nm PHY. Replace this with the auto PHY timing calculator which can calculate the PHY timings for any panel. Any

Re: [Freedreno] [[RFC]DPU PATCH 2/2] dt-bindings: drm/bridge: Document sn65dsi86 bridge bindings

On Fri, Apr 13, 2018 at 1:23 AM Sandeep Panda wrote: > Document the bindings used for the sn65dsi86 DSI to eDP bridge. > Signed-off-by: Sandeep Panda > --- > .../bindings/display/bridge/ti,sn65dsi86.txt | 75 ++ > 1