[Freedreno] [PATCH 06/13] drm/msm: Depopulate platform on probe failure

2019-06-17 Thread Sean Paul
From: Sean Paul add_display_components() calls of_platform_populate, and we depopluate on pdev remove, but not when probe fails. So if we get a probe deferral in one of the components, we won't depopulate the platform. This causes the core to keep references to devices which should be destroyed,

[Freedreno] [PATCH 09/13] drm/msm/dsi: Pull out panel init code into function

2019-06-17 Thread Sean Paul
From: Sean Paul Pull all of the panel init code out of detect() and put it in its own function. This will be useful in future patches where it's moved from detect(). Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 16 1 file changed, 12 insertions(+), 4

[Freedreno] [PATCH 05/13] drm/msm/dsi_pll_10nm: Remove impossible check

2019-06-17 Thread Sean Paul
From: Sean Paul While I'm in here, cut this out, pdev can't be NULL Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c index

[Freedreno] [PATCH 10/13] drm/msm/dsi: Simplify the logic in msm_dsi_manager_panel_init()

2019-06-17 Thread Sean Paul
From: Sean Paul This patch moves things around a bit to be a little more readable and pulls out the set_encoder_mode() call into its own function for later use. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 100 +++--- 1 file changed, 59

[Freedreno] [PATCH 03/13] drm/msm/phy/dsi_phy: Set pll to NULL in case initialization fails

2019-06-17 Thread Sean Paul
From: Sean Paul We have if (!phy->pll) checks scattered through the driver and if phy->pll is an error pointer, those checks will pass and bad things will happen :( Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[Freedreno] [PATCH 13/13] drm/msm/dsi: Move setup_encoder to modeset_init

2019-06-17 Thread Sean Paul
From: Sean Paul Now that the panel probe/setup is in the modeset path, we can call dsi_manager_setup_encoder() in a common place for both internal and external bridge setups. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/dsi/dsi.c | 2 ++ drivers/gpu/drm/msm/dsi/dsi.h | 2

[Freedreno] [PATCH 04/13] drm/msm/dsi_pll_10nm: Release clk hw on destroy and failure

2019-06-17 Thread Sean Paul
From: Sean Paul The 10nm pll driver didn't have any failure-path cleanup in register, and the destroy function didn't unregister any of the hardware. This patch adds both. The reason things haven't been blowing up horribly is that msm_drv has a reference count issue that keeps devices alive, so

[Freedreno] [PATCH 07/13] drm/msm/dsi: Split mode_flags out of msm_dsi_host_get_panel()

2019-06-17 Thread Sean Paul
From: Sean Paul We use the flags in more places than just get_panel, so split them out into a separate function. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/dsi/dsi.h | 4 ++-- drivers/gpu/drm/msm/dsi/dsi_host.c| 15 ++- drivers/gpu/drm/msm/dsi/dsi_manager.c | 7

[Freedreno] [PATCH 11/13] drm/msm/dsi: Use the new setup_encoder function in attach_dsi_device

2019-06-17 Thread Sean Paul
From: Sean Paul Now that we have a function to call set_encoder_mode() for us, use it. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/dsi/dsi.h | 2 +- drivers/gpu/drm/msm/dsi/dsi_host.c| 2 +- drivers/gpu/drm/msm/dsi/dsi_manager.c | 15 ++- 3 files changed, 4

[Freedreno] [PATCH 12/13] drm/msm/dsi: Move dsi panel init into modeset init path

2019-06-17 Thread Sean Paul
From: Sean Paul Since deferred probe from the modeset init path now works, we can move the panel initialization from detect() into connector init. This avoids doing work in detect() and hopefully will result in a more deterministic boot sequence between devices with a dsi panel, and those with

[Freedreno] [RESEND PATCH 02/13] drm/msm/dpu: Fix mmu init/destroy functions

2019-06-17 Thread Sean Paul
From: Sean Paul There's a comment in _dpu_kms_hw_destroy() that reads "safe to call these more than once during shutdown", referring to _dpu_kms_mmu_destroy(). Unfortunately that's not the case, mmu_destroy will fail hard if it's called twice. So fix that function to ensure it can be called

[Freedreno] [RESEND PATCH 01/13] drm/msm/dpu: Remove call to drm_mode_set_crtcinfo

2019-06-17 Thread Sean Paul
From: Sean Paul Now that mode_fixup has been removed, we can just rely on the call from drm_helper_probe_single_connector_modes(), Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 3 --- 1 file changed, 3 deletions(-) diff --git

Re: [Freedreno] [PATCH 5/6] soc: qcom: add OCMEM driver

2019-06-17 Thread Brian Masney
Hi Rob Clark, On Sun, Jun 16, 2019 at 10:41:06AM -0700, Bjorn Andersson wrote: > > diff --git a/drivers/soc/qcom/ocmem.xml.h b/drivers/soc/qcom/ocmem.xml.h > > I would prefer that these lived at the top of the c file, rather than > being generated. I think it would be nice to make this change

Re: [Freedreno] [PATCH 5/6] soc: qcom: add OCMEM driver

2019-06-17 Thread Rob Clark
On Mon, Jun 17, 2019 at 7:02 PM Brian Masney wrote: > > Hi Rob Clark, > > On Sun, Jun 16, 2019 at 10:41:06AM -0700, Bjorn Andersson wrote: > > > diff --git a/drivers/soc/qcom/ocmem.xml.h b/drivers/soc/qcom/ocmem.xml.h > > > > I would prefer that these lived at the top of the c file, rather than >

Re: [Freedreno] [PATCH 1/6] dt-bindings: soc: qcom: add On Chip MEMory (OCMEM) bindings

2019-06-17 Thread Rob Herring
On Sun, Jun 16, 2019 at 7:29 AM Brian Masney wrote: > > Add device tree bindings for the On Chip Memory (OCMEM) that is present > on some Qualcomm Snapdragon SoCs. > > Signed-off-by: Brian Masney > --- > .../bindings/soc/qcom/qcom,ocmem.yaml | 66 +++ .../bindings/sram/

[Freedreno] [PATCH] drm/prime: Actually remove DRIVER_PRIME everywhere

2019-06-17 Thread Daniel Vetter
Split out to make the functional changes stick out more. v2: amdgpu gained DRIVER_SYNCOBJ_TIMELINE. v3: amdgpu lost DRIVER_SYNCOBJ_TIMELINE. v4: Don't add a space in i915_drv.c (Sam) Cc: Sam Ravnborg Reviewed-by: Eric Anholt Signed-off-by: Daniel Vetter Cc: amd-...@lists.freedesktop.org Cc:

Re: [Freedreno] [PATCH 06/59] drm/prime: Actually remove DRIVER_PRIME everywhere

2019-06-17 Thread Emil Velikov
On 2019/06/14, Daniel Vetter wrote: > Split out to make the functional changes stick out more. > Since this patch flew-by, as standalone one (intentionally or not) I'd add, anything vaguely like: "Core users of DRIVER_PRIME were removed from core with prior patches." HTH Emil