Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes

2019-11-12 Thread Brian Masney
On Mon, Nov 11, 2019 at 07:51:22AM -0700, Jeffrey Hugo wrote: > On Mon, Nov 11, 2019 at 4:38 AM Brian Masney wrote: > > > > On Sun, Nov 10, 2019 at 10:37:33AM -0700, Jeffrey Hugo wrote: > > > On Sun, Nov 10, 2019 at 6:53 AM Brian Masney > > > wrote: > > > > > > > > On Fri, Nov 08, 2019 at

[Freedreno] [PATCH] drm/msm/mdp5: enable autocommit

2019-11-12 Thread Brian Masney
Since the introduction of commit 2d99ced787e3 ("drm/msm: async commit support"), command-mode panels began throwing the following errors: msm fd90.mdss: pp done time out, lm=0 Let's fix this by enabling the autorefresh feature that's available in the MDP starting at version 1.0. This

Re: [Freedreno] [PATCH 1/4] drm/msm: fix memleak on release

2019-11-12 Thread Sean Paul
On Tue, Nov 12, 2019 at 08:32:07AM -0800, Rob Clark wrote: > On Tue, Nov 12, 2019 at 6:01 AM Daniel Vetter wrote: > > > > On Tue, Nov 12, 2019 at 11:40:01AM +0100, Johan Hovold wrote: > > > On Wed, Oct 30, 2019 at 11:01:46AM +0100, Johan Hovold wrote: > > > > On Thu, Oct 10, 2019 at 03:13:30PM

Re: [Freedreno] [PATCH 1/4] drm/msm: fix memleak on release

2019-11-12 Thread Johan Hovold
On Wed, Oct 30, 2019 at 11:01:46AM +0100, Johan Hovold wrote: > On Thu, Oct 10, 2019 at 03:13:30PM +0200, Johan Hovold wrote: > > If a process is interrupted while accessing the "gpu" debugfs file and > > the drm device struct_mutex is contended, release() could return early > > and fail to free

Re: [Freedreno] [PATCH RESEND] drm/msm/adreno: Do not print error on "qcom, gpu-pwrlevels" absence

2019-11-12 Thread Jordan Crouse
On Tue, Nov 12, 2019 at 01:40:22PM -0300, Fabio Estevam wrote: > Hi Jordan, > > On Fri, Nov 1, 2019 at 11:52 AM Jordan Crouse wrote: > > > I'm good with this. This really should only be around for > > compatibility with downstream device tree files which should mean nothing > > for > > I.MX5.

[Freedreno] Add support for DisplayPort driver on SnapDragon 845 - 5.2.0 kernel from Linaro.

2019-11-12 Thread vadiraj kaveri
Hi Chandan, I am trying to enable DP on 5.2.0 based kernel from Linaro, using Inforce Computing SnapDragon 845 based board. I have integrated your DP patches done on 4.9 kernel. I am getting some compile errors as listed below. Please let me know if you have some pointers for that, also do you

Re: [Freedreno] [PATCH 1/4] drm/msm: fix memleak on release

2019-11-12 Thread Rob Clark
On Tue, Nov 12, 2019 at 6:01 AM Daniel Vetter wrote: > > On Tue, Nov 12, 2019 at 11:40:01AM +0100, Johan Hovold wrote: > > On Wed, Oct 30, 2019 at 11:01:46AM +0100, Johan Hovold wrote: > > > On Thu, Oct 10, 2019 at 03:13:30PM +0200, Johan Hovold wrote: > > > > If a process is interrupted while

Re: [Freedreno] [PATCH 14/16] drm/msm: avoid using 'timespec'

2019-11-12 Thread Jordan Crouse
On Fri, Nov 08, 2019 at 10:32:52PM +0100, Arnd Bergmann wrote: > The timespec structure and associated interfaces are deprecated and will > be removed in the future because of the y2038 overflow. > > The use of ktime_to_timespec() in timeout_to_jiffies() does not > suffer from that overflow, but

Re: [Freedreno] [PATCH RESEND] drm/msm/adreno: Do not print error on "qcom, gpu-pwrlevels" absence

2019-11-12 Thread Fabio Estevam
Hi Jordan, On Fri, Nov 1, 2019 at 11:52 AM Jordan Crouse wrote: > I'm good with this. This really should only be around for > compatibility with downstream device tree files which should mean nothing for > I.MX5. May I resend it with your Reviewed-by tag? Thanks

Re: [Freedreno] [PATCH 1/4] drm/msm: fix memleak on release

2019-11-12 Thread Daniel Vetter
On Tue, Nov 12, 2019 at 11:40:01AM +0100, Johan Hovold wrote: > On Wed, Oct 30, 2019 at 11:01:46AM +0100, Johan Hovold wrote: > > On Thu, Oct 10, 2019 at 03:13:30PM +0200, Johan Hovold wrote: > > > If a process is interrupted while accessing the "gpu" debugfs file and > > > the drm device

Re: [Freedreno] [PATCH] drm/msm/mdp5: enable autocommit

2019-11-12 Thread Jeffrey Hugo
On Tue, Nov 12, 2019 at 3:49 AM Brian Masney wrote: > > Since the introduction of commit 2d99ced787e3 ("drm/msm: async commit > support"), command-mode panels began throwing the following errors: > > msm fd90.mdss: pp done time out, lm=0 > > Let's fix this by enabling the autorefresh

[Freedreno] [PATCH AUTOSEL 4.19 079/209] msm/gpu/a6xx: Force of_dma_configure to setup DMA for GMU

2019-11-12 Thread Sasha Levin
From: Jordan Crouse [ Upstream commit 32aa27e15c28d3898ed6f9b3c98f95f34a81eab2 ] The point of the 'force_dma' parameter for of_dma_configure is to force the device to be set up even if DMA capability is not described by the firmware which is exactly the use case we have for GMU - we need SMMU