atomic state and triggers a devcoredump.
Abhinav Kumar (4):
drm: allow drm_atomic_print_state() to accept any drm_printer
disp/msm/dpu: add support to dump dpu registers
drm/msm: register the base address with dpu_dbg module
drm/msm/dpu: add dpu_dbg points across dpu driver
drivers/gpu
Register the base address of various dpu sub-modules with the
dpu_dbg module so that it can be dumped out during error scenarios.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_dbg.c | 4 +--
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c| 6 -
drivers/gpu/drm
Add dpu_dbg points across dpu driver to trigger dumps when critical
errors are hit.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 12 ++--
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 5 +++--
drivers/gpu/drm/msm/disp/dpu1
Add the dpu_dbg module which adds supports to dump dpu registers
which can be used in case of error conditions.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/Makefile | 2 +
drivers/gpu/drm/msm/disp/dpu1/dpu_dbg.c | 316 ++
drivers/gpu/drm/msm
Currently drm_atomic_print_state() internally allocates and uses a
drm_info printer. Allow it to accept any drm_printer type so that
the API can be leveraged even for taking drm snapshot.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/drm_atomic.c| 17 -
drivers/gpu
For sinks that do not support audio, there is no need to notify
audio subsystem of the connection event.
This will make sure that audio routes only to the primary display
when connected to such sinks.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/dp_display.c | 12 ++--
1
atomic state and triggers a devcoredump.
changes in v2:
- Fix kbot errors
- Rename drm_atomic_print_state function and add kernel doc for it
- Fix multiple dsi registration issue with dpu_dbg
Abhinav Kumar (4):
drm: allow drm_atomic_print_state() to accept any drm_printer
drm/msm/dpu: add
better.
changes in v2:
- Rename the function drm_atomic_print_state to
drm_atomic_print_new_state and update the commit text
- Fix kbot errors
- Add kernel doc for the newly exported function
Reported-by: kernel test robot
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/drm_atomic.c
Add the dpu_dbg module which adds supports to dump dpu registers
which can be used in case of error conditions.
changes in v2: Fix kbot errors
Reported-by: kernel test robot
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/Makefile | 2 +
drivers/gpu/drm/msm/disp/dpu1
Register the base address of various dpu sub-modules with the
dpu_dbg module so that it can be dumped out during error scenarios.
changes in v2:
- Fix an issue where the same dsi client was getting registered
multiple times to the dpu_dbg module
Signed-off-by: Abhinav Kumar
---
drivers/gpu
Add dpu_dbg points across dpu driver to trigger dumps when critical
errors are hit.
changes in v2: none
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 12 ++--
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 5 +++--
drivers/gpu/drm/msm
pointer
Fixes: d13e36d7d222 ("drm/msm/dp: add audio support for Display Port on MSM")
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/dp_display.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
b/drivers/gpu/
Update the qos remap only if the client type changes for the plane.
This will avoid unnecessary register programming and also avoid log
spam from the dpu_vbif_set_qos_remap() function.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 17 +
drivers
-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 17 +++--
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 2 ++
2 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
Fix the warnings reported by kbot across MSM DP driver.
Reported-by: kernel test robot
Reported-by: Dan Carpenter
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/dp_debug.c | 33 +
drivers/gpu/drm/msm/dp/dp_hpd.c | 4 ++--
drivers/gpu/drm/msm/dp
Fix an incorrect NULL check reported by kbot in the MSM DP driver
smatch warnings:
drivers/gpu/drm/msm/dp/dp_hpd.c:37 dp_hpd_connect()
error: we previously assumed 'hpd_priv->dp_cb' could be null
(see line 37)
Reported-by: kernel test robot
Reported-by: Dan Carpenter
Signed-of
test robot
Reported-by: Dan Carpenter
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/dp_debug.c | 2 +-
drivers/gpu/drm/msm/dp/dp_power.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_debug.c
b/drivers/gpu/drm/msm/dp/dp_debug.c
index
code. Also it silences the above Smatch
warnings that we're checking for NULL when these functions only
return error pointers.
Reported-by: kernel test robot
Reported-by: Dan Carpenter
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/dp_debug.c | 31 ---
the resp drivers
- refactor and remove the linked list logic and simplify it to have
just an array
Abhinav Kumar (3):
drm: allow drm_atomic_print_state() to accept any drm_printer
drm/msm/dpu: add support to dump dpu registers
drm/msm/dpu: add dpu_dbg points across dpu driver
drivers/gpu
it in dpu_kms
- delegate the power management of the sub-modules to the resp drivers
- refactor and remove the linked list logic and simplify it to have
just an array
Change-Id: Ide975ecf5d7952ae44daaa6eb611e27d09630be5
Reported-by: kernel test robot
Signed-off-by: Abhinav Kumar
better.
changes in v3:
- Remove empty line in the kernel doc
Change-Id: Ie425b15b9d5e84f7bad2514f9990181d05019cbf
Reported-by: kernel test robot
Signed-off-by: Abhinav Kumar
Reviewed-by: Daniel Vetter
---
drivers/gpu/drm/drm_atomic.c | 28 +++-
drivers/gpu
Add dpu_dbg points across dpu driver to trigger dumps when critical
errors are hit.
changes in v3:
- change the callers to also pass the drm device while triggering
the dump
Change-Id: I351514afe2f1c85232a1562253e5671588075197
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1
better.
changes in v4:
- none
Reported-by: kernel test robot
Signed-off-by: Abhinav Kumar
Reviewed-by: Daniel Vetter
---
drivers/gpu/drm/drm_atomic.c | 28 +++-
drivers/gpu/drm/drm_atomic_uapi.c| 4 +++-
drivers/gpu/drm/drm_crtc_internal.h
information
- cleanup block allocation and freeing logic to simplify it
Reported-by: kernel test robot
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/Makefile | 2 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h| 2 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
Add snapshot points across dpu driver to trigger dumps when critical
errors are hit.
changes in v4:
- change the callers to use the new snapshot macro
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 18 +++---
drivers/gpu/drm/msm/disp/dpu1
the snapshot of the drm
atomic state and triggers a devcoredump.
changes in v4:
- rename dpu_dbg to msm_disp_snapshot and move it to msm/disp
- start using a list of blocks to store the hardware block information
- cleanup block allocation and freeing logic to simplify it
Abhinav Kumar (3
better.
changes in v5:
- none
Reported-by: kernel test robot
Signed-off-by: Abhinav Kumar
Reviewed-by: Daniel Vetter
---
drivers/gpu/drm/drm_atomic.c | 28 +++-
drivers/gpu/drm/drm_atomic_uapi.c| 4 +++-
drivers/gpu/drm/drm_crtc_internal.h
Add an API to take a snapshot of DP controller registers. This API
will be used by the msm_disp_snapshot module to capture the DP
snapshot.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/dp_catalog.c | 9 +
drivers/gpu/drm/msm/dp/dp_catalog.h | 4
drivers/gpu/drm/msm/dp
Add an API to take a snapshot of DPU controller registers. This API
will be used by the msm_disp_snapshot module to capture the DPU
snapshot.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 50 +
drivers/gpu/drm/msm/msm_kms.h
and dp pieces for easier review
- get rid of MSM_DISP_SNAPSHOT_IN_* macros by simplifying function
Abhinav Kumar (7):
drm: allow drm_atomic_print_state() to accept any drm_printer
drm/msm: add support to take dpu snapshot
drm/msm/dsi: add API to take DSI register snapshot
drm/msm/dp: add
Add support to take the register snapshot of dsi, dp and dpu
modules.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/msm_disp_snapshot.h | 1 +
drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c | 16
2 files changed, 17 insertions(+)
diff --git a/drivers/gpu
functions
- move snprintf inside the snapshot core by using varargs
- get rid of some stale code comments
- allow snapshot module for non-DPU targets
Reported-by: kernel test robot
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/Makefile | 2 +
drivers/gpu/drm/msm/disp
Add an API to take a snapshot of DSI controller registers. This API
will be used by the msm_disp_snapshot module to capture the DSI
snapshot.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dsi/dsi.c | 4
drivers/gpu/drm/msm/dsi/dsi.h | 5 -
drivers/gpu/drm/msm/dsi
Add snapshot points across dpu driver to trigger dumps when critical
errors are hit.
changes in v5:
- change the callers to use the snapshot function directly
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 16 +---
drivers/gpu/drm/msm/disp
, it shall be applied on top
of this change.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dsi/dsi.h | 3 ++
drivers/gpu/drm/msm/dsi/dsi.xml.h | 9 ++
drivers/gpu/drm/msm/dsi/dsi_host.c| 53 +++
drivers/gpu/drm/msm/dsi/dsi_manager.c | 13
, it shall be applied on top
of this change.
Changes in v2:
- generate the new dsi.xml.h and update the bitfield names
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dsi/dsi.h | 3 ++
drivers/gpu/drm/msm/dsi/dsi_host.c| 61 +++
drivers/gpu/drm
Update the DSI controller header XML file to add registers
and bitfields to support rectangular checkered pattern
generator.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dsi/dsi.xml.h | 94 +++
1 file changed, 75 insertions(+), 19 deletions(-)
diff
Update the DSI registers to support TPG.
Signed-off-by: Abhinav Kumar
---
src/freedreno/registers/dsi/dsi.xml | 47 +
1 file changed, 47 insertions(+)
diff --git a/src/freedreno/registers/dsi/dsi.xml
b/src/freedreno/registers/dsi/dsi.xml
index bd773ef
Add and also update the email addresses to prepare for
the transition to the new ones.
Signed-off-by: Abhinav Kumar
---
.mailmap | 7 +++
1 file changed, 7 insertions(+)
diff --git a/.mailmap b/.mailmap
index 6e84911..8c5ce37 100644
--- a/.mailmap
+++ b/.mailmap
@@ -10,6 +10,7 @@
# Please
Adding myself as a designated reviewer to assist with the
code reviews for the changes coming into MSM DRM.
Signed-off-by: Abhinav Kumar
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 5b33791..503112d 100644
--- a/MAINTAINERS
+++ b
o the binding document of msm dsi controller, the
input/output endpoint of the controller is expected to have 4 lanes.
So let's set num_data_lanes to 4 by default.
Signed-off-by: Philip Chen
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 2 ++
1 file changed, 2 insertion
ve it from the mdp5 driver.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/mdp5/mdp5_mdss.c | 24 ++-
1 file changed, 2 insertions(+), 22 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_mdss.c
b/drivers/gpu/drm/msm
nd more.
Signed-off-by: Douglas Anderson
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/dp_aux.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/gpu/drm/msm/dp/dp_aux.c b/drivers/gpu/drm/msm/dp/dp_aux.c
index eb40d8413bca..6d36f63c3338 100644
--- a/drive
Add and also update the email addresses to prepare for
the transition to the new ones.
Signed-off-by: Abhinav Kumar
---
.mailmap | 8
1 file changed, 8 insertions(+)
diff --git a/.mailmap b/.mailmap
index 6e84911..92f4cd7 100644
--- a/.mailmap
+++ b/.mailmap
@@ -10,10 +10,12
Adding myself as a designated reviewer to assist with the
code reviews for the changes coming into MSM DRM.
Acked-by: Rob Clark
Signed-off-by: Abhinav Kumar
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 5b33791..503112d 100644
--- a
Adding myself as a designated reviewer to assist with the
code reviews for the changes coming into MSM DRM.
Acked-by: Rob Clark
Signed-off-by: Abhinav Kumar
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 5b33791..c27d8f7 100644
--- a
Hi Joe
Thanks for the feedback.
On 11/19/2021 7:34 PM, Joe Perches wrote:
On Fri, 2021-11-19 at 15:18 -0800, Abhinav Kumar wrote:
Adding myself as a designated reviewer to assist with the
code reviews for the changes coming into MSM DRM.
Acked-by: Rob Clark
Signed-off-by: Abhinav Kumar
because both sc7280 and SM8350 use MDP's
7x hw version.
Otherwise,
Reviewed-by: Abhinav Kumar
Signed-off-by: Bjorn Andersson
---
.../gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 18 ++
.../gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h | 3 +++
2 files changed, 21 inser
Hi Vinod
On 11/15/2021 10:22 PM, Vinod Koul wrote:
Display Stream Compression (DSC) parameters need to be calculated. Add
helpers and struct msm_display_dsc_config in msm_drv for this
msm_display_dsc_config uses drm_dsc_config for DSC parameters.
Signed-off-by: Vinod Koul
---
drivers/gpu/drm
Reviewed-by: Abhinav Kumar
Changes in v2:
-- revise commit text
-- rename dp_bridge to msm_dp_bridge
-- delete empty functions
Changes in v3:
-- replace kzalloc() with devm_kzalloc()
-- replace __dp_display_enable() with dp_display_enable()
-- replace __dp_display_disable() with
On 11/25/2021 4:50 AM, Dmitry Baryshkov wrote:
On 19/10/2021 02:54, abhin...@codeaurora.org wrote:
On 2021-10-16 07:21, Dmitry Baryshkov wrote:
On Sat, 16 Oct 2021 at 01:25, wrote:
Hi Dmitry
On 2021-10-14 17:11, Dmitry Baryshkov wrote:
> Merge old hdmi_bridge and hdmi_connector implement
Hi Dmitry
On 12/6/2021 2:47 PM, Dmitry Baryshkov wrote:
On Mon, 6 Dec 2021 at 23:42, Abhinav Kumar wrote:
On 11/25/2021 4:50 AM, Dmitry Baryshkov wrote:
On 19/10/2021 02:54, abhin...@codeaurora.org wrote:
On 2021-10-16 07:21, Dmitry Baryshkov wrote:
On Sat, 16 Oct 2021 at 01:25, wrote
On 12/6/2021 4:21 PM, Dmitry Baryshkov wrote:
On Tue, 7 Dec 2021 at 01:58, Abhinav Kumar wrote:
Hi Dmitry
On 12/6/2021 2:47 PM, Dmitry Baryshkov wrote:
On Mon, 6 Dec 2021 at 23:42, Abhinav Kumar wrote:
On 11/25/2021 4:50 AM, Dmitry Baryshkov wrote:
On 19/10/2021 02:54, abhin
On 12/1/2021 2:51 PM, Dmitry Baryshkov wrote:
Scaler and pixel_ext configuration does not contain a long living state,
it is used only during plane update, so remove these two fiels from
dpu_plane_state and allocate them on stack.
s/fiels/fields
apart from that,
Reviewed-by: Abhinav Kumar
s remove it while we are cleaning scaled configuration.
Thanks for pushing this.
This was originally reported by Dan Carpenter.
Hence, please add the Reported-by tag for Dan on this (Dan Carpenter
)
Apart from that,
Reviewed-by: Abhinav Kumar
Signed-off-by: Dmitry Baryshkov
---
drivers
On 12/1/2021 2:51 PM, Dmitry Baryshkov wrote:
Add DPU_SSPP_CSC_ANY denoting any CSC block. As we are at it, rewrite
DPU_SSPP_SCALER (any scaler) to use BIT(x) instead of hand-coded
bitshifts.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1
On 12/1/2021 2:51 PM, Dmitry Baryshkov wrote:
Client driven prefetch (CDP) is properly setup only for SSPP REC0
currently. Enable client driven prefetch also for SSPP REC1.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 12
7; condition directly in the msm_dsi_modeset_init().
Fixes: 739b4e7756d3 ("drm/msm/dsi: Fix an error code in msm_dsi_modeset_init()")
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dsi/dsi.c | 10 +++---
drivers/gpu/drm/msm/dsi/dsi.h | 1 -
.
the danger_safe itself is a per-plane feature as each SSPP can be
controlled individually.
In todays code, yes we do it for all the active planes together.
Since this is the same behavior
Reviewed-by: Abhinav Kumar
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
On 12/1/2021 2:26 PM, Dmitry Baryshkov wrote:
Make safe_status debugfs fs file actually return safe status rather than
danger status data.
Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/dr
On 12/1/2021 2:26 PM, Dmitry Baryshkov wrote:
Change \t to \n in the print format to stop putting all SSPP status in a
single line. Splitting it to one SSPP per line is much more readable.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1
On 12/1/2021 2:26 PM, Dmitry Baryshkov wrote:
Proper support for the 'default_scaling' debugfs file was removed during
DPU driver pre-merge cleanup. Remove leftover file.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_p
On 12/1/2021 2:26 PM, Dmitry Baryshkov wrote:
DRM code handles removing all debugfs recursively. Drop plane-specific
code to perform that.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 28 ---
1 file
On 12/1/2021 2:26 PM, Dmitry Baryshkov wrote:
DRM code handles removing all debugfs recursively. Drop CRTC-specific
code to perform that.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 15 ---
drivers/gpu/drm/msm
On 12/1/2021 2:26 PM, Dmitry Baryshkov wrote:
Squash dpu_debugfs_setup_regset32() into dpu_debugfs_create_regset32().
it makes little sense to have separate function to just setup the
structure.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp
On 12/1/2021 2:26 PM, Dmitry Baryshkov wrote:
We are preparing to change DPU plane implementation. Move SSPP debugfs
code from dpu_plane.c to dpu_hw_sspp.c, where it belongs.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 67 +
drivers/gp
On 12/9/2021 2:18 PM, Abhinav Kumar wrote:
On 12/1/2021 2:26 PM, Dmitry Baryshkov wrote:
We are preparing to change DPU plane implementation. Move SSPP debugfs
code from dpu_plane.c to dpu_hw_sspp.c, where it belongs.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1
On 12/15/2021 8:09 AM, Dmitry Baryshkov wrote:
Implement CRTC's atomic_print_state() callback, printing DPU-specific
CRTC state (LM, CTL and DSPP ids).
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 15 +++
1
On 12/15/2021 8:09 AM, Dmitry Baryshkov wrote:
Implement plane's atomic_print_state() callback, printing DPU-specific
plane state: blending stage, SSPP and multirect mode and index.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_pl
On 12/9/2021 4:19 PM, Dmitry Baryshkov wrote:
On 10/12/2021 01:27, Abhinav Kumar wrote:
On 12/9/2021 2:18 PM, Abhinav Kumar wrote:
On 12/1/2021 2:26 PM, Dmitry Baryshkov wrote:
We are preparing to change DPU plane implementation. Move SSPP debugfs
code from dpu_plane.c to dpu_hw_sspp.c
Add the missing layer mixer register dump information to
dpu snapshot to assist debugging.
Reviewed-by: Dmitry Baryshkov
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
b
+ /* Only create one set of debugfs per DP instance */
I would change this to DPU now instead of DP, but apart from that,
Reviewed-by: Abhinav Kumar
+ if (minor->type != DRM_MINOR_PRIMARY)
+ return 0;
+
dev = dpu_kms->dev;
priv = dev->dev_private;
On 12/16/2021 4:26 PM, Bjorn Andersson wrote:
The sc8180x has 2 DP and 1 eDP controllers, add support for these to the
DP driver.
Signed-off-by: Bjorn Andersson
Reviewed-by: Abhinav Kumar
---
Changes since v5:
- Dropped DPU hw catalog change from the patch
- Rebased the patch
drivers
On 11/25/2021 6:18 PM, Dmitry Baryshkov wrote:
Remove extra dpu_irq_* wrappers from dpu_kms.c, merge them directly into
dpu_core_irq_* functions.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.h | 12 -
.../gpu/drm
On 12/7/2021 2:29 PM, Dmitry Baryshkov wrote:
The DSI subsystem does not fully fall into the pre-enable/enable system
of callbacks, since typically DSI device bridge drivers expect to be
able to communicate with DSI devices at the pre-enable() callback. The
reason is that for some DSI hosts en
On 12/7/2021 2:29 PM, Dmitry Baryshkov wrote:
Currently the DSI driver has two separate paths: one if the next device
in a chain is a bridge and another one if the panel is connected
directly to the DSI host. Simplify the code path by using panel-bridge
driver (already selected in Kconfig) and
On 1/5/2022 11:06 PM, Dmitry Baryshkov wrote:
The round_pixclk() callback returns different rate only on MDP4 in HDMI
(DTV) case. Stop using this callback in other cases to simplify
mode_valid callbacks.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
Changes since v1
On 1/18/2022 12:01 PM, Dmitry Baryshkov wrote:
On Tue, 18 Jan 2022 at 22:41, Abhinav Kumar wrote:
On 12/7/2021 2:29 PM, Dmitry Baryshkov wrote:
Currently the DSI driver has two separate paths: one if the next device
in a chain is a bridge and another one if the panel is connected
This will help the clients to manage the real encoder states
better as they will allocate and maintain the encoder.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/drm_writeback.c | 11 +++
include/drm/drm_writeback.h | 2 +-
2 files changed, 8 insertions(+), 5 deletions(-)
diff --
Hi Laurent
Thanks for the response.
On 1/20/2022 6:43 PM, Laurent Pinchart wrote:
Hi Abhinav,
Thank you for the patch.
On Thu, Jan 20, 2022 at 06:29:55PM -0800, Abhinav Kumar wrote:
Instead of creating an internal encoder for the writeback
connector to satisfy DRM requirements, allow the
Hi Jani
On 1/21/2022 1:17 AM, Jani Nikula wrote:
On Thu, 20 Jan 2022, Abhinav Kumar wrote:
Instead of creating an internal encoder for the writeback
connector to satisfy DRM requirements, allow the clients
to pass a real encoder to it by changing the drm_writeback's
encoder to a pointer
for all of them can be incrementally added on top of this framework when
validation is improved and the test frameworks are extended to validate
them.
Abhinav Kumar (12):
drm/msm/dpu: add writeback blocks to the sm8250 DPU catalog
drm/msm/dpu: add dpu_hw_wb abstraction for writeback blocks
Add writeback blocks to the sm8250 DPU hardware catalog. Other
chipsets support writeback too but add it to sm8250 to prototype
the feature so that it can be easily extended to other chipsets.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 73
Add the dpu_hw_wb abstraction to program registers related to the
writeback block. These will be invoked once all the configuration
is set and ready to be programmed to the registers.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/Makefile | 1 +
drivers/gpu/drm/msm/disp
Add writeback blocks to DPU resource manager so that
writeback encoders can request for writeback hardware blocks
through RM and their usage can be tracked.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 3 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 2
Add an API to reset the encoder related hw blocks to ensure
a proper teardown of the pipeline. At the moment this is being
used only for the writeback encoder but eventually we can start
using this for all interfaces.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
Make changes to dpu_encoder to support virtual encoder needed
to support writeback for dpu.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 57 +
1 file changed, 42 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp
add dpu encoder APIs to prepare and cleanup writeback job
for the writeback encoder. These shall be invoked from the
prepare_wb_job/cleanup_wb_job hooks of the drm_writeback
framework.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 34
Add changes to support writeback module in the dpu_hw_ctl
interface. In addition inroduce a reset_intf_cfg op to reset
the interface bits for the currently active interfaces in
the ctl path.
Signed-off-by: Abhinav Kumar
---
.../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 3 +-
.../gpu/drm
Introduce the dpu_encoder_phys_* for the writeback interface
to handle writeback specific hardware programming.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/Makefile | 1 +
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 36 +-
.../gpu/drm/msm/disp/dpu1
Introduce the dpu_writeback module which serves as the
interface between dpu operations and the drm_writeback.
This module manages the connector related operations for
dpu writeback.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/Makefile | 1 +
drivers/gpu/drm/msm/disp
Initialize dpu encoder and connector for writeback if the
target supports it in the catalog.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 37 -
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 62 +
2 files changed, 88
triggers a commit.
Add protection in the dpu driver to ensure that commits for
writeback encoders without a valid fb are gracefully skipped.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 9 +
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 21
Add writeback block information while capturing the display
snapshot.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
index
On 2/7/2022 5:23 PM, Yang Li wrote:
Eliminate the follow smatch warning:
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c:411
_dpu_crtc_blend_setup_mixer() warn: inconsistent indenting
Reported-by: Abaci Robot
Signed-off-by: Yang Li
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1
coredump
sizes.
Signed-off-by: Abhinav Kumar
---
drivers/base/devcoredump.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/base/devcoredump.c b/drivers/base/devcoredump.c
index f4d794d..6b83ae5 100644
--- a/drivers/base/devcoredump.c
+++ b/drivers/base/devcoredump.c
Hi Johannes
Thanks for the response.
On 2/8/2022 12:35 PM, Johannes Berg wrote:
On Tue, 2022-02-08 at 11:44 -0800, Abhinav Kumar wrote:
There are cases where depending on the size of the devcoredump and the speed
at which the usermode reads the dump, it can take longer than the current 5 mins
Hi Johannes
On 2/8/2022 1:12 PM, Johannes Berg wrote:
On Tue, 2022-02-08 at 13:04 -0800, Abhinav Kumar wrote:
It opened the file rightaway but could not finish reading.
The device gets deleted so the corresponding /data will disappear too (
as the data node is under devcd*/data)
Yeah but
Hi Johannes
On 2/8/2022 1:54 PM, Johannes Berg wrote:
On Tue, 2022-02-08 at 13:40 -0800, Abhinav Kumar wrote:
I am checking what usermode sees and will get back ( I didnt see an
error do most likely it was EOF ). I didnt follow the second part.
I think probably it got -ENODEV, looking at
Hi Johannes
On 2/8/2022 11:50 PM, Johannes Berg wrote:
On Tue, 2022-02-08 at 17:55 -0800, Abhinav Kumar wrote:
Are you suggesting something like below?
diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c
index 42dcf96..14203d0 100644
--- a/fs/sysfs/file.c
No, for sure not, but I guess from the
1 - 100 of 2065 matches
Mail list logo
